rubocop-g2 1.1.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2db317ecd0cf9301879c5caff269336fa59d1c832b1aa3ab5aa2c91c187b6388
-  data.tar.gz: f4830c82a08a9ad6c794a11a409ab74f347766cbe23ce7795e2c1cb736545887
+  metadata.gz: 1db6fe3ca651f25244c105904e3ade2aa59d66e03ad9af7c723346bebc8ec3ec
+  data.tar.gz: f59831bc819a38dd8732de5784d217bc141aff96f7648634a31bf9f298021232
 SHA512:
-  metadata.gz: 105b2c319799343783bfcf1df83bc3e6eb72a40256f932fa08691d325f0662ba0357eecacc4534a7b6389f125cc9025a4c3ae9227e65f52390f0cda421d7dd72
-  data.tar.gz: dd74840c0973a2d0543e26cc592fdaa6ee78625426d9018c5f6878666b726950d84e52d668bbb4883ac5eaa4b2345415bd4d098786d40865e67ac0b244131b8b
+  metadata.gz: 922b155abca3d15cde8681c1376bc09f62623295196b3928a63377e04614332267782b8ff5b9a3364b1eb8a1a2100d5b25cd34f04bbe71ebf29bd3ae37952fa8
+  data.tar.gz: a328f94e4da34449f42a5c6fabe800f87e0e905b11c5523f33874af1b2aa5b5e71fa692be8b7be153b4d5bac6c827b138275c973dd62d7f5f0a740b688fb04ef

data/.tool-versions

@@ -1 +1 @@
-ruby 2.6.6
+ruby 2.7.2

data/Gemfile.lock

@@ -1,39 +1,39 @@
 PATH
   remote: .
   specs:
-    rubocop-g2 (1.1.0)
-      rubocop (= 0.82.0)
-      rubocop-rails (= 2.5.2)
-      rubocop-rspec (= 1.39.0)
+    rubocop-g2 (1.4.0)
+      rubocop (>= 0.82)
+      rubocop-rails (>= 2.5)
+      rubocop-rspec (>= 1.39)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3)
+    activesupport (6.1.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.2, >= 2.2.2)
-    ast (2.4.0)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    ast (2.4.2)
     coderay (1.1.2)
-    concurrent-ruby (1.1.6)
+    concurrent-ruby (1.1.9)
     diff-lcs (1.3)
-    i18n (1.8.2)
+    i18n (1.8.10)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.4)
     method_source (0.9.2)
-    minitest (5.14.0)
-    parallel (1.19.1)
-    parser (2.7.1.2)
-      ast (~> 2.4.0)
+    minitest (5.14.4)
+    parallel (1.20.0)
+    parser (3.0.1.1)
+      ast (~> 2.4.1)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    rack (2.2.2)
+    rack (2.2.3)
     rainbow (3.0.0)
     rake (12.3.3)
-    rexml (3.2.4)
+    regexp_parser (2.0.3)
+    rexml (3.2.5)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -47,36 +47,39 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.3)
-    rubocop (0.82.0)
-      jaro_winkler (~> 1.5.1)
+    rubocop (1.18.3)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
+      rubocop-ast (>= 1.7.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-rails (2.5.2)
-      activesupport
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.8.0)
+      parser (>= 3.0.1.1)
+    rubocop-rails (2.8.1)
+      activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.72.0)
-    rubocop-rspec (1.39.0)
-      rubocop (>= 0.68.1)
+      rubocop (>= 0.87.0)
+    rubocop-rspec (2.0.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
     ruby-progressbar (1.10.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.7)
-      thread_safe (~> 0.1)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
     unicode-display_width (1.7.0)
-    zeitwerk (2.3.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.17)
+  bundler (~> 2)
   pry
   rake (~> 12.3.1)
   rspec (~> 3.7)
   rubocop-g2!
 
 BUNDLED WITH
-   1.17.3
+   2.2.23

data/config/rspec/default.yml

@@ -1,7 +1,6 @@
-AllCops:
-  RSpec:
-    Patterns:
-      - '_spec.rb$'
+RSpec:
+  Include:
+    - '_spec.rb$'
 
 Lint/Void:
   Enabled: false
@@ -9,5 +8,8 @@ Lint/Void:
 RSpec/LetSetup:
   Enabled: false
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/NestedGroups:
   Max: 6

data/config/ruby/default.yml

@@ -63,6 +63,9 @@ Style/FormatStringToken:
 Style/FrozenStringLiteralComment:
   Enabled: false
 
+Style/HashAsLastArrayItem:
+  Enabled: false
+
 Style/HashEachMethods:
   Enabled: true
 

data/lib/rubocop/cop/g2/accessible_icons.rb

@@ -0,0 +1,33 @@
+module RuboCop
+  module Cop
+    module G2
+      class AccessibleIcons < RuboCop::Cop::Cop
+        MSG = 'Make SVGs accessible by either marking them as decorative (`decorative: true`) '\
+              "or adding a label (`aria_label: t('path.to.description')`)".freeze
+
+        RESTRICT_ON_SEND = %i(inline_icon).freeze
+
+        def on_send(node)
+          keyword_args = array_of_kwargs node.arguments
+          return if args_include_decorative?(keyword_args) ^ args_include_aria_label?(keyword_args)
+
+          add_offense node
+        end
+
+        private
+
+        def array_of_kwargs(args)
+          args.find(&:hash_type?)&.children&.map(&:children) || []
+        end
+
+        def args_include_decorative?(args)
+          args.include? [s(:sym, :decorative), s(:true)]
+        end
+
+        def args_include_aria_label?(args)
+          args.any? { |arg| arg.first == s(:sym, :aria_label) && arg.last != s(:nil) }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/g2/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module G2
-    VERSION = '1.1.0'.freeze
+    VERSION = '1.4.0'.freeze
   end
 end

data/lib/rubocop_g2.rb

@@ -5,3 +5,4 @@ require_relative 'rubocop/cop/g2/ban_decorators'
 require_relative 'rubocop/cop/g2/predicate_memoization'
 require_relative 'rubocop/cop/g2/raw_connection_execute'
 require_relative 'rubocop/cop/g2/aggregates_model_boundary'
+require_relative 'rubocop/cop/g2/accessible_icons'

data/rubocop-g2.gemspec

@@ -20,11 +20,11 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '0.82.0'
-  spec.add_dependency 'rubocop-rails', '2.5.2'
-  spec.add_dependency 'rubocop-rspec', '1.39.0'
+  spec.add_dependency 'rubocop', '>= 0.82'
+  spec.add_dependency 'rubocop-rails', '>= 2.5'
+  spec.add_dependency 'rubocop-rspec', '>= 1.39'
 
-  spec.add_development_dependency 'bundler', '~> 1.17'
+  spec.add_development_dependency 'bundler', '~> 2'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake', '~> 12.3.1'
   spec.add_development_dependency 'rspec', '~> 3.7'

metadata

@@ -1,71 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-g2
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Paul Mannino
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-05-08 00:00:00.000000000 Z
+date: 2021-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: '0.82'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: '0.82'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.5.2
+        version: '2.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.5.2
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.39.0
+        version: '1.39'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.39.0
+        version: '1.39'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -108,7 +108,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.7'
-description: 
+description:
 email:
 - pmannino@g2.com
 executables: []
@@ -126,6 +126,7 @@ files:
 - config/rspec/default.yml
 - config/ruby/default.yml
 - lib/rubocop-g2.rb
+- lib/rubocop/cop/g2/accessible_icons.rb
 - lib/rubocop/cop/g2/aggregates_model_boundary.rb
 - lib/rubocop/cop/g2/ban_decorators.rb
 - lib/rubocop/cop/g2/predicate_memoization.rb
@@ -136,7 +137,7 @@ files:
 homepage: https://g2.com
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -151,8 +152,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Custom cops for G2.
 test_files: []