rubocop-fourshark 0.8.3 → 0.8.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dbfa3d2a442ba57bc74ba0171563f0bcadb6f4460b769654963066462ca0b61f
-  data.tar.gz: '097de5b926870d292e63aa39f79aacc8342fe1909e34809bf9bb2f066c309a22'
+  metadata.gz: 4cdbe5b265ec54b100ac589171adad9038c99fee37dac3008cb56bba16e1a002
+  data.tar.gz: 8dfc81f74e7af24ad5518bf67ab735e9d75557cf2db03d4401ee46ba1c471f61
 SHA512:
-  metadata.gz: 36791e28a8f0c14fa70a4990d953207412390095deda3386d9aa4edb233447ef4576d645b4ea499414c5e3ecac44fe9e4d2845033d83d607453a303655d6e32a
-  data.tar.gz: 17bbb761062d3b28d03238fcf94df33bc29cc2f85ba839038469e7cf39d5c7bd0a6ced5402fac62d6660c7eb5d7c57e8971aa118f3ce1283412f7ddd366f223a
+  metadata.gz: 684f7b5b0f1064064eb545240a7f2f290207c9d0e7f759363e26d2607b2fe0d48fda173e8e48827769fa625f3eefb5ed6591ffdbdc770bf29f63bebbe156c50f
+  data.tar.gz: 19a91ad805511e8a3f19d903d18eeb007c5a2c1d4e2329733336e12d6b041cad998466f0fe080556830fbf8a90be6736f568b33eaf1d803b3e2e4c94b0dd8555

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [0.8.4] - 2026-08-07
+
+### Fixed
+
+- `Style/DisallowDelegate` — own state reached through a call on it is no longer flagged
+- `Style/DisallowDelegate` — an argument rooted at the collaborator being forwarded to is flagged again
+- `Style/DisallowDelegate` — own state read through an explicit `self` is no longer flagged
+- `Style/DisallowDelegate` — a call reached through safe navigation counts as the call it is, on both the receiver and the argument side
+
 ## [0.8.3] - 2026-08-06
 
 ### Fixed

data/lib/rubocop/cop/rails/bidirectional_association.rb

@@ -141,7 +141,7 @@ module RuboCop
         #
         # Example:
         #   "UserAccount" → "user_account"
-        #   "PlanStatementAudit::Row" → "plan_statement_audit/row"
+        #   "InvoiceLineItem::Row" → "invoice_line_item/row"
         def camel_to_snake(name)
           return '' if name.nil?
 

data/lib/rubocop/cop/rspec/inverse_of_matcher.rb

@@ -127,7 +127,7 @@ module RuboCop
           match && match[1]
         end
 
-        # "UserAccount" → "user_account"; "Plan::Statement" → "plan/statement"
+        # "UserAccount" → "user_account"; "Order::LineItem" → "order/line_item"
         def camel_to_snake(name)
           name.gsub('::', '/')
             .gsub(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')

data/lib/rubocop/cop/style/disallow_delegate.rb

@@ -37,34 +37,46 @@ module RuboCop
       # contributes something the caller would otherwise have to reach in and
       # take, and the result is a simpler API on the object that owns the data.
       #
-      # Three limits keep that exemption from swallowing the rule. The receiver
-      # must not itself be a chain — Remove Middle Man on a message chain IS the
-      # caller navigating, so composing own state does not excuse it. Own state
-      # is an instance variable or a receiverless call, so a method parameter
-      # forwarded through does not qualify and a setter stays flagged. And own
-      # state is read through a splat, a double splat, an array or a block pass,
-      # because the wrapper does not change whose state the argument carries.
-      #
-      # An argument derived from own state through another call —
-      # `variable.label(value.to_s)` — is still flagged. Recursing into an
-      # argument's receiver would also exempt `Lock.lock_key(company_id:
-      # user.company_id)`, which is delegation, so the conservative reading wins.
+      # Own state is an instance variable, `self`, or a receiverless call,
+      # reached directly, through a wrapper, or through a call on it — `record`,
+      # `record.owner_id` and `[record.owner_id]` all carry the object's own
+      # data. A method PARAMETER does not: it arrives as an `lvar`, so a setter
+      # handing its argument to a collaborator stays flagged.
+      #
+      # Two limits keep the exemption from swallowing the rule.
+      #
+      # The receiver must not itself be a chain. Remove Middle Man on a message
+      # chain IS the caller navigating, so composing own state does not excuse
+      # it.
+      #
+      # An argument rooted at the collaborator being forwarded to does not earn
+      # the exemption. `author.name(author.locale)` hands the collaborator back
+      # its own data, which is the echo this rule forbids, not composition, so
+      # with no other argument to carry it the forward stays flagged. Rooted at
+      # the object's OWN state the argument may be a chain of any depth — the
+      # object still supplied what the collaborator needed, and how far it
+      # reached inside itself to build the value is its own business.
+      #
+      # A forward to a collaborator that passes NO argument is the one that
+      # republishes, and it is always flagged. That is the line — supplying data
+      # the collaborator needs is composition, echoing back what the collaborator
+      # already knows is delegation.
       #
       # @example
       #   # bad
-      #   delegate :name, to: :commission
+      #   delegate :name, to: :author
       #
       #   # bad — same promise, written by hand
       #   def name
-      #     commission.name
+      #     author.name
       #   end
       #
       #   # good — the caller navigates
-      #   statement.commission.name
+      #   post.author.name
       #
       #   # good — the object answers about itself, not for a collaborator
       #   def lock_key
-      #     self.class.lock_key(company_id: company_id)
+      #     self.class.lock_key(owner_id: owner_id)
       #   end
       #
       #   # good — `each` is the Enumerable contract this class implements
@@ -78,12 +90,22 @@ module RuboCop
       #
       #   # good — composes its own attribute, so the caller cannot just navigate
       #   def output
-      #     variable.output(value)
+      #     formatter.output(value)
+      #   end
+      #
+      #   # good — names an expression built from its own record; not a forward
+      #   def lock_key
+      #     Registry.lock_key(owner_id: record.owner_id)
       #   end
       #
       #   # bad — a chain does not stop being a chain because an argument rode along
       #   def starts_at
-      #     commission.plan.period.starts_at(calendar)
+      #     schedule.window.period.starts_at(calendar)
+      #   end
+      #
+      #   # bad — the argument is the collaborator's own data handed back to it
+      #   def name
+      #     author.name(author.locale)
       #   end
       #
       class DisallowDelegate < ::RuboCop::Cop::Base
@@ -154,32 +176,43 @@ module RuboCop
           mixes_in_enumerable?(body)
         end
 
-        def composes_own_state?(body)
-          return false if chained_receiver?(body.receiver)
-
-          body.arguments.any? { |argument| own_state?(argument) }
-        end
-
         # Remove Middle Man on a message chain IS the caller navigating, so an
         # argument riding along does not earn the exemption.
-        def chained_receiver?(receiver)
-          return false unless receiver.send_type?
+        def composes_own_state?(body)
+          return false if call_with_receiver?(body.receiver)
 
-          !receiver.receiver.nil?
+          body.arguments.any? { |argument| own_state?(argument, body.receiver) }
         end
 
         # A method parameter reaches the body as an `lvar`, so only an instance
-        # variable or a receiverless call counts as the object's own state. An
-        # anonymous block pass carries a nil child, hence the first guard.
-        def own_state?(argument)
-          return false if argument.nil?
+        # variable, `self`, or a receiverless call counts as the object's own
+        # state — read directly, through a wrapper, or through a call on it.
+        # Anything rooted at the collaborator is that collaborator's own data
+        # coming back, which is the echo the rule forbids. The first guard
+        # refuses anything that is not a node, which covers both the nil child
+        # an anonymous block pass carries and a wrapper whose children are raw
+        # Ruby values rather than nodes.
+        def own_state?(argument, collaborator)
+          return false unless argument.is_a?(::RuboCop::AST::Node)
+          return false if argument == collaborator
           return true if argument.ivar_type?
-          return true if argument.send_type? && argument.receiver.nil?
-          return argument.children.any? { |child| own_state?(child) } if wrapper?(argument)
+          return true if argument.self_type?
+          return own_state?(argument.receiver, collaborator) if call_with_receiver?(argument)
+          return true if argument.send_type?
+          return argument.children.any? { |child| own_state?(child, collaborator) } if wrapper?(argument)
 
           false
         end
 
+        # `call_type?` is the `send`/`csend` union, so safe navigation counts as
+        # the call it is — a `&.` link neither escapes the chain limit nor stops
+        # own state from being recognized.
+        def call_with_receiver?(node)
+          return false unless node.call_type?
+
+          !node.receiver.nil?
+        end
+
         def wrapper?(argument)
           ARGUMENT_WRAPPERS.include?(argument.type)
         end

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.8.3'
+    VERSION = '0.8.4'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.8.4
 platform: ruby
 authors:
 - Paulo Ribeiro