rubocop-fourshark 0.8.0 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3715ce918bf2499ae19801f42db4966430bc7a2ae33aae165bc7676865bdfc3
-  data.tar.gz: 48d1eac2b33b6971b80463057f859d4f2cbc5efa5d03d298484a9819cb1c1989
+  metadata.gz: 9358c7dd0bcd6717781203b1f4ccdd6e282851da1e52838db50acf058ce39414
+  data.tar.gz: f219f75c7fdaea1dff73f43ed9a1c16478e97b44f45f5242d9f21044e57cd19c
 SHA512:
-  metadata.gz: 2cb23a767a11947a89a3792c32cb9a3da0e888c83ebd377447b71e9ec21c4643a3105bf361d445fdd1d942b3f92894e68989efcceed7ba4946077f882cdb36b4
-  data.tar.gz: c9f15b6c4a0a3340ead5387783a0585423c44a3e299143910c145d3bf086d15924a2d0e93a87213ff2da8f059c6cd897fd05a7f04fe9d6ff29b0517e9d00885b
+  metadata.gz: edd536903d83b3516f576bdcf318847c5914a9b747d52203f2153a2dc2eaf5af783a7fc9d16d1f730674d51a8bde815b576a29f64619655824a227551a2979b1
+  data.tar.gz: c063cd068bace0cdccf5e0948e94c40088b0160fc023f14ee315f4177374134bea62eedc49d42655a505579afc0d43a9248d1f2d4a6231344d624154e5b95afe

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+## [0.8.2] - 2026-08-06
+
+### Fixed
+
+- `Style/DisallowDelegate` — `each` in a class including `Enumerable` is no longer flagged
+- `Style/DisallowDelegate` — a method composing its own state into the call is no longer flagged
+
+## [0.8.1] - 2026-08-06
+
+### Fixed
+
+- `Style/DisallowDelegate` — a method answering about its own class is no longer flagged
+
 ## [0.8.0] - 2026-08-05
 
 ### Changed

data/lib/rubocop/cop/style/disallow_delegate.rb

@@ -17,6 +17,26 @@ module RuboCop
       # the forwarder by hand changes what `grep` finds, not what the class
       # claims to be responsible for.
       #
+      # `self.class` is not a collaborator — it is the object's own class. An
+      # instance method that composes its own attributes into a same-named class
+      # method answers for a domain it owns, so it is not delegation and is not
+      # flagged.
+      #
+      # `each` in a class that includes `Enumerable` is the module's required
+      # contract, not delegation. The class has no interface without it — every
+      # method `Enumerable` provides is built on `each` — so the class is
+      # implementing its own interface rather than answering for a collaborator.
+      # It is not flagged. Any other method in such a class still is.
+      #
+      # A body that passes the object's own state as an argument is not a
+      # pass-through. Middle Man is a method that republishes a collaborator's
+      # answer verbatim, which the caller could reach by navigating; a method
+      # that supplies its own attributes contributes something the caller would
+      # otherwise have to reach in and take, and the result is a simpler API on
+      # the object that owns the data. Own state is an instance variable or a
+      # receiverless call — a method parameter forwarded through is not, so a
+      # setter passing its argument along stays flagged.
+      #
       # @example
       #   # bad
       #   delegate :name, to: :commission
@@ -29,6 +49,25 @@ module RuboCop
       #   # good — the caller navigates
       #   statement.commission.name
       #
+      #   # good — the object answers about itself, not for a collaborator
+      #   def lock_key
+      #     self.class.lock_key(company_id: company_id)
+      #   end
+      #
+      #   # good — `each` is the Enumerable contract this class implements
+      #   class SearchResult
+      #     include Enumerable
+      #
+      #     def each(&)
+      #       results.each(&)
+      #     end
+      #   end
+      #
+      #   # good — composes its own attribute, so the caller cannot just navigate
+      #   def output
+      #     variable.output(value)
+      #   end
+      #
       class DisallowDelegate < ::RuboCop::Cop::Base
         MACRO_MSG = 'Do not use automatic delegation. Delete the forwarder and let the caller navigate.'
         FORWARDER_MSG = 'Do not forward a collaborator\'s message. Delete the forwarder and let the caller navigate.'
@@ -41,8 +80,15 @@ module RuboCop
           add_offense(node, message: MACRO_MSG)
         end
 
+        # @!method includes_enumerable?(node)
+        def_node_matcher :includes_enumerable?, <<~PATTERN
+          (send nil? :include (const {nil? cbase} :Enumerable))
+        PATTERN
+
         def on_def(node)
           return unless forwards_own_message?(node.body, node.method_name)
+          return if enumerable_contract?(node)
+          return if composes_own_state?(node.body)
 
           add_offense(node.loc.name, message: FORWARDER_MSG)
         end
@@ -53,9 +99,48 @@ module RuboCop
           return false if body.nil?
           return false unless body.send_type?
           return false if body.receiver.nil?
+          return false if own_class?(body.receiver)
 
           body.method?(method_name)
         end
+
+        def own_class?(receiver)
+          return false unless receiver.send_type?
+          return false unless receiver.method?(:class)
+          return false if receiver.receiver.nil?
+
+          receiver.receiver.self_type?
+        end
+
+        def enumerable_contract?(node)
+          return false unless node.method?(:each)
+
+          enclosing = node.each_ancestor(:class, :module).first
+          return false if enclosing.nil?
+
+          enumerable_body?(enclosing.body)
+        end
+
+        def enumerable_body?(body)
+          return false if body.nil?
+          return body.children.any? { |child| includes_enumerable?(child) } if body.begin_type?
+
+          includes_enumerable?(body)
+        end
+
+        def composes_own_state?(body)
+          body.arguments.any? { |argument| own_state?(argument) }
+        end
+
+        # A method parameter reaches the body as an `lvar`, so only an instance
+        # variable or a receiverless call counts as the object's own state.
+        def own_state?(argument)
+          return true if argument.ivar_type?
+          return true if argument.send_type? && argument.receiver.nil?
+          return argument.values.any? { |value| own_state?(value) } if argument.hash_type?
+
+          false
+        end
       end
     end
   end

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.8.0'
+    VERSION = '0.8.2'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.2
 platform: ruby
 authors:
 - Paulo Ribeiro