rubocop-fourshark 0.7.1 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 582aea0059be3aad96e3b1017d419db000bb72f5a424684b4f90347de8359bc9
-  data.tar.gz: 685cb43ef7bbc16988a954b3821cc7a9a813bb98bf7777432da0960d4808d149
+  metadata.gz: 31d77a73abb724b68a4c2d187cc780899067d2ef82564e50bcce0d6b09dbffeb
+  data.tar.gz: fd2eda214bf001b848e18be1f68df32463d70272be3f7ce999ac7cb3b1be8f8f
 SHA512:
-  metadata.gz: 1469cf2ff8d928ec8af532f2c09b0ca3fd35414c02105820ca519760d54d01ec177c172c79cf710a79e3314cafe4784c8c62f099bceb7b59753c51dc7ed5bb72
-  data.tar.gz: cf5dbfa5a4762d24715bb18b73224c92cb7251bced71e7003fa66d48d4d24be38bdcca4eb19e33e2d124e87dad74ec9a2cf53c890c69621dcefb2875aed33a07
+  metadata.gz: 61aabc197c8224de85d39c9f150cb0fb1b73916a8882fd35cb3241b4b5ca330eb44f4098a12eff4fc934b918ea2ccf75a81bd150c1eac96193678ef620ae734c
+  data.tar.gz: b0b7426b78afa3a99f028eb84b4dd78479c153d219997d55611e7e1ab3544ddfe99ead0b323306c24220c9806715ddf413b1ace76bdb19df8ccad9bb43391562

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [0.8.1] - 2026-08-06
+
+### Fixed
+
+- `Style/DisallowDelegate` — a method answering about its own class is no longer flagged
+
+## [0.8.0] - 2026-08-05
+
+### Changed
+
+- `Style/DisallowDelegate` — a method that forwards its own name to a collaborator is flagged
+
 ## [0.7.1] - 2026-08-05
 
 ### Removed

data/lib/rubocop/cop/style/disallow_delegate.rb

@@ -5,31 +5,75 @@ require 'rubocop'
 module RuboCop
   module Cop
     module Style
-      # Forbids automatic delegation — `delegate`, `delegate_missing_to`,
-      # `def_delegator`/`def_delegators` (Forwardable) and `DelegateClass`.
-      # A delegation macro is a call, not a definition, so `grep 'def foo'` and
-      # jump-to-definition find nothing; the community name for the smell is
-      # Fowler's Middle Man. Write the method, or delete the wrapper and let the
-      # caller ask the object that knows.
+      # Forbids delegation — a class answering a question that belongs to a
+      # collaborator. The community name for the smell is Fowler's Middle Man,
+      # and the prescribed refactoring is Remove Middle Man: delete the
+      # forwarder and let the caller navigate to the object that knows.
+      #
+      # Two shapes are flagged. The macro family (`delegate`,
+      # `delegate_missing_to`, `def_delegator`/`def_delegators`,
+      # `DelegateClass`) and an instance method whose entire body forwards the
+      # same message to a collaborator. The second is the same defect: writing
+      # the forwarder by hand changes what `grep` finds, not what the class
+      # claims to be responsible for.
+      #
+      # `self.class` is not a collaborator — it is the object's own class. An
+      # instance method that composes its own attributes into a same-named class
+      # method answers for a domain it owns, so it is not delegation and is not
+      # flagged.
       #
       # @example
       #   # bad
-      #   delegate :commission, to: :user_commission
+      #   delegate :name, to: :commission
+      #
+      #   # bad — same promise, written by hand
+      #   def name
+      #     commission.name
+      #   end
       #
-      #   # good
-      #   def commission
-      #     user_commission.commission
+      #   # good — the caller navigates
+      #   statement.commission.name
+      #
+      #   # good — the object answers about itself, not for a collaborator
+      #   def lock_key
+      #     self.class.lock_key(company_id: company_id)
       #   end
       #
       class DisallowDelegate < ::RuboCop::Cop::Base
-        MSG = 'Do not use automatic delegation. Write the method explicitly instead.'
+        MACRO_MSG = 'Do not use automatic delegation. Delete the forwarder and let the caller navigate.'
+        FORWARDER_MSG = 'Do not forward a collaborator\'s message. Delete the forwarder and let the caller navigate.'
 
         RESTRICT_ON_SEND = %i[delegate delegate_missing_to def_delegator def_delegators DelegateClass].freeze
 
         def on_send(node)
           return unless node.receiver.nil?
 
-          add_offense(node)
+          add_offense(node, message: MACRO_MSG)
+        end
+
+        def on_def(node)
+          return unless forwards_own_message?(node.body, node.method_name)
+
+          add_offense(node.loc.name, message: FORWARDER_MSG)
+        end
+
+        private
+
+        def forwards_own_message?(body, method_name)
+          return false if body.nil?
+          return false unless body.send_type?
+          return false if body.receiver.nil?
+          return false if own_class?(body.receiver)
+
+          body.method?(method_name)
+        end
+
+        def own_class?(receiver)
+          return false unless receiver.send_type?
+          return false unless receiver.method?(:class)
+          return false if receiver.receiver.nil?
+
+          receiver.receiver.self_type?
         end
       end
     end

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.7.1'
+    VERSION = '0.8.1'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.1
 platform: ruby
 authors:
 - Paulo Ribeiro