rubocop-fourshark 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 582aea0059be3aad96e3b1017d419db000bb72f5a424684b4f90347de8359bc9
-  data.tar.gz: 685cb43ef7bbc16988a954b3821cc7a9a813bb98bf7777432da0960d4808d149
+  metadata.gz: a3715ce918bf2499ae19801f42db4966430bc7a2ae33aae165bc7676865bdfc3
+  data.tar.gz: 48d1eac2b33b6971b80463057f859d4f2cbc5efa5d03d298484a9819cb1c1989
 SHA512:
-  metadata.gz: 1469cf2ff8d928ec8af532f2c09b0ca3fd35414c02105820ca519760d54d01ec177c172c79cf710a79e3314cafe4784c8c62f099bceb7b59753c51dc7ed5bb72
-  data.tar.gz: cf5dbfa5a4762d24715bb18b73224c92cb7251bced71e7003fa66d48d4d24be38bdcca4eb19e33e2d124e87dad74ec9a2cf53c890c69621dcefb2875aed33a07
+  metadata.gz: 2cb23a767a11947a89a3792c32cb9a3da0e888c83ebd377447b71e9ec21c4643a3105bf361d445fdd1d942b3f92894e68989efcceed7ba4946077f882cdb36b4
+  data.tar.gz: c9f15b6c4a0a3340ead5387783a0585423c44a3e299143910c145d3bf086d15924a2d0e93a87213ff2da8f059c6cd897fd05a7f04fe9d6ff29b0517e9d00885b

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [0.8.0] - 2026-08-05
+
+### Changed
+
+- `Style/DisallowDelegate` — a method that forwards its own name to a collaborator is flagged
+
 ## [0.7.1] - 2026-08-05
 
 ### Removed

data/lib/rubocop/cop/style/disallow_delegate.rb

@@ -5,31 +5,56 @@ require 'rubocop'
 module RuboCop
   module Cop
     module Style
-      # Forbids automatic delegation — `delegate`, `delegate_missing_to`,
-      # `def_delegator`/`def_delegators` (Forwardable) and `DelegateClass`.
-      # A delegation macro is a call, not a definition, so `grep 'def foo'` and
-      # jump-to-definition find nothing; the community name for the smell is
-      # Fowler's Middle Man. Write the method, or delete the wrapper and let the
-      # caller ask the object that knows.
+      # Forbids delegation — a class answering a question that belongs to a
+      # collaborator. The community name for the smell is Fowler's Middle Man,
+      # and the prescribed refactoring is Remove Middle Man: delete the
+      # forwarder and let the caller navigate to the object that knows.
+      #
+      # Two shapes are flagged. The macro family (`delegate`,
+      # `delegate_missing_to`, `def_delegator`/`def_delegators`,
+      # `DelegateClass`) and an instance method whose entire body forwards the
+      # same message to a collaborator. The second is the same defect: writing
+      # the forwarder by hand changes what `grep` finds, not what the class
+      # claims to be responsible for.
       #
       # @example
       #   # bad
-      #   delegate :commission, to: :user_commission
+      #   delegate :name, to: :commission
       #
-      #   # good
-      #   def commission
-      #     user_commission.commission
+      #   # bad — same promise, written by hand
+      #   def name
+      #     commission.name
       #   end
       #
+      #   # good — the caller navigates
+      #   statement.commission.name
+      #
       class DisallowDelegate < ::RuboCop::Cop::Base
-        MSG = 'Do not use automatic delegation. Write the method explicitly instead.'
+        MACRO_MSG = 'Do not use automatic delegation. Delete the forwarder and let the caller navigate.'
+        FORWARDER_MSG = 'Do not forward a collaborator\'s message. Delete the forwarder and let the caller navigate.'
 
         RESTRICT_ON_SEND = %i[delegate delegate_missing_to def_delegator def_delegators DelegateClass].freeze
 
         def on_send(node)
           return unless node.receiver.nil?
 
-          add_offense(node)
+          add_offense(node, message: MACRO_MSG)
+        end
+
+        def on_def(node)
+          return unless forwards_own_message?(node.body, node.method_name)
+
+          add_offense(node.loc.name, message: FORWARDER_MSG)
+        end
+
+        private
+
+        def forwards_own_message?(body, method_name)
+          return false if body.nil?
+          return false unless body.send_type?
+          return false if body.receiver.nil?
+
+          body.method?(method_name)
         end
       end
     end

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.7.1'
+    VERSION = '0.8.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Paulo Ribeiro