rubocop-fourshark 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49c5ac14dc35386b05d887fcd8b53f2ebafd991014046fef3df088a8c4174816
-  data.tar.gz: 953643562da8fcdda58cd4482246328baddff15ac4ee881468defaaf669ce218
+  metadata.gz: a3715ce918bf2499ae19801f42db4966430bc7a2ae33aae165bc7676865bdfc3
+  data.tar.gz: 48d1eac2b33b6971b80463057f859d4f2cbc5efa5d03d298484a9819cb1c1989
 SHA512:
-  metadata.gz: b0bc1b6c88559d9b780d05bfb1f052a67b99f5eebc0be6db93e6aa934e9c62cf34ecc594c9549887dee3089874c7c733320781e5025dd664aa0642ae8a211cc4
-  data.tar.gz: 91995ae5a6cabfccdb2374540e27d6dc3f481cbbc4ac54fc888359a237186400dda1e605de34e5169fb304bf3ec2b22ad78a3e80af83ba7ce1823eec69716cbc
+  metadata.gz: 2cb23a767a11947a89a3792c32cb9a3da0e888c83ebd377447b71e9ec21c4643a3105bf361d445fdd1d942b3f92894e68989efcceed7ba4946077f882cdb36b4
+  data.tar.gz: c9f15b6c4a0a3340ead5387783a0585423c44a3e299143910c145d3bf086d15924a2d0e93a87213ff2da8f059c6cd897fd05a7f04fe9d6ff29b0517e9d00885b

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [0.8.0] - 2026-08-05
+
+### Changed
+
+- `Style/DisallowDelegate` — a method that forwards its own name to a collaborator is flagged
+
+## [0.7.1] - 2026-08-05
+
+### Removed
+
+- `Style/ConditionalAssignment` configuration — the stock default governs assignment from a conditional again
+
 ## [0.7.0] - 2026-08-05
 
 ### Added

data/README.md

@@ -76,7 +76,6 @@ Where a 4Shark cop supersedes or contradicts a stock cop, `config/default.yml` t
 
 | Cop | Intent |
 |---|---|
-| `Style/ConditionalAssignment` | When a conditional decides a value, each branch assigns the variable. The cop's default (`assign_to_condition`) demands `x = if ... else ... end`, the one form the no-ternary convention rejects — converting a ternary would land straight on it. Ternaries are out of scope (`IncludeTernaryExpressions: false`): `Style/DisallowTernary` bans them, and this cop's ternary autocorrect only produces another ternary. Stock cop, configured via `EnforcedStyle`. |
 | `Style/DisallowDelegate` | Flags automatic delegation (`delegate`, `delegate_missing_to`, `def_delegator(s)`, `DelegateClass`). A `delegate` line is a macro call, not a definition, so `grep 'def foo'` and jump-to-definition find nothing — the community name for the smell is Fowler's Middle Man. Write the method, or let the caller ask the object that knows. |
 | `Style/DisallowSafeNavigation` | Flags safe navigation (`&.`). 4Shark rejects it — a `&.` chain silently swallows a `nil` that usually signals a real bug. Use an explicit conditional so the `nil` case is handled on purpose. |
 | `Style/DisallowTernary` | Flags the ternary conditional (`cond ? a : b`). `?` and `:` are punctuation that already mean other things in Ruby (`valid?`, `:symbol`), and the ternary hides a branch inside an expression where skimming misses it. Use an explicit `if`/`else`. |

data/config/default.yml

@@ -22,17 +22,6 @@ Layout/MultilineMethodCallIndentation:
 Naming/RescuedExceptionsVariableName:
   PreferredName: exception
 
-# Stock cop configured (not a 4Shark cop): when a conditional decides a value,
-# each branch assigns the variable. The cop's default (`assign_to_condition`)
-# demands `x = if ... else ... end`, the one form the 4Shark no-ternary
-# convention rejects — converting a ternary would land straight on it.
-# Ternaries are out of scope: `Style/DisallowTernary` bans them outright, and
-# this cop's ternary autocorrect produces another ternary (`cond ? x = a : x = b`),
-# which stays an offense that no autocorrect can clear.
-Style/ConditionalAssignment:
-  EnforcedStyle: assign_inside_condition
-  IncludeTernaryExpressions: false
-
 Style/DisallowDelegate:
   Description: 'Do not use automatic delegation. Write the method explicitly.'
   Enabled: true

data/lib/rubocop/cop/factory_bot/association_in_factory.rb

@@ -35,11 +35,11 @@ module RuboCop
           body = node.body
           return unless body
 
-          if body.begin_type?
-            statements = body.children
-          else
-            statements = [body]
-          end
+          statements = if body.begin_type?
+                         body.children
+                       else
+                         [body]
+                       end
 
           statements.each do |statement|
             add_offense(statement.loc.selector) if association_call?(statement)

data/lib/rubocop/cop/rails/bidirectional_association.rb

@@ -47,22 +47,22 @@ module RuboCop
 
             opposite_content = File.read(opposite_model_path)
 
-            if inverse_name
-              expected_inverse = inverse_name.to_s
-            else
-              expected_inverse = camel_to_snake(model_name).split('/').last.pluralize
-            end
+            expected_inverse = if inverse_name
+                                 inverse_name.to_s
+                               else
+                                 camel_to_snake(model_name).split('/').last.pluralize
+                               end
 
             unless /(belongs_to|has_many|has_one)\s+:#{expected_inverse}/.match?(opposite_content)
               add_global_offense("#{target_class} is missing opposite association for #{model_name}")
             end
           end
         rescue StandardError => exception
-          if processed_source && processed_source.buffer
-            source_name = processed_source.file_path
-          else
-            source_name = 'unknown'
-          end
+          source_name = if processed_source && processed_source.buffer
+                          processed_source.file_path
+                        else
+                          'unknown'
+                        end
 
           warn "Rails/BidirectionalAssociation failed on #{source_name}: #{exception.message}"
         end

data/lib/rubocop/cop/rails/mandatory_inverse_of.rb

@@ -42,11 +42,11 @@ module RuboCop
 
           add_offense(node.loc.selector) if missing_inverse_of
         rescue StandardError => exception
-          if processed_source && processed_source.buffer
-            source_name = processed_source.file_path
-          else
-            source_name = 'unknown'
-          end
+          source_name = if processed_source && processed_source.buffer
+                          processed_source.file_path
+                        else
+                          'unknown'
+                        end
 
           warn "Rails/MandatoryInverseOf failed on #{source_name}: #{exception.message}"
         end

data/lib/rubocop/cop/rails/ordered_macros.rb

@@ -39,11 +39,11 @@ module RuboCop
           body = node.body
           return unless body
 
-          if body.begin_type?
-            statements = body.children
-          else
-            statements = [body]
-          end
+          statements = if body.begin_type?
+                         body.children
+                       else
+                         [body]
+                       end
 
           MACROS.each do |macro|
             calls = statements.select { |statement| macro_call?(statement, macro) }

data/lib/rubocop/cop/rspec/inverse_of_matcher.rb

@@ -47,11 +47,11 @@ module RuboCop
             add_offense(node.loc.selector, message: MSG_FORBIDDEN_INVERSE) if chain_has_inverse_of?(node)
           end
         rescue StandardError => exception
-          if processed_source && processed_source.buffer
-            source_name = processed_source.file_path
-          else
-            source_name = 'unknown'
-          end
+          source_name = if processed_source && processed_source.buffer
+                          processed_source.file_path
+                        else
+                          'unknown'
+                        end
 
           warn "RSpec/InverseOfMatcher failed on #{source_name}: #{exception.message}"
         end

data/lib/rubocop/cop/rspec/overwritten_let.rb

@@ -65,11 +65,11 @@ module RuboCop
           body = group.body
           return false unless body
 
-          if body.begin_type?
-            statements = body.children
-          else
-            statements = [body]
-          end
+          statements = if body.begin_type?
+                         body.children
+                       else
+                         [body]
+                       end
 
           statements.any? { |statement| let_named?(statement, name) }
         end
@@ -77,11 +77,11 @@ module RuboCop
         def let_named?(statement, name)
           return false unless statement.is_a?(::RuboCop::AST::Node)
 
-          if statement.respond_to?(:send_node)
-            send = statement.send_node
-          else
-            send = statement
-          end
+          send = if statement.respond_to?(:send_node)
+                   statement.send_node
+                 else
+                   statement
+                 end
 
           return false unless send.send_type?
           return false unless LET_METHODS.include?(send.method_name) && send.receiver.nil?

data/lib/rubocop/cop/style/disallow_delegate.rb

@@ -5,31 +5,56 @@ require 'rubocop'
 module RuboCop
   module Cop
     module Style
-      # Forbids automatic delegation — `delegate`, `delegate_missing_to`,
-      # `def_delegator`/`def_delegators` (Forwardable) and `DelegateClass`.
-      # A delegation macro is a call, not a definition, so `grep 'def foo'` and
-      # jump-to-definition find nothing; the community name for the smell is
-      # Fowler's Middle Man. Write the method, or delete the wrapper and let the
-      # caller ask the object that knows.
+      # Forbids delegation — a class answering a question that belongs to a
+      # collaborator. The community name for the smell is Fowler's Middle Man,
+      # and the prescribed refactoring is Remove Middle Man: delete the
+      # forwarder and let the caller navigate to the object that knows.
+      #
+      # Two shapes are flagged. The macro family (`delegate`,
+      # `delegate_missing_to`, `def_delegator`/`def_delegators`,
+      # `DelegateClass`) and an instance method whose entire body forwards the
+      # same message to a collaborator. The second is the same defect: writing
+      # the forwarder by hand changes what `grep` finds, not what the class
+      # claims to be responsible for.
       #
       # @example
       #   # bad
-      #   delegate :commission, to: :user_commission
+      #   delegate :name, to: :commission
       #
-      #   # good
-      #   def commission
-      #     user_commission.commission
+      #   # bad — same promise, written by hand
+      #   def name
+      #     commission.name
       #   end
       #
+      #   # good — the caller navigates
+      #   statement.commission.name
+      #
       class DisallowDelegate < ::RuboCop::Cop::Base
-        MSG = 'Do not use automatic delegation. Write the method explicitly instead.'
+        MACRO_MSG = 'Do not use automatic delegation. Delete the forwarder and let the caller navigate.'
+        FORWARDER_MSG = 'Do not forward a collaborator\'s message. Delete the forwarder and let the caller navigate.'
 
         RESTRICT_ON_SEND = %i[delegate delegate_missing_to def_delegator def_delegators DelegateClass].freeze
 
         def on_send(node)
           return unless node.receiver.nil?
 
-          add_offense(node)
+          add_offense(node, message: MACRO_MSG)
+        end
+
+        def on_def(node)
+          return unless forwards_own_message?(node.body, node.method_name)
+
+          add_offense(node.loc.name, message: FORWARDER_MSG)
+        end
+
+        private
+
+        def forwards_own_message?(body, method_name)
+          return false if body.nil?
+          return false unless body.send_type?
+          return false if body.receiver.nil?
+
+          body.method?(method_name)
         end
       end
     end

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.7.0'
+    VERSION = '0.8.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Paulo Ribeiro