rubocop-fourshark 0.5.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41cd76136c01c232f0172ee89eed1812e4c9becb8d34f53b164848d82695bad3
-  data.tar.gz: d5fda1ef5f623c50ff6cad9db4f332b44df2bf851be64c4d604adb70e558bad3
+  metadata.gz: 49c5ac14dc35386b05d887fcd8b53f2ebafd991014046fef3df088a8c4174816
+  data.tar.gz: 953643562da8fcdda58cd4482246328baddff15ac4ee881468defaaf669ce218
 SHA512:
-  metadata.gz: 1950be7fc24c28c1b89dfd0208da4e2ac997b300ee5a01ecee42601e4bda5fe192619f36d1e26d5da00ff5ca164fb19ab087f09a8ff515ae6510547b3d938e7c
-  data.tar.gz: 78ed7eb5c9dd271902c2c857bdf2fe10f646bca60246813c5a7313e4a886e4e8e7b2ae7e7a516179b13f7bee2f0734f96690b89d2f9276cef3fb146f1eb620a1
+  metadata.gz: b0bc1b6c88559d9b780d05bfb1f052a67b99f5eebc0be6db93e6aa934e9c62cf34ecc594c9549887dee3089874c7c733320781e5025dd664aa0642ae8a211cc4
+  data.tar.gz: 91995ae5a6cabfccdb2374540e27d6dc3f481cbbc4ac54fc888359a237186400dda1e605de34e5169fb304bf3ec2b22ad78a3e80af83ba7ce1823eec69716cbc

data/CHANGELOG.md

@@ -1,3 +1,22 @@
+## [0.7.0] - 2026-08-05
+
+### Added
+
+- `Style/DisallowDelegate` — automatic delegation is flagged
+- `Style/DisallowTernary` — the ternary conditional is flagged
+
+### Changed
+
+- `Rails/Delegate` disabled — it asks for the macro `Style/DisallowDelegate` forbids
+- `Style/MultilineTernaryOperator`, `Style/NestedTernaryOperator` and `Style/TernaryParentheses` disabled — they shape a construct `Style/DisallowTernary` forbids outright
+- `Style/ConditionalAssignment` configured to `assign_inside_condition` — a conditional that decides a value assigns it in each branch, and ternaries are left to `Style/DisallowTernary`
+
+## [0.6.0] - 2026-08-05
+
+### Added
+
+- `Naming/RescuedExceptionsVariableName` configured to `exception` — a rescued exception is no longer bound to a single-letter name
+
 ## [0.5.1] - 2026-06-29
 
 ### Fixed

data/README.md

@@ -52,11 +52,11 @@ Activating the plugin auto-loads the gem's `config/default.yml`, which enables e
 
 All cops are **enabled by default** the moment the plugin is activated. Cops scoped to a path (models, specs, factories) only run on files matching that path. Each cop's source file under [`lib/rubocop/cop`](lib/rubocop/cop) carries runnable `@example` blocks showing the bad/good shapes.
 
-### Naming
+### Cop naming
 
 Cop names follow RuboCop's empirical convention — a noun phrase describing the construct or smell, no `Disallow*`/`No*` prefixes — with two deliberate exceptions:
 
-- **`Style/DisallowSafeNavigation` / `Style/DisallowTry`** keep the `Disallow*` prefix. RuboCop has no idiom for "forbid a construct it otherwise permits" (it uses `EnforcedStyle` on one cop), and the natural noun name is already taken by a stock cop with the *opposite* intent — `Style/SafeNavigation` *converts to* `&.`. `Disallow*` is unambiguous and collision-free.
+- **`Style/DisallowDelegate` / `Style/DisallowSafeNavigation` / `Style/DisallowTernary` / `Style/DisallowTry`** keep the `Disallow*` prefix. RuboCop has no idiom for "forbid a construct it otherwise permits" (it uses `EnforcedStyle` on one cop), and the natural noun name is already taken by a stock cop with the *opposite* intent — `Style/SafeNavigation` *converts to* `&.`, `Rails/Delegate` *converts to* `delegate`. `Disallow*` is unambiguous and collision-free.
 - **`Rails/MandatoryInverseOf`** is named to distinguish it from stock `Rails/InverseOf`, which only flags associations where Active Record cannot auto-detect the inverse. Ours mandates `inverse_of` on *every* association — a strict superset — so the gem disables the stock cop (below).
 
 ### Stock cops disabled
@@ -65,14 +65,21 @@ Where a 4Shark cop supersedes or contradicts a stock cop, `config/default.yml` t
 
 | Disabled stock cop | Why |
 |---|---|
+| `Rails/Delegate` | contradicts `Style/DisallowDelegate` — it turns an explicit method into `delegate`, we forbid the macro |
 | `Rails/InverseOf` | superseded by `Rails/MandatoryInverseOf` (covers its cases and more) |
+| `Style/MultilineTernaryOperator` | superseded by `Style/DisallowTernary` — it shapes a construct we forbid outright |
+| `Style/NestedTernaryOperator` | superseded by `Style/DisallowTernary` — same |
 | `Style/SafeNavigation` | contradicts `Style/DisallowSafeNavigation` — it pushes `&.`, we forbid it |
+| `Style/TernaryParentheses` | superseded by `Style/DisallowTernary` — same |
 
 ### Style
 
 | Cop | Intent |
 |---|---|
+| `Style/ConditionalAssignment` | When a conditional decides a value, each branch assigns the variable. The cop's default (`assign_to_condition`) demands `x = if ... else ... end`, the one form the no-ternary convention rejects — converting a ternary would land straight on it. Ternaries are out of scope (`IncludeTernaryExpressions: false`): `Style/DisallowTernary` bans them, and this cop's ternary autocorrect only produces another ternary. Stock cop, configured via `EnforcedStyle`. |
+| `Style/DisallowDelegate` | Flags automatic delegation (`delegate`, `delegate_missing_to`, `def_delegator(s)`, `DelegateClass`). A `delegate` line is a macro call, not a definition, so `grep 'def foo'` and jump-to-definition find nothing — the community name for the smell is Fowler's Middle Man. Write the method, or let the caller ask the object that knows. |
 | `Style/DisallowSafeNavigation` | Flags safe navigation (`&.`). 4Shark rejects it — a `&.` chain silently swallows a `nil` that usually signals a real bug. Use an explicit conditional so the `nil` case is handled on purpose. |
+| `Style/DisallowTernary` | Flags the ternary conditional (`cond ? a : b`). `?` and `:` are punctuation that already mean other things in Ruby (`valid?`, `:symbol`), and the ternary hides a branch inside an expression where skimming misses it. Use an explicit `if`/`else`. |
 | `Style/DisallowTry` | Flags `try` / `try!`. Same rationale — it hides the `nil`/missing-method case instead of handling it explicitly. |
 
 ### Layout
@@ -81,6 +88,12 @@ Where a 4Shark cop supersedes or contradicts a stock cop, `config/default.yml` t
 |---|---|
 | `Layout/MultilineStatementSpacing` | Requires a blank line between two consecutive statements when either spans multiple lines, so multi-line statements read as distinct units. |
 
+### Naming
+
+| Cop | Intent |
+|---|---|
+| `Naming/RescuedExceptionsVariableName` | A rescued exception is bound to `exception` (`_exception` when unread), not the cop's default `e` — 4Shark bans single-letter variables, and this is the one slot where a stock cop demanded one. Stock cop, configured via `PreferredName`; autocorrects. |
+
 ### Rails (models)
 
 | Cop | Intent |
@@ -97,7 +110,7 @@ Where a 4Shark cop supersedes or contradicts a stock cop, `config/default.yml` t
 | `RSpec/Dialect` | Use `let`, never `subject` or `let!` — every `subject`/`subject!`/`let!` is flagged in favor of a lazy `let` (force creation in an explicit `before`, not with `let!`). The implicit subject behind `is_expected` is a different method and is left untouched. Stock cop, configured via `PreferredMethods`. |
 | `RSpec/InverseOfMatcher` | Root models must assert `.inverse_of` in association specs; subclasses must not (it belongs to the parent). Scoped to `spec/models`. |
 | `RSpec/OverwrittenLet` | A `let`/`let!` must not override one defined in an outer example group — shadowing makes it ambiguous which value applies. Scenario-specific `let`s, and the same name across sibling contexts, are fine. |
-| `RSpec/ConditionalInLet` | A `let` must not contain conditional logic (`if`/`case`) — branch with separate `context`s instead. Ternaries are allowed. |
+| `RSpec/ConditionalInLet` | A `let` must not contain conditional logic (`if`/`case`) — branch with separate `context`s instead. A ternary inside a `let` is flagged by `Style/DisallowTernary`, not by this cop. |
 | `RSpec/FactoryBotInBefore` | Object creation belongs in `let`, not `before`. `before` is for actions, not for building the subjects under test. |
 
 ### FactoryBot (factories)

data/config/default.yml

@@ -14,11 +14,40 @@ Layout/MultilineStatementSpacing:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
+# Stock cop configured (not a 4Shark cop): name the rescued exception variable
+# `exception`. The cop's default is `e`, and a single-letter variable is banned by
+# the 4Shark naming convention — so the two disagree on every rescue in the
+# codebase. `PreferredName` is the option the cop ships to settle exactly that,
+# and the cop autocorrects, so the rename is mechanical.
+Naming/RescuedExceptionsVariableName:
+  PreferredName: exception
+
+# Stock cop configured (not a 4Shark cop): when a conditional decides a value,
+# each branch assigns the variable. The cop's default (`assign_to_condition`)
+# demands `x = if ... else ... end`, the one form the 4Shark no-ternary
+# convention rejects — converting a ternary would land straight on it.
+# Ternaries are out of scope: `Style/DisallowTernary` bans them outright, and
+# this cop's ternary autocorrect produces another ternary (`cond ? x = a : x = b`),
+# which stays an offense that no autocorrect can clear.
+Style/ConditionalAssignment:
+  EnforcedStyle: assign_inside_condition
+  IncludeTernaryExpressions: false
+
+Style/DisallowDelegate:
+  Description: 'Do not use automatic delegation. Write the method explicitly.'
+  Enabled: true
+  VersionAdded: '0.7.0'
+
 Style/DisallowSafeNavigation:
   Description: 'Do not use safe navigation (`&.`). Use explicit conditionals instead.'
   Enabled: true
   VersionAdded: '0.1.0'
 
+Style/DisallowTernary:
+  Description: 'Do not use the ternary conditional. Use an explicit `if`/`else` instead.'
+  Enabled: true
+  VersionAdded: '0.7.0'
+
 Style/DisallowTry:
   Description: 'Do not use `try` or `try!`. Use explicit conditionals instead.'
   Enabled: true
@@ -105,11 +134,27 @@ FactoryBot/AssociationInFactory:
   VersionAdded: '0.2.0'
 
 # Stock cops disabled because a 4Shark cop supersedes or contradicts them.
+# `Rails/Delegate` flags `def bar; foo.bar; end` and asks for `delegate :bar, to: :foo`,
+# the opposite of `Style/DisallowDelegate`.
 # `Rails/InverseOf` only flags when AR can't auto-detect the inverse;
 # `Rails/MandatoryInverseOf` covers it and more.
+# The three ternary-shaping cops are superseded by `Style/DisallowTernary`, which bans
+# every ternary — they could only ever fire on a line that is already an offense.
 # `Style/SafeNavigation` converts to `&.`, the opposite of `Style/DisallowSafeNavigation`.
+Rails/Delegate:
+  Enabled: false
+
 Rails/InverseOf:
   Enabled: false
 
+Style/MultilineTernaryOperator:
+  Enabled: false
+
+Style/NestedTernaryOperator:
+  Enabled: false
+
 Style/SafeNavigation:
   Enabled: false
+
+Style/TernaryParentheses:
+  Enabled: false

data/lib/rubocop/cop/factory_bot/association_in_factory.rb

@@ -35,7 +35,11 @@ module RuboCop
           body = node.body
           return unless body
 
-          statements = body.begin_type? ? body.children : [body]
+          if body.begin_type?
+            statements = body.children
+          else
+            statements = [body]
+          end
 
           statements.each do |statement|
             add_offense(statement.loc.selector) if association_call?(statement)

data/lib/rubocop/cop/fourshark_cops.rb

@@ -10,5 +10,7 @@ require_relative 'rspec/conditional_in_let'
 require_relative 'rspec/factory_bot_in_before'
 require_relative 'rspec/inverse_of_matcher'
 require_relative 'rspec/overwritten_let'
+require_relative 'style/disallow_delegate'
 require_relative 'style/disallow_safe_navigation'
+require_relative 'style/disallow_ternary'
 require_relative 'style/disallow_try'

data/lib/rubocop/cop/rails/bidirectional_association.rb

@@ -47,26 +47,24 @@ module RuboCop
 
             opposite_content = File.read(opposite_model_path)
 
-            expected_inverse =
-              if inverse_name
-                inverse_name.to_s
-              else
-                camel_to_snake(model_name).split('/').last.pluralize
-              end
+            if inverse_name
+              expected_inverse = inverse_name.to_s
+            else
+              expected_inverse = camel_to_snake(model_name).split('/').last.pluralize
+            end
 
             unless /(belongs_to|has_many|has_one)\s+:#{expected_inverse}/.match?(opposite_content)
               add_global_offense("#{target_class} is missing opposite association for #{model_name}")
             end
           end
-        rescue StandardError => e
-          source_name =
-            if processed_source && processed_source.buffer
-              processed_source.file_path
-            else
-              'unknown'
-            end
+        rescue StandardError => exception
+          if processed_source && processed_source.buffer
+            source_name = processed_source.file_path
+          else
+            source_name = 'unknown'
+          end
 
-          warn "Rails/BidirectionalAssociation failed on #{source_name}: #{e.message}"
+          warn "Rails/BidirectionalAssociation failed on #{source_name}: #{exception.message}"
         end
 
         private

data/lib/rubocop/cop/rails/mandatory_inverse_of.rb

@@ -41,15 +41,14 @@ module RuboCop
             !kwargs || !kwargs.hash_type? || kwargs.keys.none? { |k| k.value == :inverse_of }
 
           add_offense(node.loc.selector) if missing_inverse_of
-        rescue StandardError => e
-          source_name =
-            if processed_source && processed_source.buffer
-              processed_source.file_path
-            else
-              'unknown'
-            end
+        rescue StandardError => exception
+          if processed_source && processed_source.buffer
+            source_name = processed_source.file_path
+          else
+            source_name = 'unknown'
+          end
 
-          warn "Rails/MandatoryInverseOf failed on #{source_name}: #{e.message}"
+          warn "Rails/MandatoryInverseOf failed on #{source_name}: #{exception.message}"
         end
 
         private

data/lib/rubocop/cop/rails/ordered_macros.rb

@@ -39,7 +39,11 @@ module RuboCop
           body = node.body
           return unless body
 
-          statements = body.begin_type? ? body.children : [body]
+          if body.begin_type?
+            statements = body.children
+          else
+            statements = [body]
+          end
 
           MACROS.each do |macro|
             calls = statements.select { |statement| macro_call?(statement, macro) }

data/lib/rubocop/cop/rspec/conditional_in_let.rb

@@ -7,7 +7,7 @@ module RuboCop
     module RSpec
       # Forbids conditional logic (`if`/`case`) inside a `let`/`let!` block.
       # Branching object setup belongs in separate `context` blocks, not in a
-      # single `let`. Ternaries are allowed.
+      # single `let`. A ternary is flagged by `Style/DisallowTernary`, not here.
       #
       # @example
       #   # bad

data/lib/rubocop/cop/rspec/inverse_of_matcher.rb

@@ -46,15 +46,14 @@ module RuboCop
           elsif classification == :subclass
             add_offense(node.loc.selector, message: MSG_FORBIDDEN_INVERSE) if chain_has_inverse_of?(node)
           end
-        rescue StandardError => e
-          source_name =
-            if processed_source && processed_source.buffer
-              processed_source.file_path
-            else
-              'unknown'
-            end
-
-          warn "RSpec/InverseOfMatcher failed on #{source_name}: #{e.message}"
+        rescue StandardError => exception
+          if processed_source && processed_source.buffer
+            source_name = processed_source.file_path
+          else
+            source_name = 'unknown'
+          end
+
+          warn "RSpec/InverseOfMatcher failed on #{source_name}: #{exception.message}"
         end
 
         private
@@ -114,7 +113,9 @@ module RuboCop
 
         def model_source(model_name)
           path = File.join(Dir.pwd, 'app/models', "#{camel_to_snake(model_name)}.rb")
-          File.exist?(path) ? File.read(path) : nil
+          return File.read(path) if File.exist?(path)
+
+          nil
         end
 
         # The declared superclass of the specific class named by the spec — not the

data/lib/rubocop/cop/rspec/overwritten_let.rb

@@ -65,7 +65,11 @@ module RuboCop
           body = group.body
           return false unless body
 
-          statements = body.begin_type? ? body.children : [body]
+          if body.begin_type?
+            statements = body.children
+          else
+            statements = [body]
+          end
 
           statements.any? { |statement| let_named?(statement, name) }
         end
@@ -73,7 +77,12 @@ module RuboCop
         def let_named?(statement, name)
           return false unless statement.is_a?(::RuboCop::AST::Node)
 
-          send = statement.respond_to?(:send_node) ? statement.send_node : statement
+          if statement.respond_to?(:send_node)
+            send = statement.send_node
+          else
+            send = statement
+          end
+
           return false unless send.send_type?
           return false unless LET_METHODS.include?(send.method_name) && send.receiver.nil?
 
@@ -83,7 +92,9 @@ module RuboCop
 
         def let_name(node)
           first = node.first_argument
-          first && first.sym_type? ? first.value : nil
+          return first.value if first && first.sym_type?
+
+          nil
         end
       end
     end

data/lib/rubocop/cop/style/disallow_delegate.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Style
+      # Forbids automatic delegation — `delegate`, `delegate_missing_to`,
+      # `def_delegator`/`def_delegators` (Forwardable) and `DelegateClass`.
+      # A delegation macro is a call, not a definition, so `grep 'def foo'` and
+      # jump-to-definition find nothing; the community name for the smell is
+      # Fowler's Middle Man. Write the method, or delete the wrapper and let the
+      # caller ask the object that knows.
+      #
+      # @example
+      #   # bad
+      #   delegate :commission, to: :user_commission
+      #
+      #   # good
+      #   def commission
+      #     user_commission.commission
+      #   end
+      #
+      class DisallowDelegate < ::RuboCop::Cop::Base
+        MSG = 'Do not use automatic delegation. Write the method explicitly instead.'
+
+        RESTRICT_ON_SEND = %i[delegate delegate_missing_to def_delegator def_delegators DelegateClass].freeze
+
+        def on_send(node)
+          return unless node.receiver.nil?
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/disallow_ternary.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Style
+      # Forbids the ternary conditional. `?` and `:` are punctuation that already
+      # mean other things in Ruby (`valid?`, `:symbol`), so the reader
+      # disambiguates characters before seeing the branch — and the ternary hides
+      # a branch inside an expression, where skimming misses it. Inside a hash or
+      # an argument list, extract a named local and branch on it.
+      #
+      # @example
+      #   # bad
+      #   status = saved ? :applied : :failed
+      #
+      #   # good
+      #   if saved
+      #     status = :applied
+      #   else
+      #     status = :failed
+      #   end
+      #
+      class DisallowTernary < ::RuboCop::Cop::Base
+        MSG = 'Do not use the ternary conditional. Use an explicit `if`/`else` instead.'
+
+        def on_if(node)
+          add_offense(node) if node.ternary?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.5.1'
+    VERSION = '0.7.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Paulo Ribeiro
@@ -147,7 +147,9 @@ files:
 - lib/rubocop/cop/rspec/factory_bot_in_before.rb
 - lib/rubocop/cop/rspec/inverse_of_matcher.rb
 - lib/rubocop/cop/rspec/overwritten_let.rb
+- lib/rubocop/cop/style/disallow_delegate.rb
 - lib/rubocop/cop/style/disallow_safe_navigation.rb
+- lib/rubocop/cop/style/disallow_ternary.rb
 - lib/rubocop/cop/style/disallow_try.rb
 - lib/rubocop/fourshark.rb
 - lib/rubocop/fourshark/plugin.rb