rubocop-fourshark 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f3bb315d43f2566a53923bb26dd2c22024f52f70d85e5cf6e3de77707cd3267
-  data.tar.gz: b412c10e92d9d9c68b9d291379b87deea8bf06d60e448be493c3800308908604
+  metadata.gz: c4b2d2e8d312ae14c7f582304f4b698783d89dcbaaabb97edbdbf8eb8637d782
+  data.tar.gz: 2c21cc3d147f2210f38dc5d694b72a3955da359518a037a9270d60c67bf352d3
 SHA512:
-  metadata.gz: 2a779bab95e9568e42c16a69982cb0cb6988f7972297a94953c0865c2491741b07c612fbfa16376a4a92b42be3600929efc6156832b49ccf00c48e5baf853f6b
-  data.tar.gz: c5ff6b67765e40271346cb8cc2cbc6675b49931704289e5a3338670730eb8052bc1c336f3b20c71c30baf2d005528f90bfd2c6e3dafafa4638a11ce26da66c1d
+  metadata.gz: c314121bb42e4b79fe8e2ab9f6658c47f44042ef9cc0038bdd62a905ac8bbe986ff26f1ee67521e6d73ea2585ddaf0fd3d393cb2b54d853f16e115985cc769a6
+  data.tar.gz: 861c512174a3a30f7ecbe223467f41899ea8a418f631eb3e44c51c35715538a667be755e5e4bd7f87d7370827347fd75958cfb8cac2296c998ba2e4c1a82c058

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [0.6.0] - 2026-08-05
+
+### Added
+
+- `Naming/RescuedExceptionsVariableName` configured to `exception` — a rescued exception is no longer bound to a single-letter name
+
+## [0.5.1] - 2026-06-29
+
+### Fixed
+
+- `RSpec/Dialect` no longer remaps `subject`/`subject!` to `let`; only `let!` is remapped. The blind identifier rename rewrote value references such as `expect(subject)` into invalid `expect(let)`
+
 ## [0.5.0] - 2026-06-29
 
 ### Changed

data/README.md

@@ -52,7 +52,7 @@ Activating the plugin auto-loads the gem's `config/default.yml`, which enables e
 
 All cops are **enabled by default** the moment the plugin is activated. Cops scoped to a path (models, specs, factories) only run on files matching that path. Each cop's source file under [`lib/rubocop/cop`](lib/rubocop/cop) carries runnable `@example` blocks showing the bad/good shapes.
 
-### Naming
+### Cop naming
 
 Cop names follow RuboCop's empirical convention — a noun phrase describing the construct or smell, no `Disallow*`/`No*` prefixes — with two deliberate exceptions:
 
@@ -81,6 +81,12 @@ Where a 4Shark cop supersedes or contradicts a stock cop, `config/default.yml` t
 |---|---|
 | `Layout/MultilineStatementSpacing` | Requires a blank line between two consecutive statements when either spans multiple lines, so multi-line statements read as distinct units. |
 
+### Naming
+
+| Cop | Intent |
+|---|---|
+| `Naming/RescuedExceptionsVariableName` | A rescued exception is bound to `exception` (`_exception` when unread), not the cop's default `e` — 4Shark bans single-letter variables, and this is the one slot where a stock cop demanded one. Stock cop, configured via `PreferredName`; autocorrects. |
+
 ### Rails (models)
 
 | Cop | Intent |

data/config/default.yml

@@ -14,6 +14,14 @@ Layout/MultilineStatementSpacing:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
+# Stock cop configured (not a 4Shark cop): name the rescued exception variable
+# `exception`. The cop's default is `e`, and a single-letter variable is banned by
+# the 4Shark naming convention — so the two disagree on every rescue in the
+# codebase. `PreferredName` is the option the cop ships to settle exactly that,
+# and the cop autocorrects, so the rename is mechanical.
+Naming/RescuedExceptionsVariableName:
+  PreferredName: exception
+
 Style/DisallowSafeNavigation:
   Description: 'Do not use safe navigation (`&.`). Use explicit conditionals instead.'
   Enabled: true
@@ -56,16 +64,15 @@ Rails/OrderedMacros:
     - 'app/models/**/*.rb'
   VersionAdded: '0.2.0'
 
-# Stock cop configured (not a 4Shark cop): map `subject`/`subject!`/`let!` to `let`
-# so every `subject`, `subject!` and `let!` call is flagged in favor of a lazy
-# `let` (force creation in an explicit `before`, not with `let!`). The implicit
-# subject behind `is_expected` is a different method and is left untouched.
+# Stock cop configured (not a 4Shark cop): map `let!` to `let` so every eager
+# `let!` call is flagged in favor of a lazy `let` (force creation in an explicit
+# `before`, not with `let!`). `subject`/`subject!` are intentionally NOT remapped:
+# RSpec/Dialect renames the identifier blindly, so a `subject` -> `let` mapping
+# also rewrites value references like `expect(subject)` into invalid `expect(let)`.
 RSpec/Dialect:
-  Description: 'Use `let`, never `subject` or `let!` — objects are lazy `let`, forced in `before`.'
+  Description: 'Prefer a lazy `let` over `let!` — force creation in an explicit `before`, not with `let!`.'
   Enabled: true
   PreferredMethods:
-    subject: let
-    subject!: let
     let!: let
   Include:
     - 'spec/**/*_spec.rb'

data/lib/rubocop/cop/rails/bidirectional_association.rb

@@ -58,7 +58,7 @@ module RuboCop
               add_global_offense("#{target_class} is missing opposite association for #{model_name}")
             end
           end
-        rescue StandardError => e
+        rescue StandardError => exception
           source_name =
             if processed_source && processed_source.buffer
               processed_source.file_path
@@ -66,7 +66,7 @@ module RuboCop
               'unknown'
             end
 
-          warn "Rails/BidirectionalAssociation failed on #{source_name}: #{e.message}"
+          warn "Rails/BidirectionalAssociation failed on #{source_name}: #{exception.message}"
         end
 
         private

data/lib/rubocop/cop/rails/mandatory_inverse_of.rb

@@ -41,7 +41,7 @@ module RuboCop
             !kwargs || !kwargs.hash_type? || kwargs.keys.none? { |k| k.value == :inverse_of }
 
           add_offense(node.loc.selector) if missing_inverse_of
-        rescue StandardError => e
+        rescue StandardError => exception
           source_name =
             if processed_source && processed_source.buffer
               processed_source.file_path
@@ -49,7 +49,7 @@ module RuboCop
               'unknown'
             end
 
-          warn "Rails/MandatoryInverseOf failed on #{source_name}: #{e.message}"
+          warn "Rails/MandatoryInverseOf failed on #{source_name}: #{exception.message}"
         end
 
         private

data/lib/rubocop/cop/rspec/inverse_of_matcher.rb

@@ -46,7 +46,7 @@ module RuboCop
           elsif classification == :subclass
             add_offense(node.loc.selector, message: MSG_FORBIDDEN_INVERSE) if chain_has_inverse_of?(node)
           end
-        rescue StandardError => e
+        rescue StandardError => exception
           source_name =
             if processed_source && processed_source.buffer
               processed_source.file_path
@@ -54,7 +54,7 @@ module RuboCop
               'unknown'
             end
 
-          warn "RSpec/InverseOfMatcher failed on #{source_name}: #{e.message}"
+          warn "RSpec/InverseOfMatcher failed on #{source_name}: #{exception.message}"
         end
 
         private

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.5.0'
+    VERSION = '0.6.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Paulo Ribeiro