rubocop-fourshark 0.3.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a8b84b9e99c1ff660e70c0dc9b6d600361f175fc7ea47be4c27ceb3ed46c879c
-  data.tar.gz: b80b447aff3ef40874166bef818eba3d18caff427b39e095c0ad15099804fc88
+  metadata.gz: 8f3bb315d43f2566a53923bb26dd2c22024f52f70d85e5cf6e3de77707cd3267
+  data.tar.gz: b412c10e92d9d9c68b9d291379b87deea8bf06d60e448be493c3800308908604
 SHA512:
-  metadata.gz: abdb30af6129f55a4c37b4f788dbee1528e28129642bcdaaaddc6164d4187d6fb4b0d8177b27b0b523c5749482951af32ebcbd54963651d8c4eb16bb73b4ab19
-  data.tar.gz: eb6678c1b97f140ef14c222e047b3dbf9c6342281b1a01818f176f9000246de2c95c7d919f1fda3e6cb83507367b88697d049effac922cfd5a3c7f521de323b7
+  metadata.gz: 2a779bab95e9568e42c16a69982cb0cb6988f7972297a94953c0865c2491741b07c612fbfa16376a4a92b42be3600929efc6156832b49ccf00c48e5baf853f6b
+  data.tar.gz: c5ff6b67765e40271346cb8cc2cbc6675b49931704289e5a3338670730eb8052bc1c336f3b20c71c30baf2d005528f90bfd2c6e3dafafa4638a11ce26da66c1d

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+## [0.5.0] - 2026-06-29
+
+### Changed
+
+- Require `rubocop` `>= 1.87` — earlier versions drop the host project's `AllCops/Exclude` when this plugin's config is merged
+
+### Fixed
+
+- `Rails/BidirectionalAssociation` no longer crashes on associations with non-literal options (e.g. `inverse_of: nil`); associations that explicitly opt out of an inverse are skipped
+
+## [0.4.0] - 2026-06-29
+
+### Added
+
+- `Layout/MultilineMethodCallIndentation` configured to `indented` — multiline method-call chains indent continuation calls one step from the receiver instead of aligning with the first call
+
 ## [0.3.0] - 2026-06-19
 
 ### Added

data/README.md

@@ -36,6 +36,18 @@ Activating the plugin auto-loads the gem's `config/default.yml`, which enables e
 
 > **Note — plugins are not transitively activated.** `rubocop-fourshark` depends on the upstream plugins (`rubocop-rails`, `rubocop-rspec`, `rubocop-rspec_rails`, `rubocop-performance`, `rubocop-factory_bot`), but `lint_roller` does not auto-activate a plugin's dependencies. Each repo still lists the upstream plugins it uses in its own `plugins:` block.
 
+> **Note — list `rubocop-fourshark` last.** When this gem configures a cop that an upstream plugin also ships (e.g. `RSpec/Dialect`, owned by `rubocop-rspec`), RuboCop merges the plugins' default config in `plugins:` order and the **last** one wins. List `rubocop-fourshark` **after** the upstream plugins so its configuration is the one that takes effect:
+>
+> ```yaml
+> plugins:
+>   - rubocop-rspec
+>   - rubocop-rspec_rails
+>   - rubocop-rails
+>   - rubocop-performance
+>   - rubocop-factory_bot
+>   - rubocop-fourshark
+> ```
+
 ## Cops
 
 All cops are **enabled by default** the moment the plugin is activated. Cops scoped to a path (models, specs, factories) only run on files matching that path. Each cop's source file under [`lib/rubocop/cop`](lib/rubocop/cop) carries runnable `@example` blocks showing the bad/good shapes.

data/config/default.yml

@@ -8,6 +8,12 @@ Layout/MultilineStatementSpacing:
   Enabled: true
   VersionAdded: '0.2.0'
 
+# Stock cop configured (not a 4Shark cop): enforce the `indented` style for
+# multiline method-call chains — continuation calls are indented one step from
+# the receiver instead of aligning with the first call.
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
 Style/DisallowSafeNavigation:
   Description: 'Do not use safe navigation (`&.`). Use explicit conditionals instead.'
   Enabled: true

data/lib/rubocop/cop/rails/bidirectional_association.rb

@@ -75,18 +75,12 @@ module RuboCop
           processed_source.ast.each_descendant(:send).filter_map do |node|
             next unless %i[belongs_to has_many has_one].include?(node.method_name)
 
-            # Skip polymorphic associations and `as:` options
+            # Skip polymorphic associations, `as:` options, and explicit `inverse_of: nil/false`
             next if polymorphic_or_as?(node)
+            next if inverse_disabled?(node)
 
             model_name = class_name_from_ast
-
-            assoc_name =
-              begin
-                node.first_argument.value if node.first_argument
-              rescue StandardError
-                nil
-              end
-
+            assoc_name = literal_value(node.first_argument)
             inverse_name = extract_inverse_of(node)
             target_class = extract_class_name(node, assoc_name)
 
@@ -95,45 +89,40 @@ module RuboCop
         end
 
         def extract_inverse_of(node)
-          kwargs = node.last_argument
-          return nil unless kwargs && kwargs.hash_type?
-
-          pair =
-            begin
-              kwargs.pairs.find { |p| p.key.value == :inverse_of }
-            rescue StandardError
-              nil
-            end
-
-          pair.value.value if pair && pair.value
+          literal_value(option_value(node, :inverse_of))
         end
 
         def extract_class_name(node, assoc_name)
-          kwargs = node.last_argument
-          return assoc_name.to_s.camelize unless kwargs && kwargs.hash_type?
-
-          class_name_pair =
-            begin
-              kwargs.pairs.find { |p| p.key.value == :class_name }
-            rescue StandardError
-              nil
-            end
+          literal_value(option_value(node, :class_name)) || assoc_name.to_s.camelize
+        end
 
-          if class_name_pair
-            class_name_pair.value.value
-          else
-            assoc_name.to_s.camelize
-          end
+        def inverse_disabled?(node)
+          value = option_value(node, :inverse_of)
+          value.falsey_literal? if value
         end
 
         def polymorphic_or_as?(node)
+          %i[polymorphic as].any? { |key| option_pair(node, key) }
+        end
+
+        # The keyword options hash is the last argument; pairs whose key is not a
+        # plain symbol (string keys, double-splats) are skipped rather than read.
+        def option_pair(node, key)
           kwargs = node.last_argument
-          return false unless kwargs && kwargs.hash_type?
+          return nil unless kwargs.respond_to?(:hash_type?) && kwargs.hash_type?
 
-          kwargs.pairs.any? do |pair|
-            key = pair.key.value
-            %i[polymorphic as].include?(key)
-          end
+          kwargs.pairs.find { |pair| pair.key.sym_type? && pair.key.value == key }
+        end
+
+        def option_value(node, key)
+          pair = option_pair(node, key)
+          pair.value if pair
+        end
+
+        # A node's literal value, only when it actually carries one — guards
+        # against non-literal options like `inverse_of: nil` or `class_name: Foo`.
+        def literal_value(node)
+          node.value if node.respond_to?(:value)
         end
 
         def class_name_from_ast
@@ -159,9 +148,9 @@ module RuboCop
           return '' if name.nil?
 
           name.gsub('::', '/')
-              .gsub(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')
-              .gsub(/([a-z\d])([A-Z])/, '\1_\2')
-              .downcase
+            .gsub(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')
+            .gsub(/([a-z\d])([A-Z])/, '\1_\2')
+            .downcase
         end
       end
     end

data/lib/rubocop/cop/rspec/inverse_of_matcher.rb

@@ -129,9 +129,9 @@ module RuboCop
         # "UserAccount" → "user_account"; "Plan::Statement" → "plan/statement"
         def camel_to_snake(name)
           name.gsub('::', '/')
-              .gsub(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')
-              .gsub(/([a-z\d])([A-Z])/, '\1_\2')
-              .downcase
+            .gsub(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2')
+            .gsub(/([a-z\d])([A-Z])/, '\1_\2')
+            .downcase
         end
       end
     end

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.3.0'
+    VERSION = '0.5.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Paulo Ribeiro
@@ -29,14 +29,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.72.2
+        version: '1.87'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.72.2
+        version: '1.87'
 - !ruby/object:Gem::Dependency
   name: rubocop-factory_bot
   requirement: !ruby/object:Gem::Requirement