rubocop-fourshark 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 202b492f9486b827fd67079c3a7bb113bb194a87fd968646eebbf30b881140cc
-  data.tar.gz: 20f9b022eb67bad4c30fe2295c3d56a30c027594c15142303dcfe707c5390f85
+  metadata.gz: 6c048d884d1fbe9ba0f351c1bdf7e93e70410136084f72bb700dacb04d773cf8
+  data.tar.gz: 2459ffac3431fce8bcba699eea337e61146dedac826ea854f262b96aa01139d7
 SHA512:
-  metadata.gz: 6cd1bc1df875dc06da1fbe6091e896afe434e99f13e64c3f564e5ac43bcf23ac5cb5a4e3e0ff6792829df9df109ec331066fac1395472b536372ced8dd025d65
-  data.tar.gz: f62cfe9f582d0ef9108800eef733aa8957852b7183cc3bee53f7182680a51ceda57293d19137f4baf9badb345cf9add64f9a15643734d0b515672188026435a9
+  metadata.gz: 76dbe2d05b1dc7471ac29d280a91d5bf9daa7a3da1888b7487b0715e36049d9883e72f15de51736c7ad35a8dac5bcca738797547e3f5549b8661b9034253ef26
+  data.tar.gz: c09dcdc4fd7a190a916c9ce199116ad61fcfe2e5d5023139512f23da7418c780a1232b4489e2fb20982b417f93a264c162e2e6af1719255a4875a395c7da5898

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [0.2.2] - 2026-05-30
+
+### Fixed
+
+- `RSpec/InverseOfMatcher` no longer demands `.inverse_of` on polymorphic associations — it reads the polymorphic declaration from the model instead of the spec matcher chain
+- `RSpec/InverseOfMatcher` classifies a nested class by its own superclass instead of the first `class` line in the file — a nested root model is no longer misread as an STI subclass
+
 ## [0.2.1] - 2026-05-29
 
 ### Fixed

data/lib/rubocop/cop/rspec/inverse_of_matcher.rb

@@ -12,7 +12,7 @@ module RuboCop
       # Rules:
       # - Root models (direct superclass = `ApplicationRecord`) must include `.inverse_of`.
       # - STI subclasses (superclass is another model) must NOT include `.inverse_of` (it belongs to the parent).
-      # - Associations marked as polymorphic or through are ignored.
+      # - Associations the model declares as polymorphic are ignored (they have no single inverse).
       # - Classes whose model file is missing or whose superclass is not a model are ignored.
       #
       # The root/subclass decision is made **statically** — by reading the model
@@ -31,12 +31,13 @@ module RuboCop
 
         def on_send(node)
           return unless node.method?(:belong_to)
-          return if chain_has_option?(node, :polymorphic)
-          return if chain_has_option?(node, :through)
 
           model_name = model_class_from_spec
           return unless model_name
 
+          association_name = association_name_from(node)
+          return if association_name && polymorphic_in_model?(model_name, association_name)
+
           classification = classify_model(model_name)
           return if classification == :non_ar
 
@@ -63,13 +64,22 @@ module RuboCop
           node.each_ancestor(:send).any? { |ancestor| ancestor.method?(:inverse_of) }
         end
 
-        # Check if association has a given option (e.g., :polymorphic, :through)
-        def chain_has_option?(node, option_name)
-          node.each_ancestor(:send).any? do |ancestor|
-            ancestor.arguments.any? do |arg|
-              arg.hash_type? && arg.keys.any? { |k| k.value == option_name }
-            end
-          end
+        # The association name passed to the matcher, e.g. belong_to(:user) -> :user
+        def association_name_from(node)
+          argument = node.first_argument
+          return nil unless argument && argument.sym_type?
+
+          argument.value
+        end
+
+        # Whether the model declares this association as polymorphic. Polymorphic
+        # associations have no single inverse, so `.inverse_of` does not apply —
+        # and the declaration lives in the model, not in the spec matcher chain.
+        def polymorphic_in_model?(model_name, association_name)
+          content = model_source(model_name)
+          return false unless content
+
+          content.match?(/belongs_to\s+:#{Regexp.escape(association_name.to_s)}\b[^\n]*polymorphic:\s*true/)
         end
 
         # Convert spec file path into model class name
@@ -92,7 +102,7 @@ module RuboCop
           content = model_source(model_name)
           return :non_ar unless content
 
-          superclass = superclass_of(content)
+          superclass = superclass_of(content, model_name)
           return :non_ar unless superclass
           return :root if superclass == 'ApplicationRecord'
           return :subclass if model_source(superclass)
@@ -107,8 +117,12 @@ module RuboCop
           File.exist?(path) ? File.read(path) : nil
         end
 
-        def superclass_of(content)
-          match = content.match(/^\s*class\s+[\w:]+\s*<\s*([\w:]+)/)
+        # The declared superclass of the specific class named by the spec — not the
+        # first `class` line in the file. A nested `class Row < ApplicationRecord`
+        # inside `class Wrapper < Parent` must resolve to its own superclass.
+        def superclass_of(content, model_name)
+          class_name = model_name.split('::').last
+          match = content.match(/^\s*class\s+(?:[\w:]*::)?#{Regexp.escape(class_name)}\s*<\s*([\w:]+)/)
           match && match[1]
         end
 

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.2.1'
+    VERSION = '0.2.2'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Paulo Ribeiro