rubocop-fourshark 0.11.2 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff1f92dab1c4c499529e7729afcfe28e449879582f476e2a911952ec3140f8df
-  data.tar.gz: 17f2ab8e91dd9392f74bc0cf333dcf58b54b847e67bd05224ad4394857b583b8
+  metadata.gz: 2e6ff1114154e4093f52449659fb89bd30418cfcf6057a2175d38a97898e1ef7
+  data.tar.gz: a487773631597cee69880424b2c137f7c201e580e67b73eb44d79e1cd1be0dab
 SHA512:
-  metadata.gz: ad46dc84d1c4930addcb691f17b405685d684eaaa2fe12eb45353ce366ad352e9bc2c79ed65bc9e5b8da4c94579bebcaba65e1170ac809df467dde62d69c8196
-  data.tar.gz: f7a40f52df08988e967789e44bd7d74271a9074e14819bfc3e3c315afb7b07a6c0fdc9bba256a021b579c480158956aec9ef5066ba05c5210463d0c53fd1695d
+  metadata.gz: 2b23d8a3fc8cc19fe27f04b371ee824ae9688c26a1b0938bc47e0ec47421215913772562f0cc005ed4db3bf6121e37a999e4aa8b5a2116971b31d676ef516e37
+  data.tar.gz: d051ae90d627a60471da2ffaf31e7cc031c05027de6b9272db3c6e00fac9027d2efa44c09b4e75a06866ca28015183d4cf096d0248b185eee8e21c1dd079e756

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## [0.12.0] - 2026-10-07
+
+### Changed
+
+- Bump Dependencies
+
+### Fixed
+
+- `Style/OrderedConstants` — a constant that references one declared above it is no longer flagged
+
 ## [0.11.2] - 2026-10-07
 
 ### Added

data/lib/rubocop/cop/style/ordered_constants.rb

@@ -7,9 +7,10 @@ module RuboCop
     module Style
       # Requires a run of consecutive constant assignments to be sorted
       # alphabetically by name. A lone constant is never flagged; a run is
-      # broken by any non-constant statement. Flags without autocorrecting — a
-      # constant may reference one declared above it, so a human decides the
-      # order. Experimental: if it flags more than it helps, drop it.
+      # broken by any non-constant statement. A constant whose value references
+      # one declared above it in the run is not flagged, since Ruby cannot load
+      # it any earlier. Flags without autocorrecting. Experimental: if it flags
+      # more than it helps, drop it.
       class OrderedConstants < ::RuboCop::Cop::Base
         MSG = 'Sort constant assignments alphabetically (`%<name>s` should come before `%<previous>s`).'
 
@@ -22,16 +23,25 @@ module RuboCop
         private
 
         def flag_unsorted(run)
-          run.each_cons(2) do |previous, current|
+          run.each_cons(2).with_index do |(previous, current), index|
             previous_name = constant_name(previous)
             current_name = constant_name(current)
 
             next if current_name >= previous_name
+            next if references_earlier_constant?(current, run.first(index + 1))
 
             add_offense(current.loc.name, message: format(MSG, name: current_name, previous: previous_name))
           end
         end
 
+        def references_earlier_constant?(node, earlier_constants)
+          earlier_names = earlier_constants.map { |constant| constant_name(constant) }
+
+          node.expression.each_node(:const).any? do |reference|
+            reference.namespace.nil? && earlier_names.include?(reference.short_name.to_s)
+          end
+        end
+
         def constant_assignment?(node)
           node.is_a?(::RuboCop::AST::Node) && node.casgn_type?
         end

data/lib/rubocop/fourshark/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fourshark
-    VERSION = '0.11.2'
+    VERSION = '0.12.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fourshark
 version: !ruby/object:Gem::Version
-  version: 0.11.2
+  version: 0.12.0
 platform: ruby
 authors:
 - Paulo Ribeiro