rubocop-fluentd 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf200b231db6c6f68db7f54526977ad2e6b7e29a335e2a51612ec241f0dd33d9
-  data.tar.gz: 62d5abe1ac0b6a2e2ef55563e2a0dee22c57ec5bcf11152d9af68cdb5f9ad47c
+  metadata.gz: dd34b2ff9474b859c0cfe8209a5b5d872db2f16a5e47151f660e0f29204a9c94
+  data.tar.gz: 722d0abf4840e185c0fae586c0ab6ae9efc1d1d03bd4d0466c758d43a61563dd
 SHA512:
-  metadata.gz: 904369abf32fd8b3ee741e51d7397e71a8dd5d33979dd25e7d6cb715ec8bae3f7843b85b850bca7b74a1ed1ad351efbcdfe5173174a5e700f4eb05bfe66efd51
-  data.tar.gz: 43494d019a086657e42e483d32c07f17b46353081e2894f69ef38bf3a121f4bb79934c21f75a3d5719e16e14c113ef3f2e0a82d6bd261e6579d5040752bf6d29
+  metadata.gz: ee6647f955164e0840749bf48f1c5a634520518a3047cda78f0f3f1403268ca9460ecf7d7c2fc5e1cb44d463131fa5dd9b0289f9d9fb919f36861a29ae07ba40
+  data.tar.gz: 9e18b9374538deb1ab56d3e2f65f4b8050263a1dcb1ae34d81144d3627f472dc3962af36a18e643e0221f4c090a8cdbfa50d731969ad814665c45e90fa5cff17

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## [Unreleased]
 
+## 0.2.2 - 2025-07-18
+
+* `Lint/FluentdPluginLogScope`: Add `AssumeConfigLogLevel` property (`info` by default)
+  It suppress useless warning against `log.info` if `log_level` is same as it.
+
 ## 0.2.1 - 2025-07-15
 
 * Transfer ownership to https://github.com/fluent-plugins-nursery/rubocop-fluentd

data/README.md

@@ -22,6 +22,7 @@ Configure `.rubocop.yml` like this:
 
 ```yaml
 Lint/FluentdPluginLogScope:
+  AssumeConfigLogLevel: 'info'
   Enabled: true
 Lint/FluentdPluginConfigParamDefaultTime:
   Enabled: true

data/config/default.yml

@@ -8,6 +8,7 @@ Lint/FluentdPluginConfigParamDefaultTime:
 Lint/FluentdPluginLogLevel:
   Description: 'Warn global scope `$log` was used in Fluentd plugin. The scope of plugin log level was supported since Fluentd 0.10.43'
   Enabled: true
+  AssumeConfigLogLevel: 'info'
   VersionAdded: '0.1.0'
 
 Performance/FluentdPluginLogStringInterpolation:

data/lib/rubocop/cop/lint/plugin_log_scope.rb

@@ -39,9 +39,16 @@ module RuboCop
         MSG = 'Use plugin scope `log` instead of global scope `$log`.'
 
         # Detect only supported log level
-        RESTRICT_ON_SEND = %i[trace debug info warn error fatal].freeze
+        #RESTRICT_ON_SEND = %i[trace debug info warn error fatal].freeze
         RESTRICT_ON_BLOCK = %i[trace debug info warn error fatal].freeze
 
+        LOG_LEVELS = {'trace' => 0,
+                      'debug' => 1,
+                      'info' => 2,
+                      'warn' => 3,
+                      'error' => 4,
+                      'fatal' => 5}
+
         # @!method global_log_method?(node)
         def_node_matcher :global_reciever_method?, <<~PATTERN
           (send gvar $_ $(...))
@@ -64,10 +71,11 @@ module RuboCop
           return unless global_expression or local_expression
           if global_expression and send_global_log_node?(node)
             expression = global_expression
+            method = expression.first
+            return unless %i[trace debug info warn error fatal].freeze.include?(method)
             # $log.method(...)
             message = 'Use plugin scope `log` instead of global scope `$log`.'
             add_offense(node, message: MSG) do |corrector|
-              method = expression.first
               literal = expression.last
               source_code = "log.#{method} { #{literal.source} }"
               # $log.xxx => log.xxx
@@ -76,7 +84,25 @@ module RuboCop
           elsif local_expression and send_local_log_node?(node)
             # log.method "#{expansion}"
             expression = local_expression
+            method = expression.first
+            return unless %i[trace debug info warn error fatal].freeze.include?(method)
+
+            assume_level = cop_config['AssumeConfigLogLevel'] || 'info'
+            threshould = LOG_LEVELS[assume_level]
+
+            if LOG_LEVELS[method.to_s] >= threshould
+              # no need to apply offense because surely log will be emitted
+              return
+            end
             message = "Use block not to evaluate too long message"
+            method = expression.first
+            assume_level = cop_config['AssumeConfigLogLevel'] || 'info'
+            threshould = LOG_LEVELS[assume_level]
+
+            if LOG_LEVELS[method.to_s] >= threshould
+              # no need to apply offense because surely log will be emitted
+              return
+            end
             add_offense(node, message: message) do |corrector|
               method = expression.first
               literal = expression.last

data/lib/rubocop/fluentd/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Fluentd
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-fluentd
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Kentaro Hayashi