rubocop-faker 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98fabe8553b31d2e305e72dfcbabef73e1480a2a76373ae444cabfdd1a0dd2d6
-  data.tar.gz: e59b83219cf65ea30a506caefdb901476ae4c5a68f78cd5ad0ef618afbc3c2cd
+  metadata.gz: 6fe127b93b5b4fc49045b8e50afa3ad7283c62e1cbc94e644e7ca56f245d931e
+  data.tar.gz: b6d5f9c5ad6eae68439cc5aa1bd3bac928b990f6df6a3a2e1c1687dd9d8be8cc
 SHA512:
-  metadata.gz: 40e2a38812bc30797479531581e0dfc87290384088ddb97ad9f8825650039745a812e480597c39ca6785866a64b110eadc19480cc20f14e9f1c5a9e8afc4ed70
-  data.tar.gz: f307c18b84f97fb365d77c0cd8779120021202caf6325cb6b094703459de90c7b4219b8eb74d242383147af3086ae6338fe5a17f16ecee654e5975e41f7e6375
+  metadata.gz: dfc8a9afb128e2231d46206d34e41e29ea59cc28c0f7d25215b764454d42da2cb4f49bcbd717bb165f87c588a929915a091d64bfa6f48e02e47845fa2eb92796
+  data.tar.gz: 310d47e5ebe089f5bce8d9f2ea6e72cb02229786a21fe9ffee452a7e98c738971ff0a00c314cacf784410ff899d54de877979b69d6b7c7e7b33257c765a7c35b

data/.circleci/config.yml

@@ -35,6 +35,9 @@ workflows:
       - rake_default:
           name: Ruby 2.6
           image: circleci/ruby:2.6
+      - rake_default:
+          name: Ruby 2.7
+          image: circleci/ruby:2.7
       - rake_default:
           name: Ruby HEAD
           image: rubocophq/circleci-ruby-snapshot:latest # Nightly snapshot build

data/.rubocop.yml

@@ -62,6 +62,9 @@ Lint/UselessAccessModifier:
 Lint/BooleanSymbol:
   Enabled: false
 
+Metrics/AbcSize:
+  Max: 20
+
 Metrics/BlockLength:
   Exclude:
     - 'Rakefile'

data/.rubocop_todo.yml

@@ -6,10 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-Metrics/AbcSize:
-  Max: 17
-
 # Offense count: 5
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
@@ -19,5 +15,5 @@ Metrics/MethodLength:
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   Max: 87

data/CHANGELOG.md

@@ -1,5 +1,13 @@
+# Change log
+
 ## master (unreleased)
 
+## 1.0.0 (2019-03-14)
+
+### New features
+
+* [#3](https://github.com/koic/rubocop-faker/issues/3): Make `Faker/DeprecatedArguments` aware of `Faker::Base.unique`. ([@koic][])
+
 ## 0.2.0 (2019-09-04)
 
 ### Bug fixes

data/Gemfile

@@ -9,5 +9,8 @@ gemspec
 gem 'rake'
 gem 'rspec'
 gem 'rubocop', github: 'rubocop-hq/rubocop'
-gem 'rubocop-performance', '~> 1.4.0'
-gem 'yard', '~> 0.9'
+gem 'rubocop-performance', '~> 1.5.0'
+# Workaround for YARD 0.9.20 or lower.
+# It specifies `github` until the release that includes the following changes:
+# https://github.com/lsegal/yard/pull/1290
+gem 'yard', github: 'lsegal/yard', ref: '10a2e5b'

data/lib/rubocop/cop/faker/deprecated_arguments.rb

@@ -28,6 +28,9 @@ module RuboCop
           class_name = faker_class_name(node)
 
           return unless (methods = argument_keywords[class_name])
+
+          node = node.parent if unique_generator_method?(node)
+
           return unless (keywords = methods[node.method_name.to_s])
 
           node.arguments.each_with_index do |argument, index|
@@ -56,6 +59,10 @@ module RuboCop
 
         private
 
+        def unique_generator_method?(node)
+          node.method?(:unique) && node.arguments.size.zero?
+        end
+
         def format_message(keyword:, arg:, index:, class_name:, method_name:)
           i = case index
               when 0 then '1st'
@@ -92,7 +99,11 @@ module RuboCop
         end
 
         def faker_class_name(node)
-          node.receiver.source
+          if node.children.first.send_type? && node.children.first.method?(:unique)
+            node.children.first.receiver.source
+          else
+            node.receiver.source
+          end
         end
 
         def arguments_range(node)

data/lib/rubocop/faker/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Faker
-    VERSION = '0.2.0'
+    VERSION = '1.0.0'
   end
 end

data/tasks/cops_documentation.rake

@@ -197,7 +197,6 @@ task generate_cops_documentation: :yard_for_generate_documentation do
     cops_body(config, cop, description, examples_object, pars)
   end
 
-  # rubocop:disable Metrics/AbcSize
   def table_of_content_for_department(cops, department)
     selected_cops = cops_of_department(cops, department.to_sym).select do |cop|
       cop.to_s.start_with?('RuboCop::Cop::Faker')
@@ -214,7 +213,6 @@ task generate_cops_documentation: :yard_for_generate_documentation do
 
     content
   end
-  # rubocop:enable Metrics/AbcSize
 
   def print_table_of_contents(cops)
     path = "#{Dir.pwd}/manual/cops.md"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-faker
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Koichi ITO
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-09-04 00:00:00.000000000 Z
+date: 2020-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -34,10 +34,8 @@ files:
 - ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
-- ".rspec_status"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -76,7 +74,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A RuboCop extension for Faker.

data/.rspec_status

@@ -1,4 +0,0 @@
-example_id                        | status | run_time        |
---------------------------------- | ------ | --------------- |
-./spec/rubocop/faker_spec.rb[1:1] | passed | 0.00103 seconds |
-./spec/rubocop/faker_spec.rb[1:2] | failed | 0.0248 seconds  |

data/.travis.yml

@@ -1,6 +0,0 @@
----
-language: ruby
-cache: bundler
-rvm:
-  - 2.7.0
-before_install: gem install bundler -v 2.1.0.pre.1