rubocop-factory_bot 2.27.0 → 2.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8bb85fc163eb8e9fc141bb81dbd7d7c2d0327ec605c4aa4dcc41a1bd4bf0e841
-  data.tar.gz: 45987a7e1a5dc366a0c16ab841a863cc2f7866a9a8cba77e58b2a0924aaddcc1
+  metadata.gz: 9a5c117626f22cbe451b7044b247be8b9be8aecaa460f64ea87eb948d54cb6f5
+  data.tar.gz: eff63053af204522a4c23f814c4be844ffb985daf357751a7b411ad35b2051ec
 SHA512:
-  metadata.gz: b8ebe6d629b4f2e22a081b095abe1e2e1dc34c032e4be26b9338385e7d37c7097fe85dad3ebb03e1706594becaa680b27b1119fd6e9ab661a96aaa61a9c4cbf3
-  data.tar.gz: b6d6fede91a931b79919d1ae081b848787de025edd2651205d83d3de641e66fe71c417c082cc79307f4661b7065105694facbf3fe0bbfbd6eeb9ba06808f03be
+  metadata.gz: ef628bbb79001d540c0f21ff8d978b05bf37d3a7f9942f4a75d6348589d4c9349b5ce86406123cbc2e4c2aaa276aad488dc31c4f2058ed3d3c7f1be24604bdbb
+  data.tar.gz: 57f5195ad3056db88fe3f5c76f2085b16db8c3ba65bc27357042e22be9c7d421621fc6fefcb5be3be6380e9e70e3401230e0218e1199c567989b1cf6af8426d6

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 ## Master (Unreleased)
 
+## 2.28.0 (2025-11-12)
+
+- Fix an error for `FactoryBot/AssociationStyle` cop when `trait` is not inside `factory` block. ([@viralpraxis])
+- Fix an error for `FactoryBot/ConsistentParenthesesStyle` cop when using keyword splat argument. ([@viralpraxis])
+- Fix a false negative for `FactoryBot/SyntaxMethods` when method is used inside a module. ([@lovro-bikic])
+
+## 2.27.1 (2025-03-12)
+
+- Fix incorrect plugin version. ([@koic])
+
 ## 2.27.0 (2025-03-06)
 
 - Fix a false positive for `FactoryBot/ConsistentParenthesesStyle` when using traits and omitting hash values. ([@thejonroberts])
@@ -105,8 +115,10 @@
 [@jaydorsey]: https://github.com/jaydorsey
 [@jfragoulis]: https://github.com/jfragoulis
 [@jonatas]: https://github.com/jonatas
+[@koic]: https://github.com/koic
 [@leoarnold]: https://github.com/leoarnold
 [@liberatys]: https://github.com/Liberatys
+[@lovro-bikic]: https://github.com/lovro-bikic
 [@morissetcl]: https://github.com/morissetcl
 [@ngouy]: https://github.com/ngouy
 [@owst]: https://github.com/owst
@@ -116,6 +128,7 @@
 [@tdeo]: https://github.com/tdeo
 [@tejasbubane]: https://github.com/tejasbubane
 [@thejonroberts]: https://github.com/thejonroberts
+[@viralpraxis]: https://github.com/viralpraxis
 [@vzvu3k6k]: https://github.com/vzvu3k6k
 [@walf443]: https://github.com/walf443
 [@ybiquitous]: https://github.com/ybiquitous

data/lib/rubocop/cop/factory_bot/association_style.rb

@@ -65,14 +65,6 @@ module RuboCop
 
         include ConfigurableEnforcedStyle
 
-        DEFAULT_NON_IMPLICIT_ASSOCIATION_METHOD_NAMES = %w[
-          association
-          factory
-          sequence
-          skip_create
-          traits_for_enum
-        ].freeze
-
         RESTRICT_ON_SEND = %i[factory trait].freeze
         KEYWORDS = %i[alias and begin break case class def defined? do
                       else elsif end ensure false for if in module
@@ -175,7 +167,9 @@ module RuboCop
         def bad?(node)
           if style == :explicit
             implicit_association?(node) &&
-              !trait_within_trait?(node)
+              (factory_node = trait_factory_node(node)) && !trait_within_trait?(
+                node, factory_node
+              )
           else
             explicit_association?(node) &&
               !with_strategy_build_option?(node) &&
@@ -226,7 +220,7 @@ module RuboCop
         end
 
         def non_implicit_association_method_names
-          DEFAULT_NON_IMPLICIT_ASSOCIATION_METHOD_NAMES +
+          RuboCop::FactoryBot.reserved_methods.map(&:to_s) +
             (cop_config['NonImplicitAssociationMethodNames'] || [])
         end
 
@@ -247,12 +241,14 @@ module RuboCop
           options
         end
 
-        def trait_within_trait?(node)
-          factory_node = node.ancestors.reverse.find do |ancestor|
+        def trait_within_trait?(node, factory_node)
+          trait_name(factory_node).include?(node.method_name)
+        end
+
+        def trait_factory_node(node)
+          node.ancestors.reverse.find do |ancestor|
             ancestor.method?(:factory) if ancestor.block_type?
           end
-
-          trait_name(factory_node).include?(node.method_name)
         end
       end
     end

data/lib/rubocop/cop/factory_bot/consistent_parentheses_style.rb

@@ -81,7 +81,7 @@ module RuboCop
             #factory_call? %FACTORY_CALLS
             {sym str send lvar} _*
             (hash
-              <value_omission? ...>
+              <[!kwsplat value_omission?] ...>
             )
           )
         PATTERN

data/lib/rubocop/cop/factory_bot/syntax_methods.rb

@@ -99,19 +99,9 @@ module RuboCop
         end
 
         def inside_example_group?(node)
-          return spec_group?(node) if example_group_root?(node)
-
-          root = node.ancestors.find { |parent| example_group_root?(parent) }
-
-          spec_group?(root)
-        end
-
-        def example_group_root?(node)
-          node.parent.nil? || example_group_root_with_siblings?(node.parent)
-        end
-
-        def example_group_root_with_siblings?(node)
-          node.begin_type? && node.parent.nil?
+          spec_group?(node) || node.each_ancestor.any? do |parent|
+            spec_group?(parent)
+          end
         end
       end
     end

data/lib/rubocop/factory_bot/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module FactoryBot
     # Version information for the factory_bot RuboCop plugin.
     module Version
-      STRING = '2.27.0'
+      STRING = '2.28.0'
     end
   end
 end

data/lib/rubocop-factory_bot.rb

@@ -8,6 +8,7 @@ require 'rubocop'
 require_relative 'rubocop/factory_bot/factory_bot'
 require_relative 'rubocop/factory_bot/language'
 require_relative 'rubocop/factory_bot/plugin'
+require_relative 'rubocop/factory_bot/version'
 
 require_relative 'rubocop/cop/factory_bot/mixin/configurable_explicit_only'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-factory_bot
 version: !ruby/object:Gem::Version
-  version: 2.27.0
+  version: 2.28.0
 platform: ruby
 authors:
 - John Backus
@@ -11,7 +11,7 @@ authors:
 - Andrew Bromwich
 bindir: bin
 cert_chain: []
-date: 2025-03-06 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lint_roller
@@ -104,7 +104,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Code style checking for factory_bot files
 test_files: []