rubocop-factory_bot 2.25.0 → 2.26.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f40e3398e9038a03648df8c412610ed3d1ad3d4934a46df77667c6f0d225ddcc
-  data.tar.gz: 68d463bcc67e2f2fd3b38869a7267509db90cda9d7b8e6550367458d73f0f255
+  metadata.gz: f13120d5e06606e2f01a7521724acfcb9d79989c5dcd5725cfb9dc509f4b9244
+  data.tar.gz: a6dc74ea1bed0ae4b52a7449c2e94d11a6d404803f8eaf57b1ff4bb934a7869e
 SHA512:
-  metadata.gz: 166d045079cffb99cfcdef9b192e0ad8c90ba6b789f1539de8b5e697625a26d44ca6bafef56eb007b7c9ba9a78a655f29ba9688874a6e0081d43f1c9048b996e
-  data.tar.gz: 891d54b5c41e9ad51eec8a1e1ec2ecda863b9f6b700420af7de8cd26494444df8c31e57f78e2783bd949871d0df2bcab15a2ecfbda13e6188d2c370d7bcc11fd
+  metadata.gz: feb49a6ac85e680b9517a54937e96c0d246723082d92f1f995f90735a2b6af34bff9c8681517e164969aacc84cae22a0f1289723428050787e4096c11ba2d735
+  data.tar.gz: 151c71b63326bcd320be0db9a78a92cff0718214e41a03c349f2c178fdf3c3609a57f911658397934848b58d934b48f85ee12032daff500db8b0b67f2f0ace02

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 ## Master (Unreleased)
 
+## 2.26.0 (2024-06-08)
+
+- Fix a false positive for `FactoryBot/AssociationStyle` when using nested factories with traits. ([@jaydorsey])
+- Support `AutoCorrect: contextual` option for LSP. ([@ydah])
+
+## 2.25.1 (2024-01-08)
+
+- Fix a false positive for `FactoryBot/CreateList` when create call does have method calls and repeat multiple times with other argument. ([@ydah])
+- Fix an error occurred for `FactoryBot/IdSequence` when `sequence` with non-symbol argument or without argument. ([@ydah])
+
 ## 2.25.0 (2024-01-04)
 
 - Fix a false positive for `FactoryBot/FactoryNameStyle` when namespaced models. ([@ydah])
@@ -83,6 +93,7 @@
 [@ddieulivol]: https://github.com/ddieulivol
 [@dmitrytsepelev]: https://github.com/dmitrytsepelev
 [@harrylewis]: https://github.com/harrylewis
+[@jaydorsey]: https://github.com/jaydorsey
 [@jfragoulis]: https://github.com/jfragoulis
 [@jonatas]: https://github.com/jonatas
 [@leoarnold]: https://github.com/leoarnold

data/config/default.yml

@@ -49,6 +49,7 @@ FactoryBot/ConsistentParenthesesStyle:
 FactoryBot/CreateList:
   Description: Checks for create_list usage.
   Enabled: true
+  AutoCorrect: contextual
   Include:
     - "**/*_spec.rb"
     - "**/spec/**/*"
@@ -61,7 +62,7 @@ FactoryBot/CreateList:
   ExplicitOnly: false
   SafeAutoCorrect: false
   VersionAdded: '1.25'
-  VersionChanged: '2.24'
+  VersionChanged: '2.26'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/CreateList
 
 FactoryBot/ExcessiveCreateList:

data/lib/rubocop/cop/factory_bot/association_style.rb

@@ -67,6 +67,7 @@ module RuboCop
 
         DEFAULT_NON_IMPLICIT_ASSOCIATION_METHOD_NAMES = %w[
           association
+          factory
           sequence
           skip_create
           traits_for_enum

data/lib/rubocop/cop/factory_bot/create_list.rb

@@ -69,7 +69,7 @@ module RuboCop
         RESTRICT_ON_SEND = %i[create_list].freeze
 
         # @!method repeat_count(node)
-        def_node_matcher :repeat_count, <<-PATTERN
+        def_node_matcher :repeat_count, <<~PATTERN
           (block
             {
               (send (const {nil? cbase} :Array) :new (int $_))  # Array.new(3) { create(:user) }
@@ -90,7 +90,7 @@ module RuboCop
 
         # @!method arguments_include_method_call?(node)
         def_node_matcher :arguments_include_method_call?, <<~PATTERN
-          (send #factory_call? :create sym `(send ...))
+          (send #factory_call? :create sym ... `(send ...))
         PATTERN
 
         # @!method factory_call(node)
@@ -104,7 +104,7 @@ module RuboCop
         PATTERN
 
         # @!method factory_calls_in_array?(node)
-        def_node_search :factory_calls_in_array?, <<-PATTERN
+        def_node_search :factory_calls_in_array?, <<~PATTERN
           (array #factory_call+)
         PATTERN
 

data/lib/rubocop/cop/factory_bot/id_sequence.rb

@@ -19,12 +19,15 @@ module RuboCop
       class IdSequence < ::RuboCop::Cop::Base
         extend AutoCorrector
         include RangeHelp
+        include RuboCop::FactoryBot::Language
 
         MSG = 'Do not create a sequence for an id attribute'
         RESTRICT_ON_SEND = %i[sequence].freeze
 
         def on_send(node)
-          return unless node.first_argument.value == :id
+          return unless node.receiver.nil? || factory_bot?(node.receiver)
+          return unless node.first_argument&.sym_type? &&
+            node.first_argument.value == :id
 
           add_offense(node) do |corrector|
             range_to_remove = range_by_whole_lines(

data/lib/rubocop/factory_bot/cop/generator.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module FactoryBot
+    module Cop
+      # Source and spec generator for new cops
+      #
+      # This generator will take a cop name and generate a source file
+      # and spec file when given a valid qualified cop name.
+      # @api private
+      class Generator < RuboCop::Cop::Generator
+        def todo
+          <<~TODO
+            Do 4 steps:
+              1. Modify the description of #{badge} in config/default.yml
+              2. Implement your new cop in the generated file!
+              3. Add an entry about new cop to CHANGELOG.md
+              4. Commit your new cop with a message such as
+                 e.g. "Add new `#{badge}` cop"
+          TODO
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/factory_bot/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module FactoryBot
     # Version information for the factory_bot RuboCop plugin.
     module Version
-      STRING = '2.25.0'
+      STRING = '2.26.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-factory_bot
 version: !ruby/object:Gem::Version
-  version: 2.25.0
+  version: 2.26.0
 platform: ruby
 authors:
 - John Backus
@@ -9,10 +9,10 @@ authors:
 - Phil Pirozhkov
 - Maxim Krizhanovsky
 - Andrew Bromwich
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-01-04 00:00:00.000000000 Z
+date: 2024-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -20,18 +20,18 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.33'
+        version: '1.41'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.33'
+        version: '1.41'
 description: |
   Code style checking for factory_bot files.
   A plugin for the RuboCop code style enforcing & linting tool.
-email:
+email: 
 executables: []
 extensions: []
 extra_rdoc_files:
@@ -58,6 +58,7 @@ files:
 - lib/rubocop/cop/factory_bot/syntax_methods.rb
 - lib/rubocop/cop/factory_bot_cops.rb
 - lib/rubocop/factory_bot/config_formatter.rb
+- lib/rubocop/factory_bot/cop/generator.rb
 - lib/rubocop/factory_bot/description_extractor.rb
 - lib/rubocop/factory_bot/factory_bot.rb
 - lib/rubocop/factory_bot/language.rb
@@ -69,7 +70,7 @@ metadata:
   changelog_uri: https://github.com/rubocop/rubocop-factory_bot/blob/master/CHANGELOG.md
   documentation_uri: https://docs.rubocop.org/rubocop-factory_bot/
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -84,8 +85,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.22
-signing_key:
+rubygems_version: 3.5.9
+signing_key: 
 specification_version: 4
 summary: Code style checking for factory_bot files
 test_files: []