rubocop-factory_bot 2.24.0 → 2.25.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f2bb256bf3c94a3ff0eca302abed9006719524c843b826f194fbb68c29fea483
-  data.tar.gz: 7b619d4d6732c155369caf1edef5f8c6b1af302ba4114c4ace18eb462e2d14af
+  metadata.gz: 7993f668b5e14662f3d5d7a7c5252d1bdbc019320d5a364f9ab8645b3ca022ef
+  data.tar.gz: a69f938e6e63b6b12c76f64e3d62cda12b33f2a58fec11af1df2e321e8f19e32
 SHA512:
-  metadata.gz: 79e7569730a8530231ac5b5f584f35a7e0c2d2d23174966cee57ce5b4ea45d32617bff8adf5ba0d2ad8a4fe59a32c9bd6a6bf67d90f587cfec0a9b4a558e1bc7
-  data.tar.gz: '02965c01b59d3583720b8ca926f0cd2db764557ec41ac4992c582e0622d6d5b364a167ed3933485bd8df7e2d882febdd353878e88e1b175145ea350ffcc1da6b'
+  metadata.gz: e74eab6cd66daf17505e8452b5e422084ecf14d3ffe73fd6321197c4134fac3d0d8d9f1a34c67e92be5f2beae7e81bbfcd68c4bb5e1a39b69d778d7915c22118
+  data.tar.gz: 2410c754ae9bb83837d5c924ff2c4cfb022ec00e36c9768b9b6b60ad4ff5efa8fee51aa94f3f0ad48e7083910b70fb189613f6488c8551e44737f9e0e5cdc25c

data/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 ## Master (Unreleased)
 
+## 2.25.1 (2024-01-08)
+
+- Fix a false positive for `FactoryBot/CreateList` when create call does have method calls and repeat multiple times with other argument. ([@ydah])
+- Fix an error occurred for `FactoryBot/IdSequence` when `sequence` with non-symbol argument or without argument. ([@ydah])
+
+## 2.25.0 (2024-01-04)
+
+- Fix a false positive for `FactoryBot/FactoryNameStyle` when namespaced models. ([@ydah])
+- Add new `FactoryBot/ExcessiveCreateList` cop. ([@ddieulivol])
+- Fix a false positive for `FactoryBot/ConsistentParenthesesStyle` when hash pinning. ([@ydah])
+
 ## 2.24.0 (2023-09-18)
 
 - Fix `FactoryBot/AssociationStyle` cop to ignore explicit associations with `strategy: :build`. ([@pirj])
@@ -31,7 +42,7 @@
 
 ## Previously (see [rubocop-rspec's changelist](https://github.com/rubocop/rubocop-rspec/blob/70a97b1895ce4b9bcd6ff336d5d343ddc6175fe6/CHANGELOG.md) for details)
 
-- Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` inside `&&`, `||` and `:?` when `omit_parentheses` is on ([@dmitrytsepelev])
+- Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` inside `&&`, `||` and `:?` when `omit_parentheses` is on. ([@dmitrytsepelev])
 - Add new `RSpec/FactoryBot/FactoryNameStyle` cop. ([@ydah])
 - Fix wrong autocorrection in `n_times` style on `RSpec/FactoryBot/CreateList`. ([@r7kamura])
 - Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` when using `generate` with multiple arguments. ([@ydah])
@@ -74,6 +85,7 @@
 [@bquorning]: https://github.com/bquorning
 [@composerinteralia]: https://github.com/composerinteralia
 [@darhazer]: https://github.com/Darhazer
+[@ddieulivol]: https://github.com/ddieulivol
 [@dmitrytsepelev]: https://github.com/dmitrytsepelev
 [@harrylewis]: https://github.com/harrylewis
 [@jfragoulis]: https://github.com/jfragoulis

data/config/default.yml

@@ -14,7 +14,7 @@ FactoryBot/AssociationStyle:
   Enabled: pending
   Safe: false
   VersionAdded: '2.23'
-  VersionChanged: "<<next>>"
+  VersionChanged: '2.24'
   EnforcedStyle: implicit
   SupportedStyles:
     - explicit
@@ -26,7 +26,7 @@ FactoryBot/AttributeDefinedStatically:
   Description: Always declare attribute values as blocks.
   Enabled: true
   VersionAdded: '1.28'
-  VersionChanged: "<<next>>"
+  VersionChanged: '2.24'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/AttributeDefinedStatically
 
 FactoryBot/ConsistentParenthesesStyle:
@@ -61,9 +61,21 @@ FactoryBot/CreateList:
   ExplicitOnly: false
   SafeAutoCorrect: false
   VersionAdded: '1.25'
-  VersionChanged: "<<next>>"
+  VersionChanged: '2.24'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/CreateList
 
+FactoryBot/ExcessiveCreateList:
+  Description: Check for excessive model creation in a list.
+  Enabled: pending
+  Include:
+    - "**/*_spec.rb"
+    - "**/spec/**/*"
+    - "**/test/**/*"
+    - "**/features/support/factories/**/*.rb"
+  MaxAmount: 10
+  VersionAdded: '2.25'
+  Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/ExcessiveCreateList
+
 FactoryBot/FactoryAssociationWithStrategy:
   Description: Use definition in factory association instead of hard coding a strategy.
   Enabled: pending
@@ -80,7 +92,7 @@ FactoryBot/FactoryClassName:
   Description: Use string value when setting the class attribute explicitly.
   Enabled: true
   VersionAdded: '1.37'
-  VersionChanged: "<<next>>"
+  VersionChanged: '2.24'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/FactoryClassName
 
 FactoryBot/FactoryNameStyle:
@@ -103,7 +115,7 @@ FactoryBot/FactoryNameStyle:
 FactoryBot/IdSequence:
   Description: Do not create a FactoryBot sequence for an id column.
   Enabled: pending
-  VersionAdded: "<<next>>"
+  VersionAdded: '2.24'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/IdSequence
 
 FactoryBot/RedundantFactoryOption:

data/lib/rubocop/cop/factory_bot/attribute_defined_statically.rb

@@ -70,7 +70,7 @@ module RuboCop
         end
 
         def receiver_matches_first_block_argument?(receiver, node)
-          first_block_argument = node.arguments.first
+          first_block_argument = node.first_argument
 
           !first_block_argument.nil? &&
             receiver.lvar_type? &&

data/lib/rubocop/cop/factory_bot/consistent_parentheses_style.rb

@@ -75,6 +75,17 @@ module RuboCop
           )
         PATTERN
 
+        # @!method omit_hash_value?(node)
+        def_node_matcher :omit_hash_value?, <<~PATTERN
+          (send
+            #factory_call? %FACTORY_CALLS
+            {sym str send lvar}
+            (hash
+              <value_omission? ...>
+            )
+          )
+        PATTERN
+
         def self.autocorrect_incompatible_with
           [Style::MethodCallWithArgsParentheses]
         end
@@ -97,6 +108,7 @@ module RuboCop
         def register_offense_with_parentheses(node)
           return if style == :require_parentheses || !node.parenthesized?
           return unless same_line?(node, node.first_argument)
+          return if omit_hash_value?(node)
 
           add_offense(node.loc.selector,
                       message: MSG_OMIT_PARENS) do |corrector|

data/lib/rubocop/cop/factory_bot/create_list.rb

@@ -69,7 +69,7 @@ module RuboCop
         RESTRICT_ON_SEND = %i[create_list].freeze
 
         # @!method repeat_count(node)
-        def_node_matcher :repeat_count, <<-PATTERN
+        def_node_matcher :repeat_count, <<~PATTERN
           (block
             {
               (send (const {nil? cbase} :Array) :new (int $_))  # Array.new(3) { create(:user) }
@@ -90,7 +90,7 @@ module RuboCop
 
         # @!method arguments_include_method_call?(node)
         def_node_matcher :arguments_include_method_call?, <<~PATTERN
-          (send #factory_call? :create sym `(send ...))
+          (send #factory_call? :create sym ... `(send ...))
         PATTERN
 
         # @!method factory_call(node)
@@ -104,7 +104,7 @@ module RuboCop
         PATTERN
 
         # @!method factory_calls_in_array?(node)
-        def_node_search :factory_calls_in_array?, <<-PATTERN
+        def_node_search :factory_calls_in_array?, <<~PATTERN
           (array #factory_call+)
         PATTERN
 

data/lib/rubocop/cop/factory_bot/excessive_create_list.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module FactoryBot
+      # Check for excessive model creation in a list.
+      #
+      # @example MaxAmount: 10 (default)
+      #   # We do not allow more than 10 items to be created
+      #
+      #   # bad
+      #   create_list(:merge_request, 1000, state: :opened)
+      #
+      #   # good
+      #   create_list(:merge_request, 10, state: :opened)
+      #
+      # @example MaxAmount: 20
+      #   # We do not allow more than 20 items to be created
+      #
+      #   # bad
+      #   create_list(:merge_request, 1000, state: :opened)
+      #
+      #   # good
+      #   create_list(:merge_request, 15, state: :opened)
+      #
+      class ExcessiveCreateList < ::RuboCop::Cop::Base
+        include ConfigurableExplicitOnly
+
+        MESSAGE =
+          'Avoid using `create_list` with more than %<max_amount>s items.'
+
+        # @!method create_list?(node)
+        def_node_matcher :create_list?, <<~PATTERN
+          (send #factory_call? :create_list {sym str} $(int _) ...)
+        PATTERN
+
+        RESTRICT_ON_SEND = %i[create_list].freeze
+
+        def on_send(node)
+          number_node = create_list?(node)
+          return unless number_node
+
+          max_amount = cop_config['MaxAmount']
+          return if number_node.value <= max_amount
+
+          add_offense(number_node, message:
+            format(MESSAGE, max_amount: max_amount))
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/factory_bot/factory_name_style.rb

@@ -14,6 +14,9 @@ module RuboCop
       #   create(:user)
       #   build :user, username: "NAME"
       #
+      #   # good - namespaced models
+      #   create('users/internal')
+      #
       # @example EnforcedStyle: string
       #   # bad
       #   create(:user)
@@ -76,13 +79,17 @@ module RuboCop
         private
 
         def offense_for_symbol_style?(name)
-          name.str_type? && style == :symbol
+          name.str_type? && style == :symbol && !namespaced?(name)
         end
 
         def offense_for_string_style?(name)
           name.sym_type? && style == :string
         end
 
+        def namespaced?(name)
+          name.value.include?('/')
+        end
+
         def register_offense(name, prefer)
           add_offense(name,
                       message: format(MSG, prefer: style.to_s)) do |corrector|

data/lib/rubocop/cop/factory_bot/id_sequence.rb

@@ -19,12 +19,15 @@ module RuboCop
       class IdSequence < ::RuboCop::Cop::Base
         extend AutoCorrector
         include RangeHelp
+        include RuboCop::FactoryBot::Language
 
         MSG = 'Do not create a sequence for an id attribute'
         RESTRICT_ON_SEND = %i[sequence].freeze
 
         def on_send(node)
-          return unless node.first_argument.value == :id
+          return unless node.receiver.nil? || factory_bot?(node.receiver)
+          return unless node.first_argument&.sym_type? &&
+            node.first_argument.value == :id
 
           add_offense(node) do |corrector|
             range_to_remove = range_by_whole_lines(

data/lib/rubocop/cop/factory_bot_cops.rb

@@ -4,6 +4,7 @@ require_relative 'factory_bot/association_style'
 require_relative 'factory_bot/attribute_defined_statically'
 require_relative 'factory_bot/consistent_parentheses_style'
 require_relative 'factory_bot/create_list'
+require_relative 'factory_bot/excessive_create_list'
 require_relative 'factory_bot/factory_association_with_strategy'
 require_relative 'factory_bot/factory_class_name'
 require_relative 'factory_bot/factory_name_style'

data/lib/rubocop/factory_bot/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module FactoryBot
     # Version information for the factory_bot RuboCop plugin.
     module Version
-      STRING = '2.24.0'
+      STRING = '2.25.1'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-factory_bot
 version: !ruby/object:Gem::Version
-  version: 2.24.0
+  version: 2.25.1
 platform: ruby
 authors:
 - John Backus
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-18 00:00:00.000000000 Z
+date: 2024-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -20,14 +20,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.33'
+        version: '1.41'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.33'
+        version: '1.41'
 description: |
   Code style checking for factory_bot files.
   A plugin for the RuboCop code style enforcing & linting tool.
@@ -48,6 +48,7 @@ files:
 - lib/rubocop/cop/factory_bot/attribute_defined_statically.rb
 - lib/rubocop/cop/factory_bot/consistent_parentheses_style.rb
 - lib/rubocop/cop/factory_bot/create_list.rb
+- lib/rubocop/cop/factory_bot/excessive_create_list.rb
 - lib/rubocop/cop/factory_bot/factory_association_with_strategy.rb
 - lib/rubocop/cop/factory_bot/factory_class_name.rb
 - lib/rubocop/cop/factory_bot/factory_name_style.rb
@@ -83,7 +84,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.4.22
 signing_key:
 specification_version: 4
 summary: Code style checking for factory_bot files