rubocop-factory_bot 2.23.1 → 2.26.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5d8a45a48d47318e9e16e7b3bbde99ae9dcf94f6e90c068f0916ff2945511e85
-  data.tar.gz: 52ff0ffe8fb20bc0ed3ec4dca29aa13a29b106e39f7bacac370388f0c789bf1c
+  metadata.gz: 60519b0d051edd3ba23a10f3dfb346dc5aaed4964c489bcfabdb7d16c084cb63
+  data.tar.gz: effac41ed4215d5cb27295cdb0a37d8c7021c309e97a8f8e6f8fdf6e385e8226
 SHA512:
-  metadata.gz: 53082b6baa7e6ebe69f3ebcc1404f2c8421bfcd3ee6905eba12789faca59c1c090b84abc4696a0773598ab06eb97e8aa2b70384864376b58e568d9eef5ce2549
-  data.tar.gz: 26f1817b168218b61f7657400f777ec5eb972cedab14501b2f6a5b1bd8691af9b4c3b04607969923eb58ffca49e4070622040950a7d00742624d4d5b03cf9ee1
+  metadata.gz: ee33ad705e93ffa3a68240adabd9de50735819d4d82bbf66868f2efa80d489a0032fd045878bf8fd539dc7677fed9bbf9ef0e3755340b81b4fc1881220e0b24c
+  data.tar.gz: 89936fe77a9c8f3ff5dad656b9e30455ec2f6467ac7cba1c678e63fca22396825c3859bc1830f6e766a90109cbae3eca68f64d5a110e3bbd8cebd229cf3218e9

data/CHANGELOG.md

@@ -2,6 +2,35 @@
 
 ## Master (Unreleased)
 
+## 2.26.1 (2024-06-12)
+
+- Bump RuboCop requirement to +1.61. ([@ydah])
+
+## 2.26.0 (2024-06-08)
+
+- Fix a false positive for `FactoryBot/AssociationStyle` when using nested factories with traits. ([@jaydorsey])
+- Support `AutoCorrect: contextual` option for LSP. ([@ydah])
+
+## 2.25.1 (2024-01-08)
+
+- Fix a false positive for `FactoryBot/CreateList` when create call does have method calls and repeat multiple times with other argument. ([@ydah])
+- Fix an error occurred for `FactoryBot/IdSequence` when `sequence` with non-symbol argument or without argument. ([@ydah])
+
+## 2.25.0 (2024-01-04)
+
+- Fix a false positive for `FactoryBot/FactoryNameStyle` when namespaced models. ([@ydah])
+- Add new `FactoryBot/ExcessiveCreateList` cop. ([@ddieulivol])
+- Fix a false positive for `FactoryBot/ConsistentParenthesesStyle` when hash pinning. ([@ydah])
+
+## 2.24.0 (2023-09-18)
+
+- Fix `FactoryBot/AssociationStyle` cop to ignore explicit associations with `strategy: :build`. ([@pirj])
+- Change `FactoryBot/CreateList` so that it is not an offense if not repeated multiple times. ([@ydah])
+- Fix a false positive for `FactoryBot/AssociationStyle` when `association` is called in trait block and column name is keyword. ([@ydah])
+- Fix a false positive for `FactoryBot/AssociationStyle` when `EnforcedStyle: Explicit` and using trait within trait. ([@ydah])
+- Change `FactoryBot/AssociationStyle`, `FactoryBot/AttributeDefinedStatically`, `FactoryBot/CreateList` and `FactoryBot/FactoryClassName` to work with minitest style directory. ([@ydah])
+- Add `FactoryBot/IdSequence` cop. ([@owst])
+
 ## 2.23.1 (2023-05-15)
 
 - Fix `FactoryBot/AssociationStyle` cop for a blockless `factory`. ([@pirj])
@@ -22,7 +51,7 @@
 
 ## Previously (see [rubocop-rspec's changelist](https://github.com/rubocop/rubocop-rspec/blob/70a97b1895ce4b9bcd6ff336d5d343ddc6175fe6/CHANGELOG.md) for details)
 
-- Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` inside `&&`, `||` and `:?` when `omit_parentheses` is on ([@dmitrytsepelev])
+- Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` inside `&&`, `||` and `:?` when `omit_parentheses` is on. ([@dmitrytsepelev])
 - Add new `RSpec/FactoryBot/FactoryNameStyle` cop. ([@ydah])
 - Fix wrong autocorrection in `n_times` style on `RSpec/FactoryBot/CreateList`. ([@r7kamura])
 - Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` when using `generate` with multiple arguments. ([@ydah])
@@ -65,14 +94,17 @@
 [@bquorning]: https://github.com/bquorning
 [@composerinteralia]: https://github.com/composerinteralia
 [@darhazer]: https://github.com/Darhazer
+[@ddieulivol]: https://github.com/ddieulivol
 [@dmitrytsepelev]: https://github.com/dmitrytsepelev
 [@harrylewis]: https://github.com/harrylewis
+[@jaydorsey]: https://github.com/jaydorsey
 [@jfragoulis]: https://github.com/jfragoulis
 [@jonatas]: https://github.com/jonatas
 [@leoarnold]: https://github.com/leoarnold
 [@liberatys]: https://github.com/Liberatys
 [@morissetcl]: https://github.com/morissetcl
 [@ngouy]: https://github.com/ngouy
+[@owst]: https://github.com/owst
 [@pirj]: https://github.com/pirj
 [@r7kamura]: https://github.com/r7kamura
 [@seanpdoyle]: https://github.com/seanpdoyle

data/config/default.yml

@@ -2,9 +2,10 @@
 FactoryBot:
   Enabled: true
   Include:
-    - "**/*_spec.rb"
-    - "**/spec/**/*"
-    - "**/test/**/*"
+    - "**/spec/factories.rb"
+    - "**/spec/factories/**/*.rb"
+    - "**/test/factories.rb"
+    - "**/test/factories/**/*.rb"
     - "**/features/support/factories/**/*.rb"
   DocumentationBaseURL: https://docs.rubocop.org/rubocop-factory_bot
 
@@ -12,11 +13,8 @@ FactoryBot/AssociationStyle:
   Description: Use a consistent style to define associations.
   Enabled: pending
   Safe: false
-  Include:
-    - spec/factories.rb
-    - spec/factories/**/*.rb
-    - features/support/factories/**/*.rb
   VersionAdded: '2.23'
+  VersionChanged: '2.24'
   EnforcedStyle: implicit
   SupportedStyles:
     - explicit
@@ -27,17 +25,18 @@ FactoryBot/AssociationStyle:
 FactoryBot/AttributeDefinedStatically:
   Description: Always declare attribute values as blocks.
   Enabled: true
-  Include:
-    - spec/factories.rb
-    - spec/factories/**/*.rb
-    - features/support/factories/**/*.rb
   VersionAdded: '1.28'
-  VersionChanged: '2.0'
+  VersionChanged: '2.24'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/AttributeDefinedStatically
 
 FactoryBot/ConsistentParenthesesStyle:
   Description: Use a consistent style for parentheses in factory_bot calls.
   Enabled: pending
+  Include:
+    - "**/*_spec.rb"
+    - "**/spec/**/*"
+    - "**/test/**/*"
+    - "**/features/support/factories/**/*.rb"
   EnforcedStyle: require_parentheses
   SupportedStyles:
     - require_parentheses
@@ -50,12 +49,12 @@ FactoryBot/ConsistentParenthesesStyle:
 FactoryBot/CreateList:
   Description: Checks for create_list usage.
   Enabled: true
+  AutoCorrect: contextual
   Include:
     - "**/*_spec.rb"
     - "**/spec/**/*"
-    - spec/factories.rb
-    - spec/factories/**/*.rb
-    - features/support/factories/**/*.rb
+    - "**/test/**/*"
+    - "**/features/support/factories/**/*.rb"
   EnforcedStyle: create_list
   SupportedStyles:
     - create_list
@@ -63,12 +62,29 @@ FactoryBot/CreateList:
   ExplicitOnly: false
   SafeAutoCorrect: false
   VersionAdded: '1.25'
-  VersionChanged: '2.23'
+  VersionChanged: '2.26'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/CreateList
 
+FactoryBot/ExcessiveCreateList:
+  Description: Check for excessive model creation in a list.
+  Enabled: pending
+  Include:
+    - "**/*_spec.rb"
+    - "**/spec/**/*"
+    - "**/test/**/*"
+    - "**/features/support/factories/**/*.rb"
+  MaxAmount: 10
+  VersionAdded: '2.25'
+  Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/ExcessiveCreateList
+
 FactoryBot/FactoryAssociationWithStrategy:
   Description: Use definition in factory association instead of hard coding a strategy.
   Enabled: pending
+  Include:
+    - "**/*_spec.rb"
+    - "**/spec/**/*"
+    - "**/test/**/*"
+    - "**/features/support/factories/**/*.rb"
   VersionAdded: '2.23'
   VersionChanged: '2.23'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/FactoryAssociationWithStrategy
@@ -76,17 +92,18 @@ FactoryBot/FactoryAssociationWithStrategy:
 FactoryBot/FactoryClassName:
   Description: Use string value when setting the class attribute explicitly.
   Enabled: true
-  Include:
-    - spec/factories.rb
-    - spec/factories/**/*.rb
-    - features/support/factories/**/*.rb
   VersionAdded: '1.37'
-  VersionChanged: '2.0'
+  VersionChanged: '2.24'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/FactoryClassName
 
 FactoryBot/FactoryNameStyle:
   Description: Checks for name style for argument of FactoryBot::Syntax::Methods.
   Enabled: pending
+  Include:
+    - "**/*_spec.rb"
+    - "**/spec/**/*"
+    - "**/test/**/*"
+    - "**/features/support/factories/**/*.rb"
   EnforcedStyle: symbol
   SupportedStyles:
     - symbol
@@ -96,15 +113,31 @@ FactoryBot/FactoryNameStyle:
   VersionChanged: '2.23'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/FactoryNameStyle
 
+FactoryBot/IdSequence:
+  Description: Do not create a FactoryBot sequence for an id column.
+  Enabled: pending
+  VersionAdded: '2.24'
+  Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/IdSequence
+
 FactoryBot/RedundantFactoryOption:
   Description: Checks for redundant `factory` option.
   Enabled: pending
+  Include:
+    - "**/*_spec.rb"
+    - "**/spec/**/*"
+    - "**/test/**/*"
+    - "**/features/support/factories/**/*.rb"
   VersionAdded: '2.23'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/RedundantFactoryOption
 
 FactoryBot/SyntaxMethods:
   Description: Use shorthands from `FactoryBot::Syntax::Methods` in your specs.
   Enabled: pending
+  Include:
+    - "**/*_spec.rb"
+    - "**/spec/**/*"
+    - "**/test/**/*"
+    - "**/features/support/factories/**/*.rb"
   SafeAutoCorrect: false
   VersionAdded: '2.7'
   Reference: https://www.rubydoc.info/gems/rubocop-factory_bot/RuboCop/Cop/FactoryBot/SyntaxMethods

data/lib/rubocop/cop/factory_bot/association_style.rb

@@ -21,6 +21,16 @@ module RuboCop
       #     user
       #   end
       #
+      #   # bad
+      #   factory :post do
+      #     association :user, :author
+      #   end
+      #
+      #   # good
+      #   factory :post do
+      #     user factory: %i[user author]
+      #   end
+      #
       # @example EnforcedStyle: explicit
       #   # bad
       #   factory :post do
@@ -32,6 +42,16 @@ module RuboCop
       #     association :user
       #   end
       #
+      #   # bad
+      #   factory :post do
+      #     user factory: %i[user author]
+      #   end
+      #
+      #   # good
+      #   factory :post do
+      #     association :user, :author
+      #   end
+      #
       #   # good (NonImplicitAssociationMethodNames: ['email'])
       #   sequence :email do |n|
       #     "person#{n}@example.com"
@@ -47,12 +67,18 @@ module RuboCop
 
         DEFAULT_NON_IMPLICIT_ASSOCIATION_METHOD_NAMES = %w[
           association
+          factory
           sequence
           skip_create
           traits_for_enum
         ].freeze
 
         RESTRICT_ON_SEND = %i[factory trait].freeze
+        KEYWORDS = %i[alias and begin break case class def defined? do
+                      else elsif end ensure false for if in module
+                      next nil not or redo rescue retry return self
+                      super then true undef unless until when while
+                      yield __FILE__ __LINE__ __ENCODING__].freeze
 
         def on_send(node)
           bad_associations_in(node).each do |association|
@@ -72,6 +98,13 @@ module RuboCop
           (send nil? :association sym ...)
         PATTERN
 
+        # @!method with_strategy_build_option?(node)
+        def_node_matcher :with_strategy_build_option?, <<~PATTERN
+          (send nil? :association sym ...
+            (hash <(pair (sym :strategy) (sym :build)) ...>)
+          )
+        PATTERN
+
         # @!method implicit_association?(node)
         def_node_matcher :implicit_association?, <<~PATTERN
           (send nil? !#non_implicit_association_method_name? ...)
@@ -103,6 +136,16 @@ module RuboCop
           (send nil? :association _ (sym $_)* ...)
         PATTERN
 
+        # @!method association_names(node)
+        def_node_search :association_names, <<~PATTERN
+          (send nil? :association $...)
+        PATTERN
+
+        # @!method trait_name(node)
+        def_node_search :trait_name, <<~PATTERN
+          (send nil? :trait (sym $_) )
+        PATTERN
+
         def autocorrect(corrector, node)
           if style == :explicit
             autocorrect_to_explicit_style(corrector, node)
@@ -131,9 +174,22 @@ module RuboCop
 
         def bad?(node)
           if style == :explicit
-            implicit_association?(node)
+            implicit_association?(node) &&
+              !trait_within_trait?(node)
           else
-            explicit_association?(node)
+            explicit_association?(node) &&
+              !with_strategy_build_option?(node) &&
+              !keyword?(node)
+          end
+        end
+
+        def keyword?(node)
+          association_names(node).any? do |associations|
+            associations.any? do |association|
+              next unless association.sym_type?
+
+              KEYWORDS.include?(association.value)
+            end
           end
         end
 
@@ -190,6 +246,14 @@ module RuboCop
           end
           options
         end
+
+        def trait_within_trait?(node)
+          factory_node = node.ancestors.reverse.find do |ancestor|
+            ancestor.method?(:factory) if ancestor.block_type?
+          end
+
+          trait_name(factory_node).include?(node.method_name)
+        end
       end
     end
   end

data/lib/rubocop/cop/factory_bot/attribute_defined_statically.rb

@@ -70,7 +70,7 @@ module RuboCop
         end
 
         def receiver_matches_first_block_argument?(receiver, node)
-          first_block_argument = node.arguments.first
+          first_block_argument = node.first_argument
 
           !first_block_argument.nil? &&
             receiver.lvar_type? &&

data/lib/rubocop/cop/factory_bot/consistent_parentheses_style.rb

@@ -75,6 +75,17 @@ module RuboCop
           )
         PATTERN
 
+        # @!method omit_hash_value?(node)
+        def_node_matcher :omit_hash_value?, <<~PATTERN
+          (send
+            #factory_call? %FACTORY_CALLS
+            {sym str send lvar}
+            (hash
+              <value_omission? ...>
+            )
+          )
+        PATTERN
+
         def self.autocorrect_incompatible_with
           [Style::MethodCallWithArgsParentheses]
         end
@@ -97,6 +108,7 @@ module RuboCop
         def register_offense_with_parentheses(node)
           return if style == :require_parentheses || !node.parenthesized?
           return unless same_line?(node, node.first_argument)
+          return if omit_hash_value?(node)
 
           add_offense(node.loc.selector,
                       message: MSG_OMIT_PARENS) do |corrector|

data/lib/rubocop/cop/factory_bot/create_list.rb

@@ -58,7 +58,7 @@ module RuboCop
       #   create_list :user, 3
       #   3.times { create :user }
       #
-      class CreateList < ::RuboCop::Cop::Base
+      class CreateList < ::RuboCop::Cop::Base # rubocop:disable Metrics/ClassLength
         extend AutoCorrector
         include ConfigurableEnforcedStyle
         include RuboCop::FactoryBot::Language
@@ -68,24 +68,15 @@ module RuboCop
         MSG_N_TIMES = 'Prefer %<number>s.times.map.'
         RESTRICT_ON_SEND = %i[create_list].freeze
 
-        # @!method repetition_block?(node)
-        def_node_matcher :repetition_block?, <<-PATTERN
-          (block {#array_new? #n_times? #n_times_map?} ...)
-        PATTERN
-
-        # @!method array_new?(node)
-        def_node_matcher :array_new?, <<-PATTERN
-          (send (const {nil? cbase} :Array) :new (int _))
-        PATTERN
-
-        # @!method n_times?(node)
-        def_node_matcher :n_times?, <<-PATTERN
-          (send (int _) :times)
-        PATTERN
-
-        # @!method n_times_map?(node)
-        def_node_matcher :n_times_map?, <<-PATTERN
-          (send #n_times? :map)
+        # @!method repeat_count(node)
+        def_node_matcher :repeat_count, <<~PATTERN
+          (block
+            {
+              (send (const {nil? cbase} :Array) :new (int $_))  # Array.new(3) { create(:user) }
+              (send (int $_) :times)                            # 3.times { create(:user) }
+              (send (send (int $_) :times) :map)                # 3.times.map { create(:user) }
+            }
+          ...)
         PATTERN
 
         # @!method block_with_arg_and_used?(node)
@@ -99,7 +90,7 @@ module RuboCop
 
         # @!method arguments_include_method_call?(node)
         def_node_matcher :arguments_include_method_call?, <<~PATTERN
-          (send #factory_call? :create sym `$(send ...))
+          (send #factory_call? :create sym ... `(send ...))
         PATTERN
 
         # @!method factory_call(node)
@@ -113,12 +104,13 @@ module RuboCop
         PATTERN
 
         # @!method factory_calls_in_array?(node)
-        def_node_search :factory_calls_in_array?, <<-PATTERN
+        def_node_search :factory_calls_in_array?, <<~PATTERN
           (array #factory_call+)
         PATTERN
 
         def on_array(node)
           return unless same_factory_calls_in_array?(node)
+          return if node.values.size < 2
 
           add_offense(
             node,
@@ -128,10 +120,9 @@ module RuboCop
           end
         end
 
-        def on_block(node) # rubocop:todo InternalAffairs/NumblockHandler
+        def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler, Metrics/CyclomaticComplexity
           return unless style == :create_list
-
-          return unless repetition_block?(node)
+          return unless repeat_multiple_time?(node)
           return if block_with_arg_and_used?(node)
           return unless node.body
           return if arguments_include_method_call?(node.body)
@@ -146,6 +137,8 @@ module RuboCop
           return unless style == :n_times
 
           factory_list_call(node) do |count|
+            next if count < 2
+
             message = format(MSG_N_TIMES, number: count)
             add_offense(node.loc.selector, message: message) do |corrector|
               TimesCorrector.new(node).call(corrector)
@@ -155,6 +148,12 @@ module RuboCop
 
         private
 
+        def repeat_multiple_time?(node)
+          return false unless (count = repeat_count(node))
+
+          count > 1
+        end
+
         # For ease of modification, it is replaced with the `n_times` style,
         # but if it is not appropriate for the configured style,
         # it will be replaced in the subsequent autocorrection.

data/lib/rubocop/cop/factory_bot/excessive_create_list.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module FactoryBot
+      # Check for excessive model creation in a list.
+      #
+      # @example MaxAmount: 10 (default)
+      #   # We do not allow more than 10 items to be created
+      #
+      #   # bad
+      #   create_list(:merge_request, 1000, state: :opened)
+      #
+      #   # good
+      #   create_list(:merge_request, 10, state: :opened)
+      #
+      # @example MaxAmount: 20
+      #   # We do not allow more than 20 items to be created
+      #
+      #   # bad
+      #   create_list(:merge_request, 1000, state: :opened)
+      #
+      #   # good
+      #   create_list(:merge_request, 15, state: :opened)
+      #
+      class ExcessiveCreateList < ::RuboCop::Cop::Base
+        include ConfigurableExplicitOnly
+
+        MESSAGE =
+          'Avoid using `create_list` with more than %<max_amount>s items.'
+
+        # @!method create_list?(node)
+        def_node_matcher :create_list?, <<~PATTERN
+          (send #factory_call? :create_list {sym str} $(int _) ...)
+        PATTERN
+
+        RESTRICT_ON_SEND = %i[create_list].freeze
+
+        def on_send(node)
+          number_node = create_list?(node)
+          return unless number_node
+
+          max_amount = cop_config['MaxAmount']
+          return if number_node.value <= max_amount
+
+          add_offense(number_node, message:
+            format(MESSAGE, max_amount: max_amount))
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/factory_bot/factory_name_style.rb

@@ -14,6 +14,9 @@ module RuboCop
       #   create(:user)
       #   build :user, username: "NAME"
       #
+      #   # good - namespaced models
+      #   create('users/internal')
+      #
       # @example EnforcedStyle: string
       #   # bad
       #   create(:user)
@@ -76,13 +79,17 @@ module RuboCop
         private
 
         def offense_for_symbol_style?(name)
-          name.str_type? && style == :symbol
+          name.str_type? && style == :symbol && !namespaced?(name)
         end
 
         def offense_for_string_style?(name)
           name.sym_type? && style == :string
         end
 
+        def namespaced?(name)
+          name.value.include?('/')
+        end
+
         def register_offense(name, prefer)
           add_offense(name,
                       message: format(MSG, prefer: style.to_s)) do |corrector|

data/lib/rubocop/cop/factory_bot/id_sequence.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module FactoryBot
+      # Do not create a FactoryBot sequence for an id column.
+      #
+      # @example
+      #   # bad - can lead to conflicts between FactoryBot and DB sequences
+      #   factory :foo do
+      #     sequence :id
+      #   end
+      #
+      #   # good - a non-id column
+      #   factory :foo do
+      #     sequence :some_non_id_column
+      #   end
+      #
+      class IdSequence < ::RuboCop::Cop::Base
+        extend AutoCorrector
+        include RangeHelp
+        include RuboCop::FactoryBot::Language
+
+        MSG = 'Do not create a sequence for an id attribute'
+        RESTRICT_ON_SEND = %i[sequence].freeze
+
+        def on_send(node)
+          return unless node.receiver.nil? || factory_bot?(node.receiver)
+          return unless node.first_argument&.sym_type? &&
+            node.first_argument.value == :id
+
+          add_offense(node) do |corrector|
+            range_to_remove = range_by_whole_lines(
+              node.source_range,
+              include_final_newline: true
+            )
+
+            corrector.remove(range_to_remove)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/factory_bot_cops.rb

@@ -4,8 +4,10 @@ require_relative 'factory_bot/association_style'
 require_relative 'factory_bot/attribute_defined_statically'
 require_relative 'factory_bot/consistent_parentheses_style'
 require_relative 'factory_bot/create_list'
+require_relative 'factory_bot/excessive_create_list'
 require_relative 'factory_bot/factory_association_with_strategy'
 require_relative 'factory_bot/factory_class_name'
 require_relative 'factory_bot/factory_name_style'
+require_relative 'factory_bot/id_sequence'
 require_relative 'factory_bot/redundant_factory_option'
 require_relative 'factory_bot/syntax_methods'

data/lib/rubocop/factory_bot/cop/generator.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module FactoryBot
+    module Cop
+      # Source and spec generator for new cops
+      #
+      # This generator will take a cop name and generate a source file
+      # and spec file when given a valid qualified cop name.
+      # @api private
+      class Generator < RuboCop::Cop::Generator
+        def todo
+          <<~TODO
+            Do 4 steps:
+              1. Modify the description of #{badge} in config/default.yml
+              2. Implement your new cop in the generated file!
+              3. Add an entry about new cop to CHANGELOG.md
+              4. Commit your new cop with a message such as
+                 e.g. "Add new `#{badge}` cop"
+          TODO
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/factory_bot/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module FactoryBot
     # Version information for the factory_bot RuboCop plugin.
     module Version
-      STRING = '2.23.1'
+      STRING = '2.26.1'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-factory_bot
 version: !ruby/object:Gem::Version
-  version: 2.23.1
+  version: 2.26.1
 platform: ruby
 authors:
 - John Backus
@@ -9,10 +9,10 @@ authors:
 - Phil Pirozhkov
 - Maxim Krizhanovsky
 - Andrew Bromwich
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-16 00:00:00.000000000 Z
+date: 2024-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -20,18 +20,18 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.33'
+        version: '1.61'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.33'
+        version: '1.61'
 description: |
   Code style checking for factory_bot files.
   A plugin for the RuboCop code style enforcing & linting tool.
-email:
+email: 
 executables: []
 extensions: []
 extra_rdoc_files:
@@ -48,14 +48,17 @@ files:
 - lib/rubocop/cop/factory_bot/attribute_defined_statically.rb
 - lib/rubocop/cop/factory_bot/consistent_parentheses_style.rb
 - lib/rubocop/cop/factory_bot/create_list.rb
+- lib/rubocop/cop/factory_bot/excessive_create_list.rb
 - lib/rubocop/cop/factory_bot/factory_association_with_strategy.rb
 - lib/rubocop/cop/factory_bot/factory_class_name.rb
 - lib/rubocop/cop/factory_bot/factory_name_style.rb
+- lib/rubocop/cop/factory_bot/id_sequence.rb
 - lib/rubocop/cop/factory_bot/mixin/configurable_explicit_only.rb
 - lib/rubocop/cop/factory_bot/redundant_factory_option.rb
 - lib/rubocop/cop/factory_bot/syntax_methods.rb
 - lib/rubocop/cop/factory_bot_cops.rb
 - lib/rubocop/factory_bot/config_formatter.rb
+- lib/rubocop/factory_bot/cop/generator.rb
 - lib/rubocop/factory_bot/description_extractor.rb
 - lib/rubocop/factory_bot/factory_bot.rb
 - lib/rubocop/factory_bot/language.rb
@@ -67,7 +70,7 @@ metadata:
   changelog_uri: https://github.com/rubocop/rubocop-factory_bot/blob/master/CHANGELOG.md
   documentation_uri: https://docs.rubocop.org/rubocop-factory_bot/
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -82,8 +85,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.13
-signing_key:
+rubygems_version: 3.5.9
+signing_key: 
 specification_version: 4
 summary: Code style checking for factory_bot files
 test_files: []