rubocop-expert 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe20794a04bdfc3cbc23a95d0ca85fbd3ef6f767049647a132f8ed47cf26c033
-  data.tar.gz: cf4f4e5aaecbc5ca138d7a0ca6fdf2df7db1b804b201c3a12f6efe0082e9a28d
+  metadata.gz: 60b8509883369fbd154a5f436959f405ef456a2c4408cd94532a00b8bad6de16
+  data.tar.gz: c5fa3408ecec3d4f86dfbf84e08a417e8f88b939fec6f0a099da7d81a2efac7d
 SHA512:
-  metadata.gz: 5963fdad27ed7ed602f0b92b825f28943097b4323e41b38821a84c8eac5eab34176f439a72f938bbc0b69354c885ae207819a445b84b4c34b3fb7ff2b1ce06c8
-  data.tar.gz: bf452bcc544e79fd1d4b5e2993454919188a7eac3153b4393f288251ccc811fef2f0637a25b153554138ddfb20ac03494edb59678ce7651026de99769c454d44
+  metadata.gz: 71b246160ac1a8819f52d10d88d9fe74fdb631bfe7750be9d852529b1f17cd152e4a34bdc9effc6d45715d041672e195e1a77ecfc7d19ed5f9fb89537bb695b2
+  data.tar.gz: '0846c330f4336ea4e4a2aeb4729ed88eab59baa96ba5cab83458f9504cff33bb897b902da778bbe357d6cbd82545e424b0b7af35d7f9d3c1025054cc8fbe80e1'

data/.travis.yml

@@ -3,5 +3,18 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
-  - 2.5.1
+  - 2.3
+  - 2.5
+env:
+  global:
+    - CC_TEST_REPORTER_ID: 68143d415b78ff031776504907a575624db07d44ab31095af2ea7a80885cf898
 before_install: gem install bundler -v 1.16.4
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+script:
+  - bundle exec rubocop
+  - bundle exec rspec
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/Gemfile

@@ -6,3 +6,7 @@ git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in rubocop-expert.gemspec
 gemspec
+
+group :test do
+  gem 'simplecov', require: false
+end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-expert (0.1.0)
+    rubocop-expert (0.1.1)
       rubocop (~> 0.58.2)
       rubocop-rspec (~> 1.29.0)
 
@@ -12,7 +12,10 @@ GEM
     byebug (10.0.2)
     coderay (1.1.2)
     diff-lcs (1.3)
+    docile (1.3.1)
+    jaro_winkler (1.5.1)
     jaro_winkler (1.5.1-x86_64-darwin-17)
+    json (2.1.0)
     method_source (0.9.0)
     parallel (1.12.1)
     parser (2.5.1.2)
@@ -50,6 +53,11 @@ GEM
     rubocop-rspec (1.29.0)
       rubocop (>= 0.58.0)
     ruby-progressbar (1.10.0)
+    simplecov (0.16.1)
+      docile (~> 1.1)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
     unicode-display_width (1.4.0)
 
 PLATFORMS
@@ -61,6 +69,7 @@ DEPENDENCIES
   rake (~> 10.0)
   rspec (~> 3.0)
   rubocop-expert!
+  simplecov
 
 BUNDLED WITH
    1.16.4

data/README.md

@@ -1,11 +1,33 @@
-# Rubocop::Expert
+# RuboCop::Expert [![Gem](https://img.shields.io/gem/v/rubocop-expert.svg?logo=ruby&logoColor=ff1111&colorA=404040)](https://rubygems.org/gems/rubocop-expert)
 
-[![Gem Version](https://badge.fury.io/rb/rubocop-expert.svg)](https://badge.fury.io/rb/rubocop-expert)
-[![MIT License](https://img.shields.io/badge/license-MIT-blue.svg)](LICENSE.txt)
+[![MIT License](https://img.shields.io/badge/license-MIT-blue.svg?logo=github&logoColor=ffffff&colorA=404040)](LICENSE.txt)
+![Ruby Versions](https://img.shields.io/badge/Ruby-2.3_--_2.5-red.svg?logo=ruby&colorA=404040)
+[![Travis CI](https://img.shields.io/travis/akouryy/rubocop-expert.svg?logo=travis&colorA=404040)](https://travis-ci.org/akouryy/rubocop-expert)
+[![Maintainability](https://img.shields.io/codeclimate/maintainability-percentage/akouryy/rubocop-expert.svg?colorA=404040&logoColor=ffffff)](https://codeclimate.com/github/akouryy/rubocop-expert/maintainability)
+[![Test Coverage](https://img.shields.io/codeclimate/coverage/akouryy/rubocop-expert.svg?colorA=404040&logoColor=ffffff)](https://codeclimate.com/github/akouryy/rubocop-expert/test_coverage)
 
 [RuboCop](https://github.com/rubocop-hq/rubocop/) custom cops for elegance.
 
-## Installation
+* [Cops](#cops)
+  * [RedundantParenthesesForMethodCall](#redundantparenthesesformethodcall)
+* [Installation and Usage](#installation-and-usage)
+* [License](#license)
+
+## Cops
+
+### RedundantParenthesesForMethodCall
+
+This cop checks for any *redundant* parentheses for method calls even with arguments.
+```ruby
+# bad
+foo(/a/, *b)
+# good
+foo /a/, *b
+```
+
+For more information and examples, refer to the documentation comment in [redundant_parentheses_for_method_call.rb](lib/rubocop/cop/expert/redundant_parentheses_for_method_call.rb).
+
+## Installation and Usage
 
 Add this line to Gemfile:
 
@@ -13,8 +35,6 @@ Add this line to Gemfile:
 gem 'rubocop-akouryy'
 ```
 
-## Usage
-
 Require this gem in .rubocop.yml:
 
 ```yaml
@@ -22,10 +42,11 @@ require:
   - rubocop-expert
 ```
 
-### Cops
+Now you can check your code with:
 
-The list and documentation of cops are available at
-[/lib/rubocop/cop/expert](https://github.com/akouryy/rubocop-expert/tree/master/lib/rubocop/cop/expert).
+```sh
+$ rubocop
+```
 
 ## Development
 

data/lib/rubocop/cop/expert/redundant_parentheses_for_method_call.rb

@@ -150,6 +150,7 @@ module RuboCop
           return if allowed_by_multiline_config? node
           add_offense node, location: :begin
         end
+        alias on_csend on_send
 
         PARENS_ALLOW_CHECKERS = %i[
           among_multiple_args?
@@ -186,7 +187,7 @@ module RuboCop
 
         private def_node_matcher :among_multiple_args?, <<~PAT
           ^[
-            (send
+            ({send csend}
               !equal?(%0)
               _
               _ _ ...)        #{'>=2 args; %0 is here' * 0}
@@ -199,7 +200,7 @@ module RuboCop
             _ _ ...)          #{'>=1 values' * 0}
         PAT
 
-        private def_node_matcher :arg_s?, '(send _ _ _ ...)' # >=1 args
+        private def_node_matcher :arg_s?, '({send csend} _ _ _ ...)' # >=1 args
 
         private def_node_matcher :array_element?, '^(array ...)'
 
@@ -237,13 +238,15 @@ module RuboCop
         PAT
 
         private def_node_matcher :dot_receiver?, <<~PAT
-          ^[
-            (send
+          {
+            ^[
+              (send
+                equal?(%0)
+                ...)
+              dot?]
+            ^(csend
               equal?(%0)
-              $_
-              ...)
-            dot?
-          ]
+              ...)}
         PAT
 
         private def explicit_receiver? node
@@ -253,6 +256,7 @@ module RuboCop
         private def_node_matcher :fn_style?, <<~PAT
           {
             (send nil? ...)
+            (csend ...)
             [
               (send ...)
               dot?]}
@@ -353,7 +357,7 @@ module RuboCop
 
         private def_node_matcher :with_arg_s_and_brace_block?, <<~PAT
           [
-            (send _ _ _ ...)  #{'>=1 args' * 0}
+            ({send csend} _ _ _ ...)  #{'>=1 args' * 0}
             ^[
               (block ...)
               braces?

data/lib/rubocop/expert/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Expert
-    VERSION = '0.1.1'
+    VERSION = '0.1.2'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-expert
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - akouryy
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-31 00:00:00.000000000 Z
+date: 2018-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop