rubocop-expert 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 974e35da2dea073e6767d09157e165d66f3163e0a7824d505cfaff18f754e3c5
-  data.tar.gz: 93ca7b4ae6cc48d2f534246813a6ff36067040d80a9a5fb204bdd3fa257c15fb
+  metadata.gz: fe20794a04bdfc3cbc23a95d0ca85fbd3ef6f767049647a132f8ed47cf26c033
+  data.tar.gz: cf4f4e5aaecbc5ca138d7a0ca6fdf2df7db1b804b201c3a12f6efe0082e9a28d
 SHA512:
-  metadata.gz: d433c84d5327579694cce88ab5dc2c7fe55415ca6a8b44ed3d854a4e2c2227c84279556cf9baf7fca783ff9e08897c34905b0bc2eed4b68bdd785f52a5b7eda9
-  data.tar.gz: 056d1feee3d416ec6c5692d33ca90fa2fe439c627d815cd4016b3ba5db5c396b3d8e1e2341b90c86cd40421de2ad3ebcb1c964890182481823c6cd08858765a0
+  metadata.gz: 5963fdad27ed7ed602f0b92b825f28943097b4323e41b38821a84c8eac5eab34176f439a72f938bbc0b69354c885ae207819a445b84b4c34b3fb7ff2b1ce06c8
+  data.tar.gz: bf452bcc544e79fd1d4b5e2993454919188a7eac3153b4393f288251ccc811fef2f0637a25b153554138ddfb20ac03494edb59678ce7651026de99769c454d44

data/README.md

@@ -1,5 +1,8 @@
 # Rubocop::Expert
 
+[![Gem Version](https://badge.fury.io/rb/rubocop-expert.svg)](https://badge.fury.io/rb/rubocop-expert)
+[![MIT License](https://img.shields.io/badge/license-MIT-blue.svg)](LICENSE.txt)
+
 [RuboCop](https://github.com/rubocop-hq/rubocop/) custom cops for elegance.
 
 ## Installation
@@ -10,12 +13,6 @@ Add this line to Gemfile:
 gem 'rubocop-akouryy'
 ```
 
-Or install it yourself as:
-
-```
-gem install rubocop rubocop-rspec rubocop-akouryy
-```
-
 ## Usage
 
 Require this gem in .rubocop.yml:

data/lib/rubocop/cop/expert/redundant_parentheses_for_method_call.rb

@@ -47,6 +47,7 @@ module RuboCop
       #   # Parentheses are required.
       #   -foo(0)
       #   foo(0) + 1
+      #   foo(0) ? bar(1) : baz(2)
       #   foo(0).bar
       #   foo(0){}
       #   foo 0, bar(1)
@@ -150,6 +151,23 @@ module RuboCop
           add_offense node, location: :begin
         end
 
+        PARENS_ALLOW_CHECKERS = %i[
+          among_multiple_args?
+          among_multiple_args_like?
+          array_element?
+          assoc_bracket_multiple_element?
+          default_of_optarg?
+          explicit_receiver?
+          hash_key_or_value?
+          high_operand?
+          implicit_call?
+          rescue_error_type?
+          splat_like?
+          when_cond?
+          with_arg_s_and_brace_block?
+        ].freeze
+        private_constant :PARENS_ALLOW_CHECKERS
+
         private def allowed_by_multiline_config? node
           fn_ln = node.loc.selector&.line
           first_arg_ln = node.arguments[0]&.loc&.line
@@ -167,25 +185,46 @@ module RuboCop
         end
 
         private def_node_matcher :among_multiple_args?, <<~PAT
-          ^(send
-            !equal?(%0)
-            _
-            ...)              #{'%0 is here' * 0}
+          ^[
+            (send
+              !equal?(%0)
+              _
+              _ _ ...)        #{'>=2 args; %0 is here' * 0}
+            #fn_style?]
         PAT
 
-        private def_node_matcher :among_multiple_return?, <<~PAT
-          ^(return _ _ ...)   #{'>=1 values' * 0}
+        private def_node_matcher :among_multiple_args_like?, <<~PAT
+          ^(
+            {return break next super}
+            _ _ ...)          #{'>=1 values' * 0}
         PAT
 
+        private def_node_matcher :arg_s?, '(send _ _ _ ...)' # >=1 args
+
         private def_node_matcher :array_element?, '^(array ...)'
 
+        private def_node_matcher :assoc_bracket_multiple_element?, <<~PAT
+          ^[
+            {
+              (send
+                !equal?(%0)
+                :[]
+                _ _ ...)      #{'>=2 elements; %0 is here' * 0}
+              (send
+                !equal?(%0)
+                :[]=
+                _ _ ...       #{'>=2 elements; %0 is here' * 0}
+                _)}           #{': expr after "="' * 0}
+            !#fn_style?]
+        PAT
+
         private def_node_matcher :bracket_receiver?, <<~PAT
           ^[
             (send
               equal?(%0)
               { :[] :[]= }
               ...)
-            !dot?
+            !#fn_style?
           ]
         PAT
 
@@ -211,10 +250,17 @@ module RuboCop
           bracket_receiver?(node) || dot_receiver?(node)
         end
 
-        private def_node_matcher :hash_element?, <<~PAT
+        private def_node_matcher :fn_style?, <<~PAT
+          {
+            (send nil? ...)
+            [
+              (send ...)
+              dot?]}
+        PAT
+
+        private def_node_matcher :hash_key_or_value?, <<~PAT
           [
             ^^(hash ...)
-            ^(pair _ equal?(%0))
           ]
         PAT
 
@@ -225,10 +271,10 @@ module RuboCop
         private def_node_matcher :high_method_operator_arg?, <<~PAT
           ^[
             (send
-              !nil?
+              _
               #high_operator?
               equal?(%0))
-            !dot?
+            !#fn_style?
           ]
         PAT
 
@@ -238,12 +284,14 @@ module RuboCop
               equal?(%0)
               #high_operator?
               ...)
-            !dot?
+            !#fn_style?
+            !keyword_not?
           ]
         PAT
 
         private def high_operand? node
-          high_method_operand?(node) || high_special_operand?(node)
+          high_method_operand?(node) || high_special_operand?(node) ||
+            ternary_operand?(node)
         end
 
         private def high_operator? op
@@ -274,27 +322,33 @@ module RuboCop
         end
 
         private def parens_allowed? node
-          %i[
-            among_multiple_args?
-            among_multiple_return?
-            array_element?
-            default_of_optarg?
-            explicit_receiver?
-            hash_element?
-            high_operand?
-            implicit_call?
-            splat_like?
-            when_cond?
-            with_arg_s_and_brace_block?
-          ].any? do |sym|
-            __send__ sym, node
-          end
+          arg_s?(node) &&
+            PARENS_ALLOW_CHECKERS.any? do |sym|
+              __send__ sym, node
+            end
         end
 
+        # covered by array_element?, but check again to ensure
+        private def_node_matcher :rescue_error_type?, <<~PAT
+          [
+            ^^(resbody ...)
+            ^(array ...)]
+        PAT
+
         private def_node_matcher :special_operand?, '^({and or} ...)'
 
         private def_node_matcher :splat_like?, '^({splat kwsplat block_pass} equal?(%0))'
 
+        private def_node_matcher :ternary_operand?, <<~PAT
+          {
+            ^[(if ...) ternary?]
+            [
+              ^^[(if ...) ternary?]
+              ^{
+                (lvasgn _ equal?(%0))
+                (op_asgn _ _ equal?(%0))}]}
+        PAT
+
         private def_node_matcher :when_cond?, '^(when equal?(%0) _)'
 
         private def_node_matcher :with_arg_s_and_brace_block?, <<~PAT

data/lib/rubocop/expert/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Expert
-    VERSION = '0.1.0'
+    VERSION = '0.1.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-expert
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - akouryy
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-30 00:00:00.000000000 Z
+date: 2018-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop