rubocop-elegant 0.6.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60367f0f72f86e055af5d89d7120871578083d2812c4996e6fa027fb6d3b6cae
-  data.tar.gz: 72077f0159044736a87ebb84c818c72d8280182d8fc6fcbf42f09d776d9c0775
+  metadata.gz: 49e44073640a27652772c3b1930072896e3fa04d47f81ec741a3f1941f9dcaca
+  data.tar.gz: 9d4de768ab46f9246ac3bf5554501e9c3472a821563cd3022a21a15be6f4e728
 SHA512:
-  metadata.gz: 6f906093f750d1a9c5db831efb8ddc769d00a6449b62432a6ca645c6dc256f62944b9af2d45688f028cc5b242001ff9fa634a261ecbec928399233f2ba25b93e
-  data.tar.gz: 6f1e7b0f76573edea8582d3607c4e5deaae6b8944bfa133ed58d121cf9a2d4afc38dc6eb26d87fb4a388ded4a1bb355c9d7e56da380448f70b33d7baa35ab9e5
+  metadata.gz: 60d73b3d6db72f172ecdf0950670221938cb2c08fb88a4f70183db7b324a8d31f5ad0e03d71502cae60df24dc24aaa12e53a805f44ac914117c49cd48df74fa6
+  data.tar.gz: 81c6c3e3bb185c60ebe83b82dc810325ab8dd5b93ea17b2853ff73dc20f0664296cdad793e369652a6947a38bba63dc945cfcf35cfc37d51622b81e5582add9f

data/Gemfile

@@ -9,7 +9,7 @@ gemspec
 gem 'minitest', '~>6.0', require: false
 gem 'minitest-reporters', '~>1.7', require: false
 gem 'rake', '~>13.2', require: false
-gem 'rdoc', '7.2.0', require: false
+gem 'rdoc', '8.0.0', require: false
 gem 'rubocop', '~>1.74', require: false
 gem 'rubocop-minitest', '~>0.38', require: false
 gem 'rubocop-performance', '~>1.25', require: false

data/README.md

@@ -43,7 +43,6 @@ Then, format your `.rubocop.yml` like this:
 
 ```yaml
 AllCops:
-  EnabledByDefault: true
   NewCops: enable
 plugins:
   - rubocop-minitest

data/config/default.yml

@@ -103,6 +103,8 @@ Layout/EndOfLine:
   EnforcedStyle: lf
 Layout/ParameterAlignment:
   Enabled: false
+Layout/ArrayAlignment:
+  EnforcedStyle: with_fixed_indentation
 Layout/LineLength:
   Max: 120
 Style/MultilineBlockChain:

data/lib/rubocop/cop/elegant/good_method_name.rb

@@ -18,11 +18,16 @@ class RuboCop::Cop::Elegant::GoodMethodName < RuboCop::Cop::Base
   private
 
   def check(node, name)
+    return unless identifier?(name)
     return if allowed?(name)
     return if match?(name)
     add_offense(node, message: format(MSG, name: name))
   end
 
+  def identifier?(name)
+    /\A[a-zA-Z_]/.match?(name)
+  end
+
   def match?(name)
     pattern.match?(name)
   end

data/lib/rubocop/cop/elegant/no_nil_return.rb

@@ -3,17 +3,21 @@
 # SPDX-FileCopyrightText: Copyright (c) 2019-2026 Yegor Bugayenko
 # SPDX-License-Identifier: MIT
 
-# Forbids a method from returning the literal +nil+ explicitly. The
-# cop flags two patterns: a +return nil+ statement anywhere inside
-# the method body, and a method whose tail expression is the literal
-# +nil+ (whether it stands alone or appears as the last statement of
-# a multi-statement body). Methods that omit +return+, use a bare
+# Forbids returning the literal +nil+ explicitly. The cop flags two
+# patterns: a +return nil+ statement anywhere inside the body, and a
+# body whose tail expression is the literal +nil+ (whether it stands
+# alone or appears as the last statement of a multi-statement body).
+# Both patterns are checked inside method definitions and inside
+# blocks, lambdas, and procs. Bodies that omit +return+, use a bare
 # +return+ keyword, or merely happen to evaluate to +nil+ through
 # control flow are not flagged.
 class RuboCop::Cop::Elegant::NoNilReturn < RuboCop::Cop::Base
   MSG = 'Method must not return nil explicitly'
   public_constant :MSG
 
+  SCOPES = %i[def defs block numblock].freeze
+  private_constant :SCOPES
+
   def on_def(node)
     check(node)
   end
@@ -22,6 +26,14 @@ class RuboCop::Cop::Elegant::NoNilReturn < RuboCop::Cop::Base
     check(node)
   end
 
+  def on_block(node)
+    check(node)
+  end
+
+  def on_numblock(node)
+    check(node)
+  end
+
   private
 
   def check(node)
@@ -32,7 +44,7 @@ class RuboCop::Cop::Elegant::NoNilReturn < RuboCop::Cop::Base
 
   def explicit(node)
     node.each_descendant(:return) do |ret|
-      next unless ret.each_ancestor(:def, :defs).first.equal?(node)
+      next unless ret.each_ancestor(*SCOPES).first.equal?(node)
       add_offense(ret) if void?(ret)
     end
   end

data/rubocop-elegant.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to?(:required_rubygems_version=)
   s.required_ruby_version = '>=2.2'
   s.name = 'rubocop-elegant'
-  s.version = '0.6.0'
+  s.version = '0.7.1'
   s.license = 'MIT'
   s.summary = 'Set of custom RuboCop cops for elegant Ruby coding'
   s.description =

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-elegant
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Yegor Bugayenko