rubocop-elegant 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a4408943315c5a59e194dcb473bc2b48e7d1b2c07182a155a27ce613bc7bef5
-  data.tar.gz: a4f9028d7cd0b076315f65b9e00a0ee0c204f395a821957a036795bcf14234ff
+  metadata.gz: 0441b4d9f29a02a65680ffc46fb56985251723336a076999f7867ad7eb92185d
+  data.tar.gz: 92771eff5ed80253a14a85fd96ecaace40e7ce0476f2e26c6cb42372a26b9706
 SHA512:
-  metadata.gz: 1489006295818667d80b86717b323f179e739cc7a5cf5ff4716d8c07cac67aa6f1ab3d8236a35636f290ea147315f1e19461a1cb17f50461a48d5e48e6b1e098
-  data.tar.gz: 0c42fda07e77a2ac808325c596e57a207d1cdc19ac05d7807d2318d69d1ca91822144c75c97c14d4fcbb6656bb92fe36c3d7ea0616480c5daf388393a254b8f7
+  metadata.gz: b1fd06eba3ce66013593a26400d81698fa3eeb01725890aa3ae5e0f78d086729b6b633f9d6a0551e61e2c1118ad844a12daba2ab97da5306ff13b8feb48a3d2b
+  data.tar.gz: 7595e8287a2f7f3904d643c98c1bafc412c2bfebcf4eb2de364ae13af4badf491985eba022f86cf93362efb997d0df57a171068a3ecc1ffb0b27d0c0cbf6e028

data/lib/rubocop/cop/elegant/no_redundant_variable.rb

@@ -19,7 +19,19 @@
 # whether or when the right-hand side is evaluated. A variable that
 # is reassigned, read more than once, or never read is left alone
 # too.
+#
+# Auto-correct inlines the redundant assignment: it replaces the
+# single +lvar+ read with the source of the assignment's right-hand
+# side, then removes the whole assignment line including its leading
+# indent and trailing newline. The right-hand side is wrapped in
+# parentheses unless it is already a primary expression (literal,
+# variable, parenthesized expression, or method call with parentheses
+# or no arguments), so that operator precedence at the read site is
+# preserved.
 class RuboCop::Cop::Elegant::NoRedundantVariable < RuboCop::Cop::Base
+  extend RuboCop::Cop::AutoCorrector
+  include RuboCop::Cop::RangeHelp
+
   MSG = 'Variable "%<name>s" is redundant and must be inlined: it is read only once'
   public_constant :MSG
 
@@ -35,6 +47,12 @@ class RuboCop::Cop::Elegant::NoRedundantVariable < RuboCop::Cop::Base
   ALWAYS_HOIST_TYPES = %i[rescue resbody ensure].freeze
   public_constant :ALWAYS_HOIST_TYPES
 
+  PRIMARY_TYPES = %i[
+    int float str sym dstr dsym xstr true false nil array hash regexp
+    lvar ivar cvar gvar const self nth_ref back_ref
+  ].freeze
+  public_constant :PRIMARY_TYPES
+
   def on_def(node)
     check(node.body)
   end
@@ -56,10 +74,52 @@ class RuboCop::Cop::Elegant::NoRedundantVariable < RuboCop::Cop::Base
       next unless nodes.size == 1
       next unless reads[name].size == 1
       next if hoisted?(reads[name].first, nodes.first)
-      add_offense(nodes.first, message: format(MSG, name: name))
+      register(nodes.first, reads[name].first, name)
+    end
+  end
+
+  def register(assign, read, name)
+    return add_offense(assign, message: format(MSG, name: name)) unless solo?(assign)
+    add_offense(assign, message: format(MSG, name: name)) do |corrector|
+      corrector.replace(read.source_range, inlined(assign.children.last, read))
+      corrector.remove(range_by_whole_lines(assign.source_range, include_final_newline: true))
     end
   end
 
+  def solo?(assign)
+    range = assign.source_range
+    return false unless range.first_line == range.last_line
+    range.source_buffer.source_line(range.first_line).strip == range.source.strip
+  end
+
+  def inlined(rhs, read)
+    return "(#{braced(rhs)})" if wrap?(rhs, read)
+    braced(rhs)
+  end
+
+  def braced(rhs)
+    return "{ #{rhs.source} }" if rhs.hash_type? && rhs.loc.begin.nil?
+    rhs.source
+  end
+
+  def wrap?(rhs, read)
+    return true unless primary?(rhs)
+    rhs.hash_type? && bare?(read)
+  end
+
+  def primary?(node)
+    return true if PRIMARY_TYPES.include?(node.type)
+    return !node.loc.begin.nil? || node.arguments.empty? if node.send_type? || node.csend_type?
+    node.begin_type? && node.children.size == 1
+  end
+
+  def bare?(read)
+    parent = read.parent
+    return false if parent.nil?
+    return false unless parent.send_type? || parent.csend_type?
+    parent.loc.begin.nil? && parent.arguments.include?(read)
+  end
+
   def walk(node, assigns, reads, tainted)
     return unless node.is_a?(RuboCop::AST::Node)
     return if node.def_type? || node.defs_type?

data/lib/rubocop/cop/elegant/paired_brackets.rb

@@ -9,8 +9,17 @@
 # closing). Brackets stranded in the middle of a multi-line expression
 # are forbidden because they hide the structure of the code.
 #
+# Auto-correct relocates the offending bracket onto its own line: an
+# opener that is not at end-of-line gets a newline and the opener-line
+# indent plus two spaces inserted right after it; a closer that is not
+# at start-of-line gets a newline and the opener-line indent inserted
+# right before it. Surrounding indentation may still need a follow-up
+# layout pass, but the brackets themselves end up paired.
+#
 # See https://www.yegor256.com/2014/10/23/paired-brackets-notation.html
 class RuboCop::Cop::Elegant::PairedBrackets < RuboCop::Cop::Base
+  extend RuboCop::Cop::AutoCorrector
+
   MSG = 'Bracket %<text>s must be paired on the same line, or start/end its line'
   public_constant :MSG
 
@@ -43,8 +52,9 @@ class RuboCop::Cop::Elegant::PairedBrackets < RuboCop::Cop::Base
   def check(duo)
     opener, closer = duo
     return if opener.line == closer.line
-    register(opener) unless ends?(opener)
-    register(closer) unless starts?(closer)
+    indent = leading(opener)
+    register(opener) { |corrector| corrector.insert_after(opener.pos, "\n#{indent}  ") } unless ends?(opener)
+    register(closer) { |corrector| corrector.insert_before(closer.pos, "\n#{indent}") } unless starts?(closer)
   end
 
   def starts?(tok)
@@ -56,7 +66,11 @@ class RuboCop::Cop::Elegant::PairedBrackets < RuboCop::Cop::Base
     after.empty? || after.start_with?('#')
   end
 
-  def register(tok)
-    add_offense(tok.pos, message: format(MSG, text: tok.text))
+  def leading(tok)
+    processed_source.lines[tok.line - 1][/\A[ \t]*/]
+  end
+
+  def register(tok, &block)
+    add_offense(tok.pos, message: format(MSG, text: tok.text), &block)
   end
 end

data/rubocop-elegant.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to?(:required_rubygems_version=)
   s.required_ruby_version = '>=2.2'
   s.name = 'rubocop-elegant'
-  s.version = '0.3.0'
+  s.version = '0.4.0'
   s.license = 'MIT'
   s.summary = 'Set of custom RuboCop cops for elegant Ruby coding'
   s.description =

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-elegant
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Yegor Bugayenko