rubocop-elegant 0.0.8 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0539949abeb53317287379d9fd13d4c2f672aefe830d40b8075e62c5550cda76'
-  data.tar.gz: 890fa74b0264add82bee3d266420625e4e95c5b79109c5b61b35b7babbee8a56
+  metadata.gz: 3217f34ead6ad0b67f7a26e1161f02a95348516568d7f6e7854f55868851d61c
+  data.tar.gz: 85731d9b53196da18194c638ca619470b560ef07618d5ba3c31ebbedfa80c874
 SHA512:
-  metadata.gz: 24621f1ff1a81e8ef550e61c0aa8126658a2a087afea620428850ffd554ab7e525efd1aae365967e351cf3930ce7baeaf952b13994a2b3e171722fa89d2f7383
-  data.tar.gz: a2bde4c190887c1572c5c4500c3eb8c2f4bd5b11002dd8cce9f3931169ff4b611f413152ed90887fdb8514e766051fa59a40a662a0b4fe6aa5d572258a2f470a
+  metadata.gz: a893c8544575191d84d47bf8e44e6f109ca63858b2ec08410a298d81a3ccf9bcde4f2deafe70d03f299895e15a6e45c02bdf7c4daa55be505ca632aa6bcd6940
+  data.tar.gz: 6eb5a8ac49772f0a1d11d314ce438cbadfb6cb31f567dc453d96d3820d306d1b45376bc9b471d999ead56340796bf12b6cc09d064ae1067404bcfc630057dbf1

data/README.md

@@ -25,14 +25,21 @@ First, install it:
 gem install rubocop-elegant
 ```
 
-Then, add it to your `.rubocop.yml`:
+Then, format your `.rubocop.yml` like this:
 
 ```yaml
+AllCops:
+  EnabledByDefault: true
+  NewCops: enable
 plugins:
-  - rubocop-elegant
+  - rubocop-minitest
+  - rubocop-performance
+  - rubocop-rake
+  - rubocop-elegant # must be the last one
 ```
 
-Should work.
+The `rubocop-elegant` not only provides its own cops, but also configures
+  default ones the "right" way.
 
 ## How to contribute
 

data/config/default.yml

@@ -41,8 +41,6 @@ Naming/FileName:
   Regex: '^[a-z0-9\-._]*$'
 Minitest/EmptyLineBeforeAssertionMethods:
   Enabled: false
-Layout/EmptyLineAfterGuardClause:
-  Enabled: false
 Layout/RescueEnsureAlignment:
   Enabled: false
 Layout/MultilineMethodCallIndentation:
@@ -93,3 +91,37 @@ Metrics/CyclomaticComplexity:
   Max: 15
 Metrics/PerceivedComplexity:
   Max: 15
+Lint/ConstantResolution:
+  Enabled: false
+Style/IpAddresses:
+  Enabled: false
+Minitest/NoAssertions:
+  Enabled: false
+Layout/EmptyLineAfterGuardClause:
+  Enabled: false
+Bundler/GemComment:
+  Enabled: false
+Style/DocumentationMethod:
+  Enabled: false
+Style/MissingElse:
+  Enabled: false
+Style/MethodCalledOnDoEndBlock:
+  Enabled: false
+Style/StringHashKeys:
+  Enabled: false
+Style/HashLookupMethod:
+  Enabled: false
+Style/MethodCallWithArgsParentheses:
+  Enabled: true
+Layout/MultilineMethodArgumentLineBreaks:
+  Enabled: false
+Layout/RedundantLineBreak:
+  Enabled: true
+Performance/Casecmp:
+  Enabled: false
+Layout/FirstMethodArgumentLineBreak:
+  Enabled: false
+Style/ArrayFirstLast:
+  Enabled: false
+Minitest/AssertEmptyLiteral:
+  Enabled: false

data/lib/rubocop/cop/elegant/good_method_name.rb

@@ -8,6 +8,7 @@ module RuboCop
     module Elegant
       class GoodMethodName < Base
         MSG = 'Method name "%<name>s" does not match the required pattern'
+        public_constant :MSG
 
         def on_def(node)
           check(node, node.method_name.to_s)

data/lib/rubocop/cop/elegant/good_variable_name.rb

@@ -8,6 +8,7 @@ module RuboCop
     module Elegant
       class GoodVariableName < Base
         MSG = 'Variable name "%<name>s" does not match the required pattern'
+        public_constant :MSG
 
         def on_lvasgn(node)
           check(node, node.children.first.to_s)

data/lib/rubocop/cop/elegant/no_comments.rb

@@ -10,6 +10,7 @@ module RuboCop
         extend AutoCorrector
 
         MSG = 'Comment is not allowed, unless it is SPDX, magic, or rubocop directive'
+        public_constant :MSG
 
         def on_new_investigation
           processed_source.comments.each do |comment|

data/lib/rubocop/cop/elegant/no_empty_lines_in_methods.rb

@@ -10,6 +10,7 @@ module RuboCop
         extend AutoCorrector
 
         MSG = 'Empty line inside method body is not allowed'
+        public_constant :MSG
 
         def on_def(node)
           check(node)
@@ -31,7 +32,7 @@ module RuboCop
         def range(node)
           first = node.body.first_line
           last = node.body.last_line
-          return nil if first == last
+          return if first == last
           (first..last)
         end
 

data/lib/rubocop/elegant/version.rb

@@ -6,5 +6,6 @@
 module RuboCop
   module Elegant
     VERSION = '0.0.1'
+    public_constant :VERSION
   end
 end

data/rubocop-elegant.gemspec

@@ -6,10 +6,10 @@
 require 'English'
 
 Gem::Specification.new do |s|
-  s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to? :required_rubygems_version=
+  s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to?(:required_rubygems_version=)
   s.required_ruby_version = '>=2.2'
   s.name = 'rubocop-elegant'
-  s.version = '0.0.8'
+  s.version = '0.0.10'
   s.license = 'MIT'
   s.summary = 'Set of custom RuboCop cops for elegant Ruby coding'
   s.description =
@@ -22,6 +22,6 @@ Gem::Specification.new do |s|
   s.extra_rdoc_files = ['README.md']
   s.metadata['rubygems_mfa_required'] = 'true'
   s.metadata['default_lint_roller_plugin'] = 'RuboCop::Elegant::Plugin'
-  s.add_dependency 'lint_roller', '~> 1.1'
-  s.add_dependency 'rubocop', '~> 1.75'
+  s.add_dependency('lint_roller', '~> 1.1')
+  s.add_dependency('rubocop', '~> 1.75')
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-elegant
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.10
 platform: ruby
 authors:
 - Yegor Bugayenko