rubocop-elegant 0.0.13 → 0.0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52b4a90ea309c9255ce91551140e414d270d93084d5db71ab0ca6c274b989064
-  data.tar.gz: 88cf9d0d858f6c551fa8b4adc9c9a319f8008496f97853f458c6c419c61d8b7b
+  metadata.gz: 41a4bba1e8a54cc943ed7c75113c8a1786b4e8ae7b8e7b886133ab657bfff375
+  data.tar.gz: 6d16cb13b8b1c5d5a79ee8c39462d6957a0cc49b798294b7fe1fce3473018e72
 SHA512:
-  metadata.gz: 8578b0c3c3ec4dfda7a4bb23be3595cebffc8fc6a61189fe671d24f64ee520e3b12db3e76651d6885c6b8d29e18692f1f0cb806aac70cf1e3a4eb25cca57d303
-  data.tar.gz: 0b73760980abf0f65481797d62e82fa7e813dbc980cb9f14274ce2185132ea68dcbd116d0b0ceff8fb9ae4650f1724b76aab4534ffe8bc268111ab80845e7540
+  metadata.gz: 480a11bf5d184e5e899b3ac48bd17270bdda9fe84417aa837d5ced0f0b8efe6e77caada317cd4386d903a4a5477a7254fa5c609f1701b7b09fc4ea9500257afe
+  data.tar.gz: d5e924d77377f1446657e4c5457aab1b86763cc0fe5fb7d0d3cf79d212795f28eec3f686bac0744a99671dcd16a768c788c26f6e2db9a3b908011d9a8b7ecbc9

data/config/default.yml

@@ -16,12 +16,14 @@ Elegant/GoodVariableName:
   Description: 'Checks that variable names match the configured pattern'
   Enabled: true
   VersionAdded: '0.0.3'
-  Pattern: '^(@{1,2}|\$)?(the_|test_|fake_)?[a-z]{1,16}$'
+  Pattern: '^(_.*|(@{1,2}|\$)?(the_|test_|fake_)?[a-z]{1,16})$'
+  AllowedNames: []
 Elegant/GoodMethodName:
   Description: 'Checks that method names match the configured pattern'
   Enabled: true
   VersionAdded: '0.0.3'
-  Pattern: '^((fake_|the_)?[a-z]{1,16}[!?]?|test_[a-z_]+|on_[a-z_]+)$'
+  Pattern: '^(((to|fake|the|with|without|on)_)?[a-z]{1,16}[!?]?|test_[a-z_]+)$'
+  AllowedNames: []
 
 Naming/VariableName:
   Enabled: false

data/lib/rubocop/cop/elegant/good_method_name.rb

@@ -21,6 +21,7 @@ module RuboCop
         private
 
         def check(node, name)
+          return if allowed?(name)
           return if match?(name)
           add_offense(node, message: format(MSG, name: name))
         end
@@ -29,6 +30,10 @@ module RuboCop
           pattern.match?(name)
         end
 
+        def allowed?(name)
+          Array(cop_config['AllowedNames']).map(&:to_s).include?(name)
+        end
+
         def pattern
           @pattern ||= Regexp.new(cop_config['Pattern'] || '^[a-z]+[!?]?$')
         end

data/lib/rubocop/cop/elegant/good_variable_name.rb

@@ -29,6 +29,7 @@ module RuboCop
         private
 
         def check(node, name)
+          return if allowed?(name)
           return if match?(name)
           add_offense(node, message: format(MSG, name: name))
         end
@@ -37,6 +38,10 @@ module RuboCop
           pattern.match?(name)
         end
 
+        def allowed?(name)
+          Array(cop_config['AllowedNames']).map(&:to_s).include?(name)
+        end
+
         def pattern
           @pattern ||= Regexp.new(cop_config['Pattern'] || '^[a-z]+$')
         end

data/lib/rubocop/cop/elegant/no_comments.rb

@@ -12,11 +12,13 @@ module RuboCop
         MSG = 'Comment is not allowed, unless it is SPDX, magic, rubocop directive, or docblock'
         public_constant :MSG
 
+        # rubocop:disable Elegant/GoodMethodName
         def on_new_investigation
           processed_source.comments.each do |comment|
             register(comment) unless allowed?(comment)
           end
         end
+        # rubocop:enable Elegant/GoodMethodName
 
         private
 

data/rubocop-elegant.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to?(:required_rubygems_version=)
   s.required_ruby_version = '>=2.2'
   s.name = 'rubocop-elegant'
-  s.version = '0.0.13'
+  s.version = '0.0.15'
   s.license = 'MIT'
   s.summary = 'Set of custom RuboCop cops for elegant Ruby coding'
   s.description =

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-elegant
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.15
 platform: ruby
 authors:
 - Yegor Bugayenko