rubocop-elegant 0.0.12 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 339ef33644424e7d5a16d648c25e1816c25567ce88f65a68183ef0e6f293b335
-  data.tar.gz: dbc16893f109848be8aab8c4757115c4fefe72d8b8d486547c13046fe1dd915a
+  metadata.gz: 3620bcb1fd58f208aefb372f08005c7551bbbd51c957c335105a293c56ff83b0
+  data.tar.gz: b02183fb7f7d13d097ed472f19a55918a0a9d5dc3a8e2b713d0334323b3d9088
 SHA512:
-  metadata.gz: 9b1cdcc2a1cb3cd39a8436b8601082922587d1f8730a1f3138eff4ba6cd178114904acfd5acb6637b795f17986b5b6ac3bb4648af97e87efc39c7e3e2109ddfb
-  data.tar.gz: 74e0563ef2342162ba2d80d0fc086c605c41793d6d7568c34d5a67362944297ec0ec43bdf52bc7dd319bbdf92a10b6f39c20f176339555dbddfae01b551cd7ee
+  metadata.gz: a3cd063438b9f2c581a9a6acae90f7ae3f9b7b2017cd9c4e7b280e11bf1377ae9bb141701bc410fa1bfb793d8b4636de0da598379355558cf49d299184491f66
+  data.tar.gz: 66bebaa301d79ef897a8c54b76d60ea7a5c937b68789d7ce00ffb652515c7b7e4d1b0cf36712b8a869d70c01ae5337e3b9b04357035c624681b94f52a2a25de4

data/config/default.yml

@@ -16,12 +16,12 @@ Elegant/GoodVariableName:
   Description: 'Checks that variable names match the configured pattern'
   Enabled: true
   VersionAdded: '0.0.3'
-  Pattern: '^(@{1,2}|\$)?(the_|test_|fake_)?[a-z]{1,16}$'
+  Pattern: '^(_.*|(@{1,2}|\$)?(the_|test_|fake_)?[a-z]{1,16})$'
 Elegant/GoodMethodName:
   Description: 'Checks that method names match the configured pattern'
   Enabled: true
   VersionAdded: '0.0.3'
-  Pattern: '^((fake_|the_)?[a-z]{1,16}[!?]?|test_[a-z_]+|on_[a-z_]+)$'
+  Pattern: '^(((to|fake|the|with|without|on)_)?[a-z]{1,16}[!?]?|test_[a-z_]+)$'
 
 Naming/VariableName:
   Enabled: false

data/lib/rubocop/cop/elegant/no_comments.rb

@@ -9,14 +9,16 @@ module RuboCop
       class NoComments < Base
         extend AutoCorrector
 
-        MSG = 'Comment is not allowed, unless it is SPDX, magic, or rubocop directive'
+        MSG = 'Comment is not allowed, unless it is SPDX, magic, rubocop directive, or docblock'
         public_constant :MSG
 
+        # rubocop:disable Elegant/GoodMethodName
         def on_new_investigation
           processed_source.comments.each do |comment|
             register(comment) unless allowed?(comment)
           end
         end
+        # rubocop:enable Elegant/GoodMethodName
 
         private
 
@@ -40,8 +42,14 @@ module RuboCop
           return @gemspec if defined?(@gemspec)
           path = processed_source.path
           return @gemspec = false if path.nil?
-          dir = File.dirname(path)
-          @gemspec = Dir.glob(File.join(dir, '*.gemspec')).any?
+          @gemspec = root(File.dirname(path))
+        end
+
+        def root(dir)
+          return true if Dir.glob(File.join(dir, '*.gemspec')).any?
+          parent = File.dirname(dir)
+          return false if parent == dir
+          root(parent)
         end
 
         def docblock?(comment)

data/rubocop-elegant.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to?(:required_rubygems_version=)
   s.required_ruby_version = '>=2.2'
   s.name = 'rubocop-elegant'
-  s.version = '0.0.12'
+  s.version = '0.0.14'
   s.license = 'MIT'
   s.summary = 'Set of custom RuboCop cops for elegant Ruby coding'
   s.description =

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-elegant
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.14
 platform: ruby
 authors:
 - Yegor Bugayenko