rubocop-discourse 3.9.2 → 3.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b3535299ced6e96016ee33586fe7e9b8e0b910c6cc2a441972acb9e3c6b9207
-  data.tar.gz: 99f0a0dd461aebbc1267dba788730ade31af6a02f0709ae51c8afba65b109d98
+  metadata.gz: 4003717b78bca02f538f48bc23fdd1b0e913bb6816c5d6a1e87401c53c167a14
+  data.tar.gz: acba524c9e7e399a5b69974ce94dfefa33fbd61c5c2197ecb425b1ed22418e23
 SHA512:
-  metadata.gz: 48c1e9c95219737c00fd847c9f030f4e3704147b64dd16cc5a79449cec341535d870f498430afc7b47115ad6edb31adddcc54e145e60d100292fef7576e3b689
-  data.tar.gz: 2b19583ee4c90bb79e1dfcfe5919bf1fe9c13786ecd8a8d6b4cfe0bfaa0fc8952ae280a721631d4968b736ac13c34857290698b989bbcf8ce30dafa57bf6c0d7
+  metadata.gz: 9fd47066d7d8066da4adb2f17d95de3420fbaae18599d07925671a28c58a95a2d39b4ba8319813a0daf2106e7ecce4407a99470a93f2d99f335147bad3142269
+  data.tar.gz: 311df91f7d4cf9b5e296d3dcbf625482a0fdea6ac1da33fe389b7db41ec0339b4918434ce97a13c023ba86e3a54eb81edcb512aba7cb9abd0a21b19bb5b5527d

data/lib/rubocop/cop/discourse/services/empty_lines_around_blocks.rb

@@ -53,7 +53,7 @@ module RuboCop
           def on_block(node)
             return unless service?
             return unless top_level_block?(node)
-            return if node.single_line?
+            return if node.single_line? || single_block?(node)
 
             if missing_empty_lines?(node)
               add_offense(node, message: MSG) do |corrector|
@@ -78,6 +78,10 @@ module RuboCop
 
           private
 
+          def single_block?(node)
+            !node.ancestors.first.begin_type?
+          end
+
           def service?
             @service
           end

data/rubocop-discourse.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = "rubocop-discourse"
-  s.version = "3.9.2"
+  s.version = "3.9.3"
   s.summary = "Custom rubocop cops used by Discourse"
   s.authors = ["Discourse Team"]
   s.license = "MIT"

data/spec/lib/rubocop/cop/discourse/services/empty_lines_around_blocks_spec.rb

@@ -128,6 +128,23 @@ RSpec.describe RuboCop::Cop::Discourse::Services::EmptyLinesAroundBlocks,
     end
 
     context "when blocks are nested" do
+      context "when there is just one nested block" do
+        it "does not register an offense" do
+          expect_no_offenses(<<~RUBY)
+            class MyService
+              include Service::Base
+
+              transaction do
+                try do
+                  step :first_step
+                  step :second_step
+                end
+              end
+            end
+          RUBY
+        end
+      end
+
       context "when the nested block is in the first position" do
         context "when there is no empty line before" do
           it "does not register an offense" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-discourse
 version: !ruby/object:Gem::Version
-  version: 3.9.2
+  version: 3.9.3
 platform: ruby
 authors:
 - Discourse Team
 bindir: bin
 cert_chain: []
-date: 2025-01-06 00:00:00.000000000 Z
+date: 2025-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport