rubocop-discourse 3.16.0 → 3.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4d1f21065c28440ac92a435fe615ba1aa71be866decb87a34569b5035b6ab28
-  data.tar.gz: 40738677dd38eb78850b649f223c5e70f86a487821d28ba66ab8e25fb7fe155c
+  metadata.gz: 537fcf2646cf9fec96730f2ad390cbeaded946953aa3bcf1a629528815ddfc4e
+  data.tar.gz: ce0b6d8651f55a1e9f42aa6df409fe2a65ce1dbeba9477f76688615f6607304f
 SHA512:
-  metadata.gz: 161fab4a916b845fe201a36a7b5cdc6d329a25f4069bdaab7a62a9c0dcd9ed36e0ef3984698de67edf1aac6043351b2201a43550470fff3c86b3e531e132ab0e
-  data.tar.gz: 4a474ac36e50368a4a62fc6e1dba557f2294c9f498a53b28b589eed150a7abc2917a60ba71943d5821c32148876a309f3e4b3ca6eeee1dab9b40fa44d18c45f8
+  metadata.gz: 8bbc6c84d341cf7d1809bbcdbe6c8ee6ca095912e46031a159453695a828486d6339059e59558bf4978a9ce8762bcba3a422ce71508b4c6ca1f68c778fad2fdb
+  data.tar.gz: ca67fb3089276d717be47d2f6dbfa6092192dc68165764822d3f8e8a6598144dfeaab653fdf4cb923b3a96111e88be56bfba3cbb73d2596207dc1e1eddbf331c

data/config/default.yml

@@ -94,3 +94,6 @@ Discourse/Services/GroupKeywords:
 
 Discourse/Services/EmptyLinesAroundBlocks:
   Enabled: true
+
+Discourse/Services/MutableAttributeDefault:
+  Enabled: true

data/lib/rubocop/cop/discourse/services/mutable_attribute_default.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Discourse
+      module Services
+        # Wrap mutable `attribute` defaults in a proc — `ActiveModel::Attributes`
+        # shares the literal across instances, so mutations leak between calls.
+        # `:array`-typed attributes are exempt; the type dups on read.
+        #
+        # @example
+        #   # bad
+        #   options do
+        #   attribute :overrides, default: {}
+        #     attribute :ids, default: [1, 2]
+        #   end
+        #
+        #   # good
+        #   options do
+        #   attribute :overrides, default: -> { {} }
+        #     attribute :ids, default: -> { [1, 2] }
+        #     attribute :tags, :array, default: [] # :array dups per read
+        #   end
+        #
+        class MutableAttributeDefault < Base
+          extend AutoCorrector
+
+          MSG =
+            "Mutable `default: %<source>s` is shared across all instances; wrap it in a proc: `-> { %<source>s }`."
+          RESTRICT_ON_SEND = %i[attribute].freeze
+
+          def_node_matcher :service_include?, <<~MATCHER
+            (class _ _
+             {
+               (begin <(send nil? :include (const (const nil? :Service) :Base)) ...>)
+               <(send nil? :include (const (const nil? :Service) :Base)) ...>
+             }
+            )
+          MATCHER
+
+          def_node_matcher :mutable_default, <<~PATTERN
+            (send nil? :attribute _ ... (hash <(pair (sym :default) ${hash array}) ...>))
+          PATTERN
+
+          def_node_matcher :array_typed?, <<~PATTERN
+            (send nil? :attribute _ (sym :array) ...)
+          PATTERN
+
+          def on_class(node)
+            @service = true if service_include?(node)
+          end
+
+          def on_send(node)
+            return unless @service
+            return if array_typed?(node)
+            default = mutable_default(node)
+            return unless default
+
+            source = default.source
+            add_offense(default, message: format(MSG, source: source)) do |corrector|
+              corrector.replace(default, "-> { #{source} }")
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/discourse/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Discourse
-    VERSION = "3.16.0"
+    VERSION = "3.18.0"
   end
 end

data/rubocop-capybara.yml

@@ -1,5 +1,5 @@
 plugins:
   - rubocop-capybara
 
-Capybara/CurrentPathExpectation:
+Capybara/RSpec/CurrentPathExpectation:
   Enabled: true

data/rubocop-discourse.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "rubocop-discourse-base", ">= 1.0.0"
   s.add_runtime_dependency "rubocop-rspec", ">= 3.0.1"
   s.add_runtime_dependency "rubocop-factory_bot", ">= 2.27.0"
-  s.add_runtime_dependency "rubocop-capybara", ">= 2.22.0"
+  s.add_runtime_dependency "rubocop-capybara", ">= 2.23.0"
   s.add_runtime_dependency "rubocop-rails", ">= 2.30.3"
   s.add_runtime_dependency "rubocop-rspec_rails", ">= 2.31.0"
   s.add_runtime_dependency "lint_roller", ">= 1.1.0"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-discourse
 version: !ruby/object:Gem::Version
-  version: 3.16.0
+  version: 3.18.0
 platform: ruby
 authors:
 - Discourse Team
@@ -71,14 +71,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.22.0
+        version: 2.23.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.22.0
+        version: 2.23.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -179,6 +179,7 @@ files:
 - lib/rubocop/cop/discourse/plugins/use_require_relative.rb
 - lib/rubocop/cop/discourse/services/empty_lines_around_blocks.rb
 - lib/rubocop/cop/discourse/services/group_keywords.rb
+- lib/rubocop/cop/discourse/services/mutable_attribute_default.rb
 - lib/rubocop/cop/discourse/time_eq_matcher.rb
 - lib/rubocop/cop/discourse_cops.rb
 - lib/rubocop/discourse/plugin.rb