rubocop-discourse 2.0.1 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8e9b0623d47b96bbaa5a7e78f2da4e889d03bbce2f16e2ab90e9ce61530a69f9
-  data.tar.gz: c3385aefb750fa0a379599f2ddce69a66d03186b1e0c21e1552f0c94e9347a96
+  metadata.gz: 954b3ae3f59036a9880d2d055c37e97e5bbc0d454207638cc390efb41cfde649
+  data.tar.gz: 7b5607256ae2d3190a9d7d1ef7d95f73deb23964139a8a10c3fb628663912d96
 SHA512:
-  metadata.gz: 495b86ba2534d8d9b725628337eb70d0c96a2927aa6867f99ef59cd5b8c668530baf54637fe49f0fb08ba0b5c6b648cd2ce74a1b962af811f50d92cdb4bc6c31
-  data.tar.gz: b37411ba21ac5c4fcf1e5586f8a5c2419c251e74937499fafe68b8ecb06b75bc881582f813ac8af8f0b8c77675c0e750b001fc75e004607f460f646399b924be
+  metadata.gz: 4916ff3fcd7569705f59ced1716acbbeec52d763eff392e6eb148d5bc72d4fe6cff5644a0dfedc89353b4f856d77e609159d178b2b2d9643f904bed88d59cb4a
+  data.tar.gz: 8c1a20229b96ef6b69085147c95c5b799c6f7c9b0d38e8dc63c5cb5dc07931a332c231771f45fe656bd03c563fd3fa85f8f1c2bf79d9d64ad96415ce6ce764e3

data/.github/workflows/ci.yml

@@ -29,6 +29,9 @@ jobs:
 
       - name: Rubocop
         run: bundle exec rubocop
+      
+      - name: Rspec
+        run: bundle exec rspec spec
 
   publish:
     if: contains(github.ref, 'refs/tags/v')

data/.gitignore

@@ -1,2 +1,3 @@
 .rubocop-http*
 Gemfile.lock
+.byebug_history

data/.rubocop.yml

@@ -1,4 +1,2 @@
-inherit_from: https://raw.githubusercontent.com/discourse/discourse/master/.rubocop.yml
-
-Discourse:
-  Enabled: true
+inherit_from:
+  - default.yml

data/Gemfile

@@ -4,3 +4,7 @@ source "https://rubygems.org"
 
 # Specify dependencies in gemspec
 gemspec
+
+group :development, :test do
+  gem 'byebug'
+end

data/README.md

@@ -0,0 +1,11 @@
+# rubocop-discourse
+
+## Usage
+
+Add `gem "rubocop-discourse"` to your Gemfile.
+Then add the following to `.rubocop.yml`:
+
+```yml
+inherit_gem:
+  rubocop-discourse: default.yml
+```

data/config/default.yml

@@ -1,14 +1,52 @@
 Discourse/NoChdir:
   Enabled: true
+  Exclude:
+    - 'spec/**/*' # Specs are run sequentially, so chdir can be used
+    - 'plugins/*/spec/**/*'
 
-Discourse/NoDirectMultisiteManipulation:
+Discourse/NoTimeNewWithoutArgs:
   Enabled: true
 
-Discourse/NoTimeNewWithoutArgs:
+Discourse/NoURIEscapeEncode:
   Enabled: true
 
-Discourse/NoUriEscapeEncode:
+Discourse/NoAddReferenceOrAliasesActiveRecordMigration:
   Enabled: true
+  Include:
+  - "**/db/migrate/*"
+  - "**/db/post_migrate/*"
+
+Discourse/NoNokogiriHtmlFragment:
+  Enabled: true
+
+Discourse/NoResetColumnInformationInMigrations:
+  Enabled: false
+  Include:
+  - "**/db/migrate/*"
+  - "**/db/post_migrate/*"
+
+# Specs
+
+Discourse/NoDirectMultisiteManipulation:
+  Enabled: true
+  Patterns:
+  - _spec.rb
+  - "(?:^|/)spec/"
 
 Discourse/TimeEqMatcher:
   Enabled: true
+  Patterns:
+  - _spec.rb
+  - "(?:^|/)spec/"
+
+Discourse/NoJsonParseResponse:
+  Enabled: false
+  Patterns:
+  - _spec.rb
+  - "(?:^|/)spec/"
+
+Discourse/NoMockingJobs:
+  Enabled: true
+  Patterns:
+  - _spec.rb
+  - "(?:^|/)spec/"

data/default.yml

@@ -0,0 +1,20 @@
+require:
+  - rubocop-discourse
+
+inherit_from:
+  - ./rubocop-core.yml
+  - ./rubocop-rspec.yml
+
+AllCops:
+  TargetRubyVersion: 2.6
+  DisabledByDefault: true
+  Exclude:
+    - "db/schema.rb"
+    - "bundle/**/*"
+    - "vendor/**/*"
+    - "**/node_modules/**/*"
+    - "public/**/*"
+    - "plugins/**/gems/**/*"
+
+Discourse:
+  Enabled: true

data/lib/rubocop/cop/discourse/no_add_reference_active_record_migrations.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Discourse
+      # The methods:
+      #
+      # * add_reference
+      # * add_belongs_to
+      # * t.references
+      # * t.belongs_to
+      #
+      # in ActiveRecord migrations are magic, and they all do
+      # some unexpected things in the background. For example, by default
+      # add_reference adds an index at the same time, but not concurrently,
+      # which is a nightmare for large tables.
+      #
+      # Instead, inside a disable_ddl_transaction! migration we should create
+      # the new column (with any defaults and options required) and the index
+      # concurrently using hand-written SQL. This also allows us to handle
+      # IF NOT EXISTS cases, which enable re-runnable migrations. Also we
+      # can pick a better name for the index at the same time.
+      #
+      # @example
+      #
+      # # bad
+      # def up
+      #   add_reference :posts, :image_upload
+      #   # or add_belongs_to :posts, :image_upload
+      #   # or t.references :image_upload when doing create_table do |t|
+      #   # or t.belongs_to :image_upload when doing create_table do |t|
+      # end
+      #
+      # # good
+      # disable_ddl_transaction!
+      # def up
+      #   execute <<~SQL
+      #     ALTER TABLE posts
+      #     ADD COLUMN IF NOT EXISTS image_upload_id bigint
+      #   SQL
+      #
+      #   execute <<~SQL
+      #     CREATE INDEX CONCURRENTLY IF NOT EXISTS
+      #     index_posts_on_image_upload_id ON posts USING btree (image_upload_id)
+      #   SQL
+      # end
+      class NoAddReferenceOrAliasesActiveRecordMigration < Cop
+        MSG = <<~MSG
+          AR methods add_reference, add_belongs_to, t.references, and t.belongs_to are
+          high-risk for large tables and have too many background magic operations.
+          Instead, write a disable_ddl_transactions! migration and write custom SQL to
+          add the new column and CREATE INDEX CONCURRENTLY. Use the IF NOT EXISTS clause
+          to make the migration re-runnable if it fails partway through.
+        MSG
+
+        def_node_matcher :using_add_reference?, <<-MATCHER
+          (send nil? :add_reference ...)
+        MATCHER
+
+        def_node_matcher :using_add_belongs_to?, <<-MATCHER
+          (send nil? :add_belongs_to ...)
+        MATCHER
+
+        def_node_matcher :using_t_references?, <<-MATCHER
+          (send (lvar _) :references ...)
+        MATCHER
+
+        def_node_matcher :using_t_belongs_to?, <<-MATCHER
+          (send (lvar _) :belongs_to ...)
+        MATCHER
+
+        def on_send(node)
+          return if [
+            using_add_reference?(node),
+            using_add_belongs_to?(node),
+            using_t_references?(node),
+            using_t_belongs_to?(node)
+          ].none?
+          add_offense(node, message: MSG)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/discourse/no_json_parse_response.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Discourse
+      # Use `response.parsed_body` instead of `JSON.parse(response.body)` in specs.
+      #
+      # @example
+      #   # bad
+      #   expect(::JSON.parse(response.body)).to eq({})
+      #
+      #   # good
+      #   expect(response.parsed_body).to eq({})
+      class NoJsonParseResponse < Cop
+        MSG = "Use `response.parsed_body` instead of `JSON.parse(response.body)` in specs."
+
+        def_node_matcher :json_parse_body?, <<-MATCHER
+          (send
+            (const {cbase nil?} :JSON) :parse
+            (send
+              (send nil? :response) :body))
+        MATCHER
+
+        def on_send(node)
+          return unless json_parse_body?(node)
+
+          add_offense(node, message: MSG)
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.loc.expression, "response.parsed_body")
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/discourse/no_mocking_jobs.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Discourse
+      class NoMockingJobs < Cop
+        MSG = "Use the test helpers provided by Sidekiq instead of mocking `Jobs`."
+
+        def_node_matcher :mocking_jobs?, <<~MATCHER
+        (send (const nil? :Jobs) :expects ...)
+        MATCHER
+
+        def on_send(node)
+          return unless mocking_jobs?(node)
+          add_offense(node, message: MSG)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/discourse/no_nokogiri_html_fragment.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Discourse
+      # Do not use Nokogiri::HTML.fragment
+      # Instead use Nokogiri::HTML5.fragment, which is using Nokogumbo parser
+      #
+      # @example
+      #   # bad
+      #   Nokogiri::HTML.fragment("<p>test</p>")
+      #
+      #   # good
+      #   Nokogiri::HTML5.fragment("<p>test</p>")
+      class NoNokogiriHtmlFragment < Cop
+        MSG = "Nokogiri::HTML.fragment is deprecated and should not be used."
+
+        def_node_matcher :using_nokogiri_html_fragment?, <<-MATCHER
+          (send
+            (const
+              (const nil? :Nokogiri) :HTML) :fragment ...)
+        MATCHER
+
+        def on_send(node)
+          return if !using_nokogiri_html_fragment?(node)
+          add_offense(node, message: MSG)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/discourse/no_reset_column_information_in_migrations.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Discourse
+      # Do not use `ActiveRecord::ModelSchema.reset_column_information` in
+      # migrations. The method is not thread safe and we run migrations
+      # concurrently for multisites. Also, we don't encourage the use of
+      # ActiveRecord methods in migrations and prefer to write SQL directly.
+      class NoResetColumnInformationInMigrations < Cop
+        MSG = "ActiveRecord::ModelSchema.reset_column_information is not thread-safe " \
+          "and we run migrations concurrently on multisite clusters. Using this " \
+          "method also means ActiveRecord methods are being used in migration "\
+          "which is discouraged at Discourse. Instead, you should write SQL in your migrations instead."
+
+        def on_send(node)
+          return if node.method_name != :reset_column_information
+          add_offense(node, message: MSG)
+        end
+      end
+    end
+  end
+end

data/rubocop-core.yml

@@ -0,0 +1,123 @@
+# Prefer &&/|| over and/or.
+Style/AndOr:
+  Enabled: true
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+Style/SingleLineMethods:
+  Enabled: true
+
+Style/Semicolon:
+  Enabled: true
+  AllowAsExpressionSeparator: true
+
+Style/RedundantReturn:
+  Enabled: true
+
+Style/GlobalVars:
+  Enabled: true
+  Severity: warning
+  Exclude:
+    - 'lib/tasks/**/*'
+    - 'script/**/*'
+    - 'spec/**/*.rb'
+    - 'plugins/*/spec/**/*'
+
+# Align `when` with `case`.
+Layout/CaseIndentation:
+  Enabled: true
+
+# Align comments with method definitions.
+Layout/CommentIndentation:
+  Enabled: true
+
+# No extra empty lines.
+Layout/EmptyLines:
+  Enabled: true
+
+# Two spaces, no tabs (for indentation).
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+  Enabled: true
+
+# Use `foo {}` not `foo{}`.
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+# Use `{ a: 1 }` not `{a:1}`.
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+# Detect hard tabs, no hard tabs.
+Layout/IndentationStyle:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Layout/TrailingEmptyLines:
+  Enabled: true
+
+# No trailing whitespace.
+Layout/TrailingWhitespace:
+  Enabled: true
+
+Layout/BlockAlignment:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Layout/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+  EnforcedStyle: indented
+
+Layout/HashAlignment:
+  Enabled: true
+
+Lint/Debugger:
+  Enabled: true
+
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true
+
+Lint/ShadowingOuterLocalVariable:
+  Enabled: true
+
+Bundler/OrderedGems:
+  Enabled: false

data/rubocop-discourse.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = "rubocop-discourse"
-  s.version     = "2.0.1"
+  s.version     = "2.3.0"
   s.summary     = "Custom rubocop cops used by Discourse"
   s.authors     = ["David Taylor"]
   s.files       = `git ls-files`.split($/)
@@ -10,6 +10,8 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_runtime_dependency "rubocop", ">= 0.69.0"
+  s.add_runtime_dependency "rubocop-rspec", ">= 1.39.0"
 
   s.add_development_dependency "rake", "~> 13.0"
+  s.add_development_dependency "rspec"
 end

data/rubocop-rspec.yml

@@ -0,0 +1,211 @@
+require:
+  - rubocop-rspec
+
+RSpec/AnyInstance:
+  Enabled: false # To be decided
+
+RSpec/AroundBlock:
+  Enabled: true
+
+RSpec/BeforeAfterAll:
+  Enabled: false # To be decided
+
+RSpec/ContextMethod:
+  Enabled: false # TODO
+
+RSpec/ContextWording:
+  Enabled: false # To be decided
+
+RSpec/DescribeClass:
+  Enabled: false # To be decided
+
+RSpec/DescribeMethod:
+  Enabled: true
+
+RSpec/DescribeSymbol:
+  Enabled: false # To be decided
+
+RSpec/DescribedClass:
+  Enabled: false # To be decided
+
+RSpec/DescribedClassModuleWrapping:
+  Enabled: false # To be decided
+
+RSpec/EmptyExampleGroup:
+  Enabled: true
+  Exclude:
+    - 'spec/requests/api/*'
+
+RSpec/EmptyLineAfterExample:
+  Enabled: false # TODO
+
+RSpec/EmptyLineAfterExampleGroup:
+  Enabled: false # TODO
+
+RSpec/EmptyLineAfterFinalLet:
+  Enabled: false # TODO
+
+RSpec/EmptyLineAfterHook:
+  Enabled: false # TODO
+
+RSpec/EmptyLineAfterSubject:
+  Enabled: false # TODO
+
+RSpec/ExampleLength:
+  Enabled: false # To be decided
+
+RSpec/ExampleWithoutDescription:
+  Enabled: true
+
+RSpec/ExampleWording:
+  Enabled: false # TODO
+
+RSpec/ExpectActual:
+  Enabled: true
+
+RSpec/ExpectChange:
+  Enabled: false # To be decided
+
+RSpec/ExpectInHook:
+  Enabled: false # To be decided
+
+RSpec/ExpectOutput:
+  Enabled: true
+
+RSpec/FilePath:
+  Enabled: false # To be decided
+
+RSpec/Focus:
+  Enabled: true
+
+RSpec/HookArgument:
+  Enabled: false # TODO
+
+RSpec/HooksBeforeExamples:
+  Enabled: false # TODO
+
+RSpec/ImplicitBlockExpectation:
+  Enabled: true
+
+RSpec/ImplicitExpect:
+  Enabled: false # To be decided
+
+RSpec/ImplicitSubject:
+  Enabled: false # To be decided
+
+RSpec/InstanceSpy:
+  Enabled: true
+
+RSpec/InstanceVariable:
+  Enabled: false # TODO
+
+RSpec/InvalidPredicateMatcher:
+  Enabled: true
+
+RSpec/ItBehavesLike:
+  Enabled: true
+
+RSpec/IteratedExpectation:
+  Enabled: false # To be decided
+
+RSpec/LeadingSubject:
+  Enabled: false # TODO
+
+RSpec/LeakyConstantDeclaration:
+  Enabled: false # To be decided
+
+RSpec/LetBeforeExamples:
+  Enabled: false # TODO
+
+RSpec/LetSetup:
+  Enabled: false # TODO
+
+RSpec/MessageChain:
+  Enabled: true
+
+RSpec/MessageSpies:
+  Enabled: true
+
+RSpec/MissingExampleGroupArgument:
+  Enabled: true
+
+RSpec/MultipleDescribes:
+  Enabled: false # TODO
+
+RSpec/MultipleSubjects:
+  Enabled: true
+
+RSpec/NamedSubject:
+  Enabled: false # To be decided
+
+RSpec/NestedGroups:
+  Enabled: false # To be decided
+
+RSpec/OverwritingSetup:
+  Enabled: true
+
+RSpec/ReceiveCounts:
+  Enabled: true
+
+RSpec/ReceiveNever:
+  Enabled: true
+
+RSpec/RepeatedDescription:
+  Enabled: false # TODO
+
+RSpec/RepeatedExample:
+  Enabled: false # TODO
+
+RSpec/RepeatedExampleGroupBody:
+  Enabled: false # TODO
+
+RSpec/RepeatedExampleGroupDescription:
+  Enabled: false # TODO
+
+RSpec/ReturnFromStub:
+  Enabled: true
+
+RSpec/ScatteredSetup:
+  Enabled: false # TODO
+
+RSpec/SharedContext:
+  Enabled: true
+
+RSpec/SharedExamples:
+  Enabled: true
+
+RSpec/SingleArgumentMessageChain:
+  Enabled: true
+
+RSpec/SubjectStub:
+  Enabled: true
+
+RSpec/UnspecifiedException:
+  Enabled: true
+
+RSpec/VerifiedDoubles:
+  Enabled: true
+
+RSpec/VoidExpect:
+  Enabled: true
+
+RSpec/Yield:
+  Enabled: true
+
+Capybara/CurrentPathExpectation:
+  Enabled: true
+
+Capybara/FeatureMethods:
+  Enabled: true
+
+FactoryBot/AttributeDefinedStatically:
+  Enabled: true
+
+FactoryBot/CreateList:
+  Enabled: true
+
+FactoryBot/FactoryClassName:
+  Enabled: true
+
+Rails/HttpStatus:
+  Enabled: true

data/spec/lib/rubocop/cop/no_add_reference_active_record_migrations_spec.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe RuboCop::Cop::Discourse::NoAddReferenceOrAliasesActiveRecordMigration, :config do
+  subject(:cop) { described_class.new(config) }
+  let(:config) do
+    RuboCop::Config.new
+  end
+
+  it "raises an offense if add_reference is used, with or without arguments" do
+    inspect_source(<<~RUBY)
+      add_reference :posts, :users, foreign_key: true, null: false
+    RUBY
+    expect(cop.offenses.first.message).to eq(described_class::MSG)
+  end
+
+  it "raises an offense if add_belongs_to is used, with or without arguments" do
+    inspect_source(<<~RUBY)
+      add_belongs_to :posts, :users, foreign_key: true, null: false
+    RUBY
+    expect(cop.offenses.first.message).to eq(described_class::MSG)
+  end
+
+  it "raises an offense if t.references, or any variable.references is used, with or without arguments" do
+    inspect_source(<<~RUBY)
+      create_table do |t|
+        t.references :topic, null: false
+      end
+      create_table do |mytable|
+        mytable.references :topic, null: false
+      end
+    RUBY
+    expect(cop.offenses.count).to eq(2)
+    expect(cop.offenses.first.message).to eq(described_class::MSG)
+  end
+
+  it "raises an offense if t.belongs_to, or any variable.belongs_to is used, with or without arguments" do
+    inspect_source(<<~RUBY)
+      create_table do |t|
+        t.belongs_to :topic, null: false
+      end
+      create_table do |mytable|
+        mytable.belongs_to :topic, null: false
+      end
+    RUBY
+    expect(cop.offenses.count).to eq(2)
+    expect(cop.offenses.first.message).to eq(described_class::MSG)
+  end
+end

data/spec/lib/rubocop/cop/no_mocking_jobs_spec.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe RuboCop::Cop::Discourse::NoMockingJobs, :config do
+  subject(:cop) { described_class.new(config) }
+
+  let(:config) do
+    RuboCop::Config.new
+  end
+
+  it "raises an offense if Jobs is mocked" do
+    inspect_source(<<~RUBY)
+    Jobs.expects(:enqueue)
+    RUBY
+
+    expect(cop.offenses.first.message).to eq(described_class::MSG)
+  end
+
+  it "does not raise an offense if Jobs is not mocked" do
+    inspect_source(<<~RUBY)
+    Jobs.enqueue(:some_job)
+    RUBY
+
+    expect(cop.offenses).to eq([])
+  end
+end

data/spec/lib/rubocop/cop/no_reset_column_information_migrations_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe RuboCop::Cop::Discourse::NoResetColumnInformationInMigrations, :config do
+  subject(:cop) { described_class.new(config) }
+
+  let(:config) do
+    RuboCop::Config.new
+  end
+
+  it "raises an offense if reset_column_information is used" do
+    inspect_source(<<~RUBY)
+      class SomeMigration < ActiveRecord::Migration[6.0]
+        def up
+          Post.reset_column_information
+        end
+      end
+    RUBY
+
+    expect(cop.offenses.first.message).to eq(described_class::MSG)
+  end
+
+  it "raise an offense if reset_column_information is used without AR model" do
+    inspect_source(<<~RUBY)
+      class SomeMigration < ActiveRecord::Migration[6.0]
+        def up
+          "post".classify.constantize.reset_column_information
+        end
+      end
+    RUBY
+
+    expect(cop.offenses.first.message).to eq(described_class::MSG)
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'bundler/setup'
+Bundler.setup
+
+# Require supporting files exposed for testing.
+require 'rubocop'
+require 'rubocop/rspec/support'
+
+require 'rubocop-discourse' # and any other gems you need
+
+RSpec.configure do |config|
+  config.include RuboCop::RSpec::ExpectOffense
+  # some (optional) config here
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-discourse
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.3.0
 platform: ruby
 authors:
 - David Taylor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-24 00:00:00.000000000 Z
+date: 2020-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.69.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.39.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.39.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email: 
 executables: []
@@ -49,18 +77,31 @@ files:
 - ".rubocop.yml"
 - Gemfile
 - LICENSE
+- README.md
 - Rakefile
 - config/default.yml
+- default.yml
 - lib/rubocop-discourse.rb
+- lib/rubocop/cop/discourse/no_add_reference_active_record_migrations.rb
 - lib/rubocop/cop/discourse/no_chdir.rb
 - lib/rubocop/cop/discourse/no_direct_multisite_manipulation.rb
+- lib/rubocop/cop/discourse/no_json_parse_response.rb
+- lib/rubocop/cop/discourse/no_mocking_jobs.rb
+- lib/rubocop/cop/discourse/no_nokogiri_html_fragment.rb
+- lib/rubocop/cop/discourse/no_reset_column_information_in_migrations.rb
 - lib/rubocop/cop/discourse/no_time_new_without_args.rb
 - lib/rubocop/cop/discourse/no_uri_escape_encode.rb
 - lib/rubocop/cop/discourse/time_eq_matcher.rb
 - lib/rubocop/cop/discourse_cops.rb
 - lib/rubocop/discourse.rb
 - lib/rubocop/discourse/inject.rb
+- rubocop-core.yml
 - rubocop-discourse.gemspec
+- rubocop-rspec.yml
+- spec/lib/rubocop/cop/no_add_reference_active_record_migrations_spec.rb
+- spec/lib/rubocop/cop/no_mocking_jobs_spec.rb
+- spec/lib/rubocop/cop/no_reset_column_information_migrations_spec.rb
+- spec/spec_helper.rb
 homepage: 
 licenses:
 - MIT