rubocop-discourse 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c437e92050986771e72b6e93ae779c667a4d4522aa4b8e0d5be0395d99aeae0
-  data.tar.gz: ae8d57c8f0d17e1d154e18c46d4bb9a5cd687e0494b3b2022870f7f3ad030d2f
+  metadata.gz: ce133465e4ca5d05edcf743e5e38d4ad089c385db83920b53e2d517bee97e837
+  data.tar.gz: ead5716e3ad77ae268eb91424ff663ed6f060f59fbcf9ca08925d3925e091b9a
 SHA512:
-  metadata.gz: feae39850faf8928b55508ed478fa80e600dfe18ba513f2a4f708615645ab310e94dfb6708804da8fbf7131778790126d37550971a1b5b612c84679954182634
-  data.tar.gz: ca59eb41ee3193287eecc3e58c23f0d53ba3499f73784ecc638afa6623045b487a1a599918fab361e23a10ea96d53b79a92a85c39ef440a1d55dde064ff99cf4
+  metadata.gz: f4ea1ecd294f15ea3972f5b9aa385a74be53fe8f1dc146dd335e4487a4075e81ba26a9db64c5ffe3162a28600bfde330d52981c456fb1945e9956c56738e7fbb
+  data.tar.gz: 45c3e852541f4cd2eed5b7d7e32b3cdeac7984eebdd636aa3d9349e4cdbac7d394f0444118f3df00d060ed09a61cb4f7085444c9ed67e2a6e2da2936583fd451

data/lib/rubocop/cop/discourse_cops.rb

@@ -29,6 +29,48 @@ module RuboCop
           add_offense(node, message: MSG)
         end
       end
+
+      # Do not use URI.escape and its ilk, they are deprecated
+      # with a warning in the ruby source. Instead use
+      # Addressable::URI, which has encode, encode_component,
+      # and unencode methods. UrlHelper has helper methods for this.
+      #
+      # # @example
+      #   # bad
+      #   URI.encode("https://a%20a.com?a='a%22")
+      #
+      #   # good
+      #   UrlHelper.encode("https://a%20a.com?a='a%22")
+      #   Addressable::URI.encode("https://a%20a.com?a='a%22")
+      class NoURIEscapeEncode < Cop
+        MSG = 'URI.escape, URI.encode, URI.unescape, URI.decode are deprecated and should not be used.'
+
+        def_node_matcher :using_uri_escape?, <<-MATCHER
+          (send (const nil? :URI) :escape ...)
+        MATCHER
+
+        def_node_matcher :using_uri_encode?, <<-MATCHER
+          (send (const nil? :URI) :encode ...)
+        MATCHER
+
+        def_node_matcher :using_uri_unescape?, <<-MATCHER
+          (send (const nil? :URI) :unescape ...)
+        MATCHER
+
+        def_node_matcher :using_uri_decode?, <<-MATCHER
+          (send (const nil? :URI) :decode ...)
+        MATCHER
+
+        def on_send(node)
+          return if [
+            using_uri_escape?(node),
+            using_uri_encode?(node),
+            using_uri_unescape?(node),
+            using_uri_decode?(node)
+          ].none?
+          add_offense(node, message: MSG)
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-discourse
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - David Taylor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-18 00:00:00.000000000 Z
+date: 2019-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -51,7 +51,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Custom rubocop cops used by Discourse