rubocop-disable_syntax 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2043bf5a5a0901cb7335082d5536484f634272a0a3f9cc6d8146e75b2663a0ab
-  data.tar.gz: 9a87b08496dc0cd0b42c6ee5a373cc9b6d5f42166148f15f7f26939f3b8d1259
+  metadata.gz: 03637f71e53c2813b2ce98e8b9d6e36269d1775d0d9a44991bdd70556e1daff4
+  data.tar.gz: 6a3a1a2a71e67a870f3606805a4883176ff81f18662c0e969fdd1139594d4649
 SHA512:
-  metadata.gz: 7501434582cfcae34bb8c03ea062cefa44201d3c51cd308a7ea1f33de68ef4d3410dde6c82221bcbee1867c0460b4edacd6ba12d8381c2ede6ba93b56255bbbf
-  data.tar.gz: 5ac9ed8490f18910f3b27a9157a143b2e7751dde4a81e921ec126567f5984d74d37a00c153f2f5811b593c99e24b8285e58c9b6f8f6fb09fc287d72e139f23fb
+  metadata.gz: c6a3347551862531a90513a0f646747a392d0d1ea65d317e09936a81b2a515cc31286e06953b8272a4fae03ae5e21b61f74a97e02c503059e503732e810e51d4
+  data.tar.gz: ca3e4065ac8ae77aad96a59f8f224a04ac7e960f1d09c122e8aba62ce8849aef16d9be1982947d501acfcba49f8da80d0d984e3c0f37cec619570c9bd3984af6

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 ## master (unreleased)
 
+## 0.2.0 (2025-03-23)
+
+- Drop support for ruby < 3.2
+- Pluginify the gem (drop support for rubocop < 1.72)
+
+## 0.1.1 (2023-10-13)
+
+- Mark cop as unsafe to autocorrect
+
 ## 0.1.0 (2023-09-26)
 
 - First release

data/README.md

@@ -6,8 +6,8 @@
 
 ## Requirements
 
-- ruby 2.7+
-- rubocop 1.50+
+- ruby 3.2+
+- rubocop 1.72+
 
 ## Installation
 
@@ -30,10 +30,12 @@ You need to tell RuboCop to load the `rubocop-disable_syntax` extension.
 Put this into your `.rubocop.yml`.
 
 ```yaml
-require:
+plugins:
   - rubocop-disable_syntax
 ```
 
+**Note**: The plugin system is supported in RuboCop 1.72+. In earlier versions, use `require` instead of `plugins`.
+
 All the ruby syntax features are enabled by default and so this gem acts as a no-op. You need to manually configure
 which ruby features you want to disable:
 

data/config/default.yml

@@ -1,6 +1,7 @@
 Style/DisableSyntax:
   Description: 'Forbid some unfavorite ruby syntax, such as `unless`, safe navigation etc.'
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.1'
   SupportedDisableSyntax:
     - unless

data/lib/rubocop/cop/style/disable_syntax.rb

@@ -3,6 +3,25 @@
 module RuboCop
   module Cop
     module Style
+      # Forbid some unfavorite ruby syntax, such as `unless`, safe navigation etc.
+      #
+      # @safety
+      #   Autocorrection is unsafe because there is a different operator precedence
+      #   between logical operators (`&&`, `||` and `!`) and semantic operators (`and`, `or` and `not`),
+      #   and that might change the behavior.
+      #
+      # You can set syntax you want to disable via `DisableSyntax`.
+      # Available are: 'unless', 'ternary', 'safe_navigation', 'endless_methods',
+      # 'arguments_forwarding', 'numbered_parameters', 'pattern_matching',
+      # 'shorthand_hash_syntax', 'and_or_not', 'until', and 'percent_literals'.
+      #
+      # @example DisableSyntax: ['unless']
+      #   # bad
+      #   do_something unless condition
+      #
+      #   # good
+      #   do_something if !condition
+      #
       class DisableSyntax < Base
         extend AutoCorrector
 

data/lib/rubocop/disable_syntax/plugin.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require "lint_roller"
+
+module RuboCop
+  module DisableSyntax
+    # A plugin that integrates RuboCop Disable Syntax with RuboCop's plugin system.
+    class Plugin < LintRoller::Plugin
+      def about
+        LintRoller::About.new(
+          name: "rubocop-disable_syntax",
+          version: VERSION,
+          homepage: "https://github.com/fatkodima/rubocop-disable_syntax",
+          description: "A RuboCop plugin that allows to disable some unfavorite ruby syntax, " \
+                       "such as `unless`, safe navigation etc."
+        )
+      end
+
+      def supported?(context)
+        context.engine == :rubocop
+      end
+
+      def rules(_context)
+        LintRoller::Rules.new(
+          type: :path,
+          config_format: :rubocop,
+          value: Pathname.new(__dir__).join("../../../config/default.yml")
+        )
+      end
+    end
+  end
+end

data/lib/rubocop/disable_syntax/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module DisableSyntax
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

data/lib/rubocop/disable_syntax.rb

@@ -4,10 +4,5 @@ require_relative "disable_syntax/version"
 
 module RuboCop
   module DisableSyntax
-    PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
-    CONFIG_DEFAULT = PROJECT_ROOT.join("config", "default.yml").freeze
-    CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
-
-    private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
   end
 end

data/lib/rubocop-disable_syntax.rb

@@ -4,8 +4,5 @@ require "rubocop"
 
 require_relative "rubocop/disable_syntax"
 require_relative "rubocop/disable_syntax/version"
-require_relative "rubocop/disable_syntax/inject"
-
-RuboCop::DisableSyntax::Inject.defaults!
-
+require_relative "rubocop/disable_syntax/plugin"
 require_relative "rubocop/cop/style/disable_syntax"

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-disable_syntax
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - fatkodima
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-26 00:00:00.000000000 Z
+date: 2025-03-23 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: lint_roller
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.50'
+        version: 1.72.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.50'
+        version: 1.72.0
 description:
 email:
 - fatkodima123@gmail.com
@@ -38,7 +52,7 @@ files:
 - lib/rubocop-disable_syntax.rb
 - lib/rubocop/cop/style/disable_syntax.rb
 - lib/rubocop/disable_syntax.rb
-- lib/rubocop/disable_syntax/inject.rb
+- lib/rubocop/disable_syntax/plugin.rb
 - lib/rubocop/disable_syntax/version.rb
 homepage: https://github.com/fatkodima/rubocop-disable_syntax
 licenses:
@@ -47,6 +61,7 @@ metadata:
   homepage_uri: https://github.com/fatkodima/rubocop-disable_syntax
   source_code_uri: https://github.com/fatkodima/rubocop-disable_syntax
   changelog_uri: https://github.com/fatkodima/rubocop-disable_syntax/blob/master/CHANGELOG.md
+  default_lint_roller_plugin: RuboCop::DisableSyntax::Plugin
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -55,14 +70,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.7.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: A RuboCop plugin that allows to disable some unfavorite ruby syntax, such

data/lib/rubocop/disable_syntax/inject.rb

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-
-# The original code is from https://github.com/rubocop/rubocop-rspec/blob/master/lib/rubocop/rspec/inject.rb
-# See https://github.com/rubocop/rubocop-rspec/blob/master/MIT-LICENSE.md
-module RuboCop
-  module DisableSyntax
-    # Because RuboCop doesn't yet support plugins, we have to monkey patch in a
-    # bit of our configuration.
-    module Inject
-      def self.defaults!
-        path = CONFIG_DEFAULT.to_s
-        hash = ConfigLoader.send(:load_yaml_configuration, path)
-        config = Config.new(hash, path).tap(&:make_excludes_absolute)
-        puts "configuration from #{path}" if ConfigLoader.debug?
-        config = ConfigLoader.merge_with_default(config, path)
-        ConfigLoader.instance_variable_set(:@default_configuration, config)
-      end
-    end
-  end
-end