rubocop-dev_doc 0.16.0 → 0.18.0

data/lib/rubocop/cop/dev_doc/style/use_g_log.rb

@@ -0,0 +1,133 @@
+module RuboCop
+  module Cop
+    module DevDoc
+      module Style
+        # Route logging through `GLog` (glib-web) instead of `Rails.logger` or
+        # `Rollbar` directly.
+        #
+        # ## Rationale
+        # `GLog` is the shared logging seam: one place where destination
+        # (remote Rollbar vs local-only), level policy, and future redaction
+        # live. A call site that names its destination (`GLog.local_info` vs
+        # `GLog.error`) keeps that policy changeable; a direct `Rails.logger`
+        # or `Rollbar` call locks the destination in at the call site and
+        # bypasses any redaction added to the facade later.
+        #
+        # ## Rules
+        #
+        # **`Rails.logger.<any method>` is flagged** outside `module GLog`
+        # itself, including `::Rails.logger` and safe navigation
+        # (`Rails.logger&.info`). Local logging belongs behind
+        # `GLog.local_debug/local_info/local_warn/local_error`.
+        #
+        # **`Rollbar.<reporting method>` is flagged** — `error`, `warning`,
+        # `warn`, `info`, `debug`, `critical`, `log`, and the `log_*` family
+        # (`log_info`, `log_debug`, `log_warning`, `log_error`), which the
+        # rollbar gem delegates alongside the level names (`warn` and
+        # `warning` are both defined). A reporting send whose receiver chain
+        # roots at the constant — `Rollbar.scope(user).error(e)`,
+        # `::Rollbar.error(e)` — is flagged too. Remote reporting belongs
+        # behind `GLog.error/warn/info`.
+        #
+        # **`Rollbar.configure`, bare `Rollbar.scope(...)`, and other
+        # non-reporting calls are NOT flagged.** Configuration is setup, not
+        # reporting; matching every method on the constant (the local
+        # `Custom/UseDLog` cop this replaces did exactly that) made
+        # `Rollbar.configure` an offense.
+        #
+        # Calls inside `module GLog` itself are exempt — the facade routes to
+        # `Rails.logger` and `Rollbar` by design.
+        #
+        # **Requires glib-web >= 7.2.0** (GLog). Projects on an older
+        # glib-web disable this cop until they upgrade.
+        #
+        # @example
+        #   # bad — destination locked in at the call site
+        #   Rails.logger.info("something")
+        #   Rollbar.error(exception)
+        #   Rollbar.warn("degraded")
+        #   Rollbar.log_error("message")
+        #   Rollbar.scope(user: u).error(exception)
+        #
+        #   # good — the facade owns destination and level policy
+        #   GLog.local_info("something")
+        #   GLog.error(exception)
+        #   GLog.warn("degraded")
+        #
+        #   # good — configuration is not reporting
+        #   Rollbar.configure do |config|
+        #     config.access_token = token
+        #   end
+        class UseGLog < Base
+          MSG_RAILS_LOGGER = 'Use `GLog.local_*` instead of `Rails.logger` directly. ' \
+                             'GLog is the seam where destination, level policy, and ' \
+                             'redaction live.'.freeze
+
+          MSG_ROLLBAR = 'Use `GLog.error/warn/info` instead of `Rollbar` directly. ' \
+                        'GLog is the seam where destination, level policy, and ' \
+                        'redaction live.'.freeze
+
+          # The rollbar gem's reporting surface: the level names it delegates
+          # (`warn` and `warning` are both defined) plus the `log_*` family.
+          # `configure`, bare `scope`, and other non-reporting calls stay out —
+          # matching every method on the constant would flag configuration.
+          REPORTING_METHODS = %i[
+            error warning warn info debug critical log
+            log_info log_debug log_warning log_error
+          ].freeze
+
+          def on_send(node)
+            return if inside_g_log?(node)
+
+            if rollbar_reporting?(node)
+              add_offense(node, message: MSG_ROLLBAR)
+            elsif rails_logger?(node)
+              add_offense(node, message: MSG_RAILS_LOGGER)
+            end
+          end
+          # `Rails.logger&.info(...)` parses as a csend node.
+          alias on_csend on_send
+
+          private
+
+          # A reporting-named send whose receiver chain roots at the Rollbar
+          # constant: the direct `Rollbar.error(e)`, the cbase-spelled
+          # `::Rollbar.error(e)`, and scoped chains like
+          # `Rollbar.scope(user).error(e)`.
+          def rollbar_reporting?(node)
+            REPORTING_METHODS.include?(node.method_name) && rollbar_rooted?(node.receiver)
+          end
+
+          def rollbar_rooted?(node)
+            case node
+            when RuboCop::AST::ConstNode
+              node.const_name.to_s.sub(/\A::/, '') == 'Rollbar'
+            when RuboCop::AST::SendNode, RuboCop::AST::CsendNode
+              rollbar_rooted?(node.receiver)
+            else
+              false
+            end
+          end
+
+          # `Rails.logger.<method>`, `::Rails.logger.<method>` and the
+          # safe-navigated `Rails.logger&.<method>`.
+          def rails_logger?(node)
+            receiver = node.receiver
+            return false unless receiver.is_a?(RuboCop::AST::SendNode) || receiver.is_a?(RuboCop::AST::CsendNode)
+            return false unless receiver.method_name == :logger
+
+            const = receiver.receiver
+            const.is_a?(RuboCop::AST::ConstNode) && const.const_name.to_s.sub(/\A::/, '') == 'Rails'
+          end
+
+          # The facade itself routes to Rails.logger and Rollbar by design.
+          def inside_g_log?(node)
+            node.each_ancestor(:module).any? do |ancestor|
+              ancestor.children.first&.const_name == 'GLog'
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/dev_doc/test/prefer_find_sole_by.rb

@@ -0,0 +1,146 @@
+module RuboCop
+  module Cop
+    module DevDoc
+      module Test
+        # In test files, a `find_by` / `find_by!` on a bare model class must be
+        # `find_sole_by`, so a lookup that matches more than one row fails
+        # loudly instead of silently picking one.
+        #
+        # ## Rationale
+        # `Post.find_by(title: 'Hello')` returns the FIRST matching row, and
+        # with no `ORDER BY` "first" means whichever row the database returns
+        # first — which can differ between runs, between seeds, and between
+        # machines. When the attribute is not unique across the whole table,
+        # the test binds to a different record on a different day and fails
+        # far from the cause: the wrong fixture's association is `nil`, and the
+        # symptom is something like
+        # `ActionController::UrlGenerationError: ... missing required keys: [:id]`
+        # in a test whose diff never touched routing. The failure reproduces
+        # only under the seed that happened to expose the ordering, so it reads
+        # as a flake.
+        #
+        # Uniqueness is a property of the DATA, not of the attribute name. An
+        # `email` is unique per user but repeats across a tenant-scoped
+        # membership table (one row per organization the person belongs to);
+        # a `slug` looks like a natural key and still repeats per country. The
+        # only way to know is to read the fixture file — and `find_sole_by`
+        # does that check for you on every run: it raises
+        # `ActiveRecord::SoleRecordExceeded` when more than one row matches
+        # (and `RecordNotFound` when none does, like `find_by!`). A test that
+        # assumed uniqueness now asserts it.
+        #
+        # This cop catches the shape that shipped: the bare-class lookup, where
+        # the scope is the whole table. Scoping the lookup through the parent
+        # association is the other remedy, and it silences the cop because the
+        # receiver is no longer a constant — but the assumption only shrinks
+        # from "unique in the table" to "unique within the parent";
+        # `find_sole_by` on the association asserts that too.
+        #
+        # ## Remedy
+        #
+        #   ❌ — silently picks one of several matching rows
+        #   member = Member.find_by(email: 'admin@example.com')
+        #   member = Member.find_by!(email: 'admin@example.com')
+        #
+        #   ✔️ — raises if the match is not exactly one row
+        #   member = Member.find_sole_by(email: 'admin@example.com')
+        #
+        #   ✔️ — scoped through the parent (and still asserted unique within it)
+        #   member = organizations(:acme).members.find_sole_by(email: 'admin@example.com')
+        #
+        #   ✔️ — a fixture accessor is the canonical way to name a known row
+        #   member = members(:acme_admin)
+        #
+        #   ✔️ — a test that expects NO row asserts absence, not a nil return
+        #   assert_not Member.exists?(email: 'gone@example.com')
+        #
+        # ## Autocorrect
+        # `find_by!` → `find_sole_by` is autocorrected: both raise when nothing
+        # matches, and the only behaviour that changes is the ambiguous case,
+        # which now fails instead of passing by luck. A test that starts
+        # failing after the correction is the cop finding the bug — fix the
+        # lookup (scope it or pick a unique attribute), not the assertion.
+        #
+        # `find_by` (no bang) is flagged but NOT autocorrected: it returns `nil`
+        # when nothing matches, and a test may rely on that
+        # (`assert_nil Post.find_by(title: 'deleted')`). Rewrite by hand:
+        # `find_sole_by` where the row is expected to exist, `exists?` where it
+        # is expected not to.
+        #
+        # ## What is NOT flagged
+        # - Lookups by primary key alone — `Post.find_by(id: some_id)` cannot
+        #   match twice, and is the idiom for "nil once deleted".
+        # - Lookups whose receiver is not the bare class — an association, a
+        #   fixture accessor, a scope chain (`Post.published.find_by(...)`), a
+        #   local. Scoping IS the fix this cop pushes toward; the chain case is
+        #   deliberately out of scope until observed. (`self.class.find_by`
+        #   inside a test helper IS the bare class, and is flagged.)
+        # - Anything outside `test/` and `spec/` (`Include` in the config) —
+        #   production code returning the first match is a separate concern.
+        #
+        # NOTE: `find_sole_by` exists from Rails 7.0. On an older consumer the
+        # autocorrect produces a `NoMethodError`; disable the cop there.
+        #
+        # @example
+        #   # bad
+        #   member = Member.find_by(email: 'admin@example.com')
+        #   member = Member.find_by!(email: 'admin@example.com')
+        #
+        #   # good
+        #   member = Member.find_sole_by(email: 'admin@example.com')
+        #   member = organizations(:acme).members.find_sole_by(email: 'admin@example.com')
+        #   member = members(:acme_admin)
+        #
+        #   # good — primary key cannot match twice
+        #   assert_nil Member.find_by(id: removed_id)
+        class PreferFindSoleBy < Base
+          extend AutoCorrector
+
+          MSG_BANG = '`%<receiver>s.find_by!` returns whichever matching row the database yields ' \
+                     'first — if the attribute is not unique across the table the test binds to a ' \
+                     'different record per run. Use `find_sole_by`, which raises when the match ' \
+                     'is not exactly one row.'.freeze
+          MSG_PLAIN = '`%<receiver>s.find_by` returns whichever matching row the database yields ' \
+                      'first — if the attribute is not unique across the table the test binds to ' \
+                      'a different record per run. Use `find_sole_by` (raises unless exactly one ' \
+                      'row matches); if the test expects NO row, assert `exists?` instead.'.freeze
+
+          RESTRICT_ON_SEND = %i[find_by find_by!].freeze
+
+          # The bare class: a constant, or `self.class` inside a test helper.
+          # @!method bare_class?(node)
+          def_node_matcher :bare_class?, <<~PATTERN
+            {const (send self :class)}
+          PATTERN
+
+          # `Post.find_by(id: x)`: the primary key alone cannot match twice.
+          # @!method primary_key_only?(node)
+          def_node_matcher :primary_key_only?, <<~PATTERN
+            ({send csend} _ _ (hash (pair (sym :id) _)))
+          PATTERN
+
+          def on_send(node)
+            return unless node.receiver && bare_class?(node.receiver)
+            return if primary_key_only?(node)
+
+            if node.method?(:find_by!)
+              add_offense(node.loc.selector, message: message_for(node, MSG_BANG)) do |corrector|
+                corrector.replace(node.loc.selector, 'find_sole_by')
+              end
+            else
+              add_offense(node.loc.selector, message: message_for(node, MSG_PLAIN))
+            end
+          end
+          alias on_csend on_send
+
+          private
+
+          def message_for(node, template)
+            receiver = node.receiver.const_type? ? node.receiver.const_name : 'self.class'
+            format(template, receiver: receiver)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/dev_doc/test/test_name_special_characters.rb

@@ -0,0 +1,108 @@
+module RuboCop
+  module Cop
+    module DevDoc
+      module Test
+        # Disallows characters in `test '...'` names that break running that
+        # single test by name. Rails derives the method name from the
+        # description almost verbatim (only whitespace becomes `_`), so every
+        # other character lands in the name a developer or agent must type to
+        # run one test:
+        #
+        #   bin/rails test test/models/user_test.rb -n test_creates_(admin)_user
+        #   bin/rails test test/models/user_test.rb -n /test_creates_[admin]_user/
+        #
+        # ## Rationale
+        # Both spellings of the `-n`/`--name` filter fail on such names, and
+        # every character in the default set has a VERIFIED failure in at
+        # least one of the two forms (checked against a real minitest
+        # single-test run, not reasoned about):
+        #
+        # 1. **Unquoted, the shell mis-parses the filter before the runner
+        #    sees it.** `(`, `)`, `;`, `&`, `|`, `<`, `>`, `'`, `"`, `` ` ``,
+        #    `$`, and `\` are shell grammar: a parenthesised name dies with
+        #    `syntax error near unexpected token '('`; `<`/`>` silently
+        #    redirect and pass the runner an empty filter; `$` expands;
+        #    backtick substitutes. The test is never invoked.
+        # 2. **The `/name/` regex filter matches nothing.** The usual workaround
+        #    for (1) — wrapping the name in slashes — makes the runner treat the
+        #    string as an unanchored regex, so `[admin]` becomes a character
+        #    class, `?`/`*`/`+` become quantifiers, `^`/`$` anchor, `(...)`
+        #    groups. The result is `Nothing ran for filter`, `0 runs, 0
+        #    failures` — output that reads as a pass while zero tests
+        #    executed. Verified zero-run for: `[ ] ( ) * + ^ $ \`.
+        #
+        # The failure hides from review because writing the test and running
+        # the whole file both work; only running the test BY NAME breaks —
+        # which is exactly what an agent iterating on a failure does.
+        #
+        # ## Allowed punctuation — and its caveats
+        # `# . , - : %` break neither form. Also allowed, with a caveat each:
+        #
+        # * `?` and `{ }`: verified runnable in BOTH forms on bash (an
+        #   unanchored regex still matches around them; braces without a
+        #   comma are literal to both bash and regex). On zsh, an unquoted
+        #   `?` aborts with `no matches found` — quote the `-n` argument
+        #   rather than renaming the test.
+        # * `/`: verified runnable in both forms — the `/name/` filter pairs
+        #   the FIRST and LAST slash as delimiters, interior slashes are
+        #   regex-literal content.
+        # * `!`: literal to non-interactive shells and to regex, but
+        #   INTERACTIVE bash/zsh history-expand it (`!_` becomes the previous
+        #   command's last argument, silently running a different filter) —
+        #   quote the argument when running such a test from a terminal.
+        #
+        # ## Exception
+        # Interpolated names (`test "creates #{kind}"`) are not flagged — the
+        # matcher only sees string literals, and interpolated test names are
+        # their own anti-pattern (the method name varies with runtime data).
+        # RSpec `it`/`describe` strings are out of scope: the RSpec runner
+        # takes `-e` as a plain (quoted) exact string, which none of these
+        # characters break.
+        #
+        # NOTE: no stock cop covers this — rubocop-minitest's naming cops check
+        # the `test_` prefix convention, not the name's content. The matcher
+        # recognises implicit-receiver `test` with a string-literal name;
+        # explicit receivers (`self.test`, `helper.test`) and non-literal name
+        # arguments (`test 'name'.freeze`) are out of reach.
+        #
+        # @example
+        #   # bad — shell syntax error unquoted; regex misparse in /name/ form
+        #   test 'creates (admin) user' do
+        #   test 'creates [admin] user' do
+        #   test 'copies a*b of the record' do
+        #
+        #   # good
+        #   test 'creates admin user via dashboard' do
+        #   test 'User#name returns full name' do
+        class TestNameSpecialCharacters < Base
+          MSG = 'Test name contains %<chars>s — these break running the single test by name: unquoted, the ' \
+                'shell mis-parses the `-n` filter; in the `/name/` form, regex-significant ones match nothing ' \
+                '(0 runs). Rename using letters, digits, spaces, and allowed punctuation (see cop docs).'.freeze
+
+          RESTRICT_ON_SEND = %i[test].freeze
+
+          DEFAULT_FORBIDDEN_CHARACTERS = '()[]*+^$\\&;|<>\'"`'.freeze
+
+          def_node_matcher :test_name, <<~PATTERN
+            (send nil? :test $(str $_) ...)
+          PATTERN
+
+          def on_send(node)
+            test_name(node) do |name_node, name|
+              forbidden = forbidden_characters.chars.select { |char| name.include?(char) }
+              next if forbidden.empty?
+
+              add_offense(name_node, message: format(MSG, chars: forbidden.map { |c| "`#{c}`" }.join(' ')))
+            end
+          end
+
+          private
+
+          # `.to_s` so an explicit `ForbiddenCharacters:` with no value (YAML
+          # null) means "nothing forbidden" instead of raising on nil.chars.
+          def forbidden_characters = cop_config.fetch('ForbiddenCharacters', DEFAULT_FORBIDDEN_CHARACTERS).to_s
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/dev_doc/view/prefer_prop_over_name.rb

@@ -36,6 +36,16 @@ module RuboCop
         #   structural array-param key for the group's rows, not a labelled
         #   model attribute — the row template's inner fields are where
         #   `prop:` belongs.
+        # - `fields_file` is exempt by default: the (deprecated) File field's
+        #   `prop:` machinery calls `.attached?` on the bound model value
+        #   (glib-web fields.rb `File#created` / `#determine_value`), so a
+        #   bound prop must be an ActiveStorage attachment. A `fields_file`
+        #   that posts a raw upload the controller parses and discards (CSV
+        #   imports, server-side processing) has no attachment to bind —
+        #   converting it to `prop:` raises at render (`nil.attached?` /
+        #   `field_assert_respond_to`), and the unsafe autocorrect would
+        #   produce exactly that. Attachment-backed uploads belong on
+        #   `fields_upload`, which binds `prop:` fine.
         # ## How to fix — the decision ladder
         # Work down this ladder before even considering a disable. A full
         # convert-or-justify sweep of a mature codebase (27 offenses) ended
@@ -153,7 +163,7 @@ module RuboCop
           end
 
           def exempt_field_methods
-            cop_config.fetch('ExemptFieldMethods', %w[fields_hidden fields_creditCard fields_dynamicGroup])
+            cop_config.fetch('ExemptFieldMethods', %w[fields_hidden fields_creditCard fields_dynamicGroup fields_file])
           end
         end
       end

data/lib/rubocop/dev_doc/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module DevDoc
-    VERSION = "0.16.0".freeze
+    VERSION = "0.18.0".freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-dev_doc
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.18.0
 platform: ruby
 authors:
 - dev-doc contributors
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-08-28 00:00:00.000000000 Z
+date: 2026-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -89,12 +89,15 @@ files:
 - config/default.yml
 - config/obsoletion.yml
 - lib/dev_doc/i18n/pseudo_locale.rb
+- lib/dev_doc/i18n/tasks.rb
+- lib/dev_doc/railtie.rb
 - lib/dev_doc/test/best_practice_lints.rb
 - lib/dev_doc/test/lints/cop_drift_check.rb
 - lib/dev_doc/test/lints/cop_drift_test.rb
 - lib/dev_doc/test/lints/cron_schedule.rb
 - lib/dev_doc/test/lints/cross_tenant_canary_check.rb
 - lib/dev_doc/test/lints/cross_tenant_canary_sweep.rb
+- lib/dev_doc/test/lints/domain_class_base.rb
 - lib/dev_doc/test/lints/duplicate_snapshot.rb
 - lib/dev_doc/test/lints/enqueue_disable_naming.rb
 - lib/dev_doc/test/lints/external_io_boundary.rb
@@ -112,9 +115,10 @@ files:
 - lib/rubocop/cop/dev_doc/auth/unscoped_find_justification.rb
 - lib/rubocop/cop/dev_doc/hash_pair_removal.rb
 - lib/rubocop/cop/dev_doc/i18n/avoid_titleize_humanize.rb
+- lib/rubocop/cop/dev_doc/i18n/hardcoded_text.rb
 - lib/rubocop/cop/dev_doc/i18n/localizable_props.rb
-- lib/rubocop/cop/dev_doc/i18n/report_text.rb
 - lib/rubocop/cop/dev_doc/i18n/require_translation.rb
+- lib/rubocop/cop/dev_doc/i18n/text_shape.rb
 - lib/rubocop/cop/dev_doc/i18n/translation_key_prefix.rb
 - lib/rubocop/cop/dev_doc/migration/amount_column_in_cents.rb
 - lib/rubocop/cop/dev_doc/migration/avoid_boolean_column.rb
@@ -133,6 +137,7 @@ files:
 - lib/rubocop/cop/dev_doc/migration/require_primary_key.rb
 - lib/rubocop/cop/dev_doc/migration/require_reference_foreign_key.rb
 - lib/rubocop/cop/dev_doc/migration/require_timestamps.rb
+- lib/rubocop/cop/dev_doc/rails/application_model_base.rb
 - lib/rubocop/cop/dev_doc/rails/application_record_transaction.rb
 - lib/rubocop/cop/dev_doc/rails/avoid_bypassing_validation.rb
 - lib/rubocop/cop/dev_doc/rails/avoid_lifecycle_method_override.rb
@@ -145,6 +150,8 @@ files:
 - lib/rubocop/cop/dev_doc/rails/no_block_predicate_on_relation.rb
 - lib/rubocop/cop/dev_doc/rails/no_collection_ids_writer_in_controller.rb
 - lib/rubocop/cop/dev_doc/rails/no_deliver_later_in_transaction.rb
+- lib/rubocop/cop/dev_doc/rails/no_errors_add_in_controller.rb
+- lib/rubocop/cop/dev_doc/rails/no_form_param_lookup_in_controller.rb
 - lib/rubocop/cop/dev_doc/rails/no_manual_record_invalid.rb
 - lib/rubocop/cop/dev_doc/rails/no_perform_later_in_model.rb
 - lib/rubocop/cop/dev_doc/rails/no_persistence_in_service.rb
@@ -159,27 +166,33 @@ files:
 - lib/rubocop/cop/dev_doc/style/avoid_options_hash.rb
 - lib/rubocop/cop/dev_doc/style/avoid_symbolizing_boundary_input.rb
 - lib/rubocop/cop/dev_doc/style/case_else_decision.rb
+- lib/rubocop/cop/dev_doc/style/in_memory_association_find.rb
 - lib/rubocop/cop/dev_doc/style/literal_operator_in_condition.rb
 - lib/rubocop/cop/dev_doc/style/literal_or_in_when_clause.rb
 - lib/rubocop/cop/dev_doc/style/minimize_variable_scope.rb
+- lib/rubocop/cop/dev_doc/style/no_silent_rescue.rb
 - lib/rubocop/cop/dev_doc/style/no_unscoped_method_definitions.rb
+- lib/rubocop/cop/dev_doc/style/prefer_allowlist_symbol_param.rb
 - lib/rubocop/cop/dev_doc/style/prefer_public_send.rb
 - lib/rubocop/cop/dev_doc/style/redundant_guard_after_bang.rb
 - lib/rubocop/cop/dev_doc/style/repeated_bracket_read.rb
 - lib/rubocop/cop/dev_doc/style/repeated_safe_navigation_receiver.rb
 - lib/rubocop/cop/dev_doc/style/string_symbol_comparison.rb
 - lib/rubocop/cop/dev_doc/style/tap_block_ignores_value.rb
+- lib/rubocop/cop/dev_doc/style/use_g_log.rb
 - lib/rubocop/cop/dev_doc/test/avoid_glib_travel_freeze.rb
 - lib/rubocop/cop/dev_doc/test/avoid_unit_test.rb
 - lib/rubocop/cop/dev_doc/test/justification_header.rb
 - lib/rubocop/cop/dev_doc/test/no_persistence_in_mailer_previews.rb
 - lib/rubocop/cop/dev_doc/test/no_unit_idioms_in_integration_tests.rb
+- lib/rubocop/cop/dev_doc/test/prefer_find_sole_by.rb
 - lib/rubocop/cop/dev_doc/test/require_glib_integration_base.rb
 - lib/rubocop/cop/dev_doc/test/require_glib_travel.rb
 - lib/rubocop/cop/dev_doc/test/require_glib_travel_block.rb
 - lib/rubocop/cop/dev_doc/test/require_unit_test_justification.rb
 - lib/rubocop/cop/dev_doc/test/response_assert_equal.rb
 - lib/rubocop/cop/dev_doc/test/test_file_placement.rb
+- lib/rubocop/cop/dev_doc/test/test_name_special_characters.rb
 - lib/rubocop/cop/dev_doc/view/prefer_prop_over_name.rb
 - lib/rubocop/dev_doc.rb
 - lib/rubocop/dev_doc/plugin.rb

data/lib/rubocop/cop/dev_doc/i18n/report_text.rb

@@ -1,76 +0,0 @@
-require_relative 'localizable_props'
-
-module RuboCop
-  module Cop
-    module DevDoc
-      module I18n
-        # Report every user-facing text in a glib JSON-UI text prop — both
-        # hardcoded strings and already-localized `t(...)` calls.
-        #
-        # ## Rationale
-        # `DevDoc/I18n/RequireTranslation` flags only *hardcoded* strings; it
-        # stays silent once a value is localized. This cop is the opposite: it
-        # fires on **every** text value, localized or not, so you can sweep a
-        # codebase and collect the full list of user-facing strings (e.g. to
-        # seed a translation catalog or audit coverage).
-        #
-        # It is a tooling aid, not a lint — **disabled by default** and runs at
-        # `info` severity. Run it during a localization pass; it is not meant
-        # for every commit.
-        #
-        # Both the hardcoded form (`view.p text: 'Welcome'`) and the localized
-        # form (`view.p text: t('home.welcome')`) are reported. Blank/whitespace
-        # strings and pure dynamic values (`user.name`) carry no static text and
-        # are skipped.
-        #
-        # The watched method names and localizable keys are configurable via
-        # `WatchedMethods:` and `LocalizableKeys:`.
-        #
-        #   📋 Reported — hardcoded text
-        #   view.p text: 'Welcome'
-        #
-        #   📋 Reported — localized text
-        #   view.p text: t('home.welcome')
-        #
-        # @example
-        #   # info (hardcoded text)
-        #   view.p text: 'Welcome'
-        #
-        #   # info (localized text — still reported)
-        #   view.p text: t('home.welcome')
-        #
-        #   # info (interpolated string)
-        #   view.p text: "Hi #{name}"
-        #
-        #   # ignored (blank — no text)
-        #   view.fields_text label: ''
-        #
-        #   # ignored (pure dynamic — no static text)
-        #   view.p text: user.name
-        class ReportText < Base
-          include LocalizableProps
-
-          MSG = 'Text for `%<key>s:`: review/collect this for localization.'.freeze
-
-          private
-
-          def inspect_localizable(key, value)
-            return unless text?(value)
-
-            add_offense(value, message: format(MSG, key: key))
-          end
-
-          # Any value that carries static user-facing text: a non-blank string
-          # literal, an interpolated string, or a translation call. Blank strings
-          # and pure dynamic values (`user.name`) carry no text and are skipped.
-          def text?(node)
-            return true if node.dstr_type?
-            return !node.value.strip.empty? if node.str_type?
-
-            translation_call?(node)
-          end
-        end
-      end
-    end
-  end
-end