rubocop-dbl 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e9d5d79ad0b510d57586a22a73eea84ef43e57a2ab1656d77fe2aca677992e4
-  data.tar.gz: '090e7abd3959ce8cfef3ba4fa828e16be1cad7a2c67bdb0d6ba1b66f4218592a'
+  metadata.gz: 8558583841f690643ee75e260ac5de01bf09326f20608c4005ec4ed285ef1b23
+  data.tar.gz: 9fb41eca523ec7a0afe85d5c9ecf4b4a95390004dbc7188da76a24a55b5e6344
 SHA512:
-  metadata.gz: 5a6e75c1d37b251cb41c02d0f7b0fdb926ac1d21a0120a0436c5110ac2eac9804707bc923f107effce73602d03734cc79e2bd6f94469899b1632bcbe9d6149d2
-  data.tar.gz: 50ae4306e6f6062fe1b9dfb29f0ad20e2826dc9280dab271028c8067aa08e912763d062e39cd604f18d61f8c95227b397651203d362c4f56ef4260aa9506dbc2
+  metadata.gz: 5249980d5ca07dee5e08b47ecf003d7a22c9c816c468d9571db7d77094b529fbb65fef426dcafb89ada6c2625bdd55e010c7f911fd4eaea4a7df8a03a4ee6c60
+  data.tar.gz: e91569daf478e8a1351d107836af01f79e65e2c3fc48a94db41c16efe4f9e4f7f17638da2f289e33c5228678a62f159519d425125a3b5c8a18e6a5e77ed1861e

data/README.md

@@ -123,7 +123,7 @@ take note of the most current version of the gem, which will be printed to conso
 * publish the gem as follows
 
 ```shell
-gem push --key github --host https://YOUR_GITHUB_USER_NAME:YOUR_PAT@rubygems.pkg.github.com/dbl-works rubocop-dbl-CURRENT_GEM_VERSION.gem
+gem push --key github --host https://"$YOUR_GITHUB_USER_NAME":"$YOUR_PAT"@rubygems.pkg.github.com/dbl-works rubocop-dbl-"$CURRENT_GEM_VERSION".gem
 ```
 
 replacing `YOUR_GITHUB_USER_NAME`, `YOUR_PAT`, `CURRENT_GEM_VERSION` with the appropriate values.

data/config/cops/layout.yml

@@ -0,0 +1,26 @@
+# Defaults for this cop are found here:
+# https://github.com/rubocop/rubocop/blob/master/config/default.yml
+#
+# Add customizations below.
+#
+# Ensure to document why we change a default by linking the corresponding PR.
+# For example:
+#
+#     Layout/EndAlignment:
+#       Enabled: true
+#
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+# @NOTE: changed EnforcedStyleAlignWith from "keyword" to "variable"
+Layout/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+  AutoCorrect: true
+
+# @NOTE: changed EnforcedStyle from "with_first_parameter" to "with_fixed_indentation"
+Layout/ParameterAlignment:
+  EnforcedStyle: with_fixed_indentation
+  SupportedStyles:
+    - with_first_parameter
+    - with_fixed_indentation

data/config/cops/lint.yml

@@ -0,0 +1,38 @@
+# Defaults for this cop are found here:
+# https://github.com/rubocop/rubocop/blob/master/config/default.yml
+#
+# Add customizations below.
+#
+# Ensure to document why we change a default by linking the corresponding PR.
+# For example:
+#
+#     Lint/AmbiguousOperator:
+#       Enabled: true
+#
+
+#
+# @NOTE: the following cops are on "pending" by default
+#
+Lint/DuplicateBranch:
+  Enabled: true
+
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+
+Lint/EmptyBlock:
+  Enabled: true
+
+Lint/EmptyClass:
+  Enabled: true
+
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: true
+
+Lint/ToEnumArguments:
+  Enabled: true
+
+Lint/UnexpectedBlockArity:
+  Enabled: true
+
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true

data/config/cops/metrics.yml

@@ -0,0 +1,19 @@
+# Defaults for this cop are found here:
+# https://github.com/rubocop/rubocop/blob/master/config/default.yml
+#
+# Add customizations below.
+#
+# Ensure to document why we change a default by linking the corresponding PR.
+# For example:
+#
+#     Metrics/BlockLength:
+#       Enabled: true
+#
+
+# @NOTE: IgnoredMethods by default only contains "refine"
+Metrics/BlockLength:
+  Exclude:
+    - describe
+    - context
+    - feature
+    - scenario

data/config/cops/naming.yml

@@ -0,0 +1,16 @@
+# Defaults for this cop are found here:
+# https://github.com/rubocop/rubocop/blob/master/config/default.yml
+#
+# Add customizations below.
+#
+# Ensure to document why we change a default by linking the corresponding PR.
+# For example:
+#
+#     Naming/VariableNumber:
+#       Enabled: true
+#
+
+# @NOTE: changed EnforcedStyle from "normalcase" to "snake_case"
+# https://github.com/dbl-works/rubocop-dbl/pull/26
+Naming/VariableNumber:
+  EnforcedStyle: snake_case

data/config/cops/performance.yml

@@ -0,0 +1,11 @@
+# Defaults for this cop are found here:
+# https://github.com/rubocop/rubocop-performance/blob/master/config/default.yml
+#
+# Add customizations below.
+#
+# Ensure to document why we change a default by linking the corresponding PR.
+# For example:
+#
+#     Performance/AncestorsInclude:
+#       Enabled: true
+#

data/config/cops/rails.yml

@@ -0,0 +1,83 @@
+# Defaults for this cop are found here:
+# https://github.com/rubocop/rubocop-rails/blob/master/config/default.yml
+#
+# Add customizations below.
+#
+# Ensure to document why we change a default by linking the corresponding PR.
+# For example:
+#
+#     Rails/ActionFilter:
+#       Enabled: false
+#
+
+# @NOTE: added: "staging"
+Rails/UnknownEnv:
+  Environments:
+    - production
+    - development
+    - test
+    - staging
+
+# @NOTE: disabled
+Rails/HttpStatus:
+  Enabled: false
+
+# @NOTE: disabled
+Rails/ApplicationController:
+  Enabled: false
+
+
+#
+# @NOTE: all the cops ahead are "pending" in the current default config
+#
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+
+Rails/AfterCommitOverride:
+  Enabled: true
+
+Rails/AttributeDefaultBlockValue:
+  Enabled: true
+
+Rails/FindById:
+  Enabled: true
+
+Rails/Inquiry:
+  Enabled: true
+
+Rails/MailerName:
+  Enabled: true
+
+Rails/MatchRoute:
+  Enabled: true
+
+Rails/NegateInclude:
+  Enabled: true
+
+Rails/Pluck:
+  Enabled: true
+
+Rails/PluckInWhere:
+  Enabled: true
+
+Rails/RenderInline:
+  Enabled: true
+
+Rails/RenderPlainText:
+  Enabled: true
+
+Rails/ShortI18n:
+  Enabled: true
+  EnforcedStyle: aggressive
+
+Rails/SquishedSQLHeredocs:
+  Enabled: true
+
+Rails/WhereEquals:
+  Enabled: true
+
+Rails/WhereExists:
+  Enabled: true
+
+Rails/WhereNot:
+  Enabled: true

data/config/cops/rspec.yml

@@ -0,0 +1,37 @@
+# Defaults for this cop are found here:
+# https://github.com/rubocop/rubocop-rspec/blob/master/config/default.yml
+#
+# Add customizations below.
+#
+# Ensure to document why we change a default by linking the corresponding PR.
+# For example:
+#
+#     RSpec/AlignLeftLetBrace:
+#       Enabled: true
+#
+
+
+# @NOTE: added: "if", "and"
+RSpec/ContextWording:
+  Prefixes:
+    - when
+    - with
+    - without
+    - if
+    - and
+
+
+# @NOTE: by default, no methods are enabled
+RSpec/Capybara/FeatureMethods:
+  EnabledMethods:
+    - feature
+    - scenario
+
+# @NOTE: increased from 3 to 5
+RSpec/NestedGroups:
+  Max: 5
+
+
+# @NOTE: increased from 5 to 6
+RSpec/MultipleMemoizedHelpers:
+  Max: 6

data/config/cops/style.yml

@@ -0,0 +1,78 @@
+# Defaults for this cop are found here:
+# https://github.com/rubocop/rubocop/blob/master/config/default.yml
+#
+# Add customizations below.
+#
+# Ensure to document why we change a default by linking the corresponding PR.
+# For example:
+#
+#     Style/AndOr:
+#       Enabled: true
+#
+
+# @NOTE: changed from "always" to "never"
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: never
+
+# enforces to use 'name'.to_sym over 'name'.intern and so on
+Style/StringMethods:
+  Enabled: true
+
+# @NOTE: changed from "compact" to "expanded"
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+  SupportedStyles:
+    - compact
+    - expanded
+
+# @NOTE: allowed AllowMultipleReturnValues
+Style/RedundantReturn:
+  Enabled: true
+  AllowMultipleReturnValues: true
+
+# @NOTE: allowed AllowAsExpressionSeparator
+Style/Semicolon:
+  Enabled: true
+  AllowAsExpressionSeparator: true
+
+Style/CollectionMethods:
+  Enabled: true
+
+Style/Documentation:
+  Enabled: false
+
+# @NOTE: changed EnforcedStyleForMultiline from "no_comma" to "comma"
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+# @NOTE: changed EnforcedStyleForMultiline from "no_comma" to "comma"
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+# @NOTE: changed EnforcedStyleForMultiline from "no_comma" to "comma"
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
+
+#
+# @NOTE: the following cops are "pending" by default
+#
+Style/ArgumentsForwarding:
+  Enabled: false
+
+Style/CollectionCompact:
+  Enabled: true
+
+Style/DocumentDynamicEvalDefinition:
+  Enabled: true
+
+Style/NegatedIfElseCondition:
+  Enabled: true
+
+Style/NilLambda:
+  Enabled: true
+
+Style/RedundantArgument:
+  Enabled: true
+
+Style/SwapValues:
+  Enabled: true

data/config/cops/types.yml

@@ -0,0 +1,18 @@
+# Defaults for this cop are found here:
+# https://github.com/rubocop/rubocop/blob/master/config/default.yml
+#
+# Add customizations below.
+#
+# Ensure to document why we change a default by linking the corresponding PR.
+# For example:
+#
+#     Style/AndOr:
+#       Enabled: true
+#
+
+Sorbet/HasSigil:
+  MinimumStrictness: true
+  SuggestedStrictness: strict
+  Exclude:
+    - spec/**/*
+    - test/**/*

data/lib/generators/rubocop_dbl/install_generator.rb

@@ -2,6 +2,7 @@
 
 require 'rails/generators/base'
 require 'active_support/core_ext/string'
+require 'railties'
 
 module RubocopDbl
   module Generators

data/lib/rubocop_dbl/version.rb

@@ -1,5 +1,5 @@
 # typed: false
 
 module RubocopDbl
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.1.0'.freeze
 end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-dbl
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - 'Team DBL :rocket:'
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-30 00:00:00.000000000 Z
+date: 2023-06-04 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: railties
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '5'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '5'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -130,6 +116,15 @@ extra_rdoc_files: []
 files:
 - LICENSE
 - README.md
+- config/cops/layout.yml
+- config/cops/lint.yml
+- config/cops/metrics.yml
+- config/cops/naming.yml
+- config/cops/performance.yml
+- config/cops/rails.yml
+- config/cops/rspec.yml
+- config/cops/style.yml
+- config/cops/types.yml
 - config/dbl.yml
 - lib/generators/rubocop_dbl/install_generator.rb
 - lib/rubocop_dbl/version.rb
@@ -153,7 +148,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.4.13
 signing_key:
 specification_version: 4
 summary: RuboCop configuration for our Ruby on Rails projects