rubocop-config-umbrellio 0.49.1.6 → 0.52.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b570eca622f4981bc3c0779e48cac5982f94be22
-  data.tar.gz: ee628cde697d2de1058da583c2f043c562ca7310
+  metadata.gz: 3e9ccd86081f556c65172907292465708b963ae5
+  data.tar.gz: 0c6bcf39656cd3e638c89be9b1ced6e0ad0b6a28
 SHA512:
-  metadata.gz: adbe1c9d3dd6aba9f0d0019ebbea9a1266e52435dcac99199a60a5c0a9fdcff95b1f1fb12411f03dc982a46284f2dbc71ca58fdb340007d591fe770dec00562f
-  data.tar.gz: 3ecca67eb65f2e27c07660ce0e81b5a50019d04ee68814d8f8b554d6063306d7381b511ee324e1ea298f30592fcc1e50949d880e8e78f21b1873f6a3756cd3b5
+  metadata.gz: 6ca763bf85e5e5fb93070dae22d098e199bffb76cc0a6b6276428a2e136c4cdc66ed4ead1fdf083b1aa9eccfef14de598ca539d673bf1a63c5118d98dca4d6ad
+  data.tar.gz: 45c3257b53cf106abe3014a342d31404131091e6bfcaea3342efa71c1eac0a44bf1348f4ee60a5960177895f5b4c293a1b90268628333e6bf439f9de69b5c028

data/lib/rubocop.rails.yml

@@ -25,12 +25,19 @@ Rails/ApplicationRecord:
   # Use it even you use Sequel
   Enabled: true
 
+Rails/CreateTableWithTimestamps:
+  # Conflicts with Sequel
+  Enabled: false
+
 Rails/Delegate:
   Enabled: false
 
 Rails/HasAndBelongsToMany:
   Enabled: false
 
+Rails/HasManyOrHasOneDependent:
+  Enabled: false
+
 Rails/HttpPositionalArguments:
   # rails 5 feature https://github.com/bbatsov/rubocop/issues/3629
   Enabled: false
@@ -48,6 +55,13 @@ Rails/SaveBang:
 Rails/SkipsModelValidations:
   Enabled: false
 
+Rails/UnknownEnv:
+  Environments:
+    - development
+    - test
+    - staging
+    - production
+
 # Style
 
 Style/ClassAndModuleChildren:

data/lib/rubocop.rspec.yml

@@ -0,0 +1,107 @@
+require: rubocop-rspec
+
+AllCops:
+  RSpec/FactoryBot:
+    Patterns:
+      - spec/factories.rb
+      - spec/factories/**/*.rb
+      - features/support/factories/**/*.rb
+
+# Capybara
+
+Capybara/CurrentPathExpectation:
+  Enabled: true
+
+Capybara/FeatureMethods:
+  Enabled: false
+
+# FactoryBot
+
+FactoryBot/DynamicAttributeDefinedStatically:
+  Enabled: true
+
+# RSpec
+
+RSpec/AlignLeftLetBrace:
+  # Never do it
+  Enabled: false
+
+RSpec/AlignRightLetBrace:
+  # Never do it
+  Enabled: false
+
+RSpec/AnyInstance:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Max: 20
+  Exclude:
+    - spec/features/**/*
+
+RSpec/DescribeClass:
+  Enabled: false
+
+RSpec/DescribedClass:
+  Enabled: false
+
+RSpec/DescribeMethod:
+  Enabled: false
+
+RSpec/ContextWording:
+  Enabled: false
+
+RSpec/ExpectInHook:
+  # try not to use expect in before / after / around blocks anyway
+  Enabled: false
+
+RSpec/FilePath:
+  Enabled: false
+
+RSpec/InvalidPredicateMatcher:
+  Enabled: true
+
+RSpec/LetBeforeExamples:
+  Enabled: true
+
+RSpec/LetSetup:
+  Enabled: false
+
+RSpec/MessageChain:
+  Enabled: false
+
+RSpec/MessageSpies:
+  Enabled: false
+
+RSpec/MultipleDescribes:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/MultipleSubjects:
+  Enabled: true
+
+RSpec/NestedGroups:
+  Enabled: false
+
+RSpec/ReturnFromStub:
+  # expect(foo).to receive(:bar) { :baz } # Bad
+  # expect(foo).to receive(:bar).and_return(:baz) # Good
+  # expect(foo).to receive(:bar).and_return { Time.current } # Good
+  Enabled: true
+
+RSpec/PredicateMatcher:
+  # Predicate matchers' error messages are shitty, we should not use them unless they aren't
+  # expect(foo).to be_nil # good
+  # expect(foo).to be_active # bad if foo.inspect takes 5 screens
+  # expect(foo.active?).to be_truthy # good
+  Enabled: false
+
+RSpec/ScatteredSetup:
+  Enabled: false
+
+RSpec/VerifiedDoubles:
+  Enabled: false
+
+RSpec/VoidExpect:
+  Enabled: true

data/lib/rubocop.yml

@@ -1,4 +1,5 @@
-require: rubocop-rspec
+inherit_gem:
+  rubocop-config-umbrellio: lib/rubocop.rspec.yml
 
 AllCops:
   Exclude:
@@ -10,17 +11,11 @@ AllCops:
 Layout/AlignParameters:
   Enabled: true
 
-Layout/MultilineMethodCallIndentation:
-  # We don't like this cop
-  Enabled: false
-
-Layout/MultilineOperationIndentation:
-  Enabled: false
-
-Layout/SpaceInLambdaLiteral:
-  EnforcedStyle: require_space
+Layout/ClassStructure:
+  Enabled: true
 
-Layout/SpaceInsideBrackets:
+Layout/EmptyLinesAroundArguments:
+  # Conflicts with memery / memoist, try to enable after next rubocop upgrade
   Enabled: false
 
 Layout/IndentArray:
@@ -39,6 +34,19 @@ Layout/IndentArray:
 Layout/IndentHash:
   EnforcedStyle: consistent
 
+Layout/MultilineMethodCallIndentation:
+  # We don't like this cop
+  Enabled: false
+
+Layout/MultilineOperationIndentation:
+  Enabled: false
+
+Layout/SpaceInLambdaLiteral:
+  EnforcedStyle: require_space
+
+Layout/SpaceInsideArrayLiteralBrackets:
+  Enabled: false
+
 # Lint
 
 Lint/AmbiguousBlockAssociation:
@@ -104,59 +112,29 @@ Metrics/MethodLength:
 Metrics/PerceivedComplexity:
   Enabled: false
 
-# Performance
-
-Performance/Caller:
-  Enabled: true
-
-Performance/Casecmp:
-  Enabled: false
-
-# RSpec
-
-RSpec/AnyInstance:
-  Enabled: false
-
-RSpec/ExampleLength:
-  Max: 20
-  Exclude:
-    - spec/features/**/*
-
-RSpec/DescribeClass:
-  Enabled: false
-
-RSpec/DescribedClass:
-  Enabled: false
-
-RSpec/DescribeMethod:
-  Enabled: false
-
-RSpec/FilePath:
-  Enabled: false
-
-RSpec/LetSetup:
-  Enabled: false
+# Naming
 
-RSpec/MessageChain:
+Naming/AccessorMethodName:
+  # This cop assumes every method is accessor
   Enabled: false
 
-RSpec/MessageSpies:
-  Enabled: false
+Naming/PredicateName:
+  # `has_` is generally good
+  NamePrefixBlacklist:
+    - is_
 
-RSpec/MultipleDescribes:
-  Enabled: false
+# Performance
 
-RSpec/MultipleExpectations:
-  Enabled: false
+Performance/Caller:
+  Enabled: true
 
-RSpec/NestedGroups:
+Performance/Casecmp:
   Enabled: false
 
-RSpec/ScatteredSetup:
-  Enabled: false
+# Performance
 
-RSpec/VerifiedDoubles:
-  Enabled: false
+Performance/UnfreezeString:
+  Enabled: true
 
 # Security
 
@@ -165,10 +143,6 @@ Security/YAMLLoad:
 
 # Style
 
-Style/AccessorMethodName:
-  # This cop assumes every method is accessor
-  Enabled: false
-
 Style/AndOr:
   # `do_something and return`
   Enabled: false
@@ -184,6 +158,9 @@ Style/CommentAnnotation:
 Style/ConditionalAssignment:
   Enabled: false
 
+Style/Dir:
+  Enabled: true
+
 Style/Documentation:
   Enabled: false
 
@@ -213,7 +190,8 @@ Style/FormatStringToken:
   Enabled: true
 
 Style/IfUnlessModifier:
-  Enabled: true
+  # Doesn't work well with Metrics/LineLength
+  Enabled: false
 
 Style/GuardClause:
   Enabled: false
@@ -247,15 +225,13 @@ Style/PerlBackrefs:
   # Disable localy if realy neeeded
   Enabled: true
 
-Style/PredicateName:
-  # `has_` is generally good
-  NamePrefixBlacklist:
-    - is_
-
 Style/RaiseArgs:
   Description: 'Use `raise, ErrorClass` in all cases but not when you need ErrorClass constructor'
   Enabled: false
 
+Style/RedundantConditional:
+  Enabled: true
+
 Style/RegexpLiteral:
   EnforcedStyle: mixed
   Enabled: true
@@ -263,6 +239,9 @@ Style/RegexpLiteral:
 Style/RescueModifier:
   Enabled: false
 
+Style/RescueStandardError:
+  # We forced `rescue` over `rescue StandardError`
+  Enabled: false
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-config-umbrellio
 version: !ruby/object:Gem::Version
-  version: 0.49.1.6
+  version: 0.52.1.0
 platform: ruby
 authors:
 - JelF
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-30 00:00:00.000000000 Z
+date: 2018-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 0.52.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 0.52.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.15.1
+        version: 1.22.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.15.1
+        version: 1.22.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -74,6 +74,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/rubocop.rails.yml
+- lib/rubocop.rspec.yml
 - lib/rubocop.yml
 homepage: https://github.com/umbrellio/code-style
 licenses: []
@@ -94,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: This gem provides default rubocop settings for Umbrellio projects