rubocop-config-umbrellio 0.49.1.6 → 0.52.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: b570eca622f4981bc3c0779e48cac5982f94be22
4
- data.tar.gz: ee628cde697d2de1058da583c2f043c562ca7310
3
+ metadata.gz: 3e9ccd86081f556c65172907292465708b963ae5
4
+ data.tar.gz: 0c6bcf39656cd3e638c89be9b1ced6e0ad0b6a28
5
5
  SHA512:
6
- metadata.gz: adbe1c9d3dd6aba9f0d0019ebbea9a1266e52435dcac99199a60a5c0a9fdcff95b1f1fb12411f03dc982a46284f2dbc71ca58fdb340007d591fe770dec00562f
7
- data.tar.gz: 3ecca67eb65f2e27c07660ce0e81b5a50019d04ee68814d8f8b554d6063306d7381b511ee324e1ea298f30592fcc1e50949d880e8e78f21b1873f6a3756cd3b5
6
+ metadata.gz: 6ca763bf85e5e5fb93070dae22d098e199bffb76cc0a6b6276428a2e136c4cdc66ed4ead1fdf083b1aa9eccfef14de598ca539d673bf1a63c5118d98dca4d6ad
7
+ data.tar.gz: 45c3257b53cf106abe3014a342d31404131091e6bfcaea3342efa71c1eac0a44bf1348f4ee60a5960177895f5b4c293a1b90268628333e6bf439f9de69b5c028
@@ -25,12 +25,19 @@ Rails/ApplicationRecord:
25
25
  # Use it even you use Sequel
26
26
  Enabled: true
27
27
 
28
+ Rails/CreateTableWithTimestamps:
29
+ # Conflicts with Sequel
30
+ Enabled: false
31
+
28
32
  Rails/Delegate:
29
33
  Enabled: false
30
34
 
31
35
  Rails/HasAndBelongsToMany:
32
36
  Enabled: false
33
37
 
38
+ Rails/HasManyOrHasOneDependent:
39
+ Enabled: false
40
+
34
41
  Rails/HttpPositionalArguments:
35
42
  # rails 5 feature https://github.com/bbatsov/rubocop/issues/3629
36
43
  Enabled: false
@@ -48,6 +55,13 @@ Rails/SaveBang:
48
55
  Rails/SkipsModelValidations:
49
56
  Enabled: false
50
57
 
58
+ Rails/UnknownEnv:
59
+ Environments:
60
+ - development
61
+ - test
62
+ - staging
63
+ - production
64
+
51
65
  # Style
52
66
 
53
67
  Style/ClassAndModuleChildren:
@@ -0,0 +1,107 @@
1
+ require: rubocop-rspec
2
+
3
+ AllCops:
4
+ RSpec/FactoryBot:
5
+ Patterns:
6
+ - spec/factories.rb
7
+ - spec/factories/**/*.rb
8
+ - features/support/factories/**/*.rb
9
+
10
+ # Capybara
11
+
12
+ Capybara/CurrentPathExpectation:
13
+ Enabled: true
14
+
15
+ Capybara/FeatureMethods:
16
+ Enabled: false
17
+
18
+ # FactoryBot
19
+
20
+ FactoryBot/DynamicAttributeDefinedStatically:
21
+ Enabled: true
22
+
23
+ # RSpec
24
+
25
+ RSpec/AlignLeftLetBrace:
26
+ # Never do it
27
+ Enabled: false
28
+
29
+ RSpec/AlignRightLetBrace:
30
+ # Never do it
31
+ Enabled: false
32
+
33
+ RSpec/AnyInstance:
34
+ Enabled: false
35
+
36
+ RSpec/ExampleLength:
37
+ Max: 20
38
+ Exclude:
39
+ - spec/features/**/*
40
+
41
+ RSpec/DescribeClass:
42
+ Enabled: false
43
+
44
+ RSpec/DescribedClass:
45
+ Enabled: false
46
+
47
+ RSpec/DescribeMethod:
48
+ Enabled: false
49
+
50
+ RSpec/ContextWording:
51
+ Enabled: false
52
+
53
+ RSpec/ExpectInHook:
54
+ # try not to use expect in before / after / around blocks anyway
55
+ Enabled: false
56
+
57
+ RSpec/FilePath:
58
+ Enabled: false
59
+
60
+ RSpec/InvalidPredicateMatcher:
61
+ Enabled: true
62
+
63
+ RSpec/LetBeforeExamples:
64
+ Enabled: true
65
+
66
+ RSpec/LetSetup:
67
+ Enabled: false
68
+
69
+ RSpec/MessageChain:
70
+ Enabled: false
71
+
72
+ RSpec/MessageSpies:
73
+ Enabled: false
74
+
75
+ RSpec/MultipleDescribes:
76
+ Enabled: false
77
+
78
+ RSpec/MultipleExpectations:
79
+ Enabled: false
80
+
81
+ RSpec/MultipleSubjects:
82
+ Enabled: true
83
+
84
+ RSpec/NestedGroups:
85
+ Enabled: false
86
+
87
+ RSpec/ReturnFromStub:
88
+ # expect(foo).to receive(:bar) { :baz } # Bad
89
+ # expect(foo).to receive(:bar).and_return(:baz) # Good
90
+ # expect(foo).to receive(:bar).and_return { Time.current } # Good
91
+ Enabled: true
92
+
93
+ RSpec/PredicateMatcher:
94
+ # Predicate matchers' error messages are shitty, we should not use them unless they aren't
95
+ # expect(foo).to be_nil # good
96
+ # expect(foo).to be_active # bad if foo.inspect takes 5 screens
97
+ # expect(foo.active?).to be_truthy # good
98
+ Enabled: false
99
+
100
+ RSpec/ScatteredSetup:
101
+ Enabled: false
102
+
103
+ RSpec/VerifiedDoubles:
104
+ Enabled: false
105
+
106
+ RSpec/VoidExpect:
107
+ Enabled: true
@@ -1,4 +1,5 @@
1
- require: rubocop-rspec
1
+ inherit_gem:
2
+ rubocop-config-umbrellio: lib/rubocop.rspec.yml
2
3
 
3
4
  AllCops:
4
5
  Exclude:
@@ -10,17 +11,11 @@ AllCops:
10
11
  Layout/AlignParameters:
11
12
  Enabled: true
12
13
 
13
- Layout/MultilineMethodCallIndentation:
14
- # We don't like this cop
15
- Enabled: false
16
-
17
- Layout/MultilineOperationIndentation:
18
- Enabled: false
19
-
20
- Layout/SpaceInLambdaLiteral:
21
- EnforcedStyle: require_space
14
+ Layout/ClassStructure:
15
+ Enabled: true
22
16
 
23
- Layout/SpaceInsideBrackets:
17
+ Layout/EmptyLinesAroundArguments:
18
+ # Conflicts with memery / memoist, try to enable after next rubocop upgrade
24
19
  Enabled: false
25
20
 
26
21
  Layout/IndentArray:
@@ -39,6 +34,19 @@ Layout/IndentArray:
39
34
  Layout/IndentHash:
40
35
  EnforcedStyle: consistent
41
36
 
37
+ Layout/MultilineMethodCallIndentation:
38
+ # We don't like this cop
39
+ Enabled: false
40
+
41
+ Layout/MultilineOperationIndentation:
42
+ Enabled: false
43
+
44
+ Layout/SpaceInLambdaLiteral:
45
+ EnforcedStyle: require_space
46
+
47
+ Layout/SpaceInsideArrayLiteralBrackets:
48
+ Enabled: false
49
+
42
50
  # Lint
43
51
 
44
52
  Lint/AmbiguousBlockAssociation:
@@ -104,59 +112,29 @@ Metrics/MethodLength:
104
112
  Metrics/PerceivedComplexity:
105
113
  Enabled: false
106
114
 
107
- # Performance
108
-
109
- Performance/Caller:
110
- Enabled: true
111
-
112
- Performance/Casecmp:
113
- Enabled: false
114
-
115
- # RSpec
116
-
117
- RSpec/AnyInstance:
118
- Enabled: false
119
-
120
- RSpec/ExampleLength:
121
- Max: 20
122
- Exclude:
123
- - spec/features/**/*
124
-
125
- RSpec/DescribeClass:
126
- Enabled: false
127
-
128
- RSpec/DescribedClass:
129
- Enabled: false
130
-
131
- RSpec/DescribeMethod:
132
- Enabled: false
133
-
134
- RSpec/FilePath:
135
- Enabled: false
136
-
137
- RSpec/LetSetup:
138
- Enabled: false
115
+ # Naming
139
116
 
140
- RSpec/MessageChain:
117
+ Naming/AccessorMethodName:
118
+ # This cop assumes every method is accessor
141
119
  Enabled: false
142
120
 
143
- RSpec/MessageSpies:
144
- Enabled: false
121
+ Naming/PredicateName:
122
+ # `has_` is generally good
123
+ NamePrefixBlacklist:
124
+ - is_
145
125
 
146
- RSpec/MultipleDescribes:
147
- Enabled: false
126
+ # Performance
148
127
 
149
- RSpec/MultipleExpectations:
150
- Enabled: false
128
+ Performance/Caller:
129
+ Enabled: true
151
130
 
152
- RSpec/NestedGroups:
131
+ Performance/Casecmp:
153
132
  Enabled: false
154
133
 
155
- RSpec/ScatteredSetup:
156
- Enabled: false
134
+ # Performance
157
135
 
158
- RSpec/VerifiedDoubles:
159
- Enabled: false
136
+ Performance/UnfreezeString:
137
+ Enabled: true
160
138
 
161
139
  # Security
162
140
 
@@ -165,10 +143,6 @@ Security/YAMLLoad:
165
143
 
166
144
  # Style
167
145
 
168
- Style/AccessorMethodName:
169
- # This cop assumes every method is accessor
170
- Enabled: false
171
-
172
146
  Style/AndOr:
173
147
  # `do_something and return`
174
148
  Enabled: false
@@ -184,6 +158,9 @@ Style/CommentAnnotation:
184
158
  Style/ConditionalAssignment:
185
159
  Enabled: false
186
160
 
161
+ Style/Dir:
162
+ Enabled: true
163
+
187
164
  Style/Documentation:
188
165
  Enabled: false
189
166
 
@@ -213,7 +190,8 @@ Style/FormatStringToken:
213
190
  Enabled: true
214
191
 
215
192
  Style/IfUnlessModifier:
216
- Enabled: true
193
+ # Doesn't work well with Metrics/LineLength
194
+ Enabled: false
217
195
 
218
196
  Style/GuardClause:
219
197
  Enabled: false
@@ -247,15 +225,13 @@ Style/PerlBackrefs:
247
225
  # Disable localy if realy neeeded
248
226
  Enabled: true
249
227
 
250
- Style/PredicateName:
251
- # `has_` is generally good
252
- NamePrefixBlacklist:
253
- - is_
254
-
255
228
  Style/RaiseArgs:
256
229
  Description: 'Use `raise, ErrorClass` in all cases but not when you need ErrorClass constructor'
257
230
  Enabled: false
258
231
 
232
+ Style/RedundantConditional:
233
+ Enabled: true
234
+
259
235
  Style/RegexpLiteral:
260
236
  EnforcedStyle: mixed
261
237
  Enabled: true
@@ -263,6 +239,9 @@ Style/RegexpLiteral:
263
239
  Style/RescueModifier:
264
240
  Enabled: false
265
241
 
242
+ Style/RescueStandardError:
243
+ # We forced `rescue` over `rescue StandardError`
244
+ Enabled: false
266
245
 
267
246
  Style/StringLiterals:
268
247
  EnforcedStyle: double_quotes
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rubocop-config-umbrellio
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.49.1.6
4
+ version: 0.52.1.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - JelF
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2017-08-30 00:00:00.000000000 Z
11
+ date: 2018-01-19 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -16,28 +16,28 @@ dependencies:
16
16
  requirements:
17
17
  - - '='
18
18
  - !ruby/object:Gem::Version
19
- version: 0.49.1
19
+ version: 0.52.1
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - '='
25
25
  - !ruby/object:Gem::Version
26
- version: 0.49.1
26
+ version: 0.52.1
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: rubocop-rspec
29
29
  requirement: !ruby/object:Gem::Requirement
30
30
  requirements:
31
31
  - - '='
32
32
  - !ruby/object:Gem::Version
33
- version: 1.15.1
33
+ version: 1.22.1
34
34
  type: :runtime
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
38
  - - '='
39
39
  - !ruby/object:Gem::Version
40
- version: 1.15.1
40
+ version: 1.22.1
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: bundler
43
43
  requirement: !ruby/object:Gem::Requirement
@@ -74,6 +74,7 @@ extensions: []
74
74
  extra_rdoc_files: []
75
75
  files:
76
76
  - lib/rubocop.rails.yml
77
+ - lib/rubocop.rspec.yml
77
78
  - lib/rubocop.yml
78
79
  homepage: https://github.com/umbrellio/code-style
79
80
  licenses: []
@@ -94,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
94
95
  version: '0'
95
96
  requirements: []
96
97
  rubyforge_project:
97
- rubygems_version: 2.5.2
98
+ rubygems_version: 2.5.1
98
99
  signing_key:
99
100
  specification_version: 4
100
101
  summary: This gem provides default rubocop settings for Umbrellio projects