rubocop-config-oharagroup 2.0.0 → 2.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (6) hide show
  1. checksums.yaml +4 -4
  2. data/default.yml +44 -132
  3. data/performance.yml +5 -28
  4. data/rails.yml +5 -25
  5. data/rspec.yml +15 -30
  6. metadata +3 -3
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: f8aa261ea09ac0a498483ca1f0046e7117dd0a4742454a3df3ce57d5082afed8
4
- data.tar.gz: c632d3c780ec4362f91a8ad2971d75856ab8a4a7956dfa308309f9263e2a9cd8
3
+ metadata.gz: 53cf720e797e715a0c08e3a77f8633ae721090a29f75d1f44ed5cdecf49b658c
4
+ data.tar.gz: 35365bef8ef355e06aa071307309096c2d293a47acec0f1af26f6aedaff895c5
5
5
  SHA512:
6
- metadata.gz: e560c9ff7e6dc7edced49e535c86014f5db3506c9a340b1576f1a642fbb6ec33ee088d1544e2fbb4a24759a37f929cd5c5148e0b481a2ed8c4799171a084ee56
7
- data.tar.gz: 43486ae1f61fddb387ccb2cef2ac41915777394568740b163b82516ac2773d8f66983f90d197b15a6300133933793ae38809e9bf96fd63373c855457c0f927b8
6
+ metadata.gz: 7a0df05c7d866984ceb1fa21ce5ad350daa9c06406d0bb161bb2157c8154c2653d510650712af5282dbba33748750107dc73d36c3045d485ca3ee36923e01043
7
+ data.tar.gz: 95d39a30f675793926f70b8446648c6e16b33a14238e63c8d300f9371a3683c52dc292c40c049326cb4c919427c06f4408c6467f23d5d11f75a9488601f2c7ec
data/default.yml CHANGED
@@ -1,157 +1,69 @@
1
- # ------------------------------------------------------------
2
- # Cops that rubocop disables by default, but we want to enable
3
- # ------------------------------------------------------------
1
+ AllCops:
2
+ DisplayStyleGuide: true
3
+ ExtraDetails: true
4
+ EnabledByDefault: true
5
+ NewCops: enable
4
6
 
5
- Bundler/GemComment:
6
- Enabled: true
7
+ # Use consistent indentation for arrays even in method calls
8
+ Layout/FirstArrayElementIndentation:
9
+ EnforcedStyle: consistent
7
10
 
8
- Layout/ClassStructure:
9
- Enabled: true
11
+ # Use consistent indentation for hashes even in method calls
12
+ Layout/FirstHashElementIndentation:
13
+ EnforcedStyle: consistent
10
14
 
11
- Layout/FirstArrayElementLineBreak:
12
- Enabled: true
13
-
14
- Layout/FirstHashElementLineBreak:
15
- Enabled: true
16
-
17
- Layout/FirstMethodArgumentLineBreak:
18
- Enabled: true
19
-
20
- Layout/FirstMethodParameterLineBreak:
21
- Enabled: true
22
-
23
- Layout/HeredocArgumentClosingParenthesis:
24
- Enabled: true
25
-
26
- Layout/MultilineArrayLineBreaks:
27
- Enabled: true
28
-
29
- Layout/MultilineAssignmentLayout:
30
- Enabled: true
31
-
32
- Layout/MultilineHashKeyLineBreaks:
33
- Enabled: true
34
-
35
- Layout/MultilineMethodArgumentLineBreaks:
36
- Enabled: true
37
-
38
- Lint/HeredocMethodCallPosition:
39
- Enabled: true
40
-
41
- # Lint/NumberConversion (prefer cast invalid numbers to 0 rather than throw)
42
-
43
- Migration/DepartmentName:
44
- Enabled: true
45
-
46
- Style/AutoResourceCleanup:
47
- Enabled: true
48
-
49
- Style/CollectionMethods:
50
- Enabled: true
51
-
52
- Style/ConstantVisibility:
53
- Enabled: true
54
-
55
- Style/Copyright:
56
- Enabled: true
57
- Notice: 'Copyright \(c\) 2016 Scott O.Hara, oharagroup.net'
58
-
59
- Style/DateTime:
60
- Enabled: true
61
-
62
- # Style/DocumentationMethod (disabled due to no documentation)
63
-
64
- Style/ImplicitRuntimeError:
65
- Enabled: true
66
-
67
- # Style/InlineComment (disabled due to use of inline comments)
68
-
69
- Style/IpAddresses:
70
- Enabled: true
71
-
72
- # Style/MethodCallWithArgsParentheses (prefer no parens)
73
-
74
- Style/MethodCalledOnDoEndBlock:
75
- Enabled: true
76
-
77
- # Style/MissingElse (else not required)
78
-
79
- Style/MultilineMethodSignature:
80
- Enabled: true
81
-
82
- Style/OptionHash:
83
- Enabled: true
84
-
85
- Style/ReturnNil:
86
- Enabled: true
87
-
88
- Style/Send:
89
- Enabled: true
90
-
91
- Style/SingleLineBlockParams:
92
- Enabled: true
93
-
94
- # Style/StringHashKeys (disabled because JSON used heavily with string keys)
95
-
96
- Style/StringMethods:
97
- Enabled: true
15
+ # Prefer tabs over spaces
16
+ Layout/IndentationStyle:
17
+ EnforcedStyle: tabs
98
18
 
99
- # ------------------------------------------------------------
100
- # END disabled by default cops
101
- # ------------------------------------------------------------
102
- # Cops that rubocop enables by default, but we want to disable
103
- # ------------------------------------------------------------
19
+ # Use single tab for indentation
20
+ Layout/IndentationWidth:
21
+ Width: 1
104
22
 
105
- # Prefer tabs over spaces
106
- Layout/Tab:
23
+ # Don't enforce max line length
24
+ Layout/LineLength:
107
25
  Enabled: false
108
26
 
109
- # Block comment in spec_helper
110
- Style/BlockComments:
111
- Enabled: false
27
+ # Don't allow spaces inside literal hash braces
28
+ Layout/SpaceInsideHashLiteralBraces:
29
+ EnforcedStyle: no_space
112
30
 
113
- # Only require parens where absolutely necessary
114
- Style/NestedParenthesizedCalls:
31
+ # Prefer cast invalid numbers to 0 rather than throw
32
+ Lint/NumberConversion:
115
33
  Enabled: false
116
34
 
117
- # Disable metrics
118
- Metrics/AbcSize:
35
+ # Disable metrics department
36
+ Metrics:
119
37
  Enabled: false
120
38
 
121
- Metrics/BlockLength:
39
+ # Allow block comment in spec_helper
40
+ Style/BlockComments:
122
41
  Enabled: false
123
42
 
124
- Metrics/ClassLength:
125
- Enabled: false
43
+ Style/Copyright:
44
+ Notice: 'Copyright \(c\) 2016 Scott O.Hara, oharagroup.net'
126
45
 
127
- Metrics/CyclomaticComplexity:
46
+ # Don't require documentation comment for public methods
47
+ Style/DocumentationMethod:
128
48
  Enabled: false
129
49
 
130
- Metrics/LineLength:
50
+ # Allow trailing inline comments
51
+ Style/InlineComment:
131
52
  Enabled: false
132
53
 
133
- Metrics/MethodLength:
54
+ # Omit parens where possible
55
+ # TODO - check if we can leave this enabled and switch EnforcedStyle: omit_parentheses
56
+ Style/MethodCallWithArgsParentheses:
134
57
  Enabled: false
135
58
 
136
- Metrics/ModuleLength:
59
+ # Else not required
60
+ Style/MissingElse:
137
61
  Enabled: false
138
62
 
139
- Metrics/PerceivedComplexity:
63
+ # Only require parens where absolutely necessary
64
+ Style/NestedParenthesizedCalls:
140
65
  Enabled: false
141
66
 
142
- # ------------------------------------------------------------
143
- # END enabled by default cops
144
- # ------------------------------------------------------------
145
- # Cops that we want to reconfigure
146
- # ------------------------------------------------------------
147
-
148
- # Changed from 2 (spaces) to 1 (tab)
149
- Layout/IndentationWidth:
150
- Width: 1
151
-
152
- Layout/SpaceInsideHashLiteralBraces:
153
- EnforcedStyle: no_space
154
-
155
- # ------------------------------------------------------------
156
- # END reconfigured cops
157
- # ------------------------------------------------------------
67
+ # Disabled because JSON used heavily with string keys
68
+ Style/StringHashKeys:
69
+ Enabled: false
data/performance.yml CHANGED
@@ -1,28 +1,5 @@
1
- # ------------------------------------------------------------
2
- # Cops that rubocop disables by default, but we want to enable
3
- # ------------------------------------------------------------
4
-
5
- Performance/CaseWhenSplat:
6
- Enabled: true
7
-
8
- Performance/ChainArrayAllocation:
9
- Enabled: true
10
-
11
- Performance/OpenStruct:
12
- Enabled: true
13
-
14
- # ------------------------------------------------------------
15
- # END disabled by default cops
16
- # ------------------------------------------------------------
17
- # Cops that rubocop enables by default, but we want to disable
18
- # ------------------------------------------------------------
19
-
20
- # ------------------------------------------------------------
21
- # END enabled by default cops
22
- # ------------------------------------------------------------
23
- # Cops that we want to reconfigure
24
- # ------------------------------------------------------------
25
-
26
- # ------------------------------------------------------------
27
- # END reconfigured cops
28
- # ------------------------------------------------------------
1
+ AllCops:
2
+ DisplayStyleGuide: true
3
+ ExtraDetails: true
4
+ EnabledByDefault: true
5
+ NewCops: enable
data/rails.yml CHANGED
@@ -1,25 +1,5 @@
1
- # ------------------------------------------------------------
2
- # Cops that rubocop disables by default, but we want to enable
3
- # ------------------------------------------------------------
4
-
5
- Rails:
6
- Enabled: true
7
-
8
- Rails/SaveBang:
9
- Enabled: true
10
-
11
- # ------------------------------------------------------------
12
- # END disabled by default cops
13
- # ------------------------------------------------------------
14
- # Cops that rubocop enables by default, but we want to disable
15
- # ------------------------------------------------------------
16
-
17
- # ------------------------------------------------------------
18
- # END enabled by default cops
19
- # ------------------------------------------------------------
20
- # Cops that we want to reconfigure
21
- # ------------------------------------------------------------
22
-
23
- # ------------------------------------------------------------
24
- # END reconfigured cops
25
- # ------------------------------------------------------------
1
+ AllCops:
2
+ DisplayStyleGuide: true
3
+ ExtraDetails: true
4
+ EnabledByDefault: true
5
+ NewCops: enable
data/rspec.yml CHANGED
@@ -1,23 +1,14 @@
1
- # ------------------------------------------------------------
2
- # Cops that rubocop disables by default, but we want to enable
3
- # ------------------------------------------------------------
1
+ AllCops:
2
+ DisplayStyleGuide: true
3
+ ExtraDetails: true
4
+ EnabledByDefault: true
5
+ NewCops: enable
4
6
 
5
- # RSpec/AlignLeftLetBrace (not using)
6
- # RSpec/AlignRightLetBrace (not using)
7
-
8
- RSpec/Dialect:
9
- Enabled: true
10
-
11
- # RSpec/MessageExpectation (enable use of both `allow` and 'expect' for message expectations)
12
-
13
- RSpec/Pending:
14
- Enabled: true
15
-
16
- # ------------------------------------------------------------
17
- # END disabled by default cops
18
- # ------------------------------------------------------------
19
- # Cops that rubocop enables by default, but we want to disable
20
- # ------------------------------------------------------------
7
+ # Don't enforce alignment of braces
8
+ RSpec/AlignLeftLetBrace:
9
+ Enabled: false
10
+ RSpec/AlignRightLetBrace:
11
+ Enabled: false
21
12
 
22
13
  # Allow expect_any_instance_of to be used
23
14
  RSpec/AnyInstance:
@@ -43,6 +34,10 @@ RSpec/ExampleWording:
43
34
  RSpec/ExpectInHook:
44
35
  Enabled: false
45
36
 
37
+ # Enable use of both `allow` and 'expect' for message expectations
38
+ RSpec/MessageExpectation:
39
+ Enabled: false
40
+
46
41
  # Allow stubbing message chains
47
42
  RSpec/MessageChain:
48
43
  Enabled: false
@@ -61,14 +56,4 @@ RSpec/NestedGroups:
61
56
 
62
57
  # Allow concerns to stub subject
63
58
  RSpec/SubjectStub:
64
- Enabled: false
65
-
66
- # ------------------------------------------------------------
67
- # END enabled by default cops
68
- # ------------------------------------------------------------
69
- # Cops that we want to reconfigure
70
- # ------------------------------------------------------------
71
-
72
- # ------------------------------------------------------------
73
- # END reconfigured cops
74
- # ------------------------------------------------------------
59
+ Enabled: false
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rubocop-config-oharagroup
3
3
  version: !ruby/object:Gem::Version
4
- version: 2.0.0
4
+ version: 2.1.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Scott O'Hara
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2019-10-21 00:00:00.000000000 Z
11
+ date: 2020-05-18 00:00:00.000000000 Z
12
12
  dependencies: []
13
13
  description: Rubocop shared configuration for all O'Hara Group ruby projects
14
14
  email: scott@oharagroup.net
@@ -41,7 +41,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
41
41
  - !ruby/object:Gem::Version
42
42
  version: '0'
43
43
  requirements: []
44
- rubygems_version: 3.0.6
44
+ rubygems_version: 3.1.3
45
45
  signing_key:
46
46
  specification_version: 4
47
47
  summary: O'Hara Group Ruby style guide