rubocop-config-captive 2.2.1 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b792b47ba1dab2270b0e7509cf6533a85cd27e4d9ecb865de1659f27176c86ce
-  data.tar.gz: 2ad3adee19ed6fe6d4ef07b0b4c7e68e349a732fe22ec1d4cc1baabcd74a6841
+  metadata.gz: 0c8513544ecc3a95a4dd8315e0b9096386168107c8acf6dd03705748ff69eb69
+  data.tar.gz: 80beab80c12d93db9d69652be8dd48a0c631beb87abbcd11f4d5fcf8526c76d4
 SHA512:
-  metadata.gz: 3f890d61085363edcb57cdf460127f07f5f3b31b29cd560dd14728d026faddf596495bb0d4654659071289278beac58dfc84a325b11cbdb519550bbf364e87a8
-  data.tar.gz: f96ed6a1a39f61a0c131220631d4c7e33503d8791cf00985ecac62a483478316b952770838b13921cd7ffde299a4fa5c69634c8dbf65df3c18b7745a287ee3cd
+  metadata.gz: 6e1fdab22010877255fa49451feee1502974f520c6e9d450b3d5e087c86fb53339e553a6a2bb2c07600fe18e127f7a31cfd2f862b340db0c54a9afd9fd757a06
+  data.tar.gz: 573648923949ed27dfc0fa32b979ef66ccbc218bf9353724616ddd584a1d5e10b270e67c616befbb192f8d70428f28260a7d18a5606be49c25fc49430fcaee51

data/Gemfile

@@ -4,6 +4,10 @@ source "https://rubygems.org"
 
 gemspec
 
+group :development, :test do
+  gem "rake", "13.4.2"
+end
+
 group :development do
   gem "yard", "~> 0.9.34"
 end

data/config/__private__/rubocop-lint.yml

@@ -137,7 +137,7 @@ Lint/MissingCopEnableDirective:
   #   a = 1
   #   # rubocop:enable SomeCop
   # .inf for any size
-  MaximumRangeSize: .inf
+  MaxRangeSize: .inf
   Description: 'Checks for a `# rubocop:enable` after `# rubocop:disable`'
   Enabled: true
 

data/config/rubocop-captive.yml

@@ -4,6 +4,7 @@ require:
   - ../lib/rubocop/cop/captive/translation/rails_i18n_presence.rb
   - ../lib/rubocop/cop/captive/translation/kaminari_i18n_presence.rb
   - ../lib/rubocop/cop/captive/rspec/specify_before_parameter.rb
+  - ../lib/rubocop/cop/captive/rspec/no_db_in_unit_specs.rb
   - ../lib/rubocop/cop/captive/rails/after_commit_not_allowed.rb
   - ../lib/rubocop/cop/captive/rails/force_ssl_enabled_in_production.rb
   - ../lib/rubocop/cop/captive/rails/migration_methods.rb
@@ -43,6 +44,21 @@ Captive/RSpec/SpecifyBeforeParameter:
   Include:
     - 'spec/**/*'
 
+Captive/RSpec/NoDbInUnitSpecs:
+  Description: 'Do not hit the database in unit tests. Use `instance_double` or `Model.new` instead. If testing a scope, move to spec/integration.'
+  Enabled: true
+  Include:
+    - 'spec/**/*'
+  AllowedPaths:
+    - 'spec/requests'
+    - 'spec/system'
+    - 'spec/features'
+    - 'spec/integration'
+    - 'spec/factories'
+    - 'spec/services'
+    - 'spec/jobs'
+    - 'spec/support'
+
 # Rails
 Captive/Rails/AfterCommitNotAllowed:
   Description: "Interdit l'utilisation de `after_commit` dans les modèles Rails."

data/lib/rubocop/captive/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Captive
-    VERSION = "2.2.1"
+    VERSION = "2.3.1"
   end
 end

data/lib/rubocop/cop/captive/rspec/no_db_in_unit_specs.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Captive
+      module RSpec
+        # Do not create database records in unit tests.
+        # Use `build`, `instance_double`, or stubs instead.
+        class NoDbInUnitSpecs < Base
+          MSG =
+            "Do not hit the database in unit tests. " \
+            "Use `instance_double` or `Model.new` instead. " \
+            "If testing a scope, move to spec/integration."
+
+          DEFAULT_ALLOWED_PATHS = %w[
+            spec/requests spec/system spec/features spec/integration
+            spec/factories spec/services spec/jobs spec/support
+          ].freeze
+
+          def_node_matcher :factory_bot_db?, <<~PATTERN
+            (send (const nil? :FactoryBot) {:create :create_list :create_pair :build :build_list :build_pair :build_stubbed :build_stubbed_list} ...)
+          PATTERN
+
+          def_node_matcher :standalone_factory_bot_db?, <<~PATTERN
+            (send nil? {:create :create_list :create_pair :build :build_list :build_pair :build_stubbed :build_stubbed_list} ...)
+          PATTERN
+
+          def_node_matcher :ar_create?, <<~PATTERN
+            (send (const nil? _) {:create :create!} ...)
+          PATTERN
+
+          def_node_matcher :ar_save?, <<~PATTERN
+            (send _ {:save :save!} ...)
+          PATTERN
+
+          def on_send(node)
+            return unless unit_spec?
+            return unless db_creation?(node)
+
+            add_offense(node)
+          end
+
+          private
+
+          def unit_spec?
+            path = processed_source.path
+            return false unless path&.include?("spec/")
+
+            allowed_paths.none? { |allowed| path.include?(allowed) }
+          end
+
+          def allowed_paths
+            cop_config.fetch("AllowedPaths", DEFAULT_ALLOWED_PATHS)
+          end
+
+          def db_creation?(node)
+            factory_bot_db?(node) ||
+              standalone_factory_bot_db?(node) ||
+              ar_create?(node) ||
+              ar_save?(node)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-config-captive
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.3.1
 platform: ruby
 authors:
 - Captive
@@ -202,6 +202,7 @@ files:
 - lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb
 - lib/rubocop/cop/captive/rails/no_float_price_columns.rb
 - lib/rubocop/cop/captive/rails/no_has_many_attached.rb
+- lib/rubocop/cop/captive/rspec/no_db_in_unit_specs.rb
 - lib/rubocop/cop/captive/rspec/specify_before_parameter.rb
 - lib/rubocop/cop/captive/string_where_in_scope.rb
 - lib/rubocop/cop/captive/translation/devise_i18n_presence.rb