rubocop-config-captive 1.9.6 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 741c24b633f81291d5b575d59f69b844eabf757c75223099e7cd62c2b085a00e
-  data.tar.gz: bc022c9756db6b3a7e6be355ca25abb9d5f1b4e2b6d9e781e752ca140933a2a2
+  metadata.gz: ec090335cc21d999869f452a9a6b9b4cfe5dc6fa0a54b056c7d9bfd4ac5b50ee
+  data.tar.gz: d117c41479893741eb461de0036b9bc617e07a27a2b1f5faaa1244f180bfa52c
 SHA512:
-  metadata.gz: 3e4e204bc7a701a78c193577791663f4fb06a1792b9c303596b57e45069a5f026c82da3b76f9e90fb8602bbb7a0e61c154e137e941336ad9dc3ce3c0b54d5c3a
-  data.tar.gz: 7cb13eb1313990a92cbe65c73783b5de9e08f60a6c15a53eee82a0939e59d8d0b32c2e23ba7477a42fffca5337609a5d4225aed4c74fb1b92ae8c88205baddc8
+  metadata.gz: '058a5f90001f073c9bb595a0dc14ed402f5e03640181ec849e24120cf29ed87d0417e4721f61df67a83087d7e23c65fdf3b9258691da16fc8ab617362a18e263'
+  data.tar.gz: 3b67894e5523a7b7a45d7fd748caf54f05b184217c42a52197ab0a482f153b1de5801d807aa1bc4c434a1c12e21ed394c72ef4bc6fafeb4c223c10d9c03282a9

data/config/rubocop-magic_numbers.yml

@@ -7,6 +7,7 @@ MagicNumbers/NoArgument:
     - 0
     - -1
     - 1
+    - 100
   Exclude:
     - '**/spec/**/*.rb'
     - '**/test/**/*.rb'

data/lib/rubocop/captive/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   module Captive
     # Version information for the the Airbnb RuboCop plugin.
-    VERSION = "1.9.6"
+    VERSION = "1.10.0"
   end
 end

data/lib/rubocop/cop/captive/rails/force_ssl_enabled_in_production.rb

@@ -16,17 +16,15 @@ module RuboCop
           extend AutoCorrector
 
           MSG = "force_ssl should be enabled in production."
+          GOOD_PRACTICE = "ENV[\"SKIP_FORCE_SSL\"].blank?"
 
           def on_send(node)
             if setting_force_ssl_not_true?(node)
               add_offense(node, message: MSG) do |corrector|
-                # Replace with 'true' only if the argument is not already 'true'
-                unless node.arguments.first.true_type?
-                  corrector.replace(
-                    node.arguments.first.source_range,
-                    "true"
-                  )
-                end
+                corrector.replace(
+                  node.arguments.first.source_range,
+                  GOOD_PRACTICE
+                )
               end
             end
           end
@@ -40,14 +38,25 @@ module RuboCop
           private
 
           def setting_force_ssl_not_true?(node)
-            node.method_name == :force_ssl= && !node.arguments.first.true_type?
+            node.method_name == :force_ssl= && node.arguments != [
+              s(
+                :send,
+                s(
+                  :send,
+                  s(:const, nil, :ENV),
+                  :[],
+                  s(:str, "SKIP_FORCE_SSL")
+                ),
+                :blank?
+              ),
+            ]
           end
 
           def check_comment(comment)
             return unless force_ssl_commented?(comment.text)
 
             add_offense(comment.loc.expression, message: MSG) do |corrector|
-              corrector.replace(comment.loc.expression, "config.force_ssl = true")
+              corrector.replace(comment.loc.expression, "config.force_ssl = #{GOOD_PRACTICE}")
             end
           end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-config-captive
 version: !ruby/object:Gem::Version
-  version: 1.9.6
+  version: 1.10.0
 platform: ruby
 authors:
 - Captive
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-11-15 00:00:00.000000000 Z
+date: 2023-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop