rubocop-config-captive 1.12.0 → 1.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e81a471fa3598969b05e170d8e0c4306d92e23c3cbd94004a04fe5b158974ce
-  data.tar.gz: 22035f11b13c2d090985a2ae076f79622e6ab2924db3010283539a4a96fb2b25
+  metadata.gz: f99323665b07ddee16ef287c37c3d3d0e8e69976e81534b10880bf7b6a4a0e6c
+  data.tar.gz: 1e0355369871f031e909e215203e82b25454ba3f9b81f10fe97232c74dcdeae4
 SHA512:
-  metadata.gz: e5e5960449fab282489dd89f18d7d0c4d03aafb413c64144519d2009ba811587f18c3a158da27349ad435976f8608c7e7eab6942a22e3f31e8caacdc9ba14440
-  data.tar.gz: 743c84ce65acf593a6a11d7712a451f53a096545686d61a1f42428553dc9ad6d7eff7f5d24a28dad80b7fd84c4913d7bd33a3ce59c6c8ef6e589e81d42cd7338
+  metadata.gz: 6b070046a311cb2e15df47754629a427020cf3f3b88f7fe8d486ceb4af79083988ed8134efcd5bd11451201b6beb1d5078f5e89c973b8f4b133b7b338ea35999
+  data.tar.gz: 964cf6b224d95f54b23c7dbfb4767734945f6621d935c69e4d5e51e03ba069d530ab38f9dce2f2869e7894aca1cb07416d653e906fd83c0c4f9b4550eeeb7fb7

data/config/rubocop-captive.yml

@@ -8,6 +8,7 @@ require:
   - ../lib/rubocop/cop/captive/rails/migration_methods.rb
   - ../lib/rubocop/cop/captive/rails/no_email_from_controller.rb
   - ../lib/rubocop/cop/captive/rails/no_float_price_columns.rb
+  - ../lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb
   - ../lib/rubocop/cop/captive/string_where_in_scope.rb
   - ../lib/rubocop/cop/captive/no_app_env.rb
 
@@ -39,30 +40,31 @@ Captive/RSpec/SpecifyBeforeParameter:
   Include:
     - 'spec/**/*'
 
-# Rails
 Captive/Rails/ForceSslEnabledInProduction:
   Description: "Ensures SSL is forced in production, so that secure cookies are used."
   Include:
     - 'config/environments/production.rb'
 
-# Rails
 Captive/Rails/MigrationMethods:
   Description: "Avoid using ActiveRecord::Migration methods in `up` and `down` methods. Use `change` instead."
   Include:
     - 'db/migrate/**/*'
 
-# Rails
 Captive/Rails/NoEmailFromController:
   Description: "Do not send emails from controllers. Because it doesn't follow the MVC standard"
   Include:
     - 'app/controllers/**/*'
 
-# Rails
 Captive/Rails/NoFloatPriceColumns:
   Description: "Avoid using `float` type for price columns. Use `decimal, precision: 10, scale: 2` instead."
   Include:
     - 'db/migrate/**/*'
 
+Captive/Rails/NoFindByInScope:
+  Description: "Avoid using `find_by` in a scope. Use `where` to return a collection or define a class method if you need a single record."
+  Include:
+    - 'app/models/**/*'
+
 # other
 Captive/StringWhereInScope:
   Description: 'The `where` method should be used in a scope in a model.'

data/lib/rubocop/captive/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   module Captive
     # Version information for the the Airbnb RuboCop plugin.
-    VERSION = "1.12.0"
+    VERSION = "1.16.1"
   end
 end

data/lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Captive
+      module Rails
+        # Avoid using `find_by` in a scope. Use `where` to return a collection or define a class method if you need a single record.
+        #
+        # @see https://stackoverflow.com/questions/31329554/find-by-inside-a-scope-is-firing-2-queries
+        class NoFindByInScope < RuboCop::Cop::Cop
+          MSG = "Avoid using `find_by` in a scope. Use `where` to return \
+            a collection or define a class method if you need a single record."
+
+          def_node_matcher :find_by_in_scope?, <<~PATTERN
+            (block
+              (send nil? :scope ...)
+              (args ...)
+              (send nil? :find_by ...))
+          PATTERN
+
+          def on_block(node)
+            find_by_in_scope?(node) do
+              add_offense(node, message: MSG)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/rubocop-config-captive.gemspec

@@ -25,14 +25,14 @@ Gem::Specification.new do |gem|
   # ⚠️ Instead of depending on rubocop-airbnb we copy sources
   #
   # gem.add_dependency('rubocop-airbnb', '~> 4.0.0')
-  gem.add_dependency("rubocop", "~> 1.51.0")
-  gem.add_dependency("rubocop-performance", "~> 1.17.1 ")
+  gem.add_dependency("rubocop", "~> 1.69.2")
+  gem.add_dependency("rubocop-performance", "~> 1.23.0 ")
   gem.add_dependency("rubocop-rake", "~> 0.6.0")
-  gem.add_dependency("rubocop-rails", "~> 2.18.0")
-  gem.add_dependency("rubocop-rspec", "~> 2.22.0")
-  gem.add_dependency("rubocop-capybara", "~> 2.18.0")
-  gem.add_dependency("rubocop-factory_bot", "~> 2.23.1")
-  gem.add_dependency("rubocop-magic_numbers", "~> 0.4.0")
+  gem.add_dependency("rubocop-rails", "~> 2.27.0")
+  gem.add_dependency("rubocop-rspec", "~> 3.3.0")
+  gem.add_dependency("rubocop-capybara", "~> 2.21.0")
+  gem.add_dependency("rubocop-factory_bot", "~> 2.26.1")
+  gem.add_dependency("rubocop-magic_numbers", "~> 0.5.0")
   gem.add_development_dependency("rspec", "~> 3.12")
   # gem.metadata['rubygems_mfa_required'] = 'true'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-config-captive
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.16.1
 platform: ruby
 authors:
 - Captive
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-07-16 00:00:00.000000000 Z
+date: 2024-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,28 +18,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.51.0
+        version: 1.69.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.51.0
+        version: 1.69.2
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.17.1
+        version: 1.23.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.17.1
+        version: 1.23.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -60,70 +60,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.18.0
+        version: 2.27.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.18.0
+        version: 2.27.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.22.0
+        version: 3.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.22.0
+        version: 3.3.0
 - !ruby/object:Gem::Dependency
   name: rubocop-capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.18.0
+        version: 2.21.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.18.0
+        version: 2.21.0
 - !ruby/object:Gem::Dependency
   name: rubocop-factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.23.1
+        version: 2.26.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.23.1
+        version: 2.26.1
 - !ruby/object:Gem::Dependency
   name: rubocop-magic_numbers
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -187,6 +187,7 @@ files:
 - lib/rubocop/cop/captive/rails/force_ssl_enabled_in_production.rb
 - lib/rubocop/cop/captive/rails/migration_methods.rb
 - lib/rubocop/cop/captive/rails/no_email_from_controller.rb
+- lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb
 - lib/rubocop/cop/captive/rails/no_float_price_columns.rb
 - lib/rubocop/cop/captive/rspec/specify_before_parameter.rb
 - lib/rubocop/cop/captive/string_where_in_scope.rb