rubocop-config-captive 1.11.0 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d97b68d10ca94ef35962dc273c1157d64839ac6b2fced7c99aed0f07f5eb4a7
-  data.tar.gz: c98e237061db822fc35993bc780260340eb59bcae41b3cd252d04025effa8216
+  metadata.gz: b503af1733f071e5c225a59a847816f26d0875946d448922b6cc3b2a2ae6d9f2
+  data.tar.gz: e20df47f5ee50dc31edebc772837db84d83041bc6c825fa10e1cbf5c3c0f30d8
 SHA512:
-  metadata.gz: 87ded8aca4ebc42f5eff1ff4bc5aa57c7f3289d02ba1f95c7b08b46f8ecd75927ffe49aa127d3f0066f004f6c5b81969a30f2137960e607c70c7b43230e74b83
-  data.tar.gz: aa6036eeabf88151a60b912c0d805e1bbcedcfb36bf5e80d07c0ad5b4b6e55c98c3fc6fe7427e7ede5939657f5050d0227d5d6ac0698b4c6630118edd9ea38fa
+  metadata.gz: 462270c228e9abb16e6a204bcbd35f46051e71343688333b968ac2e3b347ed344c160d150ba4f58a0adcb56527db72067ae96810964164321c1d2f474aaaa1a6
+  data.tar.gz: 4aa2cad847ffb5f47859cd15288693cfa0bfb5fbd20eb2adc56689e181e65099aa393b181367c5ceb9d8813405739842c2c3e5e517a442b804f570fd12c3a490

data/config/rubocop-captive.yml

@@ -7,6 +7,8 @@ require:
   - ../lib/rubocop/cop/captive/rails/force_ssl_enabled_in_production.rb
   - ../lib/rubocop/cop/captive/rails/migration_methods.rb
   - ../lib/rubocop/cop/captive/rails/no_email_from_controller.rb
+  - ../lib/rubocop/cop/captive/rails/no_float_price_columns.rb
+  - ../lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb
   - ../lib/rubocop/cop/captive/string_where_in_scope.rb
   - ../lib/rubocop/cop/captive/no_app_env.rb
 
@@ -38,24 +40,31 @@ Captive/RSpec/SpecifyBeforeParameter:
   Include:
     - 'spec/**/*'
 
-# Rails
 Captive/Rails/ForceSslEnabledInProduction:
   Description: "Ensures SSL is forced in production, so that secure cookies are used."
   Include:
     - 'config/environments/production.rb'
 
-# Rails
 Captive/Rails/MigrationMethods:
   Description: "Avoid using ActiveRecord::Migration methods in `up` and `down` methods. Use `change` instead."
   Include:
     - 'db/migrate/**/*'
 
-# Rails
 Captive/Rails/NoEmailFromController:
   Description: "Do not send emails from controllers. Because it doesn't follow the MVC standard"
   Include:
     - 'app/controllers/**/*'
 
+Captive/Rails/NoFloatPriceColumns:
+  Description: "Avoid using `float` type for price columns. Use `decimal, precision: 10, scale: 2` instead."
+  Include:
+    - 'db/migrate/**/*'
+
+Captive/Rails/NoFindByInScope:
+  Description: "Avoid using `find_by` in a scope. Use `where` to return a collection or define a class method if you need a single record."
+  Include:
+    - 'app/models/**/*'
+
 # other
 Captive/StringWhereInScope:
   Description: 'The `where` method should be used in a scope in a model.'

data/lib/rubocop/captive/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   module Captive
     # Version information for the the Airbnb RuboCop plugin.
-    VERSION = "1.11.0"
+    VERSION = "1.13.0"
   end
 end

data/lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Captive
+      module Rails
+        # Avoid using `find_by` in a scope. Use `where` to return a collection or define a class method if you need a single record.
+        class NoFindByInScope < RuboCop::Cop::Cop
+          MSG = "Avoid using `find_by` in a scope. Use `where` to return \
+            a collection or define a class method if you need a single record."
+
+          def_node_matcher :find_by_in_scope?, <<~PATTERN
+            (block
+              (send nil? :scope ...)
+              (args ...)
+              (send nil? :find_by ...))
+          PATTERN
+
+          def on_block(node)
+            find_by_in_scope?(node) do
+              add_offense(node, message: MSG)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/captive/rails/no_float_price_columns.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Captive
+      module Rails
+        class NoFloatPriceColumns < Base
+          MSG = "Avoid using `float` type for price columns. \
+            Use `decimal, precision: 10, scale: 2` instead."
+
+          def_node_matcher :add_column_call?, <<~PATTERN
+            (send nil? :add_column _ $(sym {:price :prix}) (sym :float) ...)
+          PATTERN
+
+          def on_send(node)
+            add_column_call?(node) do |column|
+              add_offense(column, message: MSG)
+            end
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-config-captive
 version: !ruby/object:Gem::Version
-  version: 1.11.0
+  version: 1.13.0
 platform: ruby
 authors:
 - Captive
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-02-14 00:00:00.000000000 Z
+date: 2024-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -187,6 +187,8 @@ files:
 - lib/rubocop/cop/captive/rails/force_ssl_enabled_in_production.rb
 - lib/rubocop/cop/captive/rails/migration_methods.rb
 - lib/rubocop/cop/captive/rails/no_email_from_controller.rb
+- lib/rubocop/cop/captive/rails/no_find_by_in_scope.rb
+- lib/rubocop/cop/captive/rails/no_float_price_columns.rb
 - lib/rubocop/cop/captive/rspec/specify_before_parameter.rb
 - lib/rubocop/cop/captive/string_where_in_scope.rb
 - lib/rubocop/cop/captive/translation/devise_i18n_presence.rb
@@ -212,7 +214,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
 summary: Shared rubocop configurations