rubocop-config-captive 1.10.0 → 1.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec090335cc21d999869f452a9a6b9b4cfe5dc6fa0a54b056c7d9bfd4ac5b50ee
-  data.tar.gz: d117c41479893741eb461de0036b9bc617e07a27a2b1f5faaa1244f180bfa52c
+  metadata.gz: 9e81a471fa3598969b05e170d8e0c4306d92e23c3cbd94004a04fe5b158974ce
+  data.tar.gz: 22035f11b13c2d090985a2ae076f79622e6ab2924db3010283539a4a96fb2b25
 SHA512:
-  metadata.gz: '058a5f90001f073c9bb595a0dc14ed402f5e03640181ec849e24120cf29ed87d0417e4721f61df67a83087d7e23c65fdf3b9258691da16fc8ab617362a18e263'
-  data.tar.gz: 3b67894e5523a7b7a45d7fd748caf54f05b184217c42a52197ab0a482f153b1de5801d807aa1bc4c434a1c12e21ed394c72ef4bc6fafeb4c223c10d9c03282a9
+  metadata.gz: e5e5960449fab282489dd89f18d7d0c4d03aafb413c64144519d2009ba811587f18c3a158da27349ad435976f8608c7e7eab6942a22e3f31e8caacdc9ba14440
+  data.tar.gz: 743c84ce65acf593a6a11d7712a451f53a096545686d61a1f42428553dc9ad6d7eff7f5d24a28dad80b7fd84c4913d7bd33a3ce59c6c8ef6e589e81d42cd7338

data/README.md

@@ -110,3 +110,18 @@ To contribute, here are some inspirations for good configurations :
 [license-image]: https://img.shields.io/badge/license-MIT-green.svg?style=flat-square
 <!-- AUTO-GENERATED-CONTENT:END -->
 [license-url]: ./LICENSE
+
+About Captive
+-------------
+
+![captive](https://raw.githubusercontent.com/Captive-Studio/assets/main/logo_captive_blue_avec_fond.webp)
+
+rubocop-config-captive is maintained and funded by Captive.
+The names and logos for captive are trademarks of captive-studio.
+
+We love open source software!
+See [our other projects][community] or
+[hire us][hire] to design, develop, and grow your product.
+
+[community]: https://github.com/Captive-Studio
+[hire]: https://www.captive.fr/contact?utm_source=github

data/config/rubocop-captive.yml

@@ -4,8 +4,10 @@ require:
   - ../lib/rubocop/cop/captive/translation/rails_i18n_presence.rb
   - ../lib/rubocop/cop/captive/translation/kaminari_i18n_presence.rb
   - ../lib/rubocop/cop/captive/rspec/specify_before_parameter.rb
-  - ../lib/rubocop/cop/captive/rails/no_email_from_controller.rb
   - ../lib/rubocop/cop/captive/rails/force_ssl_enabled_in_production.rb
+  - ../lib/rubocop/cop/captive/rails/migration_methods.rb
+  - ../lib/rubocop/cop/captive/rails/no_email_from_controller.rb
+  - ../lib/rubocop/cop/captive/rails/no_float_price_columns.rb
   - ../lib/rubocop/cop/captive/string_where_in_scope.rb
   - ../lib/rubocop/cop/captive/no_app_env.rb
 
@@ -37,6 +39,18 @@ Captive/RSpec/SpecifyBeforeParameter:
   Include:
     - 'spec/**/*'
 
+# Rails
+Captive/Rails/ForceSslEnabledInProduction:
+  Description: "Ensures SSL is forced in production, so that secure cookies are used."
+  Include:
+    - 'config/environments/production.rb'
+
+# Rails
+Captive/Rails/MigrationMethods:
+  Description: "Avoid using ActiveRecord::Migration methods in `up` and `down` methods. Use `change` instead."
+  Include:
+    - 'db/migrate/**/*'
+
 # Rails
 Captive/Rails/NoEmailFromController:
   Description: "Do not send emails from controllers. Because it doesn't follow the MVC standard"
@@ -44,10 +58,10 @@ Captive/Rails/NoEmailFromController:
     - 'app/controllers/**/*'
 
 # Rails
-Captive/Rails/ForceSslEnabledInProduction:
-  Description: "Ensures SSL is forced in production, so that secure cookies are used."
+Captive/Rails/NoFloatPriceColumns:
+  Description: "Avoid using `float` type for price columns. Use `decimal, precision: 10, scale: 2` instead."
   Include:
-    - 'config/environments/production.rb'
+    - 'db/migrate/**/*'
 
 # other
 Captive/StringWhereInScope:

data/config/rubocop-magic_numbers.yml

@@ -27,13 +27,7 @@ MagicNumbers/NoAssignment:
     - '**/config/**/*'
 
 MagicNumbers/NoDefault:
-  Enabled: true
-  Exclude:
-    - '**/spec/**/*.rb'
-    - '**/test/**/*.rb'
-    - '**/*_spec.rb'
-    - '**/*_test.rb'
-    - '**/config/**/*'
+  Enabled: false
 
 MagicNumbers/NoReturn:
   Enabled: true

data/config/rubocop-rspec.yml

@@ -13,3 +13,19 @@ RSpec/ScatteredSetup:
 RSpec/RepeatedExample:
   Exclude:
     - 'spec/requests/**/*'
+
+RSpec/ContextWording:
+  Enabled: true
+  Prefixes:
+    - when
+    - with
+    - without
+    - if
+    - unless
+    - for
+    - quand
+    - avec
+    - sans
+    - si
+    - sauf si
+    - pour

data/lib/rubocop/captive/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   module Captive
     # Version information for the the Airbnb RuboCop plugin.
-    VERSION = "1.10.0"
+    VERSION = "1.12.0"
   end
 end

data/lib/rubocop/cop/captive/rails/migration_methods.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Captive
+      module Rails
+        ##
+        # This cop ensures the use `change` method when is possible.
+        #
+        # Il est possible d'utiliser la méthode `change` lors de l'utilisation de méthode de ActiveRecord::Migration tel que : `remove_column`, `add_column`, `add_index`, ...
+        # La méthode gère automatiquement le UP et le DOWN.
+        # Il n'est donc pas nécéssaire définir le `def up` et `def down` seulement lors d'une migration de donnée
+        #
+        # @example
+        #   # bad
+        #   def up
+        #     remove_column :table, :column, :type
+        #   end
+        #
+        #   def down
+        #     add_column :table, :column, :type
+        #   end
+        #
+        #   # good
+        #   def change
+        #     remove_column :table, :column, :type
+        #   end
+        #
+        # @see https://git.captive.fr/captive/iris-galerie/iris-platform/-/merge_requests/676#note_186669
+        class MigrationMethods < Base
+          MSG = "Avoid using ActiveRecord::Migration methods in `up` and `down` methods. \
+            Use `change` instead."
+
+          BLACKLISTED_METHODS = %i(
+            add_column
+            add_foreign_key
+            add_index
+            add_reference
+            add_timestamps
+            change_column
+            change_table
+            create_table
+            create_join_table
+            drop_table
+            remove_column
+            remove_foreign_key
+            remove_index
+            remove_reference
+            remove_timestamps
+            rename_column
+            rename_index
+            rename_table
+          ).freeze
+
+          def_node_search :migration_method?, <<~PATTERN
+            (send nil? {#{BLACKLISTED_METHODS.map(&:inspect).join(" ")}} ...)
+          PATTERN
+
+          def on_def(node)
+            return unless %i(up down).include?(node.method_name)
+            return unless migration_method?(node)
+
+            add_offense(node, message: MSG)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/captive/rails/no_float_price_columns.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Captive
+      module Rails
+        class NoFloatPriceColumns < Base
+          MSG = "Avoid using `float` type for price columns. \
+            Use `decimal, precision: 10, scale: 2` instead."
+
+          def_node_matcher :add_column_call?, <<~PATTERN
+            (send nil? :add_column _ $(sym {:price :prix}) (sym :float) ...)
+          PATTERN
+
+          def on_send(node)
+            add_column_call?(node) do |column|
+              add_offense(column, message: MSG)
+            end
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-config-captive
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.12.0
 platform: ruby
 authors:
 - Captive
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-11-20 00:00:00.000000000 Z
+date: 2024-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -185,7 +185,9 @@ files:
 - lib/rubocop/cop/captive/active_admin/active_admin_addons_presence.rb
 - lib/rubocop/cop/captive/no_app_env.rb
 - lib/rubocop/cop/captive/rails/force_ssl_enabled_in_production.rb
+- lib/rubocop/cop/captive/rails/migration_methods.rb
 - lib/rubocop/cop/captive/rails/no_email_from_controller.rb
+- lib/rubocop/cop/captive/rails/no_float_price_columns.rb
 - lib/rubocop/cop/captive/rspec/specify_before_parameter.rb
 - lib/rubocop/cop/captive/string_where_in_scope.rb
 - lib/rubocop/cop/captive/translation/devise_i18n_presence.rb
@@ -211,7 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
 summary: Shared rubocop configurations