rubocop-codetakt 0.82.0.0 → 0.85.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ce6c7a74ef3e10599646185d4cdb5f24e9b7c28a642dab9fcd991320eb0a266
-  data.tar.gz: 9c5ba3dc1a0cb4ee4a3573fc3d94ad0f18dcbf5b0920690a6335cb57604e3bd2
+  metadata.gz: 99b0b2dbfa491efc42fd10b008e04a0b60e82d81cd558515e3f1b2f4ca6bb1ef
+  data.tar.gz: 84d39918e20a3d2e71365ce670cca7046b1a2cb9050d0c0c81ae5f73b41d6658
 SHA512:
-  metadata.gz: 758dda084a7a4ee3463c853642c706fea238a7375c936b5ca36cc2a2a3661df1d87bb37442dae25509c13558cc4844fc8a2d45f62489b6f2818f7958041cfe9a
-  data.tar.gz: c1941541ff7a5b8a3f605e3de6732ddad53f55e6a171e548b4da5ad809afb478f456370ac458ba765e4d249314473e8ff82bd180ba7e66f75b3364a6532c6ac9
+  metadata.gz: 428cd71860e50467b9e05a7fc5f9525c0582220d5a11ec1459d31ba8240a92e0a28df1224edbe175555fc17b53874c0f61c95f70d59a984bf8556127b2687e60
+  data.tar.gz: 278c4702a98046c804437db704bf027bad59fe666124aee9971142bd49845796eeb39943cb9e8812b2f9562887b9bd107efc3cc1b4530bc4a33fc678a24f914f

data/.rubocop.yml

@@ -1,12 +1,4 @@
-inherit_gem:
-  rubocop-codetakt:
-    - "config/rubocop.yml"
-    # uncomment if use performance cops
-    - "config/performance.yml"
-    # uncomment if use rails cops
-    - "config/rails.yml"
-    # uncomment if use rspec cops
-    - "config/rspec.yml"
-
-AllCops:
-  TargetRubyVersion: 2.5
+inherit_from:
+  - "config/rubocop.yml"
+  - "config/performance.yml"
+  - "config/rspec.yml"

data/CHANGELOG.md

@@ -1,13 +1,36 @@
 # rubocop-codetakt:
 
+## v0.85.0.0 (2020-06-04)
+
+* Update `rubocop` v0.85.0
+
+## v0.84.0.0 (2020-06-04)
+
+* Update `rubocop` v0.84.0, `rubocop-rspec` v1.39.0, `rubocop-rails` v2.5.0 and `rubocop-performance` v1.6.0
+* Clarify `Layout/HashAlignment` cop option
+
+## v0.83.0.1 (2020-06-03)
+
+* Disable `RSpec/MultipleExpectations:` cop
+
+## v0.83.0.0 (2020-05-18)
+
+* Update `rubocop` v0.83.0
+
+## v0.82.0.1 (2020-06-01)
+
+* Make the code in this repository to no offenses
+* Accept the default setting of new cops
+
 ## v0.82.0.0 (2020-04-20)
 
 * Fork from onk/onkcop to codetakt/rubocop-codetakt
+* Update `rubocop` v0.82.0, `rubocop-rspec` v1.38.0, `rubocop-rails` v2.5.0 and `rubocop-performance` v1.5.0
 * Follow upstream renamings
 * Separate the file of performance settings
 * Clarify requiring the `rubocop-rails` gem in the Rails settings file
 * Refine dependency settings
-* Remove `Layout/DotPosition` cop'
+* Remove `Layout/DotPosition` cop
 * Remove `Layout/IndentationConsistency` cop
 * Remove `Style/BracesAroundHashParameters` cop
 * Remove `Style/MethodCalledOnDoEndBlock`
@@ -65,7 +88,7 @@
 * Update `rubocop` v0.52.0 and `rubocop-rspec` v1.21.0
 * Remove `DisplayCopNames` configuration
 * Enable new `Style/ClassStructure` cop
-* Disalbe `Style/FormatStringToken` cop
+* Disable `Style/FormatStringToken` cop
 * Change `Layout/SpaceBeforeBlockBraces` cop's empty braces style to `space`
 * Change `Style/RescueStandardError` cop to implicit style
 * Change `RSpec/MultipleExpectations` cop to `AggregateFailuresByDefault` style

data/Gemfile

@@ -1,10 +1,10 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rubocop-codetakt.gemspec
 gemspec
 
-gem "rake", "~> 12.0"
-gem "rspec", "~> 3.0"
-gem "rubocop-performance", "~> 1.5.0"
-gem "rubocop-rails", "~> 2.5.0"
-gem "rubocop-rspec", "~> 1.38.0"
+gem 'rake', '~> 13.0'
+gem 'rspec', '~> 3.0'
+gem 'rubocop-performance', '~> 1.6.0'
+gem 'rubocop-rails', '~> 2.5.0'
+gem 'rubocop-rspec', '~> 1.39.0'

data/Rakefile

@@ -1,4 +1,4 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:rspec)
 task :default => [:rspec]

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "rubocop_codetakt"
+require 'bundler/setup'
+require 'rubocop_codetakt'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "rubocop_codetakt"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/config/rspec.yml

@@ -40,14 +40,12 @@ RSpec/ImplicitExpect:
 RSpec/InstanceVariable:
   Enabled: false
 
-# spec_helper で meta[:aggregate_failures] を設定することで
-# aggregate_failures が全ての spec で有効になる。
-#
-# ほぼ MultipleExpectations についてはチェックされなくなる設定なので注意。
-# パフォーマンスの問題さえ無ければ 1 example 1 assertion にしておく方が
-# 読みやすいテストになりやすいので、そこはレビューで担保していく必要がある。
+# rubocop-rspec v1.34.0 から RSpec/MultipleExpectations の AggregateFailuresByDefault オプションがなくなった
+# https://github.com/rubocop-hq/rubocop-rspec/blob/v1.34.0/CHANGELOG.md
+# feature specなどでは1つのitに複数のexpectをよく書く
+# 弊社ではaggregate_failuresをデフォルトで有効にしているのでこのCopをoffにする
 RSpec/MultipleExpectations:
-  AggregateFailuresByDefault: true
+  Enabled: false
 
 # 変に名前つけて呼ぶ方が分かりづらい。
 # テスト対象メソッドを呼ぶだけの subject 以外を書かないようにする方が効く。

data/config/rubocop.yml

@@ -1,5 +1,9 @@
-# 自動生成されるものはチェック対象から除外する
 AllCops:
+  # We accept the default setting of rookie cops.
+  # https://docs.rubocop.org/rubocop/versioning.html
+  NewCops: enable
+
+  # Exclude automatically generated files.
   Exclude:
     - "node_modules/**/*" # rubocop config/default.yml
     - "vendor/**/*"       # rubocop config/default.yml
@@ -31,6 +35,15 @@ Layout/FirstArrayElementIndentation:
 Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
+# We have decided to accept the default options of this cop (as of
+# RuboCop v0.83.0.) These are certainly useful in many situations.
+# However, any product team has the discretion to locally disable this
+# cop.
+Layout/HashAlignment:
+  EnforcedHashRocketStyle: key
+  EnforcedColonStyle: key
+  EnforcedLastArgumentHashStyle: always_inspect
+
 # * 警告 120文字
 # * 禁止 160文字
 # のイメージ
@@ -139,6 +152,13 @@ Metrics/PerceivedComplexity:
 
 #################### Naming ################################
 
+# 3 文字未満だと指摘されるが、未使用を示す _ や e(rror), b(lock),
+# n(umber) といった 1 文字変数は頻出するし、前置詞(by, to, ...)や
+# よく知られた省略語 (op: operator とか pk: primary key とか) も妥当。
+# 変数 s にどんな文字列かを形容したい場合と、不要な場合とがある＝無効
+Naming/MethodParameterName:
+  Enabled: false
+
 # has_ から始まるメソッドは許可する
 Naming/PredicateName:
   ForbiddenPrefixes:
@@ -148,13 +168,6 @@ Naming/PredicateName:
     - "is_"
     - "have_"
 
-# 3 文字未満だと指摘されるが、未使用を示す _ や e(rror), b(lock),
-# n(umber) といった 1 文字変数は頻出するし、前置詞(by, to, ...)や
-# よく知られた省略語 (op: operator とか pk: primary key とか) も妥当。
-# 変数 s にどんな文字列かを形容したい場合と、不要な場合とがある＝無効
-Naming/MethodParameterName:
-  Enabled: false
-
 #################### Security ##############################
 
 # 毎回 YAML.safe_load(yaml_str, [Date, Time]) するのは面倒で。。

data/exe/rubocop-codetakt

@@ -1,10 +1,10 @@
 #!/usr/bin/env ruby
 
-$LOAD_PATH.unshift File.dirname(__FILE__) + "/../lib"
+$LOAD_PATH.unshift File.dirname(__FILE__) + '/../lib'
 
 # Exit cleanly from an early interrupt
-Signal.trap("INT") { exit 1 }
+Signal.trap('INT') { exit 1 }
 
-require "rubocop_codetakt"
+require 'rubocop_codetakt'
 
 RuboCop::Codetakt::CLI.start(ARGV)

data/lib/rubocop/codetakt/cli.rb

@@ -1,4 +1,4 @@
-require "fileutils"
+require 'fileutils'
 
 module RuboCop
   module Codetakt
@@ -26,19 +26,20 @@ module RuboCop
 
       def self.retrieve_command_name(args)
         meth = args.first.to_s unless args.empty?
-        args.shift if meth && (meth !~ /^\-/)
+        args.shift if meth && (meth !~ /^-/)
       end
 
       def self.print_help
-        puts "rubocop-codetakt commands:"
-        puts "  init - Setup .rubocop.yml"
+        puts 'rubocop-codetakt commands:'
+        puts '  init - Setup .rubocop.yml'
       end
 
-      CONFIG_FILE_NAME = ".rubocop.yml"
+      CONFIG_FILE_NAME = '.rubocop.yml'.freeze
       def init(args)
-        raise "usage: rubocop-codetakt init" unless args.empty?
-        template_path = File.expand_path("../../../templates", __dir__)
-        puts "#{File.exist?(CONFIG_FILE_NAME) ? "overwrite" : "create"} #{CONFIG_FILE_NAME}"
+        raise 'usage: rubocop-codetakt init' unless args.empty?
+
+        template_path = File.expand_path('../../../templates', __dir__)
+        puts "#{File.exist?(CONFIG_FILE_NAME) ? 'overwrite' : 'create'} #{CONFIG_FILE_NAME}"
         FileUtils.copy_file(File.join(template_path, CONFIG_FILE_NAME), CONFIG_FILE_NAME)
       end
     end

data/lib/rubocop/codetakt/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module Codetakt
-    VERSION = "0.82.0.0"
+    VERSION = '0.85.0.0'.freeze
   end
 end

data/lib/rubocop_codetakt.rb

@@ -1,2 +1,2 @@
-require "rubocop/codetakt/cli"
-require "rubocop/codetakt/version"
+require 'rubocop/codetakt/cli'
+require 'rubocop/codetakt/version'

data/rubocop-codetakt.gemspec

@@ -1,25 +1,25 @@
-lib = File.expand_path("lib", __dir__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "rubocop/codetakt/version"
+require 'rubocop/codetakt/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "rubocop-codetakt"
+  spec.name          = 'rubocop-codetakt'
   spec.version       = RuboCop::Codetakt::VERSION
-  spec.authors       = ["codeTakt Developers"]
-  spec.email         = ["dev@codetakt.com"]
+  spec.authors       = ['codeTakt Developers']
+  spec.email         = ['dev@codetakt.com']
 
-  spec.summary       = "Unify the coding style of Ruby within codeTakt Inc."
-  spec.description   = <<-EOF
+  spec.summary       = 'Unify the coding style of Ruby within codeTakt Inc.'
+  spec.description   = <<-DESC
     This includes the RuboCop configuration used by codeTakt. It is
     for the unification and linting of coding styles.
-  EOF
-  spec.homepage      = "https://github.com/codetakt/rubocop-codetakt"
-  spec.license       = "MIT"
+  DESC
+  spec.homepage      = 'https://github.com/codetakt/rubocop-codetakt'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject {|f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) {|f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "rubocop", "~> 0.82.0"
+  spec.add_dependency 'rubocop', '~> 0.85.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-codetakt
 version: !ruby/object:Gem::Version
-  version: 0.82.0.0
+  version: 0.85.0.0
 platform: ruby
 authors:
 - codeTakt Developers
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-20 00:00:00.000000000 Z
+date: 2020-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.85.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.85.0
 description: |2
       This includes the RuboCop configuration used by codeTakt. It is
       for the unification and linting of coding styles.