rubocop-checkstyle_formatter 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7328e98e7a75c864321799d69fbc682ea1155b75
-  data.tar.gz: 3e17208c3dd76b641511ae61f13a3d2421c5e865
+  metadata.gz: f2c89d0692283e2b187a79b9a80f2120faceff09
+  data.tar.gz: 35b09c262c40909a7dac4bec096ae0017d9da874
 SHA512:
-  metadata.gz: 5dd962ab890a4ef9796bd7b73fa81fc625800deb0ab02b8a4caabc94c83472174c82d3d81a16cd646daa8fc095f5e641ea2b658f715b2aedc66110cc6299301e
-  data.tar.gz: 136687f0ae7d076062df1d7b6595cc624934a7578925971996b6471edff3dd59d25dc4e65bbdf3c39103a0de2465c9f40764750fb20de85555c484c2e0893b02
+  metadata.gz: 4fcfe89b753ea1f2c71cbe32e84617520518e96c5f647951bf43aff2c5cfafdd9f8665b1287ab21dbd6c82830d324567b35ca716cb941000caa1f5cdad3bc1ed
+  data.tar.gz: dcda42ca02dd7d5dd1115a7f8767f1a3f69f0a2cea963366c9990e8657285a5ad0e586d5d82a845258abeb6887e1a0b81ffff5f04cdec876848a1248889048a7

data/.travis.yml

@@ -0,0 +1,15 @@
+language: ruby
+rvm:
+  - 1.9.2
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - ruby-head
+  - jruby-19mode
+  - rbx-2
+matrix:
+  allow_failures:
+    - rvm: ruby-head
+before_install: gem update --remote bundler
+script:
+  - bundle exec rspec

data/README.md

@@ -3,6 +3,8 @@
 A formatter for rubocop that outputs in checkstyle format.
 It requires rubocop version 0.9.0 or above.
 
+[![Build Status](https://travis-ci.org/eitoball/rubocop-checkstyle_formatter.svg?branch=master)](https://travis-ci.org/eitoball/rubocop-checkstyle_formatter)
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -26,7 +28,7 @@ As a part of build, I execute rubocop as shell script like:
 
     bundle exec rubocop --require rubocop/formatter/checkstyle_formatter --format Rubocop::Formatter::CheckstyleFormatter --no-color --silent --rails --out tmp/checkstyle.xml
 
-Then, after build, I add 'Report Violations' and configure xml filename pattern of checkstyle to "xml/checkstyle.xml".
+Then, after build, I add 'Report Violations' and configure xml filename pattern of checkstyle to "tmp/checkstyle.xml".
 
 ## Contributing
 

data/Rakefile

@@ -1 +1,15 @@
-require "bundler/gem_tasks"
+# encoding: utf-8
+
+require 'bundler'
+require 'bundler/gem_tasks'
+begin
+  Bundler.setup(:default, :development)
+rescue Bundler::BundlerError => e
+  $stderr.puts(e.message)
+  exit(e.status_code)
+end
+require 'rspec/core'
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec) do |spec|
+  spec.pattern = FileList['spec/**/*_spec.rb']
+end

data/lib/rubocop/formatter/checkstyle_formatter.rb

@@ -30,7 +30,7 @@ module Rubocop
           REXML::Element.new('error', parent).tap do |e|
             e.attributes['line'] = offence.line
             e.attributes['column'] = offence.column
-            e.attributes['severity'] = to_checkstyle_severity(offence.severity)
+            e.attributes['severity'] = to_checkstyle_severity(offence.severity.to_s)
             e.attributes['message'] = offence.message
             e.attributes['source'] = 'com.puppycrawl.tools.checkstyle.' + offence.cop_name
           end
@@ -40,10 +40,10 @@ module Rubocop
       # TODO be able to configure severity mapping
       def to_checkstyle_severity(rubocop_severity)
         case rubocop_severity
-        when :fatal, :error; 'error'
-        when :warning; 'warning'
-        when :convention, :refactor; 'info'
-        else; 'warning'
+        when 'fatal', 'error' then 'error'
+        when 'warning' then 'warning'
+        when 'convention', 'refactor' then 'info'
+        else 'warning'
         end
       end
     end

data/rubocop-checkstyle_formatter.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |gem|
   gem.name          = 'rubocop-checkstyle_formatter'
-  gem.version       = '0.0.5'
+  gem.version       = '0.0.6'
   gem.authors       = ['Eito Katagiri']
   gem.email         = ['eitoball@gmail.com']
   gem.description   = %q{A formatter for rubocop that outputs in checkstyle format}
@@ -18,4 +18,7 @@ Gem::Specification.new do |gem|
   gem.require_paths = ['lib']
 
   gem.add_dependency 'rubocop', '>= 0.9.0'
+  gem.add_development_dependency 'bundler', '~> 1.3'
+  gem.add_development_dependency 'rake', '~> 10.1'
+  gem.add_development_dependency 'rspec', '~> 2.14.0'
 end

data/spec/rubocop/formatter/checkstyle_formatter_spec.rb

@@ -0,0 +1,42 @@
+# encoding: utf-8
+require 'spec_helper'
+require 'stringio'
+require 'rexml/document'
+
+module Rubocop
+  module Formatter
+    describe CheckstyleFormatter do
+      let(:severities) { [:refactor, :convention, :warning, :error, :fatal] }
+      let(:cop) do
+        Cop::Cop.new.tap do |c|
+          source_buffer = Parser::Source::Buffer.new('sample.rb', 1).tap { |b| b.source = '' }
+          severities.each_with_index do |severity, index|
+            c.add_offense(severity, Parser::Source::Range.new(source_buffer, 0, index), severity.to_s, severity.to_s)
+          end
+        end
+      end
+      let(:output) { StringIO.new }
+      let(:file) { 'sample.rb' }
+
+      before do
+        formatter = described_class.new(output)
+        formatter.started(file)
+        formatter.file_finished(file, cop.offenses)
+        formatter.finished([file])
+      end
+
+      it 'should convert rubocop severity to checkstyle severity' do
+        doc = REXML::Document.new(output.string)
+        REXML::XPath.match(doc, '/checkstyle/file/error').each do |error|
+          message = error.attribute('message').value
+          severity = error.attribute('severity').value
+          case message
+          when 'refactor', 'convention'; expect(severity).to eq('info')
+          when 'warning'; expect(severity).to eq('warning')
+          when 'error', 'fatal'; expect(severity).to eq('error')
+          end
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,6 @@
+# encoding: utf-8
+
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), *%w{ .. lib }))
+require 'rspec'
+require 'rubocop'
+require 'rubocop/formatter/checkstyle_formatter'

metadata

@@ -1,29 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-checkstyle_formatter
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Eito Katagiri
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-21 00:00:00.000000000 Z
+date: 2014-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.9.0
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.1'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.14.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.14.0
 description: A formatter for rubocop that outputs in checkstyle format
 email:
 - eitoball@gmail.com
@@ -31,13 +73,16 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/rubocop/formatter/checkstyle_formatter.rb
 - rubocop-checkstyle_formatter.gemspec
+- spec/rubocop/formatter/checkstyle_formatter_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/eitoball/rubocop-checkstyle_formatter
 licenses:
 - MIT
@@ -48,18 +93,20 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A formatter for rubocop that outputs in checkstyle format
-test_files: []
+test_files:
+- spec/rubocop/formatter/checkstyle_formatter_spec.rb
+- spec/spec_helper.rb