rubocop-cask 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9bf5b20c746471e14ca9683d02925add5e158c4a
-  data.tar.gz: 851a48fb146dd40985f66c032d7cb95441822d5f
+  metadata.gz: 6a4259d68effdfccd9b90d0a5c05719f1c8f75f6
+  data.tar.gz: 660486500a297c9f6ac98b314534ba5a10aec51f
 SHA512:
-  metadata.gz: b63a7a90cbf7536a60e99ebfa5e1c50abc22f1ce561ab4ce20b6129c0215cd51218db3d589f38e738ff4d893afb26371bc500e1b060511474d71b1b3ae8c2d08
-  data.tar.gz: dc86e374ae7e00881c59e004d37546c20797e468bb0e8c802e02bb63f35af6632bd6435cba0e68c12e6d9b52fad4334baf20738ffee7f5134742833ec8c178f4
+  metadata.gz: 70146ce66a4790694e73212933589ea4bcd7f3034bb5d3dac5e9843fc18d16b542d5c15e30ba1307c489435b6cb530df2255e2703d9318673667aa16ce433d97
+  data.tar.gz: 95b53d4a9e858c4694c286e1eb3eece0d1826f5abc61299ba3c0c1bd56d12e78611370af7bd930a2e6c69a281d8a8a7a3d17529f9b46ec755cd2319038eeac64

data/README.md

@@ -10,7 +10,6 @@
 Cask-specific analysis for your [Homebrew-Cask](https://github.com/caskroom/homebrew-cask) taps, as an extension to
 [RuboCop](https://github.com/bbatsov/rubocop). Heavily inspired by [`rubocop-rspec`](https://github.com/nevir/rubocop-rspec).
 
-
 ## Installation
 
 Just install the `rubocop-cask` gem
@@ -21,7 +20,7 @@ gem install rubocop-cask
 
 or if you use bundler put this in your `Gemfile`
 
-```
+```ruby
 gem 'rubocop-cask'
 ```
 
@@ -34,7 +33,7 @@ You need to tell RuboCop to load the Cask extension. There are three ways to do
 
 Put this into your `.rubocop.yml`:
 
-```
+```yaml
 require: rubocop-cask
 ```
 

data/config/default.yml

@@ -1,7 +1,3 @@
-Cask/LicenseUnknownComment:
-  Description: 'Always follow `license :unknown` with the machine-generated TODO comment.'
-  Enabled: true
-
 Cask/NoDslVersion:
   Description: 'Do not use the deprecated DSL version syntax in your cask header.'
   Enabled: true

data/lib/rubocop-cask.rb

@@ -12,7 +12,6 @@ require 'rubocop/cask/inject'
 RuboCop::Cask::Inject.defaults!
 
 require 'rubocop/cop/cask/mixin/cask_help'
-require 'rubocop/cop/cask/license_unknown_comment'
 require 'rubocop/cop/cask/no_dsl_version'
 require 'rubocop/cop/cask/stanza_order'
 require 'rubocop/cop/cask/stanza_grouping'

data/lib/rubocop/cask/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cask
     # Version information for the Cask RuboCop plugin.
     module Version
-      STRING = '0.4.1'
+      STRING = '0.5.0'
 
       def self.gem_version
         Gem::Version.new(STRING)

data/spec/spec_helper.rb

@@ -3,7 +3,7 @@ require 'rubocop'
 project_path = File.join(File.dirname(__FILE__), '..')
 rubocop_path = File.join(project_path, 'vendor/rubocop')
 unless File.directory?(rubocop_path)
-  fail "Can't run specs without a local RuboCop checkout. Look in the README."
+  raise "Can't run specs without a local RuboCop checkout. Look in the README."
 end
 Dir["#{rubocop_path}/spec/support/**/*.rb"].each { |f| require f }
 Dir["#{project_path}/spec/support/**/*.rb"].each { |f| require f }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-cask
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Joshua Hagins
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-17 00:00:00.000000000 Z
+date: 2016-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.36'
+        version: 0.37.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.36'
+        version: 0.37.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -61,13 +61,11 @@ files:
 - lib/rubocop/cask/extend/string.rb
 - lib/rubocop/cask/inject.rb
 - lib/rubocop/cask/version.rb
-- lib/rubocop/cop/cask/license_unknown_comment.rb
 - lib/rubocop/cop/cask/mixin/cask_help.rb
 - lib/rubocop/cop/cask/no_dsl_version.rb
 - lib/rubocop/cop/cask/stanza_grouping.rb
 - lib/rubocop/cop/cask/stanza_order.rb
 - spec/project_spec.rb
-- spec/rubocop/cop/cask/license_unknown_comment_spec.rb
 - spec/rubocop/cop/cask/no_dsl_version_spec.rb
 - spec/rubocop/cop/cask/stanza_grouping_spec.rb
 - spec/rubocop/cop/cask/stanza_order_spec.rb
@@ -99,7 +97,6 @@ specification_version: 4
 summary: Code style checking for Homebrew-Cask files
 test_files:
 - spec/project_spec.rb
-- spec/rubocop/cop/cask/license_unknown_comment_spec.rb
 - spec/rubocop/cop/cask/no_dsl_version_spec.rb
 - spec/rubocop/cop/cask/stanza_grouping_spec.rb
 - spec/rubocop/cop/cask/stanza_order_spec.rb

data/lib/rubocop/cop/cask/license_unknown_comment.rb

@@ -1,72 +0,0 @@
-module RuboCop
-  module Cop
-    module Cask
-      # This cop checks that if a cask uses `license :unknown`, it is followed
-      # on the same line by the machine-generated TODO comment.
-      class LicenseUnknownComment < Cop
-        include CaskHelp
-
-        COMMENT_TEXT = '# TODO: change license and remove this comment; ' \
-                       "':unknown' is a machine-generated placeholder"
-        MISSING_MSG = "Missing required comment: `#{COMMENT_TEXT}`"
-        INLINE_MSG = 'Comment belongs on the same line as `license :unknown`'
-
-        def on_cask(cask_block)
-          license_stanza = cask_block.stanzas.find(&:license?)
-          return unless license_stanza && license_unknown?(license_stanza)
-          add_offenses(license_stanza)
-        end
-
-        def autocorrect(stanza)
-          lambda do |corrector|
-            comment = license_unknown_comment
-            remove_comment(corrector, comment) if comment
-            add_comment(corrector, stanza)
-          end
-        end
-
-        private
-
-        attr_reader :cask_block
-
-        def license_unknown?(stanza)
-          stanza.source.include?(':unknown')
-        end
-
-        def add_offenses(stanza)
-          comment = license_unknown_comment
-          add_missing_offense(stanza) unless comment
-          add_not_inline_offense(stanza, comment) if comment &&
-              !on_same_line?(stanza, comment)
-        end
-
-        def license_unknown_comment
-          processed_source.comments.find { |c| c.text == COMMENT_TEXT }
-        end
-
-        def add_missing_offense(stanza)
-          add_offense(stanza, stanza.source_range, MISSING_MSG)
-        end
-
-        def add_not_inline_offense(stanza, comment)
-          add_offense(stanza, comment.loc.expression, INLINE_MSG)
-        end
-
-        def on_same_line?(stanza, comment)
-          stanza.source_range.line == comment.loc.line
-        end
-
-        def remove_comment(corrector, comment)
-          line = comment.loc.line
-          length = processed_source[line - 1].length
-          range = source_range(processed_source.buffer, line, 0, length + 1)
-          corrector.remove(range)
-        end
-
-        def add_comment(corrector, stanza)
-          corrector.insert_after(stanza.source_range, " #{COMMENT_TEXT}")
-        end
-      end
-    end
-  end
-end

data/spec/rubocop/cop/cask/license_unknown_comment_spec.rb

@@ -1,87 +0,0 @@
-describe RuboCop::Cop::Cask::LicenseUnknownComment do
-  include CopSharedExamples
-
-  subject(:cop) { described_class.new }
-  let(:license_unknown_comment) { described_class.const_get(:COMMENT_TEXT) }
-
-  context 'when cask has no license stanza' do
-    let(:source) { "cask 'foo' do; end" }
-
-    include_examples 'does not report any offenses'
-  end
-
-  context 'when license is not :unknown' do
-    let(:source) do
-      <<-CASK.undent
-        cask 'foo' do
-          license :mit
-        end
-      CASK
-    end
-
-    include_examples 'does not report any offenses'
-  end
-
-  context 'when license is :unknown' do
-    let(:correct_source) do
-      <<-CASK.undent
-        cask 'foo' do
-          license :unknown #{license_unknown_comment}
-        end
-      CASK
-    end
-
-    context 'with required comment on same line' do
-      let(:source) { correct_source }
-
-      include_examples 'does not report any offenses'
-    end
-
-    context 'with required comment on preceding line' do
-      let(:source) do
-        <<-CASK.undent
-          cask 'foo' do
-            #{license_unknown_comment}
-            license :unknown
-          end
-        CASK
-      end
-      let(:expected_offenses) do
-        [{
-          message: 'Comment belongs on the same line as `license :unknown`',
-          severity: :convention,
-          line: 2,
-          column: 2,
-          source: license_unknown_comment
-        }]
-      end
-
-      include_examples 'reports offenses'
-
-      include_examples 'autocorrects source'
-    end
-
-    context 'with required comment missing' do
-      let(:source) do
-        <<-CASK.undent
-          cask 'foo' do
-            license :unknown
-          end
-        CASK
-      end
-      let(:expected_offenses) do
-        [{
-          message: "Missing required comment: `#{license_unknown_comment}`",
-          severity: :convention,
-          line: 2,
-          column: 2,
-          source: 'license :unknown'
-        }]
-      end
-
-      include_examples 'reports offenses'
-
-      include_examples 'autocorrects source'
-    end
-  end
-end