rubocop-callback_checker 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27a8d5e0a0b8d6c92ccabe6a928f106fc80a3d438ed07002686f07bf5c3c07c9
-  data.tar.gz: 1bad8a7bb9dcf33f5758655bbdfc208f9849dc75cde2b534dbaedef18e7e31ad
+  metadata.gz: 0e884e5e21fa07e119f9f4b418e405be6611d2d5c0b696da5bdded094dd31455
+  data.tar.gz: a86502267af368a6d0922a46984190fb68b9f1e7a6523516b9695ce63c23f5b8
 SHA512:
-  metadata.gz: 222120c9a2df85dc84fd57709c17b52b494f9e05b21a9ae64fc7f94d058595f6aebb3a9a821daad78707de021ff796c7039c73710760fd1c410f43e04a07e04f
-  data.tar.gz: 29893d82a5f907f2d7cf88781864963e169f6c0e22b1bbc0f5615c0101773aa12f6a53a7e6dc5363c61a6849680090aa4edecd33e3edbe01af3130b47fc63bf6
+  metadata.gz: 6b893a0fe683cee9c9d8d8e636a10198b6fcd16c23358598c6983cb800cc7d68424a40dc334e9947853db463f8ceca043c6786b42b46a172ef1379802055a7de
+  data.tar.gz: 33aea6ae0240e55f7dfb902079679d704059ae2e00fa04f2a7b0968e1a73fa3a8ea3e51ef0bfa5d7d550d38bac804113aec35cc0254fac8a7737291a0ee73a13

data/.rubocop.yml

@@ -1,15 +1,2 @@
 require:
-  - rubocop-rspec
-
-plugins:
-  - rubocop-rake
-
-AllCops:
-  TargetRubyVersion: 3.1
-  NewCops: enable
-
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-
-Style/StringLiteralsInInterpolation:
-  EnforcedStyle: double_quotes
+  - rubocop-callback_checker

data/Rakefile

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-require "rubocop/rake_task"
+require 'rubocop/rake_task'
 
 RuboCop::RakeTask.new
 

data/lib/callback_checker/cli.rb

@@ -5,7 +5,7 @@ require_relative '../rubocop/callback_checker/version'
 require 'optparse'
 
 module CallbackChecker
-  VERSION = Rubocop::CallbackChecker::VERSION
+  VERSION = RuboCop::CallbackChecker::VERSION
 
   class CLI
     def self.run(argv)
@@ -22,15 +22,15 @@ module CallbackChecker
       parse_options
 
       if @paths.empty?
-        puts "Usage: rubocop-callback-checker [options] FILE..."
+        puts 'Usage: rubocop-callback-checker [options] FILE...'
         puts "Try 'rubocop-callback-checker --help' for more information."
         return 1
       end
 
       files = collect_files(@paths)
-      
+
       if files.empty?
-        puts "No Ruby files found to analyze."
+        puts 'No Ruby files found to analyze.'
         return 1
       end
 
@@ -38,7 +38,7 @@ module CallbackChecker
 
       files.each do |file|
         offenses = PrismAnalyzer.analyze_file(file)
-        
+
         if offenses.any?
           total_offenses += offenses.size
           print_offenses(file, offenses)
@@ -47,21 +47,21 @@ module CallbackChecker
 
       print_summary(files.size, total_offenses)
 
-      total_offenses > 0 ? 1 : 0
+      total_offenses.positive? ? 1 : 0
     end
 
     private
 
     def parse_options
       OptionParser.new do |opts|
-        opts.banner = "Usage: rubocop-callback-checker [options] FILE..."
+        opts.banner = 'Usage: rubocop-callback-checker [options] FILE...'
 
-        opts.on("-h", "--help", "Print this help") do
+        opts.on('-h', '--help', 'Print this help') do
           puts opts
           exit 0
         end
 
-        opts.on("-v", "--version", "Print version") do
+        opts.on('-v', '--version', 'Print version') do
           puts "rubocop-callback-checker version #{VERSION}"
           exit 0
         end
@@ -88,7 +88,7 @@ module CallbackChecker
 
     def print_offenses(file, offenses)
       puts "\n#{file}"
-      
+
       offenses.each do |offense|
         location = offense[:location]
         puts "  #{location[:start_line]}:#{location[:start_column]}: #{offense[:message]}"
@@ -97,7 +97,7 @@ module CallbackChecker
     end
 
     def print_summary(file_count, offense_count)
-      puts "\n" + "=" * 80
+      puts "\n#{'=' * 80}"
       puts "#{file_count} file(s) inspected, #{offense_count} offense(s) detected"
     end
   end

data/lib/callback_checker/prism_analyzer.rb

@@ -78,9 +78,7 @@ module CallbackChecker
 
     def collect_methods(class_node)
       class_node.body&.body&.each do |statement|
-        if statement.is_a?(Prism::DefNode)
-          @callback_methods[statement.name] = statement
-        end
+        @callback_methods[statement.name] = statement if statement.is_a?(Prism::DefNode)
       end
     end
 
@@ -148,7 +146,7 @@ module CallbackChecker
       if node.receiver.is_a?(Prism::ConstantReadNode)
         constant_name = node.receiver.name.to_s
         return true if SUSPICIOUS_CONSTANTS.include?(constant_name)
-        
+
         # Check for any constant that isn't a known safe pattern
         # This catches things like NewsletterSDK, CustomAPI, etc.
         return true if constant_appears_to_be_external_service?(constant_name)
@@ -165,18 +163,14 @@ module CallbackChecker
       end
 
       # Check for method chains that end with deliver_now
-      if method_name == :deliver_now && node.receiver.is_a?(Prism::CallNode)
-        return true
-      end
+      return true if method_name == :deliver_now && node.receiver.is_a?(Prism::CallNode)
 
       # Check for calls on associations or other objects (not self)
-      if node.receiver && !self_reference?(node.receiver)
-        return true if persistence_method?(method_name)
-      end
+      return true if node.receiver && !self_reference?(node.receiver) && persistence_method?(method_name)
 
       # Check for save/update on self or implicit self
-      if node.receiver.nil? || self_reference?(node.receiver)
-        return true if %i[save save! update update!].include?(method_name)
+      if (node.receiver.nil? || self_reference?(node.receiver)) && %i[save save! update update!].include?(method_name)
+        return true
       end
 
       false
@@ -187,7 +181,7 @@ module CallbackChecker
       # it's probably an external service
       return true if constant_name.end_with?('SDK', 'API', 'Client', 'Service')
       return true if constant_name == constant_name.upcase && constant_name.length > 1
-      
+
       false
     end
 

data/lib/rubocop/callback_checker/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-module Rubocop
+module RuboCop
   module CallbackChecker
-    VERSION = "0.1.0"
+    VERSION = '0.1.1'
   end
 end

data/lib/rubocop/callback_checker.rb

@@ -1,21 +1,16 @@
 # frozen_string_literal: true
 
-require_relative "callback_checker/version"
-require "pathname"
-require "yaml"
+require_relative 'callback_checker/version'
+require 'pathname'
 
-# Load all the cops
-Dir[Pathname.new(__dir__).join("cop", "callback_checker", "**", "*.rb")].each { |file| require file }
-
-module Rubocop
+module RuboCop
   module CallbackChecker
     class Error < StandardError; end
 
     PROJECT_ROOT = Pathname.new(__dir__).parent.parent.freeze
-    CONFIG_DEFAULT = PROJECT_ROOT.join("config", "default.yml").freeze
+    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
 
-    def self.version
-      VERSION
-    end
+    # Inject the plugin's default configuration into RuboCop
+    ::RuboCop::ConfigLoader.inject_defaults!(CONFIG_DEFAULT.to_s)
   end
 end

data/lib/rubocop/cop/callback_checker/attribute_assignment_only.rb

@@ -69,13 +69,13 @@ module RuboCop
 
         def on_class(node)
           @current_callbacks = {}
-          
+
           node.each_descendant(:send) do |send_node|
             next unless callback_method?(send_node)
-            
+
             callback_name = send_node.method_name
             callback_args = send_node.arguments
-            
+
             callback_args.each do |arg|
               if arg.sym_type?
                 method_name = arg.value
@@ -84,18 +84,16 @@ module RuboCop
                 check_block_for_persistence(arg, callback_name)
               end
             end
-            
-            if send_node.block_node
-              check_block_for_persistence(send_node.block_node, callback_name)
-            end
+
+            check_block_for_persistence(send_node.block_node, callback_name) if send_node.block_node
           end
-          
+
           node.each_descendant(:def) do |def_node|
             method_name = def_node.method_name
             callback_name = @current_callbacks[method_name]
-            
+
             next unless callback_name
-            
+
             check_method_for_persistence(def_node, callback_name)
           end
         end
@@ -105,7 +103,7 @@ module RuboCop
         def check_block_for_persistence(block_node, callback_name)
           block_node.each_descendant(:send) do |send_node|
             next unless persistence_call?(send_node)
-            
+
             add_offense_for_node(send_node, callback_name)
           end
         end
@@ -113,7 +111,7 @@ module RuboCop
         def check_method_for_persistence(method_node, callback_name)
           method_node.each_descendant(:send) do |send_node|
             next unless persistence_call?(send_node)
-            
+
             add_offense_for_node(send_node, callback_name)
           end
         end
@@ -121,14 +119,14 @@ module RuboCop
         def add_offense_for_node(node, callback_name)
           method_name = node.method_name
           attribute = extract_attribute_name(node)
-          
+
           message = format(
             MSG,
             attribute: attribute,
             method: method_name,
             callback: callback_name
           )
-          
+
           add_offense(node, message: message)
         end
 
@@ -138,11 +136,11 @@ module RuboCop
             key = first_hash_key(node)
             return key.to_s if key
           end
-          
+
           # Try to extract from symbol argument (e.g., update_column(:name, 'foo'))
           symbol_arg = first_symbol_arg(node)
           return symbol_arg.to_s if symbol_arg
-          
+
           'attribute'
         end
       end

data/lib/rubocop/cop/callback_checker/avoid_self_persistence.rb

@@ -23,9 +23,9 @@ module RuboCop
       #     self.status = 'active'
       #   end
       class AvoidSelfPersistence < Base
-        MSG = "Avoid calling `%<method>s` on self within `%<callback>s`. " \
-              "This can trigger infinite loops or run callbacks multiple times. " \
-              "Assign attributes directly instead: `self.attribute = value`."
+        MSG = 'Avoid calling `%<method>s` on self within `%<callback>s`. ' \
+              'This can trigger infinite loops or run callbacks multiple times. ' \
+              'Assign attributes directly instead: `self.attribute = value`.'
 
         CALLBACK_METHODS = %i[
           before_validation after_validation
@@ -84,7 +84,7 @@ module RuboCop
           elsif arg.block_pass_type?
             # Handle block pass like: after_save &:method_name
             # We can't easily analyze these, so skip
-            return
+            nil
           elsif arg.lambda_or_proc?
             check_proc_callback(arg, node.method_name)
           end

data/lib/rubocop/cop/callback_checker/callback_method_length.rb

@@ -38,8 +38,8 @@ module RuboCop
       #     # No callback, call UserRegistrationService.new(user).call from controller
       #   end
       class CallbackMethodLength < Base
-        MSG = "Callback method `%<method>s` is too long (%<length>d lines). " \
-              "Max allowed: %<max>d lines. Extract complex logic to a service object."
+        MSG = 'Callback method `%<method>s` is too long (%<length>d lines). ' \
+              'Max allowed: %<max>d lines. Extract complex logic to a service object.'
 
         CALLBACK_METHODS = %i[
           before_validation after_validation
@@ -54,7 +54,7 @@ module RuboCop
 
         def on_send(node)
           return unless callback_method?(node)
-          
+
           # Only check symbol arguments (method name references)
           node.arguments.each do |arg|
             check_callback_argument(node, arg) if arg.sym_type?
@@ -100,11 +100,11 @@ module RuboCop
           return 0 unless method_node.body
 
           body = method_node.body
-          
+
           # Calculate line count
           first_line = body.first_line
           last_line = body.last_line
-          
+
           # Count non-empty lines
           (first_line..last_line).count do |line_number|
             line = processed_source.lines[line_number - 1]

data/lib/rubocop/cop/callback_checker/conditional_style.rb

@@ -26,8 +26,8 @@ module RuboCop
       #     status == 'active' && !deleted?
       #   end
       class ConditionalStyle < Base
-        MSG = "Use a named method instead of a %<type>s for callback conditionals. " \
-              "Extract the logic to a private method with a descriptive name."
+        MSG = 'Use a named method instead of a %<type>s for callback conditionals. ' \
+              'Extract the logic to a private method with a descriptive name.'
 
         CALLBACK_METHODS = %i[
           before_validation after_validation
@@ -44,7 +44,7 @@ module RuboCop
 
         def on_send(node)
           return unless callback_method?(node)
-          
+
           check_callback_conditionals(node)
         end
 
@@ -79,7 +79,7 @@ module RuboCop
 
         def conditional_key?(key)
           return false unless key.sym_type?
-          
+
           CONDITIONAL_KEYS.include?(key.value)
         end
       end

data/lib/rubocop/cop/callback_checker/no_side_effects_in_callbacks.rb

@@ -14,8 +14,8 @@ module RuboCop
       #   # good
       #   after_commit :notify_external_api, on: :create
       class NoSideEffectsInCallbacks < Base
-        MSG = "Avoid side effects (API calls, mailers, background jobs, or modifying other records) " \
-              "in %<callback>s. Use `after_commit` instead."
+        MSG = 'Avoid side effects (API calls, mailers, background jobs, or modifying other records) ' \
+              'in %<callback>s. Use `after_commit` instead.'
 
         SIDE_EFFECT_SENSITIVE_CALLBACKS = %i[
           before_validation before_save after_save
@@ -123,12 +123,12 @@ module RuboCop
         def part_of_reported_chain?(send_node)
           parent = send_node.parent
           return false unless parent&.send_type?
-          
+
           # If parent is also a side effect, we'll report the parent instead
           # This handles cases like UserMailer.welcome(self).deliver_now
           # We want to report the .deliver_now, not the .welcome
           return false if async_delivery?(send_node) # Always report delivery methods
-          
+
           # If this is a receiver of a delivery method, don't report it
           parent.receiver == send_node && async_delivery?(parent)
         end

data/lib/rubocop/cop/callback_checker_cops.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require_relative 'callback_checker/no_side_effects_in_callbacks'
+require_relative 'callback_checker/avoid_self_persistence'
+require_relative 'callback_checker/attribute_assignment_only'
+require_relative 'callback_checker/callback_method_length'
+require_relative 'callback_checker/conditional_style'

data/lib/rubocop/cop/cops.rb

@@ -1,5 +1,5 @@
-require_relative "callback_checker/no_side_effects_in_callbacks"
-require_relative "callback_checker/avoid_self_persistence"
-require_relative "callback_checker/attribute_assignment_only"
-require_relative "callback_checker/callback_method_length"
-require_relative "callback_checker/conditional_style"
+require_relative 'callback_checker/no_side_effects_in_callbacks'
+require_relative 'callback_checker/avoid_self_persistence'
+require_relative 'callback_checker/attribute_assignment_only'
+require_relative 'callback_checker/callback_method_length'
+require_relative 'callback_checker/conditional_style'

data/lib/rubocop-callback_checker.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+require_relative 'rubocop/callback_checker'
+require_relative 'rubocop/cop/callback_checker_cops'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-callback_checker
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - rahsheen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-03-13 00:00:00.000000000 Z
+date: 2026-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -81,33 +81,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rake
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '2.0'
 description: A RuboCop extension focused on avoiding callback hell in Rails.
 email:
 - rahsheen.porter@gmail.com
@@ -127,6 +127,7 @@ files:
 - exe/rubocop-callback-checker
 - lib/callback_checker/cli.rb
 - lib/callback_checker/prism_analyzer.rb
+- lib/rubocop-callback_checker.rb
 - lib/rubocop/callback_checker.rb
 - lib/rubocop/callback_checker/version.rb
 - lib/rubocop/cop/callback_checker/attribute_assignment_only.rb
@@ -134,6 +135,7 @@ files:
 - lib/rubocop/cop/callback_checker/callback_method_length.rb
 - lib/rubocop/cop/callback_checker/conditional_style.rb
 - lib/rubocop/cop/callback_checker/no_side_effects_in_callbacks.rb
+- lib/rubocop/cop/callback_checker_cops.rb
 - lib/rubocop/cop/cops.rb
 - sig/rubocop/callback_checker.rbs
 homepage: https://github.com/rahsheen/rubocop-callback_checker