rubocop-brands_insurance 1.4.0.pre.rc.1 → 1.4.0.pre.rc.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f71b8941f86c6189771d5c9bfcc81f4744e9fb821d45d5ba3c93c5a0fd195320
-  data.tar.gz: 8032dc595911c74d1d4296d0123918c98e60cb273fd4aa0d1654602526363936
+  metadata.gz: a8f11dcd441570d4e6573a18c06ec7aea8b1843c8d498b45cfdbe1e2d8ebdef0
+  data.tar.gz: 79cd3dd5f7cf1d32ebec7c401022f2c991ea99af5c47027bbac6f25b444931ca
 SHA512:
-  metadata.gz: f9a13ac68f7eead1d4186767b1fef7c6e8eaae15beb823a1344acb33bc7a969ef4bf3c8b05665e3fc3291b32f749293237539163d7f8eafc13e4a78f346faed7
-  data.tar.gz: 58be8bafe667d21c2b9be721a6102fe9fabe16ec8b03633d430385366bb37b4b1dabbb73c552d1f5197affe9f5cbc637b3aefa4a30739f27f640d7431ec898a8
+  metadata.gz: c8cdf895613d815d6f41bd2d318843cd652706923c48b88289c47a2dcbfe4929adb818dcc8b8e5fe9f47557253766ebc26f87f4e9b513ba65af2d76228f143b0
+  data.tar.gz: aa9dd85adc9a5f2a68ce2b1887409d0047c2b4f38e59268216d1b7ac49632857450423b59224ae9cb1f5b74dea130c3f460711f0809c3802837e0f158e289139

data/README.adoc

@@ -35,7 +35,6 @@ BrandsInsurance/Style/DisallowedMethods:
 
 == Departments
 
-* xref:./docs/cops/layout/README.adoc[``Layout``]
 * xref:./docs/cops/style/README.adoc[``Style``]
 
 == Contributing

data/config/default.yml

@@ -1,10 +1,3 @@
-BrandsInsurance/Layout/MultilineArrayLineBreaks:
-  Description: 'Fork of base Layout/MultilineArrayLineBreaks rule'
-  Enabled: true
-  VersionAdded: '1.3.0'
-  AllowMultilineFinalElement: true
-  AllowPercentArray: true
-
 BrandsInsurance/Style/DisallowedMethods:
   Description: 'Disallows the usage of `#abort` and `#tap` methods'
   Enabled: true

data/lib/rubocop/brands_insurance/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module BrandsInsurance
-    VERSION = '1.4.0-rc.1'
+    VERSION = '1.4.0-rc.3'
   end
 end

data/lib/rubocop/cop/brands_insurance_cops.rb

@@ -1,4 +1,3 @@
 # frozen_string_literal: true
 
 require_relative 'brands_insurance/style/disallowed_methods'
-require_relative 'brands_insurance/layout/multiline_array_line_breaks'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-brands_insurance
 version: !ruby/object:Gem::Version
-  version: 1.4.0.pre.rc.1
+  version: 1.4.0.pre.rc.3
 platform: ruby
 authors:
 - Brands Insurance
@@ -35,8 +35,6 @@ files:
 - LICENSE.txt
 - README.adoc
 - config/default.yml
-- docs/cops/layout/README.adoc
-- docs/cops/layout/multiline_array_line_breaks/README.adoc
 - docs/cops/style/README.adoc
 - docs/cops/style/disallowed_methods/README.adoc
 - lib/rubocop-brands_insurance.rb
@@ -46,7 +44,6 @@ files:
 - lib/rubocop/cop/brands_insurance/generator.rb
 - lib/rubocop/cop/brands_insurance/generator/cop_readme_injector.rb
 - lib/rubocop/cop/brands_insurance/generator/dept_readme_injector.rb
-- lib/rubocop/cop/brands_insurance/layout/multiline_array_line_breaks.rb
 - lib/rubocop/cop/brands_insurance/style/disallowed_methods.rb
 - lib/rubocop/cop/brands_insurance_cops.rb
 homepage: https://github.com/BrandsInsurance/expert-chainsaw/

data/docs/cops/layout/README.adoc

@@ -1,7 +0,0 @@
-= Layout
-
-Layout cops check for stylistic whitespace in your code
-
-== Cops
-
-* xref:./multiline_array_line_breaks/README.adoc[``Layout/MultilineArrayLineBreaks``]

data/docs/cops/layout/multiline_array_line_breaks/README.adoc

@@ -1,44 +0,0 @@
-= ``Layout/MultilineArrayLineBreaks``
-
-== Description
-
-Extends the built-in link:https://docs.rubocop.org/rubocop/1.49/cops_layout.html#layoutmultilinearraylinebreaks[``Layout/MultilineArrayLineBreaks``]
-and adds the ``AllowPercentArray`` option
-
-== Examples
-
-[source,ruby]
-----
-# bad
-%w[
-  1
-  2
-  3
-  4
-]
-
-# good
-%w[
-  1 2
-  3 4
-]
-----
-
-== Configurable Attributes
-
-|===
-|Name |Default value |Configurable values
-
-|AllowMultilineFinalElement
-|false
-|Boolean
-
-|AllowPercentArray
-|false
-|Boolean
-
-|===
-
-== References
-
-https://github.com/BrandsInsurance/expert-chainsaw/issues/1032

data/lib/rubocop/cop/brands_insurance/layout/multiline_array_line_breaks.rb

@@ -1,73 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module BrandsInsurance
-      module Layout
-        class MultilineArrayLineBreaks < Base
-          include RuboCop::Cop::MultilineElementLineBreaks
-          # extend RuboCop::Cop::AutoCorrector
-
-          # `RuboCop::Cop::AutoCorrector` must be extended but it only has this method returning `true`
-          #
-          # @return [Boolean]
-          #
-          def support_autocorrect?
-            false
-          end
-
-          MESSAGE = 'Each item in a multi-line array must start on a separate line.'
-          # MSG is needed for `check_line_breaks`
-          MSG = MESSAGE
-
-          def on_array(node)
-            return if allowed_percent_array?(node)
-
-            check_line_breaks(node, node.children, ignore_last: ignore_last_element?)
-          end
-
-          private
-
-            # Check conig option
-            #
-            # @return [Boolean]
-            #
-            def ignore_last_element?
-              cop_config.fetch('AllowMultilineFinalElement', false)
-            end
-
-            # Check conig option
-            #
-            # @return [Boolean]
-            #
-            def allowed_percent_array?(node)
-              cop_config.fetch('AllowPercentArray', false) && node.percent_literal?
-            end
-
-            # Copied from rubocop's source
-            def check_line_breaks(_node, children, ignore_last: false)
-              return if all_on_same_line?(children, ignore_last: ignore_last)
-
-              last_seen_line = -1
-              children.each do |child|
-                if last_seen_line >= child.first_line
-                  add_offense(child, message: MESSAGE)
-                else
-                  last_seen_line = child.last_line
-                end
-              end
-            end
-
-            # Copied from rubocop's source
-            def all_on_same_line?(nodes, ignore_last: false)
-              return true if nodes.empty?
-
-              return same_line?(nodes.first, nodes.last) if ignore_last
-
-              nodes.first.first_line == nodes.last.last_line
-            end
-        end
-      end
-    end
-  end
-end