rubocop-blueapron 0.1.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 35d1077d0ea4cfb652e9729262175aac2b468b9e
+  data.tar.gz: bf51a2ffcbc66cecaae81f984f32c222a8723ba9
+SHA512:
+  metadata.gz: 6162fc4ce3875fe1e60839b39aeb388d00ebe26e4f8961af196305e7781358e961716b5016ee8d2fd10a0ef1492d5d3e79564316b1315f920feafd157e6b1393
+  data.tar.gz: 625c9b0455298f4d93a017423e793d2159ad1cc64d9877865367adf9ae65bd1371641a653fb2bd57d2557ac9189383d156ac24d2ee468fb70b38bf920607661f

data/LICENSE

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2016 Blue Apron
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/README.md

@@ -0,0 +1,44 @@
+# RuboCop Blue Apron
+
+Blue Apron Style Guide RuboCop extension.
+
+## Installation
+
+Add `rubocop-blueapron` to your `Gemfile`
+
+```
+gem 'rubocop-blueapron'
+```
+
+## Usage
+
+Configure RuboCop to load the extension in `.rubocop.yml`.
+
+```
+require: rubocop-blueapron
+```
+
+## Contributing
+
+1. Fork it!
+2. Create your feature branch: `git checkout -b my-new-feature`
+3. Commit your changes: `git commit -am 'Add some feature'`
+4. Push to the branch: `git push origin my-new-feature`
+5. Submit a pull request :D
+
+For running the spec files, this project depends on RuboCop's spec helpers.
+This means that in order to run the specs locally, you need a (shallow) clone
+of the RuboCop repository:
+
+```bash
+git clone --depth 1 git://github.com/bbatsov/rubocop.git vendor/rubocop
+```
+
+## Credits
+
+Based on [rubocop-rspec](https://github.com/nevir/rubocop-rspec).
+
+## License
+
+`rubocop-blueapron` is MIT licensed. [See the accompanying file](MIT-LICENSE.md) for
+the full text.

data/config/default.yml

@@ -0,0 +1,7 @@
+Blueapron/DateTimeNowUtc:
+  Description: 'Check that DateTime.now is interpreted as UTC.'
+  Enabled: true
+
+Blueapron/TimeNowUtc:
+  Description: 'Check that Time.now is interpreted as UTC.'
+  Enabled: true

data/lib/rubocop-blueapron.rb

@@ -0,0 +1,9 @@
+require 'rubocop'
+
+require 'rubocop/blueapron/version'
+require 'rubocop/blueapron/inject'
+
+RuboCop::Blueapron::Inject.defaults!
+
+require 'rubocop/cop/blueapron/date_time_now_utc'
+require 'rubocop/cop/blueapron/time_now_utc'

data/lib/rubocop/blueapron/inject.rb

@@ -0,0 +1,21 @@
+require 'yaml'
+
+module RuboCop
+  module Blueapron
+    # Because RuboCop doesn't yet support plugins, we have to monkey patch in a
+    # bit of our configuration.
+    module Inject
+      DEFAULT_FILE = File.expand_path(
+        '../../../../config/default.yml', __FILE__
+      )
+
+      def self.defaults!
+        hash = YAML.load_file(DEFAULT_FILE)
+        puts "configuration from #{DEFAULT_FILE}" if ConfigLoader.debug?
+        config = ConfigLoader.merge_with_default(hash, DEFAULT_FILE)
+
+        ConfigLoader.instance_variable_set(:@default_configuration, config)
+      end
+    end
+  end
+end

data/lib/rubocop/blueapron/version.rb

@@ -0,0 +1,9 @@
+module RuboCop
+  module Blueapron
+    MAJOR = '0'
+    MINOR = '1'
+    PATCH = '1'
+
+    VERSION = [MAJOR, MINOR, PATCH].join('.')
+  end
+end

data/lib/rubocop/cop/blueapron/date_time_now_utc.rb

@@ -0,0 +1,18 @@
+module RuboCop
+  module Cop
+    module Blueapron
+      class DateTimeNowUtc < Cop
+        DATE_TIME_NOW = s(:send, s(:const, nil, :DateTime), :now)
+
+        MESSAGE = 'DateTime.now should be interpreted as UTC.'
+
+        def on_send(node)
+          return if node != DATE_TIME_NOW
+          return if node.parent && node.parent.children.last == :utc
+
+          add_offense(node, :expression, MESSAGE)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/blueapron/time_now_utc.rb

@@ -0,0 +1,18 @@
+module RuboCop
+  module Cop
+    module Blueapron
+      class TimeNowUtc < Cop
+        TIME_NOW = s(:send, s(:const, nil, :Time), :now)
+
+        MESSAGE = 'Time.now should be interpreted as UTC.'
+
+        def on_send(node)
+          return if node != TIME_NOW
+          return if node.parent && node.parent.children.last == :utc
+
+          add_offense(node, :expression, MESSAGE)
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cop/blueapron/date_time_now_utc_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe RuboCop::Cop::Blueapron::DateTimeNowUtc do
+  subject(:cop) { described_class.new }
+
+  it 'reports offense when DateTime.now is not interpreted as UTC' do
+    inspect_source(cop, "def foo\n DateTime.now\n end")
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses.map(&:line).sort).to eq([2])
+    expect(cop.messages).to eq(['DateTime.now should be interpreted as UTC.'])
+  end
+
+  it 'does not report offense when DateTime.now is interpreted as UTC' do
+    inspect_source(cop, "def foo\n DateTime.now.utc\n end")
+    expect(cop.offenses).to be_empty
+  end
+end

data/spec/rubocop/cop/blueapron/time_now_utc_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe RuboCop::Cop::Blueapron::TimeNowUtc do
+  subject(:cop) { described_class.new }
+
+  it 'reports offense when Time.now is not interpreted as UTC' do
+    inspect_source(cop, "def foo\n Time.now\n end")
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses.map(&:line).sort).to eq([2])
+    expect(cop.messages).to eq(['Time.now should be interpreted as UTC.'])
+  end
+
+  it 'does not report offense when Time.now is interpreted as UTC' do
+    inspect_source(cop, "def foo\n Time.now.utc\n end")
+    expect(cop.offenses).to be_empty
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,23 @@
+require 'rubocop'
+
+rubocop_path = File.join(File.dirname(__FILE__), '../vendor/rubocop')
+unless File.directory?(rubocop_path)
+  fail "Can't run specs without a local RuboCop checkout. Look in the README."
+end
+Dir["#{rubocop_path}/spec/support/**/*.rb"].each { |f| require f }
+
+RSpec.configure do |config|
+  config.order = :random
+
+  config.expect_with :rspec do |expectations|
+    expectations.syntax = :expect # Disable `should`
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.syntax = :expect # Disable `should_receive` and `stub`
+  end
+end
+
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+require 'rubocop-blueapron'

metadata

@@ -0,0 +1,130 @@
+--- !ruby/object:Gem::Specification
+name: rubocop-blueapron
+version: !ruby/object:Gem::Version
+  version: 0.1.1
+platform: ruby
+authors:
+- Blue Apron Engineering
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2016-01-19 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.34'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.34'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.9'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.9'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.11'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.11'
+description: Blue Apron Style Guide RuboCop extension.
+email:
+- engineering@blueapron.com
+executables: []
+extensions: []
+extra_rdoc_files:
+- LICENSE
+- README.md
+files:
+- LICENSE
+- README.md
+- config/default.yml
+- lib/rubocop-blueapron.rb
+- lib/rubocop/blueapron/inject.rb
+- lib/rubocop/blueapron/version.rb
+- lib/rubocop/cop/blueapron/date_time_now_utc.rb
+- lib/rubocop/cop/blueapron/time_now_utc.rb
+- spec/rubocop/cop/blueapron/date_time_now_utc_spec.rb
+- spec/rubocop/cop/blueapron/time_now_utc_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/blueapron/rubocop-blueapron
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.4.5.1
+signing_key: 
+specification_version: 4
+summary: Blue Apron Style Guide RuboCop extension.
+test_files:
+- spec/rubocop/cop/blueapron/date_time_now_utc_spec.rb
+- spec/rubocop/cop/blueapron/time_now_utc_spec.rb
+- spec/spec_helper.rb