rubocop-betterment 1.14.0 → 1.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72ecfa7e731527b0864a131730eb79829789b2b34647dd73ed6b17bdc5c5e630
-  data.tar.gz: 5337dbddc978a69778f40dde95c9136e83df54bf90e5b5eb122aaa925cf14e97
+  metadata.gz: 9b851af1c0666fffea3f63f36504e7acf1c6d6324e58caba76bcea50ac752f50
+  data.tar.gz: 6dcbd29396beb9c7310f6ff9082ae9494219741fb17b6306ea976747445e337e
 SHA512:
-  metadata.gz: 9a1a2417233fd6494e0e4a99d4423fe0c1b051aaeb6e54cafe23791622f612afb48d169f06a4d23911a614fb19e937f3862743141915facc4bfdfbe64dd6bcd0
-  data.tar.gz: f0beed1cf45c911d169061c703db710d05400da4ddc13cf16151338668bb023df9b98fe311e863caca8fa4979f099ab054ccf8c40eebac070ed52f6bf6a0135a
+  metadata.gz: 2067d92a8d52c91b76f3f42a470f852567f858ccc34b6ba0d50b0aa2c275ef8ba7b32287bf8592efbea39e18d1a7356ef375e51ffbddd6153d1809173ff5385c
+  data.tar.gz: 8d18894011ce90246f1cdaf5a8c42043df0c6dcd7a92bf9af6407c300c9c01cdd1d2c4ebe941ed26b4eb09500b0abb45f4d59d1286ee1eb622f3a75b2003dff0

data/lib/rubocop/cop/betterment.rb

@@ -7,3 +7,4 @@ require 'rubocop/cop/betterment/memoization_with_arguments'
 require 'rubocop/cop/betterment/site_prism_loaded'
 require 'rubocop/cop/betterment/spec_helper_required_outside_spec_dir'
 require 'rubocop/cop/betterment/implicit_redirect_type'
+require 'rubocop/cop/betterment/active_job_performable'

data/lib/rubocop/cop/betterment/active_job_performable.rb

@@ -0,0 +1,40 @@
+module RuboCop
+  module Cop
+    module Betterment
+      class ActiveJobPerformable < Cop
+        MSG = <<-DOC.freeze
+          Classes that are "performable" should be ActiveJobs
+
+          class MyJob < ApplicationJob
+            def perform
+            end
+          end
+
+          You can learn more about ActiveJob here:
+          https://guides.rubyonrails.org/active_job_basics.html
+        DOC
+
+        def_node_matcher :subclasses_application_job?, <<-PATTERN
+          (class (const ...) (const _ :ApplicationJob) ...)
+        PATTERN
+
+        def_node_matcher :is_perform_method?, <<-PATTERN
+          (def :perform ...)
+        PATTERN
+
+        def on_class(node)
+          return unless has_perform_method?(node)
+          return if subclasses_application_job?(node)
+
+          add_offense(node.children.first)
+        end
+
+        private
+
+        def has_perform_method?(node)
+          node.descendants.find(&method(:is_perform_method?))
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-betterment
 version: !ruby/object:Gem::Version
-  version: 1.14.0
+  version: 1.15.0
 platform: ruby
 authors:
 - Development
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-01 00:00:00.000000000 Z
+date: 2020-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -91,6 +91,7 @@ files:
 - STYLEGUIDE.md
 - config/default.yml
 - lib/rubocop/cop/betterment.rb
+- lib/rubocop/cop/betterment/active_job_performable.rb
 - lib/rubocop/cop/betterment/authorization_in_controller.rb
 - lib/rubocop/cop/betterment/dynamic_params.rb
 - lib/rubocop/cop/betterment/implicit_redirect_type.rb
@@ -118,7 +119,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Betterment rubocop configuration