rubocop-betterment 1.10.0 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 90431e9c1e2edefc54944622ad8885b0ae7bda94bcdea4e1364f766e6d88880a
-  data.tar.gz: d1ee2fcf9fdebb45a726394ddaa36458454cecede00949ed70d43abbe66aa4cd
+  metadata.gz: 53a8c97fad6bd1efe6b5698e45325d58185d2f767c5b43375faff67721b69ad2
+  data.tar.gz: 99430282d066784a5e4dfca2fd9f872d86483c337a8b3aa8562785e3d2f4b808
 SHA512:
-  metadata.gz: 4c0d493052df02777e92c08759c36e573c452994ed770d0e20059f3f9804f44f914ee1a2985137e0e8b68ec7205ae5125307aeb7f5b8d8fd9c2c2b8976b23b38
-  data.tar.gz: 3fec119ef35007f33a3ce0ab48a2e3bcd2dbfc8abebb1d010e8ca27d728c5cd72cd466af9b2b6fb7b1ee787e88af1191cce90f28d5335fb12ce9b305ba1e36db
+  metadata.gz: 9915e7cd9a2b0fc718621baf131281ecdbac8ebc63d6d2fde808ea4c4af8677a6b85b44044d854a529a4b85aecb899e99aa6a285eaaeb276861195c7d00bb2c2
+  data.tar.gz: 468d83dfb01860aa77c24d3f938060b8d05c82ae75b0e46a3a1f887c27fd183cef2c002783c72472820ad506ee4134ac82cd4804631643ed2621be97f67e1d98

data/lib/rubocop/cop/betterment/implicit_redirect_type.rb

@@ -0,0 +1,70 @@
+module RuboCop
+  module Cop
+    module Betterment
+      # Require explicit redirect statuses in routes.rb. Refer to the book for more details:
+      # https://github.com/Betterment/the-book/blob/master/platform-specific/ruby.markdown#use-temporary-redirects-eg-redirectstatus-302
+      #
+      # @example
+      #   # bad
+      #   get '/', redirect('/dashboard')
+      #   get { |params, request| '/dashboard' }
+      #
+      #   # good
+      #   get '/', redirect('/dashboard', status: 301)
+      #   get(status: 302) { |params, request| '/dashboard' }
+      class ImplicitRedirectType < Cop
+        ROUTES_FILE_NAME = 'routes.rb'.freeze
+        MSG =
+          'Rails will create a permanent (301) redirect, which is dangerous. ' \
+          'Please specify your desired status, e.g. redirect(..., status: 302)'.freeze
+
+        # redirect('/')
+        def_node_matcher :arg_form_without_options?, <<-PATTERN
+          (send nil? :redirect (str _))
+        PATTERN
+
+        # redirect { |_params, _request| '/' }
+        def_node_matcher :block_form_without_options?, <<-PATTERN
+          (block (send nil? :redirect) ...)
+        PATTERN
+
+        # redirect('/', foo: 'bar')
+        def_node_matcher :arg_form_with_options, <<-PATTERN
+          (send nil? :redirect (str _) (hash $...))
+        PATTERN
+
+        # redirect(foo: 'bar') { |_params, _request| '/' }
+        def_node_matcher :block_form_with_options, <<-PATTERN
+          (block (send nil? :redirect (hash $...)) ...)
+        PATTERN
+
+        # status: anything
+        def_node_matcher :valid_status_option?, <<-PATTERN
+          (pair (sym :status) _)
+        PATTERN
+
+        def on_block(node)
+          return unless routes_file?
+
+          if block_form_with_options(node) { |options| options.none?(&method(:valid_status_option?)) } || block_form_without_options?(node)
+            add_offense(node, message: MSG)
+          end
+        end
+
+        def on_send(node)
+          return unless routes_file?
+
+          if arg_form_with_options(node) { |options| options.none?(&method(:valid_status_option?)) } || arg_form_without_options?(node)
+            add_offense(node, message: MSG)
+          end
+        end
+
+        private
+
+        def routes_file?
+          Pathname.new(processed_source.buffer.name).basename.to_s == ROUTES_FILE_NAME
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/betterment.rb

@@ -3,3 +3,4 @@ require 'rubocop/cop/betterment/timeout'
 require 'rubocop/cop/betterment/memoization_with_arguments'
 require 'rubocop/cop/betterment/site_prism_loaded'
 require 'rubocop/cop/betterment/spec_helper_required_outside_spec_dir'
+require 'rubocop/cop/betterment/implicit_redirect_type'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-betterment
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.0
 platform: ruby
 authors:
 - Development
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-31 00:00:00.000000000 Z
+date: 2019-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -91,6 +91,7 @@ files:
 - STYLEGUIDE.md
 - config/default.yml
 - lib/rubocop/cop/betterment.rb
+- lib/rubocop/cop/betterment/implicit_redirect_type.rb
 - lib/rubocop/cop/betterment/memoization_with_arguments.rb
 - lib/rubocop/cop/betterment/site_prism_loaded.rb
 - lib/rubocop/cop/betterment/spec_helper_required_outside_spec_dir.rb
@@ -114,7 +115,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Betterment rubocop configuration