rubocop-ast 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe900ddbeb79b1f5bc64a232c83261e6c947d95639886ecc727a14e928521d87
-  data.tar.gz: d35cd600bbe5b2653e34c3726a7bd860130088dc30d21a4e3838fd1cc05f88db
+  metadata.gz: d9e5dc8ddfc947af0653c81c0579c18eba59551567d977dc3bf0a4ca4ea92d59
+  data.tar.gz: 4110b86811007a0a28e52c090f45b34449a0e3a6ede4cec97463052c1fb3a8a2
 SHA512:
-  metadata.gz: bf280eb45f3b9e6554202cbfd57edb386a5736881251d9492190f29b5c539ac1ad3bf95f39c449cddcda318968e4f09019b70cbc703d3d59044721e5576dee5b
-  data.tar.gz: 85344e01afb0f05836e63c50f7031249fffa2fd5bbf4e8fc8a09f16a05eecaeb339b65b15acc677340621c71955fc295408b7fbabbc24e8d365839700ec515a3
+  metadata.gz: 827480d8986177910eee3a5d7bebafd9eb169818d755d79c16f9d4a3f89ebcd486494f35f07fbf3e0f6ffcc2a82da74a86b0475504c79b4fb1de3b3ad732a78f
+  data.tar.gz: 6daa124ee67a95fbc6e91cf5cc0a1179e9aad6718fd8a3f9d54b48c5209b45ede07875e1becbdae84ee2106458bb23538fc144a8aefcc35e922204fcb4c30619

data/lib/rubocop/ast/node/def_node.rb

@@ -58,6 +58,11 @@ module RuboCop
       def receiver
         children[-4]
       end
+
+      # @return [Boolean] if the definition is without an `end` or not.
+      def endless?
+        !loc.end
+      end
     end
   end
 end

data/lib/rubocop/ast/node_pattern/compiler/debug.rb

@@ -43,7 +43,7 @@ module RuboCop
 
             # Result of a NodePattern run against a particular AST
             # Consider constructor is private
-            Result = Struct.new(:colorizer, :trace, :returned, :ruby_ast) do # rubocop:disable Metrics/BlockLength
+            Result = Struct.new(:colorizer, :trace, :returned, :ruby_ast) do
               # @return [String] a Rainbow colorized version of ruby
               def colorize(color_scheme = COLOR_SCHEME)
                 map = color_map(color_scheme)

data/lib/rubocop/ast/node_pattern/parser.racc.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 #
 # DO NOT MODIFY!!!!
-# This file is automatically generated by Racc 1.5.0
+# This file is automatically generated by Racc 1.4.16
 # from Racc grammar file "".
 #
 

data/lib/rubocop/ast/traversal.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/ModuleLength
 module RuboCop
   module AST
     # Provides methods for traversing an AST.
@@ -8,198 +7,175 @@ module RuboCop
     # Override methods to perform custom processing. Remember to call `super`
     # if you want to recursively process descendant nodes.
     module Traversal
+      # Only for debugging.
+      # @api private
+      class DebugError < RuntimeError
+      end
+
+      TYPE_TO_METHOD = Hash.new { |h, type| h[type] = :"on_#{type}" }
+
       def walk(node)
         return if node.nil?
 
-        send(:"on_#{node.type}", node)
+        send(TYPE_TO_METHOD[node.type], node)
         nil
       end
 
-      NO_CHILD_NODES    = %i[true false nil int float complex
-                             rational str sym regopt self lvar
-                             ivar cvar gvar nth_ref back_ref cbase
-                             arg restarg blockarg shadowarg
-                             kwrestarg zsuper redo retry
-                             forward_args forwarded_args
-                             match_var match_nil_pattern empty_else
-                             forward_arg lambda procarg0 __ENCODING__].freeze
-      ONE_CHILD_NODE    = %i[splat kwsplat block_pass not break next
-                             preexe postexe match_current_line defined?
-                             arg_expr pin match_rest if_guard unless_guard
-                             match_with_trailing_comma].freeze
-      MANY_CHILD_NODES  = %i[dstr dsym xstr regexp array hash pair
-                             mlhs masgn or_asgn and_asgn rasgn mrasgn
-                             undef alias args super yield or and
-                             while_post until_post iflipflop eflipflop
-                             match_with_lvasgn begin kwbegin return
-                             in_match match_alt
-                             match_as array_pattern array_pattern_with_tail
-                             hash_pattern const_pattern find_pattern
-                             index indexasgn].freeze
-      SECOND_CHILD_ONLY = %i[lvasgn ivasgn cvasgn gvasgn optarg kwarg
-                             kwoptarg].freeze
-      private_constant :NO_CHILD_NODES, :ONE_CHILD_NODE, :MANY_CHILD_NODES, :SECOND_CHILD_ONLY
-
-      NO_CHILD_NODES.each do |type|
-        module_eval("def on_#{type}(node); end", __FILE__, __LINE__)
-      end
-
-      ONE_CHILD_NODE.each do |type|
-        module_eval(<<~RUBY, __FILE__, __LINE__ + 1)
-          def on_#{type}(node)
-            if (child = node.children[0])
-              send(:"on_\#{child.type}", child)
+      # @api private
+      module CallbackCompiler
+        SEND = 'send(TYPE_TO_METHOD[child.type], child)'
+        assign_code = 'child = node.children[%<index>i]'
+        code = "#{assign_code}\n#{SEND}"
+        TEMPLATE = {
+          skip: '',
+          always: code,
+          nil?: "#{code} if child"
+        }.freeze
+
+        def def_callback(type, *signature,
+                         arity: signature.size..signature.size,
+                         arity_check: ENV['RUBOCOP_DEBUG'] && self.arity_check(arity),
+                         body: self.body(signature, arity_check))
+          type, *aliases = type
+          lineno = caller_locations(1, 1).first.lineno
+          module_eval(<<~RUBY, __FILE__, lineno) # rubocop:disable Style/EvalWithLocation
+            def on_#{type}(node)
+              #{body}
+              nil
             end
+          RUBY
+          aliases.each do |m|
+            alias_method "on_#{m}", "on_#{type}"
           end
-        RUBY
-      end
-
-      MANY_CHILD_NODES.each do |type|
-        module_eval(<<~RUBY, __FILE__, __LINE__ + 1)
-          def on_#{type}(node)
-            node.children.each { |child| send(:"on_\#{child.type}", child) }
-            nil
-          end
-        RUBY
-      end
+        end
 
-      SECOND_CHILD_ONLY.each do |type|
-        # Guard clause is for nodes nested within mlhs
-        module_eval(<<~RUBY, __FILE__, __LINE__ + 1)
-          def on_#{type}(node)
-            if (child = node.children[1])
-              send(:"on_\#{child.type}", child)
+        def body(signature, prelude)
+          signature
+            .map.with_index do |arg, i|
+              TEMPLATE[arg].gsub('%<index>i', i.to_s)
             end
-          end
-        RUBY
-      end
-
-      def on_const(node)
-        return unless (child = node.children[0])
-
-        send(:"on_#{child.type}", child)
-      end
-
-      def on_casgn(node)
-        children = node.children
-        if (child = children[0]) # always const???
-          send(:"on_#{child.type}", child)
+            .unshift(prelude)
+            .join("\n")
         end
-        return unless (child = children[2])
-
-        send(:"on_#{child.type}", child)
-      end
 
-      def on_class(node)
-        children = node.children
-        child = children[0] # always const???
-        send(:"on_#{child.type}", child)
-        if (child = children[1])
-          send(:"on_#{child.type}", child)
+        def arity_check(range)
+          <<~RUBY
+            n = node.children.size
+            raise DebugError, [
+              'Expected #{range} children, got',
+              n, 'for', node.inspect
+            ].join(' ') unless (#{range}).cover?(node.children.size)
+          RUBY
         end
-        return unless (child = children[2])
-
-        send(:"on_#{child.type}", child)
-      end
-
-      def on_def(node)
-        children = node.children
-        on_args(children[1])
-        return unless (child = children[2])
-
-        send(:"on_#{child.type}", child)
       end
-
-      def on_send(node)
+      private_constant :CallbackCompiler
+      extend CallbackCompiler
+      send_code = CallbackCompiler::SEND
+
+      ### arity == 0
+      no_children = %i[true false nil self cbase zsuper redo retry
+                       forward_args forwarded_args match_nil_pattern
+                       forward_arg lambda empty_else kwnilarg
+                       __FILE__ __LINE__ __ENCODING__]
+
+      ### arity == 0..1
+      opt_symbol_child = %i[restarg kwrestarg]
+      opt_node_child = %i[splat kwsplat match_rest]
+
+      ### arity == 1
+      literal_child = %i[int float complex
+                         rational str sym lvar
+                         ivar cvar gvar nth_ref back_ref
+                         arg blockarg shadowarg
+                         kwarg match_var]
+
+      many_symbol_children = %i[regopt]
+
+      node_child = %i[block_pass not
+                      match_current_line defined?
+                      arg_expr pin if_guard unless_guard
+                      match_with_trailing_comma]
+      node_or_nil_child = %i[preexe postexe]
+
+      NO_CHILD_NODES = (no_children + opt_symbol_child + literal_child).to_set.freeze
+      private_constant :NO_CHILD_NODES # Used by Commissioner
+
+      ### arity > 1
+      symbol_then_opt_node = %i[lvasgn ivasgn cvasgn gvasgn]
+      symbol_then_node_or_nil = %i[optarg kwoptarg]
+      node_then_opt_node = %i[while until module sclass]
+
+      ### variable arity
+      many_node_children = %i[dstr dsym xstr regexp array hash pair
+                              mlhs masgn or_asgn and_asgn rasgn mrasgn
+                              undef alias args super yield or and
+                              while_post until_post iflipflop eflipflop
+                              match_with_lvasgn begin kwbegin return
+                              in_match match_alt break next
+                              match_as array_pattern array_pattern_with_tail
+                              hash_pattern const_pattern find_pattern
+                              index indexasgn procarg0]
+      many_opt_node_children = %i[case rescue resbody ensure for when
+                                  case_match in_pattern irange erange]
+
+      ### Callbacks for above
+      def_callback no_children
+      def_callback opt_symbol_child, :skip, arity: 0..1
+      def_callback opt_node_child, :nil?, arity: 0..1
+
+      def_callback literal_child, :skip
+      def_callback node_child, :always
+      def_callback node_or_nil_child, :nil?
+
+      def_callback symbol_then_opt_node, :skip, :nil?, arity: 1..2
+      def_callback symbol_then_node_or_nil, :skip, :nil?
+      def_callback node_then_opt_node, :always, :nil?
+
+      def_callback many_symbol_children, :skip, arity_check: nil
+      def_callback many_node_children, body: <<~RUBY
+        node.children.each { |child| #{send_code} }
+      RUBY
+      def_callback many_opt_node_children,
+                   body: <<~RUBY
+                     node.children.each { |child| #{send_code} if child }
+                   RUBY
+
+      ### Other particular cases
+      def_callback :const, :nil?, :skip
+      def_callback :casgn, :nil?, :skip, :nil?, arity: 2..3
+      def_callback :class, :always, :nil?, :nil?
+      def_callback :def, :skip, :always, :nil?
+      def_callback :op_asgn, :always, :skip, :always
+      def_callback :if, :always, :nil?, :nil?
+      def_callback :block, :always, :always, :nil?
+      def_callback :numblock, :always, :skip, :nil?
+      def_callback :defs, :always, :skip, :always, :nil?
+
+      def_callback %i[send csend], body: <<~RUBY
         node.children.each_with_index do |child, i|
           next if i == 1
 
-          send(:"on_#{child.type}", child) if child
+          #{send_code} if child
         end
-        nil
-      end
-
-      alias on_csend on_send
-
-      def on_op_asgn(node)
-        children = node.children
-        child = children[0]
-        send(:"on_#{child.type}", child)
-        child = children[2]
-        send(:"on_#{child.type}", child)
-      end
-
-      def on_defs(node)
-        children = node.children
-        child = children[0]
-        send(:"on_#{child.type}", child)
-        on_args(children[2])
-        return unless (child = children[3])
-
-        send(:"on_#{child.type}", child)
-      end
-
-      def on_if(node)
-        children = node.children
-        child = children[0]
-        send(:"on_#{child.type}", child)
-        if (child = children[1])
-          send(:"on_#{child.type}", child)
-        end
-        return unless (child = children[2])
-
-        send(:"on_#{child.type}", child)
-      end
-
-      def on_while(node)
-        children = node.children
-        child = children[0]
-        send(:"on_#{child.type}", child)
-        return unless (child = children[1])
-
-        send(:"on_#{child.type}", child)
-      end
-
-      alias on_until  on_while
-      alias on_module on_while
-      alias on_sclass on_while
-
-      def on_block(node)
-        children = node.children
-        child = children[0]
-        send(:"on_#{child.type}", child) # can be send, zsuper...
-        on_args(children[1])
-        return unless (child = children[2])
-
-        send(:"on_#{child.type}", child)
-      end
-
-      def on_case(node)
+      RUBY
+
+      ### generic processing of any other node (forward compatibility)
+      defined = instance_methods(false)
+                .grep(/^on_/)
+                .map { |s| s.to_s[3..-1].to_sym } # :on_foo => :foo
+
+      to_define = ::Parser::Meta::NODE_TYPES.to_a
+      to_define -= defined
+      to_define -= %i[numargs ident] # transient
+      to_define -= %i[blockarg_expr restarg_expr] # obsolete
+      to_define -= %i[objc_kwarg objc_restarg objc_varargs] # mac_ruby
+      def_callback to_define, body: <<~RUBY
         node.children.each do |child|
-          send(:"on_#{child.type}", child) if child
+          next unless child.class == Node
+          #{send_code}
         end
-        nil
-      end
-
-      alias on_rescue     on_case
-      alias on_resbody    on_case
-      alias on_ensure     on_case
-      alias on_for        on_case
-      alias on_when       on_case
-      alias on_case_match on_case
-      alias on_in_pattern on_case
-      alias on_irange     on_case
-      alias on_erange     on_case
-
-      def on_numblock(node)
-        children = node.children
-        child = children[0]
-        send(:"on_#{child.type}", child)
-        return unless (child = children[2])
-
-        send(:"on_#{child.type}", child)
-      end
+      RUBY
+      MISSING = to_define if ENV['RUBOCOP_DEBUG']
     end
   end
 end
-# rubocop:enable Metrics/ModuleLength

data/lib/rubocop/ast/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module AST
     module Version
-      STRING = '0.7.1'
+      STRING = '0.8.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-ast
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-28 00:00:00.000000000 Z
+date: 2020-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -165,7 +165,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.1.2
 signing_key:
 specification_version: 4
 summary: RuboCop tools to deal with Ruby code AST.