rubocop-asjer 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c77e721d22becd80eb1bbaccc3500469cd8212a4da6c7fd11f44a09cabe8aeb8
-  data.tar.gz: f5d7b66942be7be87b03f40c77e6464580634bac15962c78472f570cf1c836f8
+  metadata.gz: 33824991e93fac5f0a6dc2ac7170e29f1f19ced20457f9ce1e3ce65fe1fb2073
+  data.tar.gz: 360f3e9dd1884e3f59325d639771ab7204c35a86fdb2ced78eadf14333d70dda
 SHA512:
-  metadata.gz: 3fe9c2037c36e265dfb0a175caef40d1132dc4c0eb50b8e70cd47d3cc4b8479196e32eab6ef46f5ed408c0909de1c2f74f52979da414eab3900384b10917503a
-  data.tar.gz: 0357f2dfb8e2495a44a756f93e80654a7f0533d085b3e814ba6de18cb80912b1b23689e6e7bdea96a319d620fcf73ad71b8f1ec1763c46a1b0848d85150b33d2
+  metadata.gz: 81cb50c70f94b0a6ef221022971961b8939519f786e492a926e7fb5dff0b49dabad85c9f8ac9fd8490e55f68af32136667238b438679f4e0440c006279729398
+  data.tar.gz: fcd0440e6123b3f3e871de30276b62eea4bcd80e466f829e1ee97b49f6c6668ba709cc353aefb2045fc3260a111b88e501c821affae1d21f3092b40261aef964

data/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "0.5.0"
+  ".": "0.6.0"
 }

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.6.0](https://github.com/asjer/rubocop-asjer/compare/v0.5.0...v0.6.0) (2026-10-28)
+
+
+### Features
+
+* **cop:** flag bare login_as calls in system specs ([c4d99a4](https://github.com/asjer/rubocop-asjer/commit/c4d99a42f25072bfc55f5b381c3fe89ff303e391))
+
 ## [0.5.0](https://github.com/asjer/rubocop-asjer/compare/v0.4.5...v0.5.0) (2026-10-15)
 
 

data/README.md

@@ -161,6 +161,41 @@ migration_context.migrate(20261012170000)
 
 By default, this cop runs on `spec/migrations/**/*_spec.rb`.
 
+### Asjer/SystemSpecLoginAs
+
+Requires unqualified `login_as` calls in system specs to be replaced with an application-provided helper such as `sign_in_and_visit(user, path)`. Warden's handoff applies to whichever request reaches the app server next, not necessarily the browser's intended visit.
+
+Every matching call is reported, including calls in `before` blocks, whether a `visit` follows immediately, later, or not at all. Calls with an explicit receiver, such as `foo.login_as(user)`, are outside this cop's scope.
+
+```ruby
+# bad
+login_as(user)
+visit dashboard_path
+
+before do
+  login_as(user)
+end
+
+# good
+sign_in_and_visit(user, dashboard_path)
+```
+
+By default, this cop only runs on `spec/system/**/*.rb` and is `Enabled: pending`. Opt in explicitly (or enable new cops with `AllCops/NewCops: enable`):
+
+```yaml
+Asjer/SystemSpecLoginAs:
+  Enabled: true
+  Include:
+    - 'spec/system/**/*.rb'
+  MethodNames:
+    - login_as
+  PreferredHelper: sign_in_and_visit
+```
+
+`MethodNames` replaces the default list of methods to flag; `PreferredHelper` changes the helper named in the offense message. Define that helper in your application's system-spec support; this gem does not provide it.
+
+**No autocorrect:** the cop cannot infer the destination path or safely move authentication out of a `before` block.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `bundle exec rspec` to run the tests.

data/config/default.yml

@@ -165,3 +165,13 @@ Asjer/RailsClassOrder:
     - has_secure_token
     - generates_token_for
     - composed_of
+
+Asjer/SystemSpecLoginAs:
+  Description: Requires system specs to use a helper that signs in and visits together instead of a bare Warden handoff.
+  Enabled: pending
+  VersionAdded: "0.6.0"
+  Include:
+    - 'spec/system/**/*.rb'
+  MethodNames:
+    - login_as
+  PreferredHelper: sign_in_and_visit

data/lib/rubocop/asjer/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Asjer
-    VERSION = '0.5.0'
+    VERSION = '0.6.0'
   end
 end

data/lib/rubocop/asjer.rb

@@ -8,6 +8,7 @@ require_relative 'cop/asjer/no_default_translation'
 require_relative 'cop/asjer/explicit_migration_version_in_spec'
 require_relative 'cop/asjer/migration_schema_only'
 require_relative 'cop/asjer/rails_class_order'
+require_relative 'cop/asjer/system_spec_login_as'
 
 module RuboCop
   module Asjer

data/lib/rubocop/cop/asjer/system_spec_login_as.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Asjer
+      # Requires system specs to use a helper that signs in and visits together.
+      #
+      # Warden's handoff applies to the next request reaching the app server,
+      # which need not be the browser's intended visit. The application must
+      # provide the replacement helper.
+      #
+      # @example
+      #   # bad
+      #   login_as(user)
+      #   visit dashboard_path
+      #
+      #   # good
+      #   sign_in_and_visit(user, dashboard_path)
+      #
+      class SystemSpecLoginAs < Base
+        MSG = 'Use `%<helper>s` instead of `%<method>s` in system specs: ' \
+              'the Warden handoff applies to whichever request reaches the app server next, ' \
+              "not necessarily the browser's visit."
+
+        def on_send(node)
+          return unless node.receiver.nil?
+          return unless cop_config.fetch('MethodNames', ['login_as']).include?(node.method_name.to_s)
+
+          helper = cop_config.fetch('PreferredHelper', 'sign_in_and_visit')
+          add_offense(node.loc.selector, message: format(MSG, helper: helper, method: node.method_name))
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-asjer
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Asjer Querido
@@ -60,6 +60,7 @@ files:
 - lib/rubocop/cop/asjer/migration_schema_only.rb
 - lib/rubocop/cop/asjer/no_default_translation.rb
 - lib/rubocop/cop/asjer/rails_class_order.rb
+- lib/rubocop/cop/asjer/system_spec_login_as.rb
 - mise.toml
 - release-please-config.json
 - sig/rubocop/i18n.rbs