rubocop-airbnb 4.0.0 → 5.0.0

data/spec/rubocop/cop/airbnb/rspec_environment_modification_spec.rb

@@ -1,64 +1,54 @@
-describe RuboCop::Cop::Airbnb::RspecEnvironmentModification do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::RspecEnvironmentModification, :config do
   before(:each) do
     allow(cop).to receive(:is_spec_file?).and_return(true)
   end
 
   it 'does not allow assignment of Rails.env' do
-    source = [
-      'Rails.env = :production',
-    ].join("\n")
-    inspect_source(source)
-    expect(cop.offenses.size).to eql(1)
+    expect_offense(<<~RUBY)
+      Rails.env = :production
+      ^^^^^^^^^^^^^^^^^^^^^^^ Do not stub or set Rails.env in specs. [...]
+    RUBY
   end
 
   it 'allows assignment of Rails.env when not in spec' do
     allow(cop).to receive(:is_spec_file?).and_return(false)
-    source = [
-      'Rails.env = :production',
-    ].join("\n")
-    inspect_source(source)
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      Rails.env = :production
+    RUBY
   end
 
   it 'rejects allow style stubbing of Rails.env' do
-    source = [
-      'def some_method(a)',
-      '  allow(Rails.env).to receive(:production?)',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-    expect(cop.offenses.size).to eql(1)
+    expect_offense(<<~RUBY)
+      def some_method(a)
+        allow(Rails.env).to receive(:production?)
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub or set Rails.env in specs. [...]
+      end
+    RUBY
   end
 
   it 'rejects expect style stubbing of Rails.env' do
-    source = [
-      'def some_method(a)',
-      '  expect(Rails.env).to receive(:production?)',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-    expect(cop.offenses.size).to eql(1)
+    expect_offense(<<~RUBY)
+      def some_method(a)
+        expect(Rails.env).to receive(:production?)
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub or set Rails.env in specs. [...]
+      end
+    RUBY
   end
 
   it 'rejects .stub stubbing of Rails.env' do
-    source = [
-      'def some_method(a)',
-      '  Rails.env.stub(:production)',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-    expect(cop.offenses.size).to eql(1)
+    expect_offense(<<~RUBY)
+      def some_method(a)
+        Rails.env.stub(:production)
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub or set Rails.env in specs. [...]
+      end
+    RUBY
   end
 
   it 'allows stub_env' do
-    source = [
-      'def some_method(a)',
-      '  stub_env(:production)',
-      'end',
-    ].join("\n")
-    inspect_source(source)
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      def some_method(a)
+        stub_env(:production)
+      end
+    RUBY
   end
 end

data/spec/rubocop/cop/airbnb/simple_modifier_conditional_spec.rb

@@ -1,122 +1,98 @@
-describe RuboCop::Cop::Airbnb::SimpleModifierConditional do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::SimpleModifierConditional, :config do
   context 'multiple conditionals' do
     it 'rejects with modifier if with multiple conditionals' do
-      source = [
-        'return true if some_method == 0 || another_method',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses.size).to eq(1)
+      expect_offense(<<~RUBY)
+        return true if some_method == 0 || another_method
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Modifier if/unless usage is okay when [...]
+      RUBY
     end
 
     it 'rejects with modifier unless with multiple conditionals' do
-      source = [
-        'return true unless true && false',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses.size).to eq(1)
+      expect_offense(<<~RUBY)
+        return true unless true && false
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Modifier if/unless usage is okay when [...]
+      RUBY
     end
 
     it 'allows with modifier if operator conditional' do
-      source = [
-        'return true if some_method == 0',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses).to be_empty
+      expect_no_offenses(<<~RUBY)
+        return true if some_method == 0
+      RUBY
     end
 
     it 'allows with modifier if with single conditional' do
-      source = [
-        'return true if some_method == 0',
-        'return true if another_method',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses).to be_empty
+      expect_no_offenses(<<~RUBY)
+        return true if some_method == 0
+        return true if another_method
+      RUBY
     end
 
     it 'allows with modifier if and unless with single conditional ' do
-      source = [
-        'return true if some_method',
-        'return true unless another_method > 5',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses).to be_empty
+      expect_no_offenses(<<~RUBY)
+        return true if some_method
+        return true unless another_method > 5
+      RUBY
     end
 
     it 'allows multiple conditionals in block form' do
-      source = [
-        'if some_method == 0 && another_method > 5 || true || false',
-        ' return true',
-        'end',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses).to be_empty
+      expect_no_offenses(<<~RUBY)
+        if some_method == 0 && another_method > 5 || true || false
+         return true
+        end
+      RUBY
     end
   end
 
   context 'multiple lines' do
     it 'rejects modifier conditionals that span multiple lines' do
-      source = [
-        'return true if true ||',
-        '               false',
-        'return true unless true ||',
-        '                   false',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses.size).to eq(2)
+      expect_offense(<<~RUBY)
+        return true if true ||
+        ^^^^^^^^^^^^^^^^^^^^^^ Modifier if/unless usage is okay when [...]
+                       false
+        return true unless true ||
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^ Modifier if/unless usage is okay when [...]
+                           false
+      RUBY
     end
 
     it 'rejects with modifier if with method that spans multiple lines' do
-      source = [
-        'return true if some_method(param1,',
-        '                           param2,',
-        '                           param3)',
-        'return true unless some_method(param1,',
-        '                               param2,',
-        '                               param3)',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses.size).to eq(2)
+      expect_offense(<<~RUBY)
+        return true if some_method(param1,
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Modifier if/unless usage is okay when [...]
+                                   param2,
+                                   param3)
+        return true unless some_method(param1,
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Modifier if/unless usage is okay when [...]
+                                       param2,
+                                       param3)
+      RUBY
     end
 
     it 'rejects inline if/unless after a multiline statement' do
-      source = [
-        'return some_method(',
-        '  param1,',
-        '  param2,',
-        '  param3',
-        ') if another_method == 0',
-        'return some_method(',
-        '  param1,',
-        '  param2,',
-        '  param3',
-        ') unless another_method == 0',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses.size).to eq(2)
+      expect_offense(<<~RUBY)
+        return some_method(
+        ^^^^^^^^^^^^^^^^^^^ Modifier if/unless usage is okay when [...]
+          param1,
+          param2,
+          param3
+        ) if another_method == 0
+        return some_method(
+        ^^^^^^^^^^^^^^^^^^^ Modifier if/unless usage is okay when [...]
+          param1,
+          param2,
+          param3
+        ) unless another_method == 0
+      RUBY
     end
 
     it 'allows multline conditionals in block form' do
-      source = [
-        'if some_method(param1,',
-        '               param2,',
-        '               parma3)',
-        ' return true',
-        'end',
-      ].join("\n")
-
-      inspect_source(source)
-      expect(cop.offenses).to be_empty
+      expect_no_offenses(<<~RUBY)
+        if some_method(param1,
+                       param2,
+                       parma3)
+         return true
+        end
+      RUBY
     end
   end
 end

data/spec/rubocop/cop/airbnb/simple_unless_spec.rb

@@ -1,36 +1,26 @@
-describe RuboCop::Cop::Airbnb::SimpleUnless do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::SimpleUnless, :config do
   it 'rejects unless with multiple conditionals' do
-    source = [
-      'unless boolean_condition || another_method',
-      '  return true',
-      'end',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses.size).to eq(1)
+    expect_offense(<<~RUBY)
+      unless boolean_condition || another_method
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Unless usage is okay when there is only one conditional
+        return true
+      end
+    RUBY
   end
 
   it 'allows if with multiple conditionals' do
-    source = [
-      'if boolean_condition || another_method',
-      '  return true',
-      'end',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      if boolean_condition || another_method
+        return true
+      end
+    RUBY
   end
 
   it 'allows with modifier if operator conditional' do
-    source = [
-      'unless boolean_condition',
-      '  return true',
-      'end',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      unless boolean_condition
+        return true
+      end
+    RUBY
   end
 end

data/spec/rubocop/cop/airbnb/spec_constant_assignment_spec.rb

@@ -1,80 +1,62 @@
-describe RuboCop::Cop::Airbnb::SpecConstantAssignment do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::SpecConstantAssignment, :config do
   it 'rejects constant definition inside of a describe block' do
-    source = [
-      'describe Someclass do',
-      '  CONSTANT = 5',
-      'end',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses.size).to eq(1)
+    expect_offense(<<~RUBY)
+      describe Someclass do
+        CONSTANT = 5
+        ^^^^^^^^^^^^ Defining constants inside of specs can cause spurious behavior. [...]
+      end
+    RUBY
   end
 
   it 'allows constant defined inside of a module' do
-    source = [
-      'module Someclass',
-      '  CONSTANT = 5',
-      'end',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      module Someclass
+        CONSTANT = 5
+      end
+    RUBY
   end
 
-  it 'allows constant defined in global space' do
-    source = [
-      'CONSTANT = 5',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses.size).to eq(1)
+  it 'rejects constant defined in global space' do
+    expect_offense(<<~RUBY)
+      CONSTANT = 5
+      ^^^^^^^^^^^^ Defining constants inside of specs can cause spurious behavior. [...]
+    RUBY
   end
 
   it 'rejects constant assignment inside a before block' do
-    source = [
-      'describe Someclass do',
-      '  before { CONSTANT = 5 }',
-      'end',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses.size).to eq(1)
+    expect_offense(<<~RUBY)
+      describe Someclass do
+        before { CONSTANT = 5 }
+                 ^^^^^^^^^^^^ Defining constants inside of specs can cause spurious behavior. [...]
+      end
+    RUBY
   end
 
   it 'rejects namespaced constant assignment inside a before block' do
-    source = [
-      'describe Someclass do',
-      '  before { MyModule::CONSTANT = 5 }',
-      'end',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses.size).to eq(1)
+    expect_offense(<<~RUBY)
+      describe Someclass do
+        before { MyModule::CONSTANT = 5 }
+                 ^^^^^^^^^^^^^^^^^^^^^^ Defining constants inside of specs can cause spurious behavior. [...]
+      end
+    RUBY
   end
 
   it 'rejects constant assignment inside it block' do
-    source = [
-      'describe Someclass do',
-      '  it "tests stuff" do',
-      '    CONSTANT = 5',
-      '  end',
-      'end',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses.size).to eq(1)
+    expect_offense(<<~RUBY)
+      describe Someclass do
+        it "tests stuff" do
+          CONSTANT = 5
+          ^^^^^^^^^^^^ Defining constants inside of specs can cause spurious behavior. [...]
+        end
+      end
+    RUBY
   end
 
   it 'allows let statements that do not assign constants' do
-    source = [
-      'describe Someclass do',
-      '  let(:constant) { 5 }',
-      'end',
-    ].join("\n")
-
-    inspect_source(source)
-    expect(cop.offenses).to be_empty
+    expect_no_offenses(<<~RUBY)
+      describe Someclass do
+        let(:constant) { 5 }
+      end
+    RUBY
   end
 end

data/spec/rubocop/cop/airbnb/unsafe_yaml_marshal_spec.rb

@@ -1,50 +1,38 @@
-describe RuboCop::Cop::Airbnb::UnsafeYamlMarshal do
-  subject(:cop) { described_class.new }
-
+describe RuboCop::Cop::Airbnb::UnsafeYamlMarshal, :config do
   context 'send' do
     it 'rejects YAML.load' do
-      source = [
-        'def some_method(a)',
-        '  YAML.load(a)',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-      expect(cop.offenses.size).to eql(1)
-      expect(cop.offenses.first.message).to match(/`safe_load`, `parse`, `parse_file`/)
+      expect_offense(<<~RUBY)
+        def some_method(a)
+          YAML.load(a)
+          ^^^^^^^^^^^^ Using `YAML.load` on untrusted input [...]
+        end
+      RUBY
     end
 
     it 'rejects Psych.load' do
-      source = [
-        'def some_method(a)',
-        '  Psych.load(a)',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-      expect(cop.offenses.size).to eql(1)
-      expect(cop.offenses.first.message).to match(/`safe_load`, `parse`, `parse_file`/)
+      expect_offense(<<~RUBY)
+        def some_method(a)
+          Psych.load(a)
+          ^^^^^^^^^^^^^ Using `Psych.load` on untrusted input [...]
+        end
+      RUBY
     end
 
     it 'accepts YAML.safe_load' do
-      source = [
-        'def some_method(a)',
-        '  YAML.safe_load(a)',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-      expect(cop.offenses.size).to eql(0)
+      expect_no_offenses(<<~RUBY)
+        def some_method(a)
+          YAML.safe_load(a)
+        end
+      RUBY
     end
 
     it 'rejects on Marshal.load' do
-      source = [
-        'def some_method(a)',
-        '  Marshal.load(a)',
-        'end',
-      ].join("\n")
-      inspect_source(source)
-      expect(cop.offenses.size).to eql(1)
-      expect(cop.offenses.first.message).to match(
-        /`Marshal.load` on untrusted input can lead to remote code execution/
-      )
+      expect_offense(<<~RUBY)
+        def some_method(a)
+          Marshal.load(a)
+          ^^^^^^^^^^^^^^^ Using `Marshal.load` on untrusted input can lead to remote code execution. [...]
+        end
+      RUBY
     end
   end
 end

data/spec/spec_helper.rb

@@ -13,6 +13,8 @@ spec_helper_glob = File.expand_path('{support,shared}/*.rb', SpecHelper::ROOT)
 Dir.glob(spec_helper_glob).map(&method(:require))
 
 RSpec.configure do |config|
+  config.include RuboCop::RSpec::ExpectOffense
+
   config.order = :random
 
   # Define spec metadata for all rspec cop spec files

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-airbnb
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Airbnb Engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-21 00:00:00.000000000 Z
+date: 2023-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: 1.22.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.93.1
+        version: 1.22.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.44.1
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.44.1
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -163,14 +163,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.3.1
 signing_key: 
 specification_version: 4
 summary: Custom code style checking for Airbnb.